Print a warning when the number of rows dumped does not match the expected count (#85)

mpdude · web-flow · commit bfca7266415c · 2021-12-20T12:08:22.000+01:00
diff --git a/src/Webfactory/Slimdump/Database/Dumper.php b/src/Webfactory/Slimdump/Database/Dumper.php
@@ -183,6 +183,7 @@ public function dumpData($table, Table $tableConfig, Connection $db, bool $noPro
         /** @var PDOConnection $wrappedConnection */
         $wrappedConnection = $db->getWrappedConnection();
         $wrappedConnection->setAttribute(PDO::MYSQL_ATTR_USE_BUFFERED_QUERY, false);
+        $actualRows = 0;
 
         foreach ($db->query($s) as $row) {
             $b = $this->rowLengthEstimate($row);
@@ -222,6 +223,8 @@ public function dumpData($table, Table $tableConfig, Connection $db, bool $noPro
             if (null !== $progress) {
                 $progress->advance();
             }
+
+            ++$actualRows;
         }
 
         if (null !== $progress) {
@@ -232,6 +235,10 @@ public function dumpData($table, Table $tableConfig, Connection $db, bool $noPro
             }
         }
 
+        if ($actualRows !== $numRows) {
+            $this->output->getErrorOutput()->writeln(sprintf('<error>Expected %d rows, actually processed %d &ndash; verify results!</error>', $numRows, $actualRows));
+        }
+
         $wrappedConnection->setAttribute(PDO::MYSQL_ATTR_USE_BUFFERED_QUERY, true);
 
         if ($bufferSize) {

Original file line number	Diff line number	Diff line change
`@@ -183,6 +183,7 @@ public function dumpData($table, Table $tableConfig, Connection $db, bool $noPro`
`183`	`183`	`/** @var PDOConnection $wrappedConnection */`
`184`	`184`	`$wrappedConnection = $db->getWrappedConnection();`
`185`	`185`	`$wrappedConnection->setAttribute(PDO::MYSQL_ATTR_USE_BUFFERED_QUERY, false);`
	`186`	`+ $actualRows = 0;`
`186`	`187`
`187`	`188`	`foreach ($db->query($s) as $row) {`
`188`	`189`	`$b = $this->rowLengthEstimate($row);`
`@@ -222,6 +223,8 @@ public function dumpData($table, Table $tableConfig, Connection $db, bool $noPro`
`222`	`223`	`if (null !== $progress) {`
`223`	`224`	`$progress->advance();`
`224`	`225`	`}`
	`226`	`+`
	`227`	`+ ++$actualRows;`
`225`	`228`	`}`
`226`	`229`
`227`	`230`	`if (null !== $progress) {`
`@@ -232,6 +235,10 @@ public function dumpData($table, Table $tableConfig, Connection $db, bool $noPro`
`232`	`235`	`}`
`233`	`236`	`}`
`234`	`237`
	`238`	`+ if ($actualRows !== $numRows) {`
	`239`	`+ $this->output->getErrorOutput()->writeln(sprintf('<error>Expected %d rows, actually processed %d – verify results!</error>', $numRows, $actualRows));`
	`240`	`+ }`
	`241`	`+`
`235`	`242`	`$wrappedConnection->setAttribute(PDO::MYSQL_ATTR_USE_BUFFERED_QUERY, true);`
`236`	`243`
`237`	`244`	`if ($bufferSize) {`