Align on .yesno styling #457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While .applies is specific to HTML (for now), it seems best to include that rule here.
annevk
added a commit
to whatwg/html
that referenced
this pull request
Mar 7, 2025
This was referenced Mar 7, 2025
domenic
approved these changes
Mar 7, 2025
|
Wait, we should probably rev in this PR to make sure all the service worker caches get updated. |
|
Good call, will do! |
annevk
added a commit
to whatwg/html
that referenced
this pull request
Mar 7, 2025
annevk
added a commit
to whatwg/url
that referenced
this pull request
Mar 7, 2025
This did not work correctly as pointed out here: #772 (comment) See also whatwg/whatwg.org#457.
manc95
added a commit
to manc95/url
that referenced
this pull request
Mar 8, 2025
This did not work correctly as pointed out here: whatwg#772 (comment) See also whatwg/whatwg.org#457. <!-- Thank you for contributing to the URL Standard! Please describe the change you are making and complete the checklist below if your change is not editorial. When you submit this PR, and each time you edit this comment (including checking a checkbox through the UI!), PR Preview will run and update it. As such make any edits in one go and only after PR Preview has run. If you think your PR is ready to land, please double-check that the build is passing and the checklist is complete before pinging. --> - [ ] At least two implementers are interested (and none opposed): * … * … - [ ] [Tests](https://github.com/web-platform-tests/wpt) are written and can be reviewed and commented upon at: * … <!-- If these tests are tentative, link a PR to make them non-tentative. --> - [ ] [Implementation bugs](https://github.com/whatwg/meta/blob/main/MAINTAINERS.md#handling-pull-requests) are filed: * Chromium: … * Gecko: … * WebKit: … * Deno: … * Node.js: … - [ ] [MDN issue](https://github.com/whatwg/meta/blob/main/MAINTAINERS.md#handling-pull-requests) is filed: … - [ ] The top of this comment includes a [clear commit message](https://github.com/whatwg/meta/blob/main/COMMITTING.md) to use. <!-- If you created this PR from a single commit, Github copied its message. Otherwise, you need to add a commit message yourself. --> (See [WHATWG Working Mode: Changes](https://whatwg.org/working-mode#changes) for more details.)
lozy219
pushed a commit
to lozy219/html
that referenced
this pull request
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While .applies is specific to HTML (for now), it seems best to include that rule here.