feat(PullRefresh): add a maxPullDistance param to enable cancellation #13484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13484 +/- ##
==========================================
+ Coverage 89.60% 89.62% +0.02%
==========================================
Files 257 257
Lines 7013 7046 +33
Branches 1736 1747 +11
==========================================
+ Hits 6284 6315 +31
- Misses 384 385 +1
- Partials 345 346 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CoderMonkie
force-pushed
the
feat/pull-refresh-cancel
branch
from
9b1d095 to
961be08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In pull-refresh component
I add a max-pull-distance prop to enable cancellation of pull refresh.
If not passed this prop, the behavior will keep the same as before.