ci(pr-test): use PWD instead of CONTENT_TRANSLATED_ROOT #28386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
system
caugner
changed the title
caugner
reviewed
Aug 14, 2025
.github/workflows/pr-test.yml
Outdated
Comment on lines
157
to
158
| file_without_prefix="${file#files/}" | ||
| ARGS+=("-f" "$CONTENT_TRANSLATED_ROOT/$file_without_prefix") |
There was a problem hiding this comment.
What is the reason to go with this, rather than replicating what we do in the content workflow?
Suggested change
| file_without_prefix="${file#files/}" | |
| ARGS+=("-f" "$CONTENT_TRANSLATED_ROOT/$file_without_prefix") | |
| ARGS+=("-f" "$PWD/$file") |
There was a problem hiding this comment.
I was replicating what was there in the first place. But I don't have a strong opinion on either.
There was a problem hiding this comment.
But being somewhat in line with the content repository's workflows, I am happy to change.
There was a problem hiding this comment.
Let's do this, and get this out asap.
caugner
approved these changes
Aug 14, 2025
caugner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a double
files/path component introduced in the last change