Skip to content

feat: support TS syntax in init-declarations #19540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 31, 2025
Merged

Conversation

snitin315
Copy link
Contributor

@snitin315 snitin315 commented Mar 19, 2025

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Refs #19173

It adds support for TypeScript's declare variables.

Is there anything you'd like reviewers to focus on?

@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Mar 19, 2025
@eslint-github-bot eslint-github-bot bot added the feature This change adds a new feature to ESLint label Mar 19, 2025
@github-actions github-actions bot added the rule Relates to ESLint's core rules label Mar 19, 2025
Copy link

netlify bot commented Mar 19, 2025

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 9918115
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/67e5ccde5912430008a85a94

@nzakas nzakas moved this from Needs Triage to Implementing in Triage Mar 21, 2025
@snitin315 snitin315 marked this pull request as ready for review March 22, 2025 13:24
@snitin315 snitin315 requested a review from a team as a code owner March 22, 2025 13:24
@mdjermanovic mdjermanovic added the accepted There is consensus among the team that this change meets the criteria for inclusion label Mar 26, 2025
mdjermanovic
mdjermanovic previously approved these changes Mar 26, 2025
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Leaving open for a 2nd review.

@mdjermanovic mdjermanovic moved this from Implementing to Second Review Needed in Triage Mar 26, 2025
Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking very good! Just a couple of touchup requests, one in source and one in test. 🚀

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Leaving open for @JoshuaKGoldberg to verify.

Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 Looks great, thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 72650ac into main Mar 31, 2025
31 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the ts/init-declarations branch March 31, 2025 14:46
@github-project-automation github-project-automation bot moved this from Second Review Needed to Complete in Triage Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion feature This change adds a new feature to ESLint rule Relates to ESLint's core rules
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

3 participants