Skip to content

feat: support TS syntax in no-dupe-class-members #19558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 27, 2025

Conversation

snitin315
Copy link
Contributor

@snitin315 snitin315 commented Mar 22, 2025

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Refs #19173

  • Rule Reference

  • TypeScript allows method overloads, where multiple method signatures can be declared but only one implementation exists.

    class A {
      foo(value: string): void;
      foo(value: number): void;
      foo(value: string | number) {} // ✅ This is the actual implementation.
    }

Is there anything you'd like reviewers to focus on?

No

@eslint-github-bot eslint-github-bot bot added the feature This change adds a new feature to ESLint label Mar 22, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Mar 22, 2025
@github-actions github-actions bot added the rule Relates to ESLint's core rules label Mar 22, 2025
@snitin315 snitin315 changed the base branch from ts/max-parens to main March 22, 2025 17:24
@snitin315 snitin315 marked this pull request as ready for review March 22, 2025 17:25
@snitin315 snitin315 requested a review from a team as a code owner March 22, 2025 17:25
@snitin315 snitin315 closed this Mar 22, 2025
@snitin315 snitin315 reopened this Mar 22, 2025
@github-project-automation github-project-automation bot moved this from Needs Triage to Complete in Triage Mar 22, 2025
@github-project-automation github-project-automation bot moved this from Complete to Evaluating in Triage Mar 22, 2025
Copy link

netlify bot commented Mar 24, 2025

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 0a911aa
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/67e42aca0f73410007247b1b
😎 Deploy Preview https://deploy-preview-19558--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdjermanovic mdjermanovic added the accepted There is consensus among the team that this change meets the criteria for inclusion label Mar 27, 2025
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Leaving open for a 2nd review.

@mdjermanovic mdjermanovic moved this from Evaluating to Second Review Needed in Triage Mar 27, 2025
Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚡ Sweet! Love to see the simpler implementation than typescript-eslint's 😄.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 071dcd3 into main Mar 27, 2025
31 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the ts/no-dupe-class-members branch March 27, 2025 11:39
@github-project-automation github-project-automation bot moved this from Second Review Needed to Complete in Triage Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion feature This change adds a new feature to ESLint rule Relates to ESLint's core rules
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

3 participants