Skip to content

chore: modify .editorconfig to keep parity with prettier config #19577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 26, 2025

Conversation

SwetaTanwar
Copy link
Contributor

@SwetaTanwar SwetaTanwar commented Mar 26, 2025

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Issue: The local .editorconfig rules defined in the IDE were overriding the prettierconfig rules defined in project, making unrelated prettier changes getting pushed during commit

Fix: Added .editorconfig in parity with .prettierconfig to make sure only relevant changes get pushed

Is there anything you'd like reviewers to focus on?

@SwetaTanwar SwetaTanwar requested a review from a team as a code owner March 26, 2025 16:31
@eslint-github-bot eslint-github-bot bot added the chore This change is not user-facing label Mar 26, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Mar 26, 2025
Copy link

netlify bot commented Mar 26, 2025

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 2d7a5c6
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/67e431f4dbbd87000831937b

@mdjermanovic mdjermanovic changed the title chore: add .editorconfig to keep parity with prettier config chore: modify .editorconfig to keep parity with prettier config Mar 26, 2025
@snitin315 snitin315 added the accepted There is consensus among the team that this change meets the criteria for inclusion label Mar 26, 2025
mdjermanovic
mdjermanovic previously approved these changes Mar 26, 2025
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@snitin315 snitin315 moved this from Needs Triage to Implementing in Triage Mar 26, 2025
snitin315
snitin315 previously approved these changes Mar 26, 2025
Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic requested a review from snitin315 March 26, 2025 17:09
Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snitin315 snitin315 merged commit bdcc91d into eslint:main Mar 26, 2025
30 checks passed
@github-project-automation github-project-automation bot moved this from Implementing to Complete in Triage Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion chore This change is not user-facing
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

3 participants