Skip to content

chore: replace invalid int type with number inside JSDocs. #19597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 5, 2025

Conversation

aryaemami59
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

This PR:

  • replaces invalid int type with number.

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Apr 3, 2025
@eslint-github-bot
Copy link

Hi @aryaemami59!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
  • There should be a space following the initial tag and colon, for example 'feat: Message'.

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

@github-actions github-actions bot added rule Relates to ESLint's core rules cli Relates to ESLint's command-line interface core Relates to ESLint's core APIs and features formatter Relates to the formatters bundled with ESLint labels Apr 3, 2025
Copy link

netlify bot commented Apr 3, 2025

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 78aa382
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/67f0e67bfee27c0008d6cb4b

@aryaemami59 aryaemami59 changed the title chore(jsdoc): replace invalid int type with number chore: replace invalid int type with number inside JSDocs. Apr 3, 2025
@eslint-github-bot eslint-github-bot bot added the chore This change is not user-facing label Apr 3, 2025
@aryaemami59 aryaemami59 force-pushed the chore/replace-int-with-number branch from 31fb392 to 5bab02f Compare April 3, 2025 09:51
@aryaemami59 aryaemami59 marked this pull request as ready for review April 3, 2025 10:24
@aryaemami59 aryaemami59 requested a review from a team as a code owner April 3, 2025 10:24
@aryaemami59 aryaemami59 force-pushed the chore/replace-int-with-number branch from 5bab02f to 0779db6 Compare April 3, 2025 17:05
@nzakas nzakas moved this from Needs Triage to Triaging in Triage Apr 3, 2025
@aryaemami59 aryaemami59 force-pushed the chore/replace-int-with-number branch from 0779db6 to 951887d Compare April 3, 2025 21:27
@fasttime fasttime added the accepted There is consensus among the team that this change meets the criteria for inclusion label Apr 4, 2025
@aryaemami59 aryaemami59 force-pushed the chore/replace-int-with-number branch 2 times, most recently from 280c062 to 8524979 Compare April 5, 2025 07:42
@aryaemami59 aryaemami59 force-pushed the chore/replace-int-with-number branch from 8524979 to eff4fff Compare April 5, 2025 08:01
@aryaemami59 aryaemami59 force-pushed the chore/replace-int-with-number branch from eff4fff to 78aa382 Compare April 5, 2025 08:14
Copy link
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fasttime fasttime merged commit 22ea18b into eslint:main Apr 5, 2025
31 of 32 checks passed
@github-project-automation github-project-automation bot moved this from Triaging to Complete in Triage Apr 5, 2025
@aryaemami59 aryaemami59 deleted the chore/replace-int-with-number branch April 5, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion chore This change is not user-facing cli Relates to ESLint's command-line interface core Relates to ESLint's core APIs and features formatter Relates to the formatters bundled with ESLint rule Relates to ESLint's core rules
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

3 participants