Skip to content

test: fix no-loop-func test with duplicate variable reports #19610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025

Conversation

mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Apr 7, 2025

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Fixes a no-loop-func test that is currently failing on the main branch.

The test was added in #19559, but in the meantime we merged #19595, which changes the expected error message.

What changes did you make? (Give an overview)

Updated the test to not expect the same variable to be reported multiple times.

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic requested a review from a team as a code owner April 7, 2025 20:19
@eslint-github-bot eslint-github-bot bot added the chore This change is not user-facing label Apr 7, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Apr 7, 2025
Copy link

netlify bot commented Apr 7, 2025

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 9c6924a
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/67f433552b97980008a09455

@aladdin-add aladdin-add merged commit dd20cf2 into main Apr 8, 2025
31 checks passed
@aladdin-add aladdin-add deleted the test-fix-no-loop-func branch April 8, 2025 01:45
@github-project-automation github-project-automation bot moved this from Needs Triage to Complete in Triage Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore This change is not user-facing
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

2 participants