docs: update no-undef-init when not to use section
#19624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mdjermanovic
added
rule
There was a problem hiding this comment.
Can you also update the first paragraph of this section, as there are two situations where initializing to undefined behaves differently than omitting the initialization (mentioned loop, and redeclaration).
eslint/docs/src/rules/no-undef-init.md
Line 83 in a40348f
snitin315
reviewed
Apr 17, 2025
docs/src/rules/no-undef-init.md
Outdated
Comment on lines
83
to
85
| There are two situations where initializing to `undefined` behaves differently than omitting the initialization. | ||
|
|
||
| The first is when a `var` declaration occurs inside of a loop. For example: |
There was a problem hiding this comment.
Are we sure there are only two situations?
Suggested change
| There are two situations where initializing to `undefined` behaves differently than omitting the initialization. | |
| The first is when a `var` declaration occurs inside of a loop. For example: | |
| There are situations where initializing to `undefined` behaves differently than omitting the initialization. | |
| One such case is when a `var` declaration occurs inside a loop. For example: |
snitin315
reviewed
Apr 17, 2025
docs/src/rules/no-undef-init.md
Outdated
| @@ -150,3 +152,22 @@ for (i = 0; i < 10; i++) { | |||
| ``` | |||
|
|
|||
| ::: | |||
|
|
|||
| The second is when a variable is redeclared using `var`. For example: | |||
There was a problem hiding this comment.
Suggested change
| The second is when a variable is redeclared using `var`. For example: | |
| Another such case is when a variable is redeclared using `var`. For example: |
mdjermanovic
approved these changes
Apr 17, 2025
github-project-automation
bot
moved this from Second Review Needed
to Complete
in Triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Updated
when not to usesection ofno-undef-initrule docs by adding example of variable declaration with uninitialized and initialized withundefined.Is there anything you'd like reviewers to focus on?
Fixes #19623