Skip to content

Adds the 'itunes:type' tag #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 21, 2020
Merged

Adds the 'itunes:type' tag #16

merged 2 commits into from
Jun 21, 2020

Conversation

quienestatocando
Copy link
Contributor

@quienestatocando quienestatocando commented May 12, 2020 •
edited
Loading

I was trying to parse a podcast RSS feed that contained the <itunes:type> situational tag used by serial podcasts.

Extracted from A podcaster’s guide to RSS document:

episodic (default). Specify episodic when episodes are intended to be consumed without any specific order. Apple Podcasts will present newest episodes first and display the publish date (required) of each episode. If organized into seasons, the newest season will be presented first - otherwise, episodes will be grouped by year published, newest first.

serial. Specify serial when episodes are intended to be consumed in sequential order. Apple Podcasts will present the oldest episodes first and display the episode numbers (required) of each episode. If organized into seasons, the newest season will be presented first and itunes:episode numbers must be given for each episode.

This pull request allows us to access that tag value with channel.itunes_type.

@quienestatocando
Adds the 'itunes:type' tag
69c4f96 
The type of show is used to specify when episodes are intended to be consumed in
sequential order or not.
jmsalcido
jmsalcido approved these changes Jun 16, 2020
View reviewed changes
Copy link

@jmsalcido jmsalcido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

kou
kou reviewed Jun 21, 2020
View reviewed changes
lib/rss/itunes.rb Outdated
@@ -53,6 +53,7 @@ module ITunesBaseModel
["block", :yes_other],
["explicit", :explicit_clean_other],
["keywords", :csv],
["type"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

itunes:type must be a tag in <channel>.
It must not be used in <item>.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@kou
Make itunes:type available only in <channel>
9e69180 
Add validation.

Add support for maker.
@kou kou merged commit 8053945 into ruby:master Jun 21, 2020
@kou
Copy link
Member

kou commented Jun 21, 2020

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kou kou kou left review comments

@jmsalcido jmsalcido jmsalcido approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@quienestatocando @kou @jmsalcido