Skip to content

Add support for itunes episode & season #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 3, 2021

Conversation

saerdnaer
Copy link
Contributor

No description provided.

@olleolleolle
Copy link
Contributor

I was able to locate the information about Apple's podcasting RSS requirements: https://help.apple.com/itc/podcasts_connect/#/itcb54353390

Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw two tiny typos when running the CI job.

Cool feature.

@kou kou changed the title support for itunes episode & season Add support for itunes episode & season Apr 29, 2021
@kou
Copy link
Member

kou commented Apr 29, 2021

It seems that both of <itunes:episode> and <itunes:season> should exist in item not channel.

It seems that both of them needs validation (a non-zero integer). Do you want me to take over it?

@saerdnaer
Copy link
Contributor Author

saerdnaer commented May 1, 2021

@kou Yes thats, right. I just found this commit in one of the forks and thought this should go upstream. Feel free to take it over.

Edit: fixed it myself.

dnlrnstlff and others added 2 commits May 3, 2021 00:28
Co-authored-by: Olle Jonsson <olle.jonsson@gmail.com>
@saerdnaer saerdnaer force-pushed the itunes-episode-season branch from cf676d5 to d637cf8 Compare May 2, 2021 22:30
@saerdnaer saerdnaer force-pushed the itunes-episode-season branch from d637cf8 to 74e88f6 Compare May 2, 2021 22:38
@saerdnaer saerdnaer force-pushed the itunes-episode-season branch from d37541a to 1f74916 Compare May 2, 2021 23:02
@saerdnaer saerdnaer requested a review from olleolleolle May 2, 2021 23:03
@kou kou merged commit 05cbfaa into ruby:master May 3, 2021
@kou
Copy link
Member

kou commented May 3, 2021

I've fixed a bug that channel still parses episode and season.
I've also added non zero positive integer validation.

I've merged. Thanks.

@saerdnaer saerdnaer deleted the itunes-episode-season branch May 3, 2021 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants