Add more test cases for prefer-string-raw rule
#2690
Merged
+46
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, would you be open for the following refactor? Simplifying the following: eslint-plugin-unicorn/rules/prefer-string-raw.js Lines 11 to 32 in 944cb50 To this: function unescapeBackslash(raw) {
const quote = raw.charAt(0);
return raw
.slice(1, -1)
.replaceAll(new RegExp(String.raw`\\([\\${quote}])`, 'g'), '$1');
}It uses a regex to replace |
Seems safe to apply. But please use a named group instead. |
fisker
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a couple of new test cases that cover the following:
This covers the following check, which is currently not covered by any of the tests.
eslint-plugin-unicorn/rules/prefer-string-raw.js
Line 59 in 944cb50
These cover the
nextCharacter === quotecheck in the following line, which again is not currently covered.eslint-plugin-unicorn/rules/prefer-string-raw.js
Line 21 in 944cb50
Finally, this just highlights that if the string contains unnecessarily escaped quotes (or unnecessary escapes in general), this rule would stop complaining.