Skip to content

Bug-1828220 add documentation and release notes for browser_action.onUserSettingsChanged event #40488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

rebloor
Copy link
Contributor

@rebloor rebloor commented Jul 21, 2025

Description

Adds the documentation and release note for the addition of the browser_action.onUserSettingsChanged event.

Related issues and pull requests

Addresses the dev-doc-needed requirements of Bug 1828220 Implement onUserSettingsChanged event.

See mdn/browser-compat-data#27355 for addition to the BCD.

@rebloor rebloor requested a review from dotproto July 21, 2025 23:27
@rebloor rebloor self-assigned this Jul 21, 2025
@rebloor rebloor requested review from a team as code owners July 21, 2025 23:27
@rebloor rebloor added the Content:WebExt WebExtensions docs label Jul 21, 2025
@rebloor rebloor requested review from dipikabh and removed request for a team July 21, 2025 23:27
@github-actions github-actions bot added Content:Firefox Content in the Mozilla/Firefox subtree size/s [PR only] 6-50 LoC changed labels Jul 21, 2025
Copy link
Contributor

github-actions bot commented Jul 21, 2025

@rebloor rebloor changed the title Bug-1828220 add the browser_action.onUserSettingsChanged event Bug-1828220 add documentation and release notes for browser_action.onUserSettingsChanged event Jul 22, 2025
Copy link
Member

@Rob--W Rob--W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add the documentation changes to the action API namespace. The same changes were made in the action and browserAction namespace.

@github-actions github-actions bot added size/m [PR only] 51-500 LoC changed and removed size/s [PR only] 6-50 LoC changed labels Jul 23, 2025
rebloor and others added 3 commits July 23, 2025 14:43
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ent' of ssh://github.com/rebloor/content into Bug-1828220-add-browser_action.onUserSettingsChanged-event
@rebloor rebloor requested a review from Rob--W July 23, 2025 02:45
@rebloor
Copy link
Contributor Author

rebloor commented Aug 8, 2025

@Rob--W a reminder about your review on requested changes, I believe I've addressed them.

Copy link
Member

@Rob--W Rob--W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay, thanks for the fix!

@rebloor rebloor merged commit 0bbc834 into mdn:main Aug 9, 2025
8 checks passed
@rebloor rebloor deleted the Bug-1828220-add-browser_action.onUserSettingsChanged-event branch August 9, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Firefox Content in the Mozilla/Firefox subtree Content:WebExt WebExtensions docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants