Namespaces #268
Merged
Namespaces #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwecan
reviewed
Sep 18, 2018
version
Outdated
| @@ -1 +1 @@ | |||
| 0.6.4 | |||
| 0.6.5 | |||
There was a problem hiding this comment.
I missed that this change was made on this initial PR's commit. Would you mind getting it reverted @tiny-dancer? Pending that I see no reason we can't get this merged in. (FWIW, I am intending for a few other changes to go out in the 0.6.5 release that is tentatively slated for Oct. 1st.)
|
@jeffwecan updated |
jeffwecan
approved these changes
Sep 18, 2018
Codecov Report
@@ Coverage Diff @@
## master #268 +/- ##
=========================================
- Coverage 89.96% 89.9% -0.06%
=========================================
Files 16 16
Lines 1166 1169 +3
=========================================
+ Hits 1049 1051 +2
- Misses 117 118 +1
|
|
@jeffwecan updated |
Codecov Report
@@ Coverage Diff @@
## master #268 +/- ##
=========================================
- Coverage 89.96% 89.9% -0.06%
=========================================
Files 16 16
Lines 1166 1169 +3
=========================================
+ Hits 1049 1051 +2
- Misses 117 118 +1
|
2 similar comments
Codecov Report
@@ Coverage Diff @@
## master #268 +/- ##
=========================================
- Coverage 89.96% 89.9% -0.06%
=========================================
Files 16 16
Lines 1166 1169 +3
=========================================
+ Hits 1049 1051 +2
- Misses 117 118 +1
|
Codecov Report
@@ Coverage Diff @@
## master #268 +/- ##
=========================================
- Coverage 89.96% 89.9% -0.06%
=========================================
Files 16 16
Lines 1166 1169 +3
=========================================
+ Hits 1049 1051 +2
- Misses 117 118 +1
|
jeffwecan
approved these changes
Sep 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#265
@stenio123 was taking too long :)