Skip to content

lazily set zenohid in the config if it is unset #1977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DenisBiryukov91
Copy link
Contributor

lazily set zenohid in the config if it is unset;
resolves #998

@DenisBiryukov91 DenisBiryukov91 added the api fix Correct API label Jun 3, 2025
Copy link

github-actions bot commented Jun 3, 2025

PR missing one of the required labels: {'documentation', 'breaking-change', 'dependencies', 'new feature', 'internal', 'enhancement', 'bug'}

Copy link

github-actions bot commented Jun 3, 2025

PR missing one of the required labels: {'bug', 'new feature', 'enhancement', 'internal', 'dependencies', 'breaking-change', 'documentation'}

@DenisBiryukov91 DenisBiryukov91 added the internal Changes not included in the changelog label Jun 3, 2025
@DenisBiryukov91 DenisBiryukov91 force-pushed the lazy-zenohid-in-config branch from 97f4bc2 to 65bd4a7 Compare June 3, 2025 14:37
Copy link

codecov bot commented Jun 3, 2025

Codecov Report

Attention: Patch coverage is 53.48837% with 20 lines in your changes missing coverage. Please review.

Project coverage is 70.83%. Comparing base (11c2978) to head (db30c49).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
commons/zenoh-config/src/lib.rs 52.77% 17 Missing ⚠️
zenohd/src/main.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1977      +/-   ##
==========================================
- Coverage   70.92%   70.83%   -0.10%     
==========================================
  Files         364      364              
  Lines       61509    61557      +48     
==========================================
- Hits        43628    43603      -25     
- Misses      17881    17954      +73     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api fix Correct API internal Changes not included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config cannot be not be reused
1 participant