Skip to content

fix(core): Focus Lost After mouseleave During Arrow Key Navigation #11019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(core): Focus Lost After mouseleave During Arrow Key Navigation #11019

wants to merge 3 commits into from

Conversation

aliveairush
Copy link

@aliveairush aliveairush commented May 27, 2025 •
edited
Loading

Fixes #11018

Demo

2025-05-27.20-30-57.mov

@aliveairush aliveairush requested a review from a team as a code owner May 27, 2025 17:23
@aliveairush aliveairush requested review from MarsiBarsi, waterplea, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team May 27, 2025 17:23
@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented May 27, 2025 •
edited
Loading

Tests completed successfully ✅

Good job 🔥

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented May 27, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit db0e9d1.

Command Status Duration Result
nx e2e demo-playwright -- --project=chromium --... ✅ Succeeded 5m 31s View ↗
nx e2e demo-playwright -- --project=chromium --... ✅ Succeeded 4m 34s View ↗
nx e2e demo-playwright -- --update-snapshots --... ✅ Succeeded 6m 41s View ↗
nx e2e demo-playwright -- --project=chromium --... ✅ Succeeded 2m 50s View ↗
nx e2e demo-playwright -- --project=chromium --... ✅ Succeeded 3m 11s View ↗
nx e2e demo-playwright -- --project=chromium --... ✅ Succeeded 2m 3s View ↗
nx e2e demo-playwright -- --project=chromium --... ✅ Succeeded 1m 58s View ↗
nx e2e demo-playwright -- --project=chromium --... ✅ Succeeded 2m 24s View ↗
Additional runs (13) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-05-27 18:00:11 UTC

@codecov Codecov
Copy link

codecov bot commented May 27, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 64.41%. Comparing base (ad6c629) to head (db0e9d1).

Files with missing lines Patch % Lines
...s/core/components/data-list/data-list.component.ts 0.00% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11019      +/-   ##
==========================================
- Coverage   64.43%   64.41%   -0.02%     
==========================================
  Files        1310     1310              
  Lines       17468    17473       +5     
  Branches     2577     2577              
==========================================
  Hits        11256    11256              
- Misses       5966     5999      +33     
+ Partials      246      218      -28
Flag Coverage Δ
summary 64.41% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bundlemon BundleMon
Copy link

bundlemon bot commented May 27, 2025 •
edited
Loading

BundleMon

Unchanged files (5)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 328.38KB +10%
✅ demo/browser/vendor.(hash).js
 260.81KB +10%
✅ demo/browser/runtime.(hash).js
 50.55KB +10%
✅ demo/browser/styles.(hash).css
 21.16KB +10%
✅ demo/browser/polyfills.(hash).js
 11.18KB +10%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
✅ demo/browser/*..js
 8.9MB -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@splincode
Copy link
Member

@waterplea Good day, please review 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@splincode splincode splincode approved these changes

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi MarsiBarsi is a code owner automatically assigned from taiga-family/core-team

@waterplea waterplea Awaiting requested review from waterplea waterplea is a code owner automatically assigned from taiga-family/core-team

@nsbarsukov nsbarsukov Awaiting requested review from nsbarsukov nsbarsukov is a code owner automatically assigned from taiga-family/core-team

@vladimirpotekhin vladimirpotekhin Awaiting requested review from vladimirpotekhin vladimirpotekhin is a code owner automatically assigned from taiga-family/core-team

@mdlufy mdlufy Awaiting requested review from mdlufy mdlufy is a code owner automatically assigned from taiga-family/core-team

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐞 - tui-data-list Focus Lost After mouseleave During Arrow Key Navigation
2 participants
@aliveairush @splincode