build: clean up obsolete logic for old compilers #4849
+50
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgritz
force-pushed
the
lg-gccver
branch
2 times, most recently
from
0005231 to
549dc84
Compare
* Enforce gcc, clang, and apple clang minimum versions. * Raise advertised minimum clang version to 10.0. Error for clang < 5, which we know is the true minimum because earlier than that won't support C++17 which we require. But in truth, we haven't tested versions older than 10.0 for a long time, so we should not be implying we know older versions will work or that we will support them. * Simplify cases no longer relevant for older gcc and clang. * Remove unneeded gcc guard in simd.h. I think it was important only for gcc 5! But it was also preventing the slightly faster construct from activating for clang. Seems to pass all our CI jobs with this simplified. Signed-off-by: Larry Gritz <lg@larrygritz.com>
lgritz
added
the
build / testing / port / CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enforce gcc, clang, and apple clang minimum versions.
Raise advertised minimum clang version to 10.0. Error for clang < 5,
which we know is the true minimum because earlier than that won't
support C++17 which we require. But in truth, we haven't tested
versions older than 10.0 for a long time, so we should not be
implying we know older versions will work or that we will support
them.
Simplify cases no longer relevant for older gcc and clang.
Remove unneeded gcc guard in simd.h. I think it was important only
for gcc 5! But it was also preventing the slightly faster construct
from activating for clang. Seems to pass all our CI jobs with this
simplified.