Add support for finding targets in auxilary browsing contexts #1218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After performing a recursive depth first search for a target on all browsing contexts starting from the first and continuing until the top-most, then all auxilary browsing context should be searched. Also, any new child context created which is not a frame context should be an auxilary browsing context, and added as a direct child of the top-most browsing context, rather than the browsing context attempting to create it. The order for searching auxilary browsing contexts is currently up to the implementation to decide, so long as it is consistent. The order chosen in this implementation is the order the auxilary browsing contexts were created.
FlorianRappl
approved these changes
Feb 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of Changes
Prerequisites
Please make sure you can check the following two boxes:
Contribution Type
What types of changes does your code introduce? Put an
xin all the boxes that apply:Description
This is an update to the previous pull request that covers a missing piece for targeting a frame within a new window from the original window. It also updates new windows to be a child of the top most browsing context to emulate auxilary browsing contexts within a browsing group.