Prevent duplicate left joins in translation order queries. #454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request modifies the
scopeOrderByTranslationmethod insrc/Translatable/Traits/Scopes.phpto improve its functionality and flexibility by adding support for specifying a locale and optimizing the query logic.Enhancements to
scopeOrderByTranslation:?string $local = nullparameter to allow specifying a locale directly when ordering translations. If not provided, the method defaults to using the current locale.LEFT JOINclauses on the translations table before adding a new one, preventing redundant joins and improving query efficiency.$localeKeyand$keyName) and streamlined the join logic to use class methods directly for retrieving keys and table names.