Skip to content

GameWrapper: Castlevania - The Adventure (GB) #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

GameWrapper: Castlevania - The Adventure (GB) #361

wants to merge 1 commit into from

Conversation

BackrndSource
Copy link
Contributor

This PR adds a Game Wrapper for Castlevania: The Adventure (GB).

Baekalfen
Baekalfen reviewed Feb 8, 2025
View reviewed changes
Copy link
Owner

@Baekalfen Baekalfen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'll see if it compiles etc. And then I'll probably have to make a faux test, as I don't own this game. Maybe I'll find it in time.

@BackrndSource
Copy link
Contributor Author

Thank you very much for the code review. I will probably add some methods like set_health or set_lives_left, and maybe other attributes. I can also take the opportunity to create the "vrai" tests. So if you want, don't worry about merging until further notice :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Baekalfen Baekalfen Baekalfen left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BackrndSource @Baekalfen