V2 #48
Open
V2 #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes support for all PHP 7.X versions in the test matrix, might still work, but not worried about them, they can fall back to V1 if needed and I'm not testing code on that
Removes support for PHP 8.0 as that's only security updates for now
Considering a BC break on the
.cigar.jsonfile as the dot always annoyed me - why did I go with that?!Likely going to introduce PHP_CS and psalm at somepoint, just because I use them elsewhere and it'd be nice to have them here for automated checking of standards and code-niceness