Guy.mor/support decoding fetch v13 to v17 #36199

guymor4 · 2025-04-16T12:28:20Z

What does this PR do?

Motivation

Support kafka fetch versions in decoding v13+ (was 12, now 17)
// TODO

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

Our classification can work with newer version of fetch and produce, while decoding can't We modify the code base to allow classifying all fetch APIs although the decoding supports only up to 12

…atest fetch and produce versions

…X_SUPPORTED_FETCH_REQUEST_API_VERSION to 12

…port-produce-v11-and-fixes

…port-new-produce-fetch-versions

Our classification can work with newer version of fetch and produce, while decoding can't We modify the code base to allow classifying all fetch APIs although the decoding supports only up to 12

…X_SUPPORTED_FETCH_REQUEST_API_VERSION to 12

agent-platform-auto-pr · 2025-05-18T15:00:03Z

Uncompressed package size comparison

Comparison with ancestor 004777aef920de42f637aca55dbbaa33591e71ef

Diff per package

package	diff	status	size	ancestor	threshold
datadog-agent-amd64-deb	2.32MB	❌	775.78MB	773.46MB	0.50MB
datadog-agent-arm64-deb	2.32MB	❌	761.73MB	759.40MB	0.50MB
datadog-agent-aarch64-rpm	2.32MB	❌	770.66MB	768.33MB	0.50MB
datadog-agent-x86_64-rpm	2.32MB	❌	784.73MB	782.41MB	0.50MB
datadog-agent-x86_64-suse	2.32MB	❌	784.73MB	782.41MB	0.50MB
datadog-dogstatsd-amd64-deb	0.00MB	✅	31.99MB	31.99MB	0.50MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	32.07MB	32.07MB	0.50MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	32.07MB	32.07MB	0.50MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	30.47MB	30.47MB	0.50MB
datadog-heroku-agent-amd64-deb	0.00MB	✅	380.17MB	380.17MB	0.50MB
datadog-iot-agent-amd64-deb	0.00MB	✅	62.79MB	62.79MB	0.50MB
datadog-iot-agent-x86_64-rpm	0.00MB	✅	62.88MB	62.88MB	0.50MB
datadog-iot-agent-x86_64-suse	0.00MB	✅	62.87MB	62.87MB	0.50MB
datadog-iot-agent-arm64-deb	0.00MB	✅	59.37MB	59.37MB	0.50MB
datadog-iot-agent-aarch64-rpm	0.00MB	✅	59.45MB	59.45MB	0.50MB

Decision

❌ Failed

Currently this PR is blocked, you can reach out to #agent-delivery-help to get support/ask for an exception.

agent-platform-auto-pr · 2025-05-18T15:55:56Z

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 004777a

Successful checks

Info

	Quality gate	Delta	On disk size (MiB)	Delta	On wire size (MiB)
✅	agent_deb_amd64	$${\color{green}-2.21}$$	$${\color{green}748.39}$$ < $${752.99}$$	$${\color{green}-0.16}$$	$${\color{green}184.89}$$ < $${187.44}$$
✅	agent_deb_amd64_fips	$${\color{green}-2.22}$$	$${\color{green}746.76}$$ < $${751.36}$$	$${\color{green}-0.13}$$	$${\color{green}184.35}$$ < $${187.06}$$
✅	agent_heroku_amd64	$${\color{green}0}$$	$${\color{green}368.55}$$ < $${369.68}$$	$${\color{green}-0}$$	$${\color{green}98.54}$$ < $${99.55}$$
✅	agent_msi	$${\color{red}+0}$$	$${\color{green}977.62}$$ < $${978.01}$$	$${\color{green}-0.02}$$	$${\color{green}148.36}$$ < $${149.12}$$
✅	agent_rpm_amd64	$${\color{green}-2.21}$$	$${\color{green}748.38}$$ < $${752.98}$$	$${\color{green}-0.12}$$	$${\color{green}186.53}$$ < $${190.03}$$
✅	agent_rpm_amd64_fips	$${\color{green}-2.22}$$	$${\color{green}746.75}$$ < $${751.35}$$	$${\color{green}-0.1}$$	$${\color{green}186.27}$$ < $${189.81}$$
✅	agent_rpm_arm64	$${\color{green}-2.21}$$	$${\color{green}734.96}$$ < $${739.42}$$	$${\color{green}-0.19}$$	$${\color{green}168.59}$$ < $${171.23}$$
✅	agent_rpm_arm64_fips	$${\color{green}-2.21}$$	$${\color{green}733.45}$$ < $${737.91}$$	$${\color{green}-0.13}$$	$${\color{green}167.7}$$ < $${170.22}$$
✅	agent_suse_amd64	$${\color{green}-2.21}$$	$${\color{green}748.38}$$ < $${752.98}$$	$${\color{green}-0.12}$$	$${\color{green}186.53}$$ < $${190.03}$$
✅	agent_suse_amd64_fips	$${\color{green}-2.22}$$	$${\color{green}746.75}$$ < $${751.35}$$	$${\color{green}-0.1}$$	$${\color{green}186.27}$$ < $${189.81}$$
✅	agent_suse_arm64	$${\color{green}-2.21}$$	$${\color{green}734.96}$$ < $${739.42}$$	$${\color{green}-0.19}$$	$${\color{green}168.59}$$ < $${171.23}$$
✅	agent_suse_arm64_fips	$${\color{green}-2.21}$$	$${\color{green}733.45}$$ < $${737.91}$$	$${\color{green}-0.13}$$	$${\color{green}167.7}$$ < $${170.22}$$
✅	docker_agent_amd64	$${\color{green}-2.23}$$	$${\color{green}832.18}$$ < $${849.39}$$	$${\color{green}-0.34}$$	$${\color{green}282.1}$$ < $${288.34}$$
✅	docker_agent_arm64	$${\color{green}-2.22}$$	$${\color{green}842.21}$$ < $${858.97}$$	$${\color{green}-0.33}$$	$${\color{green}268.23}$$ < $${274.36}$$
✅	docker_agent_jmx_amd64	$${\color{green}-2.23}$$	$${\color{green}832.18}$$ < $${849.39}$$	$${\color{green}-0.34}$$	$${\color{green}282.1}$$ < $${288.34}$$
✅	docker_agent_jmx_arm64	$${\color{green}-2.22}$$	$${\color{green}842.21}$$ < $${858.97}$$	$${\color{green}-0.33}$$	$${\color{green}268.23}$$ < $${274.36}$$
✅	docker_agent_windows1809	$${\color{green}-2.23}$$	$${\color{green}832.18}$$ < $${849.39}$$	$${\color{green}-0.34}$$	$${\color{green}282.1}$$ < $${288.34}$$
✅	docker_agent_windows1809_core	$${\color{green}-2.23}$$	$${\color{green}832.18}$$ < $${849.39}$$	$${\color{green}-0.34}$$	$${\color{green}282.1}$$ < $${288.34}$$
✅	docker_agent_windows1809_core_jmx	$${\color{green}-2.23}$$	$${\color{green}832.18}$$ < $${849.39}$$	$${\color{green}-0.34}$$	$${\color{green}282.1}$$ < $${288.34}$$
✅	docker_agent_windows1809_jmx	$${\color{green}-2.23}$$	$${\color{green}832.18}$$ < $${849.39}$$	$${\color{green}-0.34}$$	$${\color{green}282.1}$$ < $${288.34}$$
✅	docker_agent_windows2022	$${\color{green}-2.23}$$	$${\color{green}832.18}$$ < $${849.39}$$	$${\color{green}-0.34}$$	$${\color{green}282.1}$$ < $${288.34}$$
✅	docker_agent_windows2022_core	$${\color{green}-2.23}$$	$${\color{green}832.18}$$ < $${849.39}$$	$${\color{green}-0.34}$$	$${\color{green}282.1}$$ < $${288.34}$$
✅	docker_agent_windows2022_core_jmx	$${\color{green}-2.23}$$	$${\color{green}832.18}$$ < $${849.39}$$	$${\color{green}-0.34}$$	$${\color{green}282.1}$$ < $${288.34}$$
✅	docker_agent_windows2022_jmx	$${\color{green}-2.23}$$	$${\color{green}832.18}$$ < $${849.39}$$	$${\color{green}-0.34}$$	$${\color{green}282.1}$$ < $${288.34}$$
✅	docker_cluster_agent_amd64	$${\color{green}-0.01}$$	$${\color{green}258.94}$$ < $${259.73}$$	$${\color{red}+0}$$	$${\color{green}102.78}$$ < $${103.68}$$
✅	docker_cluster_agent_arm64	$${\color{green}-0.01}$$	$${\color{green}273.44}$$ < $${274.24}$$	$${\color{green}-0}$$	$${\color{green}97.54}$$ < $${98.45}$$
✅	docker_cws_instrumentation_amd64	$${\color{red}+0}$$	$${\color{green}7.08}$$ < $${7.12}$$	$${\color{red}+0}$$	$${\color{green}2.95}$$ < $${3.29}$$
✅	docker_cws_instrumentation_arm64	$${\color{red}+0}$$	$${\color{green}6.69}$$ < $${6.92}$$	$${\color{red}+0}$$	$${\color{green}2.7}$$ < $${3.07}$$
✅	docker_dogstatsd_amd64	$${\color{green}0}$$	$${\color{green}38.63}$$ < $${39.57}$$	$${\color{red}+0}$$	$${\color{green}14.81}$$ < $${15.76}$$
✅	docker_dogstatsd_arm64	$${\color{green}-0}$$	$${\color{green}37.26}$$ < $${38.2}$$	$${\color{green}-0}$$	$${\color{green}13.88}$$ < $${14.83}$$
✅	dogstatsd_deb_amd64	$${\color{green}0}$$	$${\color{green}30.58}$$ < $${31.52}$$	$${\color{green}-0}$$	$${\color{green}8.03}$$ < $${8.97}$$
✅	dogstatsd_deb_arm64	$${\color{green}0}$$	$${\color{green}29.14}$$ < $${30.08}$$	$${\color{green}-0}$$	$${\color{green}6.97}$$ < $${7.92}$$
✅	dogstatsd_rpm_amd64	$${\color{green}0}$$	$${\color{green}30.58}$$ < $${31.52}$$	$${\color{red}+0}$$	$${\color{green}8.03}$$ < $${8.98}$$
✅	dogstatsd_suse_amd64	$${\color{green}0}$$	$${\color{green}30.58}$$ < $${31.52}$$	$${\color{red}+0}$$	$${\color{green}8.03}$$ < $${8.98}$$
✅	iot_agent_deb_amd64	$${\color{green}0}$$	$${\color{green}59.96}$$ < $${60.17}$$	$${\color{green}-0}$$	$${\color{green}14.99}$$ < $${15.82}$$
✅	iot_agent_deb_arm64	$${\color{green}0}$$	$${\color{green}56.69}$$ < $${56.94}$$	$${\color{green}-0}$$	$${\color{green}12.86}$$ < $${13.86}$$
✅	iot_agent_deb_armhf	$${\color{green}0}$$	$${\color{green}56.14}$$ < $${56.41}$$	$${\color{red}+0.02}$$	$${\color{green}12.99}$$ < $${13.86}$$
✅	iot_agent_rpm_amd64	$${\color{green}0}$$	$${\color{green}59.96}$$ < $${60.18}$$	$${\color{green}-0}$$	$${\color{green}15.01}$$ < $${15.84}$$
✅	iot_agent_rpm_arm64	$${\color{green}0}$$	$${\color{green}56.69}$$ < $${56.94}$$	$${\color{red}+0}$$	$${\color{green}12.88}$$ < $${13.76}$$
✅	iot_agent_suse_amd64	$${\color{green}0}$$	$${\color{green}59.96}$$ < $${60.18}$$	$${\color{green}-0}$$	$${\color{green}15.01}$$ < $${15.84}$$

…decoding-fetch-v13

cit-pr-commenter · 2025-05-22T15:37:38Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 28d44c2c-02f7-4199-93ff-8e396c3b79f1

Baseline: 004777a
Comparison: 21703ba
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+1.11	[-1.59, +3.82]	1	Logs bounds checks dashboard
➖	tcp_syslog_to_blackhole	ingress throughput	+1.09	[+1.03, +1.16]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.93	[+0.06, +1.80]	1	Logs
➖	ddot_logs	memory utilization	+0.25	[+0.12, +0.39]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	+0.17	[+0.13, +0.21]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.10	[-0.49, +0.69]	1	Logs
➖	otlp_ingest_metrics	memory utilization	+0.10	[-0.06, +0.26]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	+0.09	[-0.54, +0.72]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.05	[-0.07, +0.16]	1	Logs bounds checks dashboard
➖	file_to_blackhole_0ms_latency_http1	egress throughput	+0.03	[-0.58, +0.64]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.01	[-0.63, +0.65]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.27, +0.27]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.02, +0.02]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	-0.02	[-0.25, +0.21]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	-0.05	[-0.66, +0.57]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.06	[-0.68, +0.56]	1	Logs
➖	ddot_metrics	memory utilization	-0.06	[-0.17, +0.05]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.08	[-0.69, +0.54]	1	Logs
➖	otlp_ingest_logs	memory utilization	-0.34	[-0.46, -0.22]	1	Logs
➖	docker_containers_memory	memory utilization	-0.70	[-0.78, -0.62]	1	Logs
➖	quality_gate_idle	memory utilization	-0.95	[-1.01, -0.90]	1	Logs bounds checks dashboard
➖	docker_containers_cpu	% cpu utilization	-2.00	[-5.78, +1.78]	1	Logs
➖	file_tree	memory utilization	-2.23	[-2.42, -2.03]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	docker_containers_cpu	simple_check_run	10/10
✅	docker_containers_memory	memory_usage	10/10
✅	docker_containers_memory	simple_check_run	10/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

guyarb and others added 30 commits March 17, 2025 16:25

usm: kafka: Rename const to indicate it is related to decoding

e849b36

usm: kafka: Differentiate between classification and decoding

7559cf7

Our classification can work with newer version of fetch and produce, while decoding can't We modify the code base to allow classifying all fetch APIs although the decoding supports only up to 12

usm: kafka: tests: Modify tests to verify classification works with l…

35d55ce

…atest fetch and produce versions

Merge branch 'main' into arbitman/kafka-enhanced-classification

5a90b7b

fixed leaking connections in tests, decreased KAFKA_CLASSIFICATION_MA…

cf11bde

…X_SUPPORTED_FETCH_REQUEST_API_VERSION to 12

bumped max produce version to 12

c31adb2

CR

ed0a081

works

7dd7a6d

revert fix for cleanProtocolMapByProtocol

11848df

Merge branch 'guy.mor/fix-tests-clean-kafka-procmap' into guy.mor/sup…

f1aad77

…port-produce-v11-and-fixes

changed kafka produce test to v11 (was v10)

e069718

added UUID v4 verification

729c91a

support fetch v17

8145e2e

CR 2

96ac999

fix kafka telemetry

10a0811

Merge branch 'guy.mor/support-produce-v11-and-fixes' into guy.mor/sup…

e9fe9d9

…port-new-produce-fetch-versions

upgraded kafka but left kafka-old

65e5971

upgraded franz-go kafka lib

1c7c52a

updated kmsg to non-broken beta version

5eeb6a1

review prep

ac2735d

usm: kafka: Rename const to indicate it is related to decoding

0974932

usm: kafka: Differentiate between classification and decoding

69cd220

Our classification can work with newer version of fetch and produce, while decoding can't We modify the code base to allow classifying all fetch APIs although the decoding supports only up to 12

fixed leaking connections in tests, decreased KAFKA_CLASSIFICATION_MA…

c915196

…X_SUPPORTED_FETCH_REQUEST_API_VERSION to 12

bumped max produce version to 12

f12ccf8

CR

e33783d

revert fix for cleanProtocolMapByProtocol

a772fe5

changed kafka produce test to v11 (was v10)

138c88b

CR 2

6faee8d

fix kafka telemetry

93236d5

add tests to make sure we don't test unsuppored versions

2748f47

guymor4 added 2 commits May 18, 2025 13:19

Merge branch 'main' into guy.mor/fetch-v13-classification

657a135

working POC for apiversions classification with debug prints

9c2f405

guymor4 and others added 6 commits May 21, 2025 18:20

fixed verifier bounds error

10f4fca

Fixed verifier

2208aa2

Merge branch 'main' into guy.mor/fetch-v13-classification

7e2a6e5

CR

83a0d93

switch another call to pktbuf_load_bytes_with_telemetry

64cf9df

parenthesis

06ccfca

guymor4 changed the base branch from guy.mor/support-new-produce-fetch-versions to guy.mor/fetch-v13-classification May 22, 2025 13:44

Merge branch 'guy.mor/fetch-v13-classification' into guy.mor/support-…

5149975

…decoding-fetch-v13

Base automatically changed from guy.mor/fetch-v13-classification to main May 22, 2025 19:32

guymor4 added 2 commits May 25, 2025 13:36

Merge branch 'main' into guy.mor/support-decoding-fetch-v13

ea6848d

api versions request classification works + passed testS

86ad2bf

github-actions bot added component/system-probe long review PR is complex, plan time to review it labels May 25, 2025

guymor4 added 12 commits May 25, 2025 15:41

removes classification debug logs

e414534

WIP - metadata response parsing works

21703ba

WIP - topic mapping POC

a059b89

WIP - fixes get_varint_number_of_topics bug

918a79d

should work

bb1f2b5

removed conntup in map, WIP

107b598

WIP

b92f3f2

working transactions - WIP

2fbd2e3

many topics works, fragmentation does not, debug logs

930a501

fixed max allowed topic name size

c6830f8

fixed more tests

d43564f

fixed map dump

f36c93b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Guy.mor/support decoding fetch v13 to v17 #36199

Guy.mor/support decoding fetch v13 to v17 #36199

Uh oh!

guymor4 commented Apr 16, 2025

Uh oh!

agent-platform-auto-pr bot commented May 18, 2025 •

edited

Loading

Uh oh!

agent-platform-auto-pr bot commented May 18, 2025 •

edited

Loading

Info

Uh oh!

cit-pr-commenter bot commented May 22, 2025 •

edited

Loading

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

Uh oh!

Uh oh!

Guy.mor/support decoding fetch v13 to v17 #36199

Are you sure you want to change the base?

Guy.mor/support decoding fetch v13 to v17 #36199

Uh oh!

Conversation

guymor4 commented Apr 16, 2025

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

Uh oh!

agent-platform-auto-pr bot commented May 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uncompressed package size comparison

Decision

Uh oh!

agent-platform-auto-pr bot commented May 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Static quality checks

Info

Uh oh!

cit-pr-commenter bot commented May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

CI Pass/Fail Decision

Uh oh!

Uh oh!

agent-platform-auto-pr bot commented May 18, 2025 •

edited

Loading

agent-platform-auto-pr bot commented May 18, 2025 •

edited

Loading

cit-pr-commenter bot commented May 22, 2025 •

edited

Loading