Skip to content

[ AGNTLOG-56 ] - Final removal of the pkg/logs/auditor instance #36348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2025
Merged

[ AGNTLOG-56 ] - Final removal of the pkg/logs/auditor instance #36348

merged 1 commit into from
Jun 11, 2025

Conversation

ddrthall
Copy link
Contributor

@ddrthall ddrthall commented Apr 21, 2025 •
edited
Loading

What does this PR do?

Completely remove the now-defunct pkg/logs/auditor entity. It has no remaining usages in the codebase.

Motivation

Describe how you validated your changes

Automated build process were sufficient validation, not finding an imported package would be a compile time error.

Possible Drawbacks / Trade-offs

Additional Notes

Full MR list for auditor migration:
#36259
#36292
#36295
#36348

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Apr 21, 2025 •
edited
Loading

Uncompressed package size comparison

Comparison with ancestor e72db428cc3a791eefb13e5e8b5c81d228eb5d34

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB ✅ 773.46MB 773.46MB 0.50MB
datadog-agent-x86_64-rpm 0.00MB ✅ 782.41MB 782.41MB 0.50MB
datadog-agent-x86_64-suse 0.00MB ✅ 782.41MB 782.41MB 0.50MB
datadog-agent-arm64-deb 0.00MB ✅ 759.40MB 759.40MB 0.50MB
datadog-agent-aarch64-rpm 0.00MB ✅ 768.33MB 768.33MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB ✅ 31.99MB 31.99MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB ✅ 32.07MB 32.07MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB ✅ 32.07MB 32.07MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB ✅ 30.47MB 30.47MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB ✅ 380.17MB 380.17MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB ✅ 62.79MB 62.79MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB ✅ 62.88MB 62.88MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB ✅ 62.87MB 62.87MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB ✅ 59.37MB 59.37MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB ✅ 59.45MB 59.45MB 0.50MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

dda inv aws.create-vm --pipeline-id=62841792 --os-family=ubuntu

Note: This applies to commit b577d73

@cit-pr-commenter cit-pr-commenter
Copy link

cit-pr-commenter bot commented Apr 21, 2025 •
edited
Loading

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: e5268dc9-aace-437c-938f-2770f0c98e77

Baseline: 96e38c9
Comparison: ce04529
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ quality_gate_idle_all_features memory utilization +0.44 [+0.35, +0.53] 1 Logs bounds checks dashboard
➖ ddot_logs memory utilization +0.38 [+0.23, +0.52] 1 Logs
➖ docker_containers_cpu % cpu utilization +0.35 [-2.60, +3.31] 1 Logs
➖ quality_gate_idle memory utilization +0.16 [+0.10, +0.22] 1 Logs bounds checks dashboard
➖ file_to_blackhole_100ms_latency egress throughput +0.09 [-0.53, +0.71] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput +0.05 [-0.51, +0.61] 1 Logs
➖ file_to_blackhole_0ms_latency_http2 egress throughput +0.05 [-0.52, +0.62] 1 Logs
➖ otlp_ingest_metrics memory utilization +0.03 [-0.12, +0.19] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.02, +0.03] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput -0.00 [-0.28, +0.27] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput -0.01 [-0.64, +0.63] 1 Logs
➖ file_to_blackhole_1000ms_latency_linear_load egress throughput -0.02 [-0.26, +0.21] 1 Logs
➖ file_tree memory utilization -0.05 [-0.20, +0.11] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput -0.06 [-0.64, +0.52] 1 Logs
➖ file_to_blackhole_0ms_latency_http1 egress throughput -0.06 [-0.67, +0.55] 1 Logs
➖ file_to_blackhole_300ms_latency egress throughput -0.07 [-0.64, +0.51] 1 Logs
➖ quality_gate_logs % cpu utilization -0.15 [-2.90, +2.60] 1 Logs bounds checks dashboard
➖ uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.15 [-0.20, -0.10] 1 Logs
➖ tcp_syslog_to_blackhole ingress throughput -0.28 [-0.34, -0.23] 1 Logs
➖ ddot_metrics memory utilization -0.37 [-0.48, -0.25] 1 Logs
➖ docker_containers_memory memory utilization -0.60 [-0.66, -0.53] 1 Logs
➖ otlp_ingest_logs memory utilization -0.80 [-0.93, -0.67] 1 Logs
➖ uds_dogstatsd_to_api_cpu % cpu utilization -2.04 [-2.88, -1.20] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
✅ docker_containers_cpu simple_check_run 10/10
✅ docker_containers_memory memory_usage 10/10
✅ docker_containers_memory simple_check_run 10/10
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http1 memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http2 memory_usage 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_300ms_latency lost_bytes 10/10
✅ file_to_blackhole_300ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Apr 21, 2025 •
edited
Loading

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 96e38c9

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
✅ agent_deb_amd64 $${0}$$ $${696.06}$$ < $${752.99}$$ $${+0.09}$$ $${176.07}$$ < $${187.44}$$
✅ agent_deb_amd64_fips $${0}$$ $${694.29}$$ < $${751.36}$$ $${+0.02}$$ $${175.51}$$ < $${187.06}$$
✅ agent_heroku_amd64 $${0}$$ $${358.56}$$ < $${369.68}$$ $${-0}$$ $${96.5}$$ < $${99.55}$$
✅ agent_msi $${0}$$ $${959.87}$$ < $${987.01}$$ $${-0.01}$$ $${146.43}$$ < $${150.72}$$
✅ agent_rpm_amd64 $${0}$$ $${696.05}$$ < $${752.98}$$ $${+0.01}$$ $${177.56}$$ < $${190.03}$$
✅ agent_rpm_amd64_fips $${0}$$ $${694.28}$$ < $${751.35}$$ $${-0.02}$$ $${177.41}$$ < $${189.81}$$
✅ agent_rpm_arm64 $${0}$$ $${686.0}$$ < $${739.42}$$ $${+0.04}$$ $${161.04}$$ < $${171.23}$$
✅ agent_rpm_arm64_fips $${0}$$ $${684.35}$$ < $${737.91}$$ $${+0.03}$$ $${160.1}$$ < $${170.22}$$
✅ agent_suse_amd64 $${0}$$ $${696.05}$$ < $${752.98}$$ $${+0.01}$$ $${177.56}$$ < $${190.03}$$
✅ agent_suse_amd64_fips $${0}$$ $${694.28}$$ < $${751.35}$$ $${-0.02}$$ $${177.41}$$ < $${189.81}$$
✅ agent_suse_arm64 $${0}$$ $${686.0}$$ < $${739.42}$$ $${+0.04}$$ $${161.04}$$ < $${171.23}$$
✅ agent_suse_arm64_fips $${0}$$ $${684.35}$$ < $${737.91}$$ $${+0.03}$$ $${160.1}$$ < $${170.22}$$
✅ docker_agent_amd64 $${-0}$$ $${779.85}$$ < $${849.39}$$ $${-0}$$ $${268.59}$$ < $${288.34}$$
✅ docker_agent_arm64 $${+0}$$ $${793.26}$$ < $${858.97}$$ $${+0}$$ $${255.98}$$ < $${274.36}$$
✅ docker_agent_jmx_amd64 $${-0}$$ $${779.85}$$ < $${849.39}$$ $${-0}$$ $${268.59}$$ < $${288.34}$$
✅ docker_agent_jmx_arm64 $${+0}$$ $${793.26}$$ < $${858.97}$$ $${+0}$$ $${255.98}$$ < $${274.36}$$
✅ docker_agent_windows1809 $${-0}$$ $${779.85}$$ < $${849.39}$$ $${-0}$$ $${268.59}$$ < $${288.34}$$
✅ docker_agent_windows1809_core $${-0}$$ $${779.85}$$ < $${849.39}$$ $${-0}$$ $${268.59}$$ < $${288.34}$$
✅ docker_agent_windows1809_core_jmx $${-0}$$ $${779.85}$$ < $${849.39}$$ $${-0}$$ $${268.59}$$ < $${288.34}$$
✅ docker_agent_windows1809_jmx $${-0}$$ $${779.85}$$ < $${849.39}$$ $${-0}$$ $${268.59}$$ < $${288.34}$$
✅ docker_agent_windows2022 $${-0}$$ $${779.85}$$ < $${849.39}$$ $${-0}$$ $${268.59}$$ < $${288.34}$$
✅ docker_agent_windows2022_core $${-0}$$ $${779.85}$$ < $${849.39}$$ $${-0}$$ $${268.59}$$ < $${288.34}$$
✅ docker_agent_windows2022_core_jmx $${-0}$$ $${779.85}$$ < $${849.39}$$ $${-0}$$ $${268.59}$$ < $${288.34}$$
✅ docker_agent_windows2022_jmx $${-0}$$ $${779.85}$$ < $${849.39}$$ $${-0}$$ $${268.59}$$ < $${288.34}$$
✅ docker_cluster_agent_amd64 $${-0}$$ $${259.2}$$ < $${259.73}$$ $${-0}$$ $${102.88}$$ < $${103.68}$$
✅ docker_cluster_agent_arm64 $${-0}$$ $${273.58}$$ < $${274.24}$$ $${-0}$$ $${97.61}$$ < $${98.45}$$
✅ docker_cws_instrumentation_amd64 $${0}$$ $${7.08}$$ < $${7.12}$$ $${+0}$$ $${2.95}$$ < $${3.29}$$
✅ docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${+0}$$ $${2.7}$$ < $${3.07}$$
✅ docker_dogstatsd_amd64 $${+0}$$ $${38.93}$$ < $${39.57}$$ $${-0}$$ $${14.95}$$ < $${15.76}$$
✅ docker_dogstatsd_arm64 $${0}$$ $${37.52}$$ < $${38.2}$$ $${+0}$$ $${13.96}$$ < $${14.83}$$
✅ dogstatsd_deb_amd64 $${0}$$ $${30.61}$$ < $${31.52}$$ $${+0}$$ $${8.04}$$ < $${8.97}$$
✅ dogstatsd_deb_arm64 $${0}$$ $${29.16}$$ < $${30.08}$$ $${+0}$$ $${6.97}$$ < $${7.92}$$
✅ dogstatsd_rpm_amd64 $${0}$$ $${30.61}$$ < $${31.52}$$ $${-0}$$ $${8.04}$$ < $${8.98}$$
✅ dogstatsd_suse_amd64 $${0}$$ $${30.61}$$ < $${31.52}$$ $${-0}$$ $${8.04}$$ < $${8.98}$$
✅ iot_agent_deb_amd64 $${0}$$ $${50.49}$$ < $${60.17}$$ $${-0}$$ $${12.85}$$ < $${15.82}$$
✅ iot_agent_deb_arm64 $${0}$$ $${47.94}$$ < $${56.94}$$ $${+0}$$ $${11.14}$$ < $${13.86}$$
✅ iot_agent_deb_armhf $${0}$$ $${47.52}$$ < $${56.41}$$ $${-0.01}$$ $${11.21}$$ < $${13.86}$$
✅ iot_agent_rpm_amd64 $${0}$$ $${50.49}$$ < $${60.18}$$ $${+0}$$ $${12.87}$$ < $${15.84}$$
✅ iot_agent_rpm_arm64 $${0}$$ $${47.94}$$ < $${56.94}$$ $${-0}$$ $${11.16}$$ < $${13.76}$$
✅ iot_agent_suse_amd64 $${0}$$ $${50.49}$$ < $${60.18}$$ $${+0}$$ $${12.87}$$ < $${15.84}$$

@ddrthall ddrthall force-pushed the ryan.hall/logs-agent-auditor-v4 branch from b577d73 to 26af1d9 Compare April 24, 2025 20:14
@ddrthall ddrthall mentioned this pull request Apr 25, 2025
Merged
@ddrthall ddrthall force-pushed the ryan.hall/logs-agent-auditor-v4 branch from 26af1d9 to e1eab75 Compare April 25, 2025 19:49
This was referenced May 1, 2025
Merged
Merged
@ddrthall ddrthall added this to the 7.67.0 milestone May 13, 2025
@ddrthall ddrthall force-pushed the ryan.hall/logs-agent-auditor-v4 branch 2 times, most recently from 040b412 to 0b73c17 Compare May 20, 2025 19:36
@ddrthall ddrthall modified the milestones: 7.67.0, 7.68.0 May 20, 2025
@ddrthall ddrthall added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests labels May 20, 2025
@ddrthall ddrthall force-pushed the ryan.hall/logs-agent-auditor-v4 branch 2 times, most recently from 534fc93 to d640167 Compare May 23, 2025 18:31
@ddrthall ddrthall force-pushed the ryan.hall/logs-agent-auditor-v4 branch 2 times, most recently from aa742d2 to eb10a34 Compare June 2, 2025 17:13
@ddrthall ddrthall force-pushed the ryan.hall/logs-agent-auditor-v4 branch from eb10a34 to ce04529 Compare June 10, 2025 11:51
@ddrthall ddrthall marked this pull request as ready for review June 10, 2025 13:49
@ddrthall ddrthall requested review from a team as code owners June 10, 2025 13:49
@ddrthall ddrthall requested a review from misteriaud June 10, 2025 13:49
@ddrthall
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jun 11, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-06-11 12:47:18 UTC ℹ️ Start processing command /merge

2025-06-11 12:47:24 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 47m (p90).

2025-06-11 13:31:24 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit b6186a8 into main Jun 11, 2025
524 of 526 checks passed
@dd-mergequeue dd-mergequeue bot deleted the ryan.hall/logs-agent-auditor-v4 branch June 11, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soberpeach soberpeach soberpeach approved these changes

@misteriaud misteriaud misteriaud approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog component/system-probe long review PR is complex, plan time to review it qa/done QA done before merge and regressions are covered by tests team/agent-log-pipelines
Projects
None yet
Milestone
7.68.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ddrthall @soberpeach @misteriaud