[USMON-1439] - Add error types to USM Redis stats #36857

Saarshta · 2025-05-12T08:23:31Z

What does this PR do?

Adds reporting of error prefix for USM Redis stats.

Motivation

Let customers know what type of errors they receive, other than indicating whether an error occurred or not.

Describe how you validated your changes

Updated tests to use error types.
Tested in staging.

Possible Drawbacks / Trade-offs

Additional Notes

agent-platform-auto-pr · 2025-05-14T11:31:28Z

Uncompressed package size comparison

Comparison with ancestor f3e0381b6de8ea5570594c8ddce9904fdb151d42

Diff per package

package	diff	status	size	ancestor	threshold
datadog-agent-x86_64-rpm	0.17MB	⚠️	782.57MB	782.40MB	0.50MB
datadog-agent-x86_64-suse	0.17MB	⚠️	782.57MB	782.40MB	0.50MB
datadog-agent-amd64-deb	0.17MB	⚠️	773.62MB	773.45MB	0.50MB
datadog-agent-aarch64-rpm	0.16MB	⚠️	768.49MB	768.33MB	0.50MB
datadog-agent-arm64-deb	0.16MB	⚠️	759.56MB	759.40MB	0.50MB
datadog-heroku-agent-amd64-deb	0.02MB	⚠️	380.20MB	380.17MB	0.50MB
datadog-iot-agent-amd64-deb	0.02MB	⚠️	62.81MB	62.79MB	0.50MB
datadog-iot-agent-x86_64-rpm	0.02MB	⚠️	62.90MB	62.88MB	0.50MB
datadog-iot-agent-x86_64-suse	0.02MB	⚠️	62.90MB	62.87MB	0.50MB
datadog-iot-agent-aarch64-rpm	0.02MB	⚠️	59.46MB	59.45MB	0.50MB
datadog-iot-agent-arm64-deb	0.02MB	⚠️	59.38MB	59.37MB	0.50MB
datadog-dogstatsd-amd64-deb	0.00MB	✅	31.99MB	31.99MB	0.50MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	32.07MB	32.07MB	0.50MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	32.07MB	32.07MB	0.50MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	30.47MB	30.47MB	0.50MB

Decision

⚠️ Warning

cit-pr-commenter · 2025-05-27T07:57:23Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: a7dd9d3f-3aab-40d7-bb88-017c4d43843a

Baseline: 7f0b911
Comparison: 730fd59
Diff

Optimization Goals: ❌ Regression(s) detected

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
❌	docker_containers_cpu	% cpu utilization	+5.38	[+2.26, +8.50]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
❌	docker_containers_cpu	% cpu utilization	+5.38	[+2.26, +8.50]	1	Logs
➖	quality_gate_idle	memory utilization	+0.69	[+0.63, +0.75]	1	Logs bounds checks dashboard
➖	file_tree	memory utilization	+0.69	[+0.52, +0.86]	1	Logs
➖	ddot_logs	memory utilization	+0.45	[+0.30, +0.59]	1	Logs
➖	docker_containers_memory	memory utilization	+0.39	[+0.32, +0.46]	1	Logs
➖	otlp_ingest_metrics	memory utilization	+0.32	[+0.16, +0.49]	1	Logs
➖	otlp_ingest_logs	memory utilization	+0.25	[+0.12, +0.38]	1	Logs
➖	ddot_metrics	memory utilization	+0.10	[-0.02, +0.21]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.09	[-0.47, +0.66]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.09	[-0.00, +0.18]	1	Logs bounds checks dashboard
➖	file_to_blackhole_0ms_latency	egress throughput	+0.08	[-0.47, +0.63]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	+0.04	[-0.58, +0.66]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.27, +0.27]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.02, +0.01]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	-0.01	[-0.25, +0.23]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.02	[-0.63, +0.58]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.03	[-0.64, +0.59]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	-0.03	[-0.57, +0.51]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	-0.08	[-0.64, +0.49]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-0.18	[-0.24, -0.13]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	-0.20	[-0.25, -0.15]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-1.76	[-2.60, -0.92]	1	Logs
➖	quality_gate_logs	% cpu utilization	-2.78	[-5.50, -0.05]	1	Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	docker_containers_cpu	simple_check_run	10/10
✅	docker_containers_memory	memory_usage	10/10
✅	docker_containers_memory	simple_check_run	10/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

agent-platform-auto-pr · 2025-05-27T10:47:31Z

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 1e89f14

Successful checks

Info

	Quality gate	Delta	On disk size (MiB)	Delta	On wire size (MiB)
✅	agent_deb_amd64	$${\color{red}+0.17}$$	$${\color{green}747.57}$$ < $${752.99}$$	$${\color{green}-0.02}$$	$${\color{green}185.08}$$ < $${187.44}$$
✅	agent_deb_amd64_fips	$${\color{red}+0.16}$$	$${\color{green}745.93}$$ < $${751.36}$$	$${\color{red}+0.02}$$	$${\color{green}184.53}$$ < $${187.06}$$
✅	agent_heroku_amd64	$${\color{red}+0.02}$$	$${\color{green}368.88}$$ < $${369.68}$$	$${\color{red}+0.01}$$	$${\color{green}98.71}$$ < $${99.55}$$
✅	agent_msi	$${\color{red}+0.09}$$	$${\color{green}986.4}$$ < $${987.01}$$	$${\color{red}+0.03}$$	$${\color{green}149.82}$$ < $${150.72}$$
✅	agent_rpm_amd64	$${\color{red}+0.17}$$	$${\color{green}747.56}$$ < $${752.98}$$	$${\color{red}+0.04}$$	$${\color{green}186.67}$$ < $${190.03}$$
✅	agent_rpm_amd64_fips	$${\color{red}+0.16}$$	$${\color{green}745.92}$$ < $${751.35}$$	$${\color{red}+0.01}$$	$${\color{green}186.32}$$ < $${189.81}$$
✅	agent_rpm_arm64	$${\color{red}+0.16}$$	$${\color{green}734.18}$$ < $${739.42}$$	$${\color{red}+0.04}$$	$${\color{green}168.75}$$ < $${171.23}$$
✅	agent_rpm_arm64_fips	$${\color{red}+0.17}$$	$${\color{green}732.68}$$ < $${737.91}$$	$${\color{red}+0.05}$$	$${\color{green}167.79}$$ < $${170.22}$$
✅	agent_suse_amd64	$${\color{red}+0.17}$$	$${\color{green}747.56}$$ < $${752.98}$$	$${\color{red}+0.04}$$	$${\color{green}186.67}$$ < $${190.03}$$
✅	agent_suse_amd64_fips	$${\color{red}+0.16}$$	$${\color{green}745.92}$$ < $${751.35}$$	$${\color{red}+0.01}$$	$${\color{green}186.32}$$ < $${189.81}$$
✅	agent_suse_arm64	$${\color{red}+0.16}$$	$${\color{green}734.18}$$ < $${739.42}$$	$${\color{red}+0.04}$$	$${\color{green}168.75}$$ < $${171.23}$$
✅	agent_suse_arm64_fips	$${\color{red}+0.17}$$	$${\color{green}732.68}$$ < $${737.91}$$	$${\color{red}+0.05}$$	$${\color{green}167.79}$$ < $${170.22}$$
✅	docker_agent_amd64	$${\color{red}+0.17}$$	$${\color{green}831.35}$$ < $${849.39}$$	$${\color{red}+0.06}$$	$${\color{green}282.36}$$ < $${288.34}$$
✅	docker_agent_arm64	$${\color{red}+0.16}$$	$${\color{green}841.43}$$ < $${858.97}$$	$${\color{red}+0.04}$$	$${\color{green}268.44}$$ < $${274.36}$$
✅	docker_agent_jmx_amd64	$${\color{red}+0.17}$$	$${\color{green}831.35}$$ < $${849.39}$$	$${\color{red}+0.06}$$	$${\color{green}282.36}$$ < $${288.34}$$
✅	docker_agent_jmx_arm64	$${\color{red}+0.16}$$	$${\color{green}841.43}$$ < $${858.97}$$	$${\color{red}+0.04}$$	$${\color{green}268.44}$$ < $${274.36}$$
✅	docker_agent_windows1809	$${\color{red}+0.17}$$	$${\color{green}831.35}$$ < $${849.39}$$	$${\color{red}+0.06}$$	$${\color{green}282.36}$$ < $${288.34}$$
✅	docker_agent_windows1809_core	$${\color{red}+0.17}$$	$${\color{green}831.35}$$ < $${849.39}$$	$${\color{red}+0.06}$$	$${\color{green}282.36}$$ < $${288.34}$$
✅	docker_agent_windows1809_core_jmx	$${\color{red}+0.17}$$	$${\color{green}831.35}$$ < $${849.39}$$	$${\color{red}+0.06}$$	$${\color{green}282.36}$$ < $${288.34}$$
✅	docker_agent_windows1809_jmx	$${\color{red}+0.17}$$	$${\color{green}831.35}$$ < $${849.39}$$	$${\color{red}+0.06}$$	$${\color{green}282.36}$$ < $${288.34}$$
✅	docker_agent_windows2022	$${\color{red}+0.17}$$	$${\color{green}831.35}$$ < $${849.39}$$	$${\color{red}+0.06}$$	$${\color{green}282.36}$$ < $${288.34}$$
✅	docker_agent_windows2022_core	$${\color{red}+0.17}$$	$${\color{green}831.35}$$ < $${849.39}$$	$${\color{red}+0.06}$$	$${\color{green}282.36}$$ < $${288.34}$$
✅	docker_agent_windows2022_core_jmx	$${\color{red}+0.17}$$	$${\color{green}831.35}$$ < $${849.39}$$	$${\color{red}+0.06}$$	$${\color{green}282.36}$$ < $${288.34}$$
✅	docker_agent_windows2022_jmx	$${\color{red}+0.17}$$	$${\color{green}831.35}$$ < $${849.39}$$	$${\color{red}+0.06}$$	$${\color{green}282.36}$$ < $${288.34}$$
✅	docker_cluster_agent_amd64	$${\color{red}+0.02}$$	$${\color{green}259.12}$$ < $${259.73}$$	$${\color{red}+0.01}$$	$${\color{green}102.85}$$ < $${103.68}$$
✅	docker_cluster_agent_arm64	$${\color{red}+0}$$	$${\color{green}273.57}$$ < $${274.24}$$	$${\color{green}-0}$$	$${\color{green}97.57}$$ < $${98.45}$$
✅	docker_cws_instrumentation_amd64	$${\color{red}+0}$$	$${\color{green}7.08}$$ < $${7.12}$$	$${\color{red}+0}$$	$${\color{green}2.95}$$ < $${3.29}$$
✅	docker_cws_instrumentation_arm64	$${\color{green}0}$$	$${\color{green}6.69}$$ < $${6.92}$$	$${\color{green}-0}$$	$${\color{green}2.7}$$ < $${3.07}$$
✅	docker_dogstatsd_amd64	$${\color{green}-0}$$	$${\color{green}38.92}$$ < $${39.57}$$	$${\color{red}+0}$$	$${\color{green}14.95}$$ < $${15.76}$$
✅	docker_dogstatsd_arm64	$${\color{red}+0}$$	$${\color{green}37.52}$$ < $${38.2}$$	$${\color{green}-0}$$	$${\color{green}13.96}$$ < $${14.83}$$
✅	dogstatsd_deb_amd64	$${\color{green}0}$$	$${\color{green}30.6}$$ < $${31.52}$$	$${\color{red}+0}$$	$${\color{green}8.03}$$ < $${8.97}$$
✅	dogstatsd_deb_arm64	$${\color{green}0}$$	$${\color{green}29.16}$$ < $${30.08}$$	$${\color{red}+0}$$	$${\color{green}6.97}$$ < $${7.92}$$
✅	dogstatsd_rpm_amd64	$${\color{green}0}$$	$${\color{green}30.6}$$ < $${31.52}$$	$${\color{green}-0}$$	$${\color{green}8.04}$$ < $${8.98}$$
✅	dogstatsd_suse_amd64	$${\color{green}0}$$	$${\color{green}30.6}$$ < $${31.52}$$	$${\color{green}-0}$$	$${\color{green}8.04}$$ < $${8.98}$$
✅	iot_agent_deb_amd64	$${\color{red}+0.02}$$	$${\color{green}59.95}$$ < $${60.17}$$	$${\color{red}+0}$$	$${\color{green}14.99}$$ < $${15.82}$$
✅	iot_agent_deb_arm64	$${\color{red}+0.02}$$	$${\color{green}56.68}$$ < $${56.94}$$	$${\color{red}+0.01}$$	$${\color{green}12.86}$$ < $${13.86}$$
✅	iot_agent_deb_armhf	$${\color{red}+0.02}$$	$${\color{green}56.12}$$ < $${56.41}$$	$${\color{green}-0.02}$$	$${\color{green}12.98}$$ < $${13.86}$$
✅	iot_agent_rpm_amd64	$${\color{red}+0.02}$$	$${\color{green}59.95}$$ < $${60.18}$$	$${\color{red}+0.01}$$	$${\color{green}15.01}$$ < $${15.84}$$
✅	iot_agent_rpm_arm64	$${\color{red}+0.02}$$	$${\color{green}56.68}$$ < $${56.94}$$	$${\color{red}+0}$$	$${\color{green}12.88}$$ < $${13.76}$$
✅	iot_agent_suse_amd64	$${\color{red}+0.02}$$	$${\color{green}59.95}$$ < $${60.18}$$	$${\color{red}+0.01}$$	$${\color{green}15.01}$$ < $${15.84}$$

guyarb · 2025-06-04T12:51:07Z

pkg/network/ebpf/c/protocols/redis/decoding.h

+    if (bpf_memcmp(prefix, "ERR", 3) == 0) return REDIS_ERR_ERR;
+     if (bpf_memcmp(prefix, "WRONGTYPE", 9) == 0) return REDIS_ERR_WRONGTYPE;
+     if (bpf_memcmp(prefix, "NOAUTH", 6) == 0) return REDIS_ERR_NOAUTH;
+     if (bpf_memcmp(prefix, "NOPERM", 6) == 0) return REDIS_ERR_NOPERM;
+     if (bpf_memcmp(prefix, "BUSY", 4) == 0) return REDIS_ERR_BUSY;
+     if (bpf_memcmp(prefix, "NOSCRIPT", 8) == 0) return REDIS_ERR_NOSCRIPT;
+     if (bpf_memcmp(prefix, "LOADING", 7) == 0) return REDIS_ERR_LOADING;
+     if (bpf_memcmp(prefix, "READONLY", 8) == 0) return REDIS_ERR_READONLY;
+     if (bpf_memcmp(prefix, "EXECABORT", 9) == 0) return REDIS_ERR_EXECABORT;
+     if (bpf_memcmp(prefix, "MASTERDOWN", 10) == 0) return REDIS_ERR_MASTERDOWN;
+     if (bpf_memcmp(prefix, "MISCONF", 7) == 0) return REDIS_ERR_MISCONF;
+     if (bpf_memcmp(prefix, "CROSSSLOT", 9) == 0) return REDIS_ERR_CROSSSLOT;
+     if (bpf_memcmp(prefix, "TRYAGAIN", 8) == 0) return REDIS_ERR_TRYAGAIN;
+     if (bpf_memcmp(prefix, "ASK", 3) == 0) return REDIS_ERR_ASK;
+     if (bpf_memcmp(prefix, "MOVED", 5) == 0) return REDIS_ERR_MOVED;
+     if (bpf_memcmp(prefix, "CLUSTERDOWN", 11) == 0) return REDIS_ERR_CLUSTERDOWN;
+     if (bpf_memcmp(prefix, "NOREPLICAS", 10) == 0) return REDIS_ERR_NOREPLICAS;
+     if (bpf_memcmp(prefix, "OOM", 3) == 0) return REDIS_ERR_OOM;
+     if (bpf_memcmp(prefix, "NOQUORUM", 8) == 0) return REDIS_ERR_NOQUORUM;
+     if (bpf_memcmp(prefix, "BUSYKEY", 7) == 0) return REDIS_ERR_BUSYKEY;
+     if (bpf_memcmp(prefix, "UNBLOCKED", 9) == 0) return REDIS_ERR_UNBLOCKED;
+     if (bpf_memcmp(prefix, "WRONGPASS", 9) == 0) return REDIS_ERR_WRONGPASS;
+     if (bpf_memcmp(prefix, "INVALIDOBJ", 7) == 0) return REDIS_ERR_INVALIDOBJ;


I do recommend on usind #define on the strings, and use sizeof instead of hardcoded sizes

Also, it might be benefitcal to store the PREFIXES and their values in a hash map
and just check if the key exists in the map

guyarb · 2025-06-04T12:54:08Z

pkg/network/ebpf/c/protocols/redis/decoding.h

+        bool got_error = extract_redis_error_prefix(pkt, error_prefix, sizeof(error_prefix));
+        if (got_error) {
+            transaction->error = map_redis_error_prefix(error_prefix);
+        } else {
+            transaction->error = REDIS_ERR_UNKNOWN;
+        }


With my previous comment, I think the condition is redundant, as eventually transaction->error = map_redis_error_prefix should suffice, as the default behavior is REDIS_ERR_UNKNOWN

guyarb · 2025-06-04T12:54:29Z

pkg/network/ebpf/c/protocols/redis/defs.h

@@ -13,6 +13,7 @@
 #define METHOD_LEN 3 // We only support GET and SET for now, both with length 3.
 #define MAX_DIGITS_KEY_LEN_PREFIX 3 // Since we clamp key length to 128, when reading key length prefix, we only need to read up to 3 digits.
 #define MAX_KEY_LEN 128
+#define MAX_ERROR_SIZE 20


guyarb · 2025-06-04T12:56:12Z

pkg/network/ebpf/c/protocols/redis/types.h

+    REDIS_ERR_UNKNOWN = 1,
+    REDIS_ERR_ERR = 2,
+    REDIS_ERR_WRONGTYPE = 3,
+    REDIS_ERR_NOAUTH = 4,
+    REDIS_ERR_NOPERM = 5,
+    REDIS_ERR_BUSY = 6,
+    REDIS_ERR_NOSCRIPT = 7,
+    REDIS_ERR_LOADING = 8,
+    REDIS_ERR_READONLY = 9,
+    REDIS_ERR_EXECABORT = 10,
+    REDIS_ERR_MASTERDOWN = 11,
+    REDIS_ERR_MISCONF = 12,
+    REDIS_ERR_CROSSSLOT = 13,
+    REDIS_ERR_TRYAGAIN = 14,
+    REDIS_ERR_ASK = 15,
+    REDIS_ERR_MOVED = 16,
+    REDIS_ERR_CLUSTERDOWN = 17,
+    REDIS_ERR_NOREPLICAS = 18,
+    REDIS_ERR_OOM = 19,
+    REDIS_ERR_NOQUORUM = 20,
+    REDIS_ERR_BUSYKEY = 21,
+    REDIS_ERR_UNBLOCKED = 22,
+    REDIS_ERR_WRONGPASS = 23,
+    REDIS_ERR_INVALIDOBJ = 24


numbers are redundant after you've initialized the first element (if it is 0 you don't need to declare)

pkg/network/encoding/marshal/usm_redis.go

pkg/network/protocols/redis/model_linux.go

guyarb · 2025-06-04T12:58:36Z

pkg/network/ebpf/c/protocols/redis/types.h

+    redis_command_t command;      // 1 byte
+    __u8 tags;                   // 1 byte
+    bool truncated;              // 1 byte
+    bool is_error;               // 1 byte


why do we need is_error?

guyarb

reviewed

As we now report the actual error, we don't need the binary flag to indicate if we have an error

github-actions bot added component/system-probe medium review PR review might take time long review PR is complex, plan time to review it and removed medium review PR review might take time labels May 12, 2025

WIP - report Redis error types

e47d731

Saarshta force-pushed the saar.shtalryd/redis-errors branch from 98986f8 to e47d731 Compare May 21, 2025 11:19

Saarshta added 5 commits May 21, 2025 15:00

Merge branch 'main' into saar.shtalryd/redis-errors

2c5ddfe

WIP

83d6220

Minor bug fix to propagate error type properly

590bdac

Fix tests, merge main

5243e75

dda inv tidy

595ec62

Saarshta added team/usm The USM team qa/done QA done before merge and regressions are covered by tests changelog/no-changelog labels May 26, 2025

Saarshta added 4 commits May 26, 2025 16:12

Fix tests

e680652

Fix wrong redis error type

823364f

Fix tests

03ba9da

Minor bug fix

c7f756b

Reorder redis_transaction_t struct

72438cb

Saarshta added 8 commits May 27, 2025 13:50

Fix tests

c22e78d

Fix tests

78ced58

Fix tests

3d59d18

Fix tests

7f254a2

Fix verifier

b79368f

Fix verifier

7fd541c

Reduce memory usage

8476a72

Merge main

f12b680

Bump agent-payload version

a94f5f1

Saarshta changed the title ~~Saar.shtalryd/redis errors~~ [USMON-1439] - Add error types to USM Redis stats Jun 4, 2025

Saarshta marked this pull request as ready for review June 4, 2025 12:43

Saarshta requested a review from a team as a code owner June 4, 2025 12:43

guyarb reviewed Jun 4, 2025

View reviewed changes

pkg/network/encoding/marshal/usm_redis.go Show resolved Hide resolved

guyarb reviewed Jun 4, 2025

View reviewed changes

pkg/network/protocols/redis/model_linux.go Show resolved Hide resolved

guyarb reviewed Jun 4, 2025

View reviewed changes

Saarshta and others added 11 commits June 5, 2025 16:31

Add debug log for redis errors

d78630c

Add debug log for redis errors

83d7347

attempt to fix cgo alignment

a4acc16

attempt to fix cgo alignment

de18d28

Remove debug logs

2a9e178

CR comments

478a423

Merge branch 'main' into saar.shtalryd/redis-errors

42f0384

usm: redis: Remove redundant is_error from the kernel struct

dde69c9

As we now report the actual error, we don't need the binary flag to indicate if we have an error

usm: redis: Added debug log for finding the error on staging

bef53ca

usm: merge with above: remove is_error from tests

730fd59

Wip

eb29d32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[USMON-1439] - Add error types to USM Redis stats #36857

[USMON-1439] - Add error types to USM Redis stats #36857

Uh oh!

Saarshta commented May 12, 2025 •

edited

Loading

Uh oh!

agent-platform-auto-pr bot commented May 14, 2025 •

edited

Loading

Uh oh!

cit-pr-commenter bot commented May 27, 2025 •

edited

Loading

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

Uh oh!

agent-platform-auto-pr bot commented May 27, 2025 •

edited

Loading

Info

Uh oh!

guyarb Jun 4, 2025

Uh oh!

guyarb Jun 4, 2025

Uh oh!

guyarb Jun 4, 2025

Uh oh!

guyarb Jun 4, 2025

Uh oh!

Uh oh!

Uh oh!

guyarb Jun 4, 2025

Uh oh!

guyarb left a comment

Uh oh!

Uh oh!

[USMON-1439] - Add error types to USM Redis stats #36857

Are you sure you want to change the base?

[USMON-1439] - Add error types to USM Redis stats #36857

Uh oh!

Conversation

Saarshta commented May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

Uh oh!

agent-platform-auto-pr bot commented May 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uncompressed package size comparison

Decision

Uh oh!

cit-pr-commenter bot commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Regression Detector

Regression Detector Results

Optimization Goals: ❌ Regression(s) detected

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

CI Pass/Fail Decision

Uh oh!

agent-platform-auto-pr bot commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Static quality checks

Info

Uh oh!

guyarb Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

guyarb Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

guyarb Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

guyarb Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

guyarb Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

guyarb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Saarshta commented May 12, 2025 •

edited

Loading

agent-platform-auto-pr bot commented May 14, 2025 •

edited

Loading

cit-pr-commenter bot commented May 27, 2025 •

edited

Loading

agent-platform-auto-pr bot commented May 27, 2025 •

edited

Loading