[CONTP-675]Autoscaling Failover local workload store check: subcommand, flare support #37248

zhuminyi · 2025-05-21T16:43:10Z

What does this PR do?

This PR add agent subcommand and flare report to get local autoscaling status, including store entity number, metadata etc from cluster agent

Motivation

Describe how you validated your changes

Enable autoscaling failover setting

datadog:
  env:
    - name: DD_AUTOSCALING_FAILOVER_ENABLED
      value: "true"
    - name: DD_AUTOSCALING_FAILOVER_METRICS
      value: "container.memory.usage container.cpu.usage"
clusterAgent:
  enabled: true
  replicas: 2
  env:
    - name: DD_AUTOSCALING_FAILOVER_ENABLED
      value: "true"

Go to leader cluster-agent

Run agent autoscaler-list --localstore

=== Workload Failover Metric Entity List  ===
Namespace: workload-apm, PodOwner: go-app, MetricName: container.memory.usage, Datapoints: 1
Namespace: workload-redis, PodOwner: redis-query, MetricName: container.memory.usage, Datapoints: 1
Namespace: workload-notesapp, PodOwner: notes-app-deployment, MetricName: container.memory.usage, Datapoints: 2
Namespace: workload-apm, PodOwner: nodejs-app, MetricName: container.memory.usage, Datapoints: 1
Namespace: gmp-system, PodOwner: gmp-operator, MetricName: container.memory.usage, Datapoints: 1
Namespace: workload-notesapp, PodOwner: notes-app-deployment, MetricName: container.cpu.usage, Datapoints: 2
Namespace: workload-redis, PodOwner: redis-query, MetricName: container.cpu.usage, Datapoints: 1
Namespace: workload-apm, PodOwner: nodejs-app, MetricName: container.cpu.usage, Datapoints: 1
Namespace: workload-redis, PodOwner: redis, MetricName: container.memory.usage, Datapoints: 1
Namespace: workload-nginx, PodOwner: nginx, MetricName: container.cpu.usage, Datapoints: 1
Namespace: workload-redis, PodOwner: redis, MetricName: container.cpu.usage, Datapoints: 1
Namespace: workload-nginx, PodOwner: nginx, MetricName: container.memory.usage, Datapoints: 1
Namespace: workload-apm, PodOwner: go-app, MetricName: container.cpu.usage, Datapoints: 1
Namespace: gmp-system, PodOwner: gmp-operator, MetricName: container.cpu.usage, Datapoints: 1

This is also accessible through curl -v -k https://localhost:5005/local-autoscaling-check -H "Authorization: Bearer $DD_CLUSTER_AGENT_AUTH_TOKEN
run agent flare and find local-autoscaling-check.json, example output

{
	"LocalAutoscalingWorkloadEntities": [
		{
			"Datapoints(PodLevel)": 1,
			"MetricName": "container.memory.usage",
			"Namespace": "workload-redis",
			"PodOwner": "redis"
		},
		{
			"Datapoints(PodLevel)": 1,
			"MetricName": "container.memory.usage",
			"Namespace": "workload-nginx",
			"PodOwner": "nginx"
		},
		{
			"Datapoints(PodLevel)": 1,
			"MetricName": "container.memory.usage",
			"Namespace": "kube-system",
			"PodOwner": "metrics-server-v1.32.2"
		},
		{
			"Datapoints(PodLevel)": 1,
			"MetricName": "container.memory.usage",
			"Namespace": "workload-apm",
			"PodOwner": "nodejs-app"
		}
	]
}

Possible Drawbacks / Trade-offs

Additional Notes

cit-pr-commenter · 2025-05-21T16:58:21Z

Go Package Import Differences

Baseline: ad0e415
Comparison: 0abefa1

binary	os	arch	change
cluster-agent-cloudfoundry	linux	amd64	+1, -0 +github.com/DataDog/datadog-agent/pkg/clusteragent/autoscaling/workload/loadstore
cluster-agent-cloudfoundry	linux	arm64	+1, -0 +github.com/DataDog/datadog-agent/pkg/clusteragent/autoscaling/workload/loadstore

agent-platform-auto-pr · 2025-05-21T17:16:01Z

Uncompressed package size comparison

Comparison with ancestor 06e08cf387fb430c0acb1508a8e0b55778d2f6c7

Diff per package

package	diff	status	size	ancestor	threshold
datadog-agent-x86_64-rpm	0.00MB	✅	783.22MB	783.22MB	0.50MB
datadog-agent-x86_64-suse	0.00MB	✅	783.22MB	783.22MB	0.50MB
datadog-agent-amd64-deb	0.00MB	✅	774.27MB	774.27MB	0.50MB
datadog-agent-aarch64-rpm	0.00MB	✅	769.30MB	769.30MB	0.50MB
datadog-agent-arm64-deb	0.00MB	✅	760.37MB	760.37MB	0.50MB
datadog-dogstatsd-amd64-deb	0.00MB	✅	31.99MB	31.99MB	0.50MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	32.07MB	32.07MB	0.50MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	32.07MB	32.07MB	0.50MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	30.47MB	30.47MB	0.50MB
datadog-heroku-agent-amd64-deb	0.00MB	✅	380.65MB	380.65MB	0.50MB
datadog-iot-agent-amd64-deb	0.00MB	✅	62.80MB	62.80MB	0.50MB
datadog-iot-agent-x86_64-rpm	0.00MB	✅	62.88MB	62.88MB	0.50MB
datadog-iot-agent-x86_64-suse	0.00MB	✅	62.88MB	62.88MB	0.50MB
datadog-iot-agent-arm64-deb	0.00MB	✅	59.37MB	59.37MB	0.50MB
datadog-iot-agent-aarch64-rpm	0.00MB	✅	59.45MB	59.45MB	0.50MB

Decision

✅ Passed

cit-pr-commenter · 2025-05-21T18:07:58Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 54a0189b-ed1f-4d3b-806f-ac67aea8e18e

Baseline: ad0e415
Comparison: 0abefa1
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	ddot_metrics	memory utilization	+0.47	[+0.35, +0.59]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	+0.34	[+0.26, +0.41]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.30	[+0.21, +0.39]	1	Logs bounds checks dashboard
➖	otlp_ingest_metrics	memory utilization	+0.14	[-0.02, +0.31]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.11	[-0.49, +0.71]	1	Logs
➖	ddot_logs	memory utilization	+0.07	[-0.07, +0.21]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.06	[-0.47, +0.60]	1	Logs
➖	docker_containers_cpu	% cpu utilization	+0.05	[-2.99, +3.08]	1	Logs
➖	otlp_ingest_logs	memory utilization	+0.04	[-0.09, +0.17]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.02, +0.01]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.29, +0.28]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	-0.01	[-0.59, +0.56]	1	Logs
➖	quality_gate_idle	memory utilization	-0.02	[-0.08, +0.05]	1	Logs bounds checks dashboard
➖	file_to_blackhole_500ms_latency	egress throughput	-0.03	[-0.65, +0.59]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	-0.06	[-0.29, +0.18]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.06	[-0.59, +0.47]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	-0.06	[-0.62, +0.49]	1	Logs
➖	file_tree	memory utilization	-0.07	[-0.23, +0.08]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	-0.09	[-0.68, +0.51]	1	Logs
➖	quality_gate_logs	% cpu utilization	-0.32	[-3.07, +2.42]	1	Logs bounds checks dashboard
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-0.47	[-1.34, +0.40]	1	Logs
➖	docker_containers_memory	memory utilization	-0.80	[-0.85, -0.74]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	-0.89	[-0.93, -0.85]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	docker_containers_cpu	simple_check_run	10/10
✅	docker_containers_memory	memory_usage	10/10
✅	docker_containers_memory	simple_check_run	10/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

agent-platform-auto-pr · 2025-05-21T18:56:49Z

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor ad0e415

Successful checks

Info

	Quality gate	Delta	On disk size (MiB)	Delta	On wire size (MiB)
✅	agent_deb_amd64	$${0}$$	$${696.04}$$ < $${752.99}$$	$${-0.02}$$	$${176.02}$$ < $${187.44}$$
✅	agent_deb_amd64_fips	$${0}$$	$${694.26}$$ < $${751.36}$$	$${+0.02}$$	$${175.46}$$ < $${187.06}$$
✅	agent_heroku_amd64	$${0}$$	$${358.56}$$ < $${369.68}$$	$${-0}$$	$${96.5}$$ < $${99.55}$$
✅	agent_msi	$${0}$$	$${959.85}$$ < $${987.01}$$	$${+0.02}$$	$${146.46}$$ < $${150.72}$$
✅	agent_rpm_amd64	$${0}$$	$${696.03}$$ < $${752.98}$$	$${-0}$$	$${177.56}$$ < $${190.03}$$
✅	agent_rpm_amd64_fips	$${0}$$	$${694.25}$$ < $${751.35}$$	$${-0.01}$$	$${177.38}$$ < $${189.81}$$
✅	agent_rpm_arm64	$${0}$$	$${685.98}$$ < $${739.42}$$	$${-0.01}$$	$${160.99}$$ < $${171.23}$$
✅	agent_rpm_arm64_fips	$${0}$$	$${684.33}$$ < $${737.91}$$	$${+0}$$	$${160.07}$$ < $${170.22}$$
✅	agent_suse_amd64	$${0}$$	$${696.03}$$ < $${752.98}$$	$${-0}$$	$${177.56}$$ < $${190.03}$$
✅	agent_suse_amd64_fips	$${0}$$	$${694.25}$$ < $${751.35}$$	$${-0.01}$$	$${177.38}$$ < $${189.81}$$
✅	agent_suse_arm64	$${0}$$	$${685.98}$$ < $${739.42}$$	$${-0.01}$$	$${160.99}$$ < $${171.23}$$
✅	agent_suse_arm64_fips	$${0}$$	$${684.33}$$ < $${737.91}$$	$${+0}$$	$${160.07}$$ < $${170.22}$$
✅	docker_agent_amd64	$${+0}$$	$${779.82}$$ < $${849.39}$$	$${-0}$$	$${268.58}$$ < $${288.34}$$
✅	docker_agent_arm64	$${-0}$$	$${793.23}$$ < $${858.97}$$	$${+0}$$	$${255.96}$$ < $${274.36}$$
✅	docker_agent_jmx_amd64	$${+0}$$	$${779.82}$$ < $${849.39}$$	$${-0}$$	$${268.58}$$ < $${288.34}$$
✅	docker_agent_jmx_arm64	$${-0}$$	$${793.23}$$ < $${858.97}$$	$${+0}$$	$${255.96}$$ < $${274.36}$$
✅	docker_agent_windows1809	$${+0}$$	$${779.82}$$ < $${849.39}$$	$${-0}$$	$${268.58}$$ < $${288.34}$$
✅	docker_agent_windows1809_core	$${+0}$$	$${779.82}$$ < $${849.39}$$	$${-0}$$	$${268.58}$$ < $${288.34}$$
✅	docker_agent_windows1809_core_jmx	$${+0}$$	$${779.82}$$ < $${849.39}$$	$${-0}$$	$${268.58}$$ < $${288.34}$$
✅	docker_agent_windows1809_jmx	$${+0}$$	$${779.82}$$ < $${849.39}$$	$${-0}$$	$${268.58}$$ < $${288.34}$$
✅	docker_agent_windows2022	$${+0}$$	$${779.82}$$ < $${849.39}$$	$${-0}$$	$${268.58}$$ < $${288.34}$$
✅	docker_agent_windows2022_core	$${+0}$$	$${779.82}$$ < $${849.39}$$	$${-0}$$	$${268.58}$$ < $${288.34}$$
✅	docker_agent_windows2022_core_jmx	$${+0}$$	$${779.82}$$ < $${849.39}$$	$${-0}$$	$${268.58}$$ < $${288.34}$$
✅	docker_agent_windows2022_jmx	$${+0}$$	$${779.82}$$ < $${849.39}$$	$${-0}$$	$${268.58}$$ < $${288.34}$$
✅	docker_cluster_agent_amd64	$${+0.01}$$	$${259.2}$$ < $${259.73}$$	$${+0}$$	$${102.89}$$ < $${103.68}$$
✅	docker_cluster_agent_arm64	$${-0}$$	$${273.64}$$ < $${274.24}$$	$${+0}$$	$${97.6}$$ < $${98.45}$$
✅	docker_cws_instrumentation_amd64	$${0}$$	$${7.08}$$ < $${7.12}$$	$${0}$$	$${2.95}$$ < $${3.29}$$
✅	docker_cws_instrumentation_arm64	$${+0}$$	$${6.69}$$ < $${6.92}$$	$${+0}$$	$${2.7}$$ < $${3.07}$$
✅	docker_dogstatsd_amd64	$${0}$$	$${38.93}$$ < $${39.57}$$	$${-0}$$	$${14.95}$$ < $${15.76}$$
✅	docker_dogstatsd_arm64	$${0}$$	$${37.52}$$ < $${38.2}$$	$${+0}$$	$${13.96}$$ < $${14.83}$$
✅	dogstatsd_deb_amd64	$${0}$$	$${30.61}$$ < $${31.52}$$	$${-0}$$	$${8.03}$$ < $${8.97}$$
✅	dogstatsd_deb_arm64	$${0}$$	$${29.16}$$ < $${30.08}$$	$${-0}$$	$${6.97}$$ < $${7.92}$$
✅	dogstatsd_rpm_amd64	$${0}$$	$${30.61}$$ < $${31.52}$$	$${+0}$$	$${8.05}$$ < $${8.98}$$
✅	dogstatsd_suse_amd64	$${0}$$	$${30.61}$$ < $${31.52}$$	$${+0}$$	$${8.05}$$ < $${8.98}$$
✅	iot_agent_deb_amd64	$${0}$$	$${50.48}$$ < $${60.17}$$	$${+0}$$	$${12.85}$$ < $${15.82}$$
✅	iot_agent_deb_arm64	$${0}$$	$${47.93}$$ < $${56.94}$$	$${-0}$$	$${11.14}$$ < $${13.86}$$
✅	iot_agent_deb_armhf	$${0}$$	$${47.51}$$ < $${56.41}$$	$${+0}$$	$${11.21}$$ < $${13.86}$$
✅	iot_agent_rpm_amd64	$${0}$$	$${50.48}$$ < $${60.18}$$	$${+0}$$	$${12.86}$$ < $${15.84}$$
✅	iot_agent_rpm_arm64	$${0}$$	$${47.94}$$ < $${56.94}$$	$${+0}$$	$${11.16}$$ < $${13.76}$$
✅	iot_agent_suse_amd64	$${0}$$	$${50.48}$$ < $${60.18}$$	$${+0}$$	$${12.86}$$ < $${15.84}$$

Copilot

Pull Request Overview

This PR adds a subcommand to the cluster agent for checking local autoscaling workload store data including workload entities and their metadata. Key changes include:

Creation and update of the local autoscaling workload store logic with tests.
Addition of a new CLI flag and endpoint for retrieving local autoscaling debug information.
Implementation of both active and noop versions based on build tags.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
pkg/clusteragent/autoscaling/workload/loadstore/workload_status_test.go	Adds tests for the workload status updates.
pkg/clusteragent/autoscaling/workload/loadstore/workload_status_noop.go	Provides a noop implementation for non‑kubeapiserver builds.
pkg/clusteragent/autoscaling/workload/loadstore/workload_status.go	Implements the workload status aggregator for local autoscaling.
pkg/cli/subcommands/autoscalerlist/command.go	Updates CLI command to support a new localstore flag and debug endpoint.
cmd/cluster-agent/api/agent/agent.go	Adds a new API handler for local autoscaling workload check.

Comments suppressed due to low confidence (1)

pkg/cli/subcommands/autoscalerlist/command.go:71

[nitpick] The shorthand flag 'v' is commonly associated with 'verbose', which may cause confusion given its usage here for enabling the localstore output. Consider using a different, more specific shorthand (e.g. 'l') if possible.

cmd.Flags().BoolVarP(&cliParams.localstore, "localstore", "v", false, "print autoscaling localstore debug info")

pkg/cli/subcommands/autoscalerlist/command.go

pkg/clusteragent/autoscaling/workload/loadstore/workload_status_noop.go

pkg/cli/subcommands/autoscalerlist/command.go

pkg/clusteragent/autoscaling/workload/loadstore/workload_status.go

jennchenn · 2025-05-23T22:16:53Z

pkg/clusteragent/autoscaling/workload/loadstore/workload_status.go

+		if !ok || datapoints == nil {
+			continue
+		}
+		fmt.Fprintf(w, "Namespace: %s, PodOwner: %s, MetricName: %s, Datapoints: %v\n",


the output is quite dense, i'm wondering if it makes sense to add more newlines between to make it easier to read (but i guess we expect a lot of metric data so maybe that would make the output too long and unreadable as well)

With thousands of entities, it is better to keep it short for each item.

pkg/clusteragent/autoscaling/workload/loadstore/workload_status_test.go

jennchenn · 2025-05-23T22:20:35Z

pkg/cli/subcommands/autoscalerlist/command.go

@@ -122,3 +134,34 @@ func getAutoscalerList(w io.Writer, url string) error {
 	autoscalerDump.Print(w)
 	return nil
 }
+
+func getLocalAutoscalingWorkloadCheck(w io.Writer, config config.Component) error {
+	c := util.GetClient()


as a headsup: i think this might have to change depending on if #37247 gets merged in first

jennchenn · 2025-06-03T19:53:40Z

pkg/clusteragent/autoscaling/workload/loadstore/dump.go

+	}
+	for _, statsResult := range lStoreInfo.StatsResults {
+		// Skip the disabled namespaces
+		if _, ok := defaultDisabledNamespaces()[statsResult.Namespace]; ok {


do we expect the value returned by defaultDisabledNamespaces() to change very frequently? or can we fetch the disabled namespaces once outside of the loop and then check against it? (to avoid so many reinitializations)

wdhif

LGTM for @DataDog/container-platform files

zhuminyi · 2025-06-07T05:06:08Z

/merge

dd-devflow · 2025-06-07T05:06:12Z

View all feedbacks in Devflow UI.

2025-06-07 05:06:12 UTC ℹ️ Start processing command /merge

2025-06-07 05:06:18 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-06-07 09:07:02 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

zhuminyi · 2025-06-09T17:49:07Z

/merge

dd-devflow · 2025-06-09T17:49:11Z

View all feedbacks in Devflow UI.

2025-06-09 17:49:10 UTC ℹ️ Start processing command /merge

2025-06-09 17:49:18 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-06-09 21:50:03 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

zhuminyi · 2025-06-10T12:36:01Z

/merge

dd-devflow · 2025-06-10T12:36:06Z

View all feedbacks in Devflow UI.

2025-06-10 12:36:05 UTC ℹ️ Start processing command /merge

2025-06-10 12:36:11 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 47m (p90).

2025-06-10 13:17:04 UTC ℹ️ MergeQueue: This merge request was merged

github-actions bot added the medium review PR review might take time label May 21, 2025

zhuminyi force-pushed the autoscaling_failover_status branch from 60f468b to fcb95df Compare May 21, 2025 17:19

zhuminyi added this to the 7.68.0 milestone May 21, 2025

zhuminyi added team/container-platform The Container Platform Team qa/done QA done before merge and regressions are covered by tests team/container-integrations changelog/no-changelog labels May 21, 2025

zhuminyi changed the title ~~failover metric store check~~ [CONTP-675]Autoscaling Failover local workload store check May 21, 2025

zhuminyi force-pushed the autoscaling_failover_status branch 2 times, most recently from e1a69ef to 8b98f20 Compare May 21, 2025 21:39

zhuminyi marked this pull request as ready for review May 21, 2025 21:42

zhuminyi requested review from a team as code owners May 21, 2025 21:42

zhuminyi force-pushed the autoscaling_failover_status branch 2 times, most recently from c6f8cff to 2b74246 Compare May 22, 2025 19:13

zhuminyi requested a review from Copilot May 22, 2025 19:16

Copilot AI reviewed May 22, 2025

View reviewed changes

pkg/cli/subcommands/autoscalerlist/command.go Outdated Show resolved Hide resolved

pkg/clusteragent/autoscaling/workload/loadstore/workload_status_noop.go Outdated Show resolved Hide resolved

zhuminyi force-pushed the autoscaling_failover_status branch 3 times, most recently from a508b46 to 539f16b Compare May 23, 2025 16:19

jennchenn reviewed May 23, 2025

View reviewed changes

github-actions bot added long review PR is complex, plan time to review it and removed medium review PR review might take time labels May 23, 2025

zhuminyi force-pushed the autoscaling_failover_status branch 2 times, most recently from 607291c to c33dbac Compare June 3, 2025 11:54

zhuminyi force-pushed the autoscaling_failover_status branch 3 times, most recently from bee398a to 3432d07 Compare June 3, 2025 14:13

zhuminyi requested a review from a team as a code owner June 3, 2025 19:12

zhuminyi requested a review from hush-hush June 3, 2025 19:12

jennchenn approved these changes Jun 3, 2025

View reviewed changes

hush-hush approved these changes Jun 4, 2025

View reviewed changes

zhuminyi changed the title ~~[CONTP-675]Autoscaling Failover local workload store check~~ [CONTP-675]Autoscaling Failover local workload store check: subcommand, flare support Jun 4, 2025

wdhif approved these changes Jun 5, 2025

View reviewed changes

zhuminyi force-pushed the autoscaling_failover_status branch 2 times, most recently from c488c7e to 8a3d2d1 Compare June 7, 2025 02:19

zhuminyi force-pushed the autoscaling_failover_status branch from 8a3d2d1 to 3df9385 Compare June 9, 2025 17:15

zhuminyi force-pushed the autoscaling_failover_status branch from 3df9385 to e399e26 Compare June 9, 2025 20:24

zhuminyi added 6 commits June 9, 2025 21:23

failover metric store check

42f4bdd

address commit

be05a02

address commit

6a4f28f

update struct

a7ad54d

add flare

c656f6e

merge/rebase

0abefa1

zhuminyi force-pushed the autoscaling_failover_status branch from e399e26 to 0abefa1 Compare June 10, 2025 01:23

dd-mergequeue bot merged commit 9d6ecd4 into main Jun 10, 2025
242 checks passed

dd-mergequeue bot deleted the autoscaling_failover_status branch June 10, 2025 13:17

[CONTP-675]Autoscaling Failover local workload store check: subcommand, flare support #37248

[CONTP-675]Autoscaling Failover local workload store check: subcommand, flare support #37248

Uh oh!

Conversation

zhuminyi commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

Uh oh!

cit-pr-commenter bot commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Go Package Import Differences

Uh oh!

agent-platform-auto-pr bot commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uncompressed package size comparison

Decision

Uh oh!

cit-pr-commenter bot commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

CI Pass/Fail Decision

Uh oh!

agent-platform-auto-pr bot commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Static quality checks

Info

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jennchenn May 23, 2025

Choose a reason for hiding this comment

Uh oh!

zhuminyi Jun 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jennchenn May 23, 2025

Choose a reason for hiding this comment

Uh oh!

jennchenn Jun 3, 2025

Choose a reason for hiding this comment

Uh oh!

wdhif left a comment

Choose a reason for hiding this comment

Uh oh!

zhuminyi commented Jun 7, 2025

Uh oh!

dd-devflow bot commented Jun 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zhuminyi commented Jun 9, 2025

Uh oh!

dd-devflow bot commented Jun 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zhuminyi commented Jun 10, 2025

Uh oh!

dd-devflow bot commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

zhuminyi commented May 21, 2025 •

edited

Loading

cit-pr-commenter bot commented May 21, 2025 •

edited

Loading

agent-platform-auto-pr bot commented May 21, 2025 •

edited

Loading

cit-pr-commenter bot commented May 21, 2025 •

edited

Loading

agent-platform-auto-pr bot commented May 21, 2025 •

edited

Loading

dd-devflow bot commented Jun 7, 2025 •

edited

Loading

dd-devflow bot commented Jun 9, 2025 •

edited

Loading

dd-devflow bot commented Jun 10, 2025 •

edited

Loading