Skip to content

Test stack cleaner #37357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Test stack cleaner #37357

wants to merge 3 commits into from

Conversation

CelianR
Copy link
Contributor

@CelianR CelianR commented May 26, 2025

What does this PR do?

Relates to https://github.com/DataDog/dd-source/pull/210306

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@CelianR CelianR self-assigned this May 26, 2025
@CelianR CelianR added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels May 26, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented May 26, 2025 •
edited
Loading

Uncompressed package size comparison

Comparison with ancestor 5984549d9bb60f8ad23d78b2493babaf0780b05b

Diff per package
package diff status size ancestor threshold
datadog-agent-x86_64-rpm 0.01MB ⚠️ 782.41MB 782.41MB 0.50MB
datadog-agent-x86_64-suse 0.01MB ⚠️ 782.41MB 782.41MB 0.50MB
datadog-agent-amd64-deb 0.01MB ⚠️ 773.46MB 773.46MB 0.50MB
datadog-agent-arm64-deb 0.00MB ✅ 759.40MB 759.40MB 0.50MB
datadog-agent-aarch64-rpm 0.00MB ✅ 768.33MB 768.33MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB ✅ 31.99MB 31.99MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB ✅ 32.07MB 32.07MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB ✅ 32.07MB 32.07MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB ✅ 30.47MB 30.47MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB ✅ 380.17MB 380.17MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB ✅ 62.79MB 62.79MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB ✅ 62.88MB 62.88MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB ✅ 62.87MB 62.87MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB ✅ 59.37MB 59.37MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB ✅ 59.45MB 59.45MB 0.50MB

Decision

⚠️ Warning

@cit-pr-commenter cit-pr-commenter
Copy link

cit-pr-commenter bot commented May 26, 2025 •
edited
Loading

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 4a83f277-d6c8-4175-b010-c69824079c7b

Baseline: 5984549
Comparison: 0344b6d
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ docker_containers_cpu % cpu utilization +2.59 [-1.34, +6.53] 1 Logs
➖ quality_gate_logs % cpu utilization +1.42 [-1.24, +4.08] 1 Logs bounds checks dashboard
➖ docker_containers_memory memory utilization +0.99 [+0.91, +1.07] 1 Logs
➖ otlp_ingest_logs memory utilization +0.82 [+0.70, +0.95] 1 Logs
➖ tcp_syslog_to_blackhole ingress throughput +0.63 [+0.57, +0.70] 1 Logs
➖ uds_dogstatsd_to_api_cpu % cpu utilization +0.47 [-0.41, +1.36] 1 Logs
➖ quality_gate_idle memory utilization +0.27 [+0.21, +0.33] 1 Logs bounds checks dashboard
➖ file_to_blackhole_0ms_latency_http2 egress throughput +0.14 [-0.50, +0.78] 1 Logs
➖ otlp_ingest_metrics memory utilization +0.08 [-0.09, +0.24] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput +0.07 [-0.52, +0.66] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput +0.01 [-0.01, +0.03] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput +0.00 [-0.58, +0.59] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput -0.00 [-0.28, +0.27] 1 Logs
➖ file_to_blackhole_300ms_latency egress throughput -0.01 [-0.63, +0.62] 1 Logs
➖ ddot_logs memory utilization -0.04 [-0.17, +0.10] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput -0.04 [-0.66, +0.59] 1 Logs
➖ file_to_blackhole_1000ms_latency_linear_load egress throughput -0.05 [-0.28, +0.18] 1 Logs
➖ file_to_blackhole_0ms_latency_http1 egress throughput -0.05 [-0.63, +0.53] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput -0.11 [-0.71, +0.49] 1 Logs
➖ ddot_metrics memory utilization -0.30 [-0.42, -0.19] 1 Logs
➖ uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.31 [-0.36, -0.27] 1 Logs
➖ quality_gate_idle_all_features memory utilization -0.48 [-0.58, -0.39] 1 Logs bounds checks dashboard
➖ file_tree memory utilization -0.60 [-0.74, -0.45] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
✅ docker_containers_cpu simple_check_run 10/10
✅ docker_containers_memory memory_usage 10/10
✅ docker_containers_memory simple_check_run 10/10
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http1 memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http2 memory_usage 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_300ms_latency lost_bytes 10/10
✅ file_to_blackhole_300ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented May 26, 2025 •
edited
Loading

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 5984549

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
✅ agent_deb_amd64 $${\color{green}-0.01}$$ $${\color{green}746.18}$$ < $${752.99}$$ $${\color{red}+0.02}$$ $${\color{green}184.73}$$ < $${187.44}$$
✅ agent_deb_amd64_fips $${\color{green}-0.01}$$ $${\color{green}744.54}$$ < $${751.36}$$ $${\color{green}-0.07}$$ $${\color{green}184.21}$$ < $${187.06}$$
✅ agent_heroku_amd64 $${\color{green}0}$$ $${\color{green}368.55}$$ < $${369.68}$$ $${\color{red}+0.01}$$ $${\color{green}98.53}$$ < $${99.55}$$
✅ agent_msi $${\color{red}+0}$$ $${\color{green}977.62}$$ < $${978.01}$$ $${\color{red}+0.01}$$ $${\color{green}148.33}$$ < $${149.12}$$
✅ agent_rpm_amd64 $${\color{green}-0.01}$$ $${\color{green}746.17}$$ < $${752.98}$$ $${\color{red}+0.01}$$ $${\color{green}186.38}$$ < $${190.03}$$
✅ agent_rpm_amd64_fips $${\color{green}-0.01}$$ $${\color{green}744.53}$$ < $${751.35}$$ $${\color{green}-0.01}$$ $${\color{green}186.19}$$ < $${189.81}$$
✅ agent_rpm_arm64 $${\color{green}-0}$$ $${\color{green}732.74}$$ < $${739.42}$$ $${\color{green}-0.04}$$ $${\color{green}168.41}$$ < $${171.23}$$
✅ agent_rpm_arm64_fips $${\color{green}-0}$$ $${\color{green}731.24}$$ < $${737.91}$$ $${\color{green}-0.03}$$ $${\color{green}167.56}$$ < $${170.22}$$
✅ agent_suse_amd64 $${\color{green}-0.01}$$ $${\color{green}746.17}$$ < $${752.98}$$ $${\color{red}+0.01}$$ $${\color{green}186.38}$$ < $${190.03}$$
✅ agent_suse_amd64_fips $${\color{green}-0.01}$$ $${\color{green}744.53}$$ < $${751.35}$$ $${\color{green}-0.01}$$ $${\color{green}186.19}$$ < $${189.81}$$
✅ agent_suse_arm64 $${\color{green}-0}$$ $${\color{green}732.74}$$ < $${739.42}$$ $${\color{green}-0.04}$$ $${\color{green}168.41}$$ < $${171.23}$$
✅ agent_suse_arm64_fips $${\color{green}-0}$$ $${\color{green}731.24}$$ < $${737.91}$$ $${\color{green}-0.03}$$ $${\color{green}167.56}$$ < $${170.22}$$
✅ docker_agent_amd64 $${\color{green}-0.02}$$ $${\color{green}829.97}$$ < $${849.39}$$ $${\color{green}-0.03}$$ $${\color{green}281.8}$$ < $${288.34}$$
✅ docker_agent_arm64 $${\color{green}-0.01}$$ $${\color{green}839.99}$$ < $${858.97}$$ $${\color{green}-0.01}$$ $${\color{green}267.91}$$ < $${274.36}$$
✅ docker_agent_jmx_amd64 $${\color{green}-0.02}$$ $${\color{green}829.97}$$ < $${849.39}$$ $${\color{green}-0.03}$$ $${\color{green}281.8}$$ < $${288.34}$$
✅ docker_agent_jmx_arm64 $${\color{green}-0.01}$$ $${\color{green}839.99}$$ < $${858.97}$$ $${\color{green}-0.01}$$ $${\color{green}267.91}$$ < $${274.36}$$
✅ docker_agent_windows1809 $${\color{green}-0.02}$$ $${\color{green}829.97}$$ < $${849.39}$$ $${\color{green}-0.03}$$ $${\color{green}281.8}$$ < $${288.34}$$
✅ docker_agent_windows1809_core $${\color{green}-0.02}$$ $${\color{green}829.97}$$ < $${849.39}$$ $${\color{green}-0.03}$$ $${\color{green}281.8}$$ < $${288.34}$$
✅ docker_agent_windows1809_core_jmx $${\color{green}-0.02}$$ $${\color{green}829.97}$$ < $${849.39}$$ $${\color{green}-0.03}$$ $${\color{green}281.8}$$ < $${288.34}$$
✅ docker_agent_windows1809_jmx $${\color{green}-0.02}$$ $${\color{green}829.97}$$ < $${849.39}$$ $${\color{green}-0.03}$$ $${\color{green}281.8}$$ < $${288.34}$$
✅ docker_agent_windows2022 $${\color{green}-0.02}$$ $${\color{green}829.97}$$ < $${849.39}$$ $${\color{green}-0.03}$$ $${\color{green}281.8}$$ < $${288.34}$$
✅ docker_agent_windows2022_core $${\color{green}-0.02}$$ $${\color{green}829.97}$$ < $${849.39}$$ $${\color{green}-0.03}$$ $${\color{green}281.8}$$ < $${288.34}$$
✅ docker_agent_windows2022_core_jmx $${\color{green}-0.02}$$ $${\color{green}829.97}$$ < $${849.39}$$ $${\color{green}-0.03}$$ $${\color{green}281.8}$$ < $${288.34}$$
✅ docker_agent_windows2022_jmx $${\color{green}-0.02}$$ $${\color{green}829.97}$$ < $${849.39}$$ $${\color{green}-0.03}$$ $${\color{green}281.8}$$ < $${288.34}$$
✅ docker_cluster_agent_amd64 $${\color{green}-0.01}$$ $${\color{green}258.94}$$ < $${259.73}$$ $${\color{red}+0}$$ $${\color{green}102.78}$$ < $${103.68}$$
✅ docker_cluster_agent_arm64 $${\color{green}-0.01}$$ $${\color{green}273.44}$$ < $${274.24}$$ $${\color{green}-0}$$ $${\color{green}97.54}$$ < $${98.45}$$
✅ docker_cws_instrumentation_amd64 $${\color{green}0}$$ $${\color{green}7.08}$$ < $${7.12}$$ $${\color{green}-0}$$ $${\color{green}2.95}$$ < $${3.29}$$
✅ docker_cws_instrumentation_arm64 $${\color{green}0}$$ $${\color{green}6.69}$$ < $${6.92}$$ $${\color{green}-0}$$ $${\color{green}2.7}$$ < $${3.07}$$
✅ docker_dogstatsd_amd64 $${\color{red}+0}$$ $${\color{green}38.63}$$ < $${39.57}$$ $${\color{red}+0}$$ $${\color{green}14.81}$$ < $${15.76}$$
✅ docker_dogstatsd_arm64 $${\color{green}0}$$ $${\color{green}37.26}$$ < $${38.2}$$ $${\color{green}-0}$$ $${\color{green}13.88}$$ < $${14.83}$$
✅ dogstatsd_deb_amd64 $${\color{green}0}$$ $${\color{green}30.58}$$ < $${31.52}$$ $${\color{red}+0}$$ $${\color{green}8.03}$$ < $${8.97}$$
✅ dogstatsd_deb_arm64 $${\color{green}0}$$ $${\color{green}29.14}$$ < $${30.08}$$ $${\color{green}-0}$$ $${\color{green}6.97}$$ < $${7.92}$$
✅ dogstatsd_rpm_amd64 $${\color{green}0}$$ $${\color{green}30.58}$$ < $${31.52}$$ $${\color{red}+0}$$ $${\color{green}8.04}$$ < $${8.98}$$
✅ dogstatsd_suse_amd64 $${\color{green}0}$$ $${\color{green}30.58}$$ < $${31.52}$$ $${\color{red}+0}$$ $${\color{green}8.04}$$ < $${8.98}$$
✅ iot_agent_deb_amd64 $${\color{green}0}$$ $${\color{green}59.96}$$ < $${60.17}$$ $${\color{red}+0}$$ $${\color{green}14.99}$$ < $${15.82}$$
✅ iot_agent_deb_arm64 $${\color{green}0}$$ $${\color{green}56.69}$$ < $${56.94}$$ $${\color{green}-0}$$ $${\color{green}12.86}$$ < $${13.86}$$
✅ iot_agent_deb_armhf $${\color{green}0}$$ $${\color{green}56.14}$$ < $${56.41}$$ $${\color{red}+0.01}$$ $${\color{green}12.99}$$ < $${13.86}$$
✅ iot_agent_rpm_amd64 $${\color{green}0}$$ $${\color{green}59.96}$$ < $${60.18}$$ $${\color{green}-0}$$ $${\color{green}15.01}$$ < $${15.84}$$
✅ iot_agent_rpm_arm64 $${\color{green}0}$$ $${\color{green}56.69}$$ < $${56.94}$$ $${\color{red}+0}$$ $${\color{green}12.88}$$ < $${13.76}$$
✅ iot_agent_suse_amd64 $${\color{green}0}$$ $${\color{green}59.96}$$ < $${60.18}$$ $${\color{green}-0}$$ $${\color{green}15.01}$$ < $${15.84}$$

@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label May 26, 2025
@CelianR
Copy link
Contributor Author

CelianR commented May 28, 2025

/ddci trigger

@dd-devflow
Copy link

dd-devflow bot commented May 28, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-05-28 13:01:52 UTC ℹ️ Start processing command /ddci trigger

2025-05-28 13:02:09 UTC ℹ️ Devflow: /ddci trigger

✅ Tasks request sent successfully.
🔑 DDCI Request ID: 2890686588963503156
🔍 Debug this request with Datadog Traces

@CelianR
Copy link
Contributor Author

CelianR commented Jun 2, 2025

/ddci trigger

@dd-devflow
Copy link

dd-devflow bot commented Jun 2, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-06-02 08:46:12 UTC ℹ️ Start processing command /ddci trigger

2025-06-02 08:46:25 UTC ℹ️ Devflow: /ddci trigger

✅ Tasks request sent successfully.
🔑 DDCI Request ID: 2170533098036460361
🔍 Debug this request with Datadog Traces

@CelianR
Copy link
Contributor Author

CelianR commented Jun 5, 2025

/ddci trigger

@dd-devflow
Copy link

dd-devflow bot commented Jun 5, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-06-05 07:13:20 UTC ℹ️ Start processing command /ddci trigger

2025-06-05 07:13:55 UTC ℹ️ Devflow: /ddci trigger

✅ Tasks request sent successfully.
🔑 DDCI Request ID: 5905016246447635860
🔍 Debug this request with Datadog Traces

@CelianR
Copy link
Contributor Author

CelianR commented Jun 5, 2025

/ddci trigger

@dd-devflow
Copy link

dd-devflow bot commented Jun 5, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-06-05 12:01:16 UTC ℹ️ Start processing command /ddci trigger

2025-06-05 12:01:28 UTC ℹ️ Devflow: /ddci trigger

✅ Tasks request sent successfully.
🔑 DDCI Request ID: 3376623444784499079
🔍 Debug this request with Datadog Traces

@CelianR
Copy link
Contributor Author

CelianR commented Jun 10, 2025

/ddci trigger

@dd-devflow
Copy link

dd-devflow bot commented Jun 10, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-06-10 12:59:21 UTC ℹ️ Start processing command /ddci trigger

2025-06-10 12:59:30 UTC ℹ️ Devflow: /ddci trigger

✅ Tasks request sent successfully.
🔑 DDCI Request ID: 4475640776584881504
🔍 Debug this request with Datadog Traces

@CelianR
Copy link
Contributor Author

CelianR commented Jun 12, 2025

/ddci trigger

@dd-devflow
Copy link

dd-devflow bot commented Jun 12, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-06-12 13:53:41 UTC ℹ️ Start processing command /ddci trigger

2025-06-12 13:54:04 UTC ℹ️ Devflow: /ddci trigger

✅ Tasks request sent successfully.
🔑 DDCI Request ID: 4748855008075190989
🔍 Debug this request with Datadog Traces

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@CelianR CelianR

Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@CelianR