Skip to content

chore(fleet): Create APM SSI script #37362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 11, 2025

Conversation

BaptisteFoy
Copy link
Contributor

@BaptisteFoy BaptisteFoy commented May 26, 2025

What does this PR do?

Creates an APM SSI install script flavour that will install the packages & copy the installer to /usr/bin/datadog-installer if the agent isn't installed.
Updates the APM scripts to reference that installer instead of the packaged one.

Motivation

Describe how you validated your changes

Manual QA, E2E tests

Possible Drawbacks / Trade-offs

Additional Notes

@github-actions github-actions bot added medium review PR review might take time team/windows-agent labels May 26, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented May 26, 2025

Uncompressed package size comparison

Comparison with ancestor 004777aef920de42f637aca55dbbaa33591e71ef

Diff per package
package diff status size ancestor threshold
datadog-heroku-agent-amd64-deb 0.01MB ⚠️ 380.18MB 380.17MB 0.50MB
datadog-agent-aarch64-rpm 0.00MB 768.34MB 768.33MB 0.50MB
datadog-agent-arm64-deb 0.00MB 759.41MB 759.40MB 0.50MB
datadog-agent-x86_64-rpm 0.00MB 782.41MB 782.41MB 0.50MB
datadog-agent-x86_64-suse 0.00MB 782.41MB 782.41MB 0.50MB
datadog-agent-amd64-deb 0.00MB 773.47MB 773.46MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 31.99MB 31.99MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 32.07MB 32.07MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 32.07MB 32.07MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 30.47MB 30.47MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 62.79MB 62.79MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 62.88MB 62.88MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 62.87MB 62.87MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 59.37MB 59.37MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 59.45MB 59.45MB 0.50MB

Decision

⚠️ Warning

Copy link

cit-pr-commenter bot commented May 26, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: ae9be239-f2fd-45cf-80a4-2941385a5b5c

Baseline: 6402feb
Comparison: 582b6e2
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +4.36 [+3.48, +5.24] 1 Logs
quality_gate_logs % cpu utilization +2.22 [-0.58, +5.01] 1 Logs bounds checks dashboard
otlp_ingest_metrics memory utilization +0.85 [+0.68, +1.01] 1 Logs
quality_gate_idle memory utilization +0.61 [+0.55, +0.68] 1 Logs bounds checks dashboard
otlp_ingest_logs memory utilization +0.56 [+0.43, +0.68] 1 Logs
ddot_metrics memory utilization +0.17 [+0.05, +0.29] 1 Logs
docker_containers_memory memory utilization +0.13 [+0.07, +0.19] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.12 [-0.40, +0.65] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.05 [-0.54, +0.63] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.03 [-0.58, +0.65] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.03 [-0.20, +0.26] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.01 [-0.02, +0.03] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.26, +0.26] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.00 [-0.62, +0.61] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.03 [-0.59, +0.54] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.03 [-0.67, +0.60] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.05 [-0.68, +0.59] 1 Logs
file_tree memory utilization -0.06 [-0.23, +0.12] 1 Logs
quality_gate_idle_all_features memory utilization -0.23 [-0.35, -0.11] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput -0.44 [-0.53, -0.36] 1 Logs
ddot_logs memory utilization -0.60 [-0.74, -0.47] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.78 [-0.85, -0.72] 1 Logs
docker_containers_cpu % cpu utilization -1.52 [-4.57, +1.54] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@BaptisteFoy BaptisteFoy added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests and removed team/windows-agent labels May 26, 2025
@BaptisteFoy BaptisteFoy force-pushed the baptiste.foy/FA/update-injector-scripts branch from 79efadf to ab12bfc Compare May 26, 2025 11:23
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented May 26, 2025

Gitlab CI Configuration Changes

Modified Jobs

installer-install-scripts
  installer-install-scripts:
    artifacts:
      expire_in: 2 weeks
      paths:
      - $OMNIBUS_PACKAGE_DIR
    image: registry.ddbuild.io/ci/datadog-agent-buildimages/linux-glibc-2-17-x64$CI_IMAGE_LINUX_GLIBC_2_17_X64_SUFFIX:$CI_IMAGE_LINUX_GLIBC_2_17_X64
    needs:
    - go_mod_tidy_check
    - go_deps
    - installer-amd64-oci
    - installer-arm64-oci
    rules:
    - if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
      when: never
    - when: on_success
    script:
    - mkdir -p $GOPATH/pkg/mod/cache && tar xJf modcache.tar.xz -C $GOPATH/pkg/mod/cache
      || exit 101
    - rm -f modcache.tar.xz
    - VERSION="$(dda inv agent.version --url-safe)-1" || exit $?
    - echo "About to build for $VERSION"
    - mkdir -p $OMNIBUS_PACKAGE_DIR
    - tar -xJOf $OMNIBUS_PACKAGE_DIR/datadog-installer-7*amd64.tar.xz --wildcards "opt/datadog-packages/datadog-installer/*/bin/installer/installer"
      > installer-amd64
    - tar -xJOf $OMNIBUS_PACKAGE_DIR/datadog-installer-7*arm64.tar.xz --wildcards "opt/datadog-packages/datadog-installer/*/bin/installer/installer"
      > installer-arm64
    - dda inv -- -e installer.build-linux-script "default" "$VERSION" "installer-amd64"
      "installer-arm64" "install.sh" --package="agent-package"
+   - dda inv -- -e installer.build-linux-script "APM SSI" "$VERSION" "installer-amd64"
+     "installer-arm64" "install-ssi.sh" --package="agent-package"
    - dda inv -- -e installer.build-linux-script "databricks" "$VERSION" "installer-amd64"
      "installer-arm64" "install-databricks.sh"
    - dda inv -- -e installer.build-linux-script "emr" "$VERSION" "installer-amd64"
      "installer-arm64" "install-emr.sh"
    - dda inv -- -e installer.build-linux-script "dataproc" "$VERSION" "installer-amd64"
      "installer-arm64" "install-dataproc.sh"
    - mv ./bin/installer/install*.sh $OMNIBUS_PACKAGE_DIR/
    - ls -la $OMNIBUS_PACKAGE_DIR
    stage: package_build
    tags:
    - arch:amd64
    variables:
      KUBERNETES_CPU_REQUEST: 8
      KUBERNETES_MEMORY_LIMIT: 16Gi
      KUBERNETES_MEMORY_REQUEST: 16Gi

Changes Summary

Removed Modified Added Renamed
0 1 0 0

ℹ️ Diff available in the job log.

@BaptisteFoy BaptisteFoy force-pushed the baptiste.foy/FA/update-injector-scripts branch 2 times, most recently from f65e82a to 15e8cfe Compare May 26, 2025 14:21
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented May 26, 2025

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 6402feb

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 $${-0}$$ $${695.69}$$ < $${752.99}$$ $${-0}$$ $${175.92}$$ < $${187.44}$$
agent_deb_amd64_fips $${+0}$$ $${693.9}$$ < $${751.36}$$ $${+0.03}$$ $${175.6}$$ < $${187.06}$$
agent_heroku_amd64 $${+0}$$ $${358.2}$$ < $${369.68}$$ $${+0.01}$$ $${96.44}$$ < $${99.55}$$
agent_msi $${0}$$ $${957.7}$$ < $${987.01}$$ $${+0.02}$$ $${146.12}$$ < $${150.72}$$
agent_rpm_amd64 $${-0}$$ $${695.68}$$ < $${752.98}$$ $${-0.06}$$ $${177.45}$$ < $${190.03}$$
agent_rpm_amd64_fips $${+0}$$ $${693.89}$$ < $${751.35}$$ $${-0.01}$$ $${177.34}$$ < $${189.81}$$
agent_rpm_arm64 $${+0}$$ $${685.69}$$ < $${739.42}$$ $${-0}$$ $${160.85}$$ < $${171.23}$$
agent_rpm_arm64_fips $${+0}$$ $${684.04}$$ < $${737.91}$$ $${-0.07}$$ $${159.96}$$ < $${170.22}$$
agent_suse_amd64 $${-0}$$ $${695.68}$$ < $${752.98}$$ $${-0.06}$$ $${177.45}$$ < $${190.03}$$
agent_suse_amd64_fips $${+0}$$ $${693.89}$$ < $${751.35}$$ $${-0.01}$$ $${177.34}$$ < $${189.81}$$
agent_suse_arm64 $${+0}$$ $${685.69}$$ < $${739.42}$$ $${-0}$$ $${160.85}$$ < $${171.23}$$
agent_suse_arm64_fips $${+0}$$ $${684.04}$$ < $${737.91}$$ $${-0.07}$$ $${159.96}$$ < $${170.22}$$
docker_agent_amd64 $${-0}$$ $${779.48}$$ < $${849.39}$$ $${+0}$$ $${268.47}$$ < $${288.34}$$
docker_agent_arm64 $${+0}$$ $${792.94}$$ < $${858.97}$$ $${-0}$$ $${255.82}$$ < $${274.36}$$
docker_agent_jmx_amd64 $${-0}$$ $${970.67}$$ < $${1040.59}$$ $${+0}$$ $${337.4}$$ < $${357.3}$$
docker_agent_jmx_arm64 $${+0}$$ $${972.73}$$ < $${1038.77}$$ $${+0.01}$$ $${320.78}$$ < $${339.32}$$
docker_agent_windows1809 $${-0.01}$$ $${1485.79}$$ < $${1557.19}$$ $${+0.23}$$ $${487.7}$$ < $${507.33}$$
docker_agent_windows1809_core $${+0.02}$$ $${6215.76}$$ < $${6287.46}$$ $${0}$$ $${2048.0}$$ < $${2067.76}$$
docker_agent_windows1809_core_jmx $${+0}$$ $${6337.32}$$ < $${6409.04}$$ $${0}$$ $${2048.0}$$ < $${2067.76}$$
docker_agent_windows1809_jmx $${+0}$$ $${1607.42}$$ < $${1679.14}$$ $${-0.01}$$ $${529.89}$$ < $${550.27}$$
docker_agent_windows2022 $${-0.19}$$ $${1504.9}$$ < $${1576.85}$$ $${+0.04}$$ $${500.39}$$ < $${520.76}$$
docker_agent_windows2022_core $${+0.03}$$ $${6188.84}$$ < $${6260.53}$$ $${0}$$ $${2048.0}$$ < $${2067.76}$$
docker_agent_windows2022_core_jmx $${-0.22}$$ $${6310.49}$$ < $${6382.17}$$ $${0}$$ $${2048.0}$$ < $${2067.76}$$
docker_agent_windows2022_jmx $${-0.15}$$ $${1626.72}$$ < $${1698.2}$$ $${-0}$$ $${542.62}$$ < $${562.99}$$
docker_cluster_agent_amd64 $${-0}$$ $${259.21}$$ < $${259.73}$$ $${-0}$$ $${102.9}$$ < $${103.68}$$
docker_cluster_agent_arm64 $${-0}$$ $${273.64}$$ < $${274.24}$$ $${-0}$$ $${97.58}$$ < $${98.45}$$
docker_cws_instrumentation_amd64 $${0}$$ $${7.08}$$ < $${7.12}$$ $${-0}$$ $${2.95}$$ < $${3.29}$$
docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${-0}$$ $${2.7}$$ < $${3.07}$$
docker_dogstatsd_amd64 $${0}$$ $${38.76}$$ < $${39.57}$$ $${+0}$$ $${14.9}$$ < $${15.76}$$
docker_dogstatsd_arm64 $${0}$$ $${37.4}$$ < $${38.2}$$ $${-0}$$ $${13.91}$$ < $${14.83}$$
dogstatsd_deb_amd64 $${0}$$ $${30.44}$$ < $${31.52}$$ $${-0}$$ $${8.0}$$ < $${8.97}$$
dogstatsd_deb_arm64 $${0}$$ $${29.01}$$ < $${30.08}$$ $${-0}$$ $${6.94}$$ < $${7.92}$$
dogstatsd_rpm_amd64 $${0}$$ $${30.44}$$ < $${31.52}$$ $${-0}$$ $${8.0}$$ < $${8.98}$$
dogstatsd_suse_amd64 $${0}$$ $${30.44}$$ < $${31.52}$$ $${-0}$$ $${8.0}$$ < $${8.98}$$
iot_agent_deb_amd64 $${0}$$ $${50.31}$$ < $${60.17}$$ $${-0}$$ $${12.8}$$ < $${15.82}$$
iot_agent_deb_arm64 $${0}$$ $${47.78}$$ < $${56.94}$$ $${-0}$$ $${11.11}$$ < $${13.86}$$
iot_agent_deb_armhf $${0}$$ $${47.35}$$ < $${56.41}$$ $${-0}$$ $${11.18}$$ < $${13.86}$$
iot_agent_rpm_amd64 $${0}$$ $${50.31}$$ < $${60.18}$$ $${+0}$$ $${12.82}$$ < $${15.84}$$
iot_agent_rpm_arm64 $${0}$$ $${47.78}$$ < $${56.94}$$ $${-0}$$ $${11.13}$$ < $${13.76}$$
iot_agent_suse_amd64 $${0}$$ $${50.31}$$ < $${60.18}$$ $${+0}$$ $${12.82}$$ < $${15.84}$$

@BaptisteFoy BaptisteFoy force-pushed the baptiste.foy/FA/update-injector-scripts branch from 15e8cfe to 450173d Compare May 27, 2025 07:24
@BaptisteFoy BaptisteFoy force-pushed the baptiste.foy/FA/update-injector-scripts branch from 450173d to 131baea Compare May 27, 2025 07:28
@BaptisteFoy BaptisteFoy marked this pull request as ready for review May 27, 2025 11:18
@BaptisteFoy BaptisteFoy requested review from a team as code owners May 27, 2025 11:18
@BaptisteFoy BaptisteFoy force-pushed the baptiste.foy/FA/update-injector-scripts branch from ef22c08 to 850052f Compare May 28, 2025 15:52
@github-actions github-actions bot added long review PR is complex, plan time to review it and removed medium review PR review might take time labels Jun 4, 2025
@BaptisteFoy BaptisteFoy force-pushed the baptiste.foy/FA/update-injector-scripts branch from a2f392b to 1284f33 Compare June 4, 2025 15:22
@BaptisteFoy BaptisteFoy force-pushed the baptiste.foy/FA/update-injector-scripts branch from 18ed53c to ff6a0e1 Compare June 5, 2025 07:46
@BaptisteFoy BaptisteFoy requested a review from a team as a code owner June 11, 2025 06:45
@BaptisteFoy BaptisteFoy force-pushed the baptiste.foy/FA/update-injector-scripts branch from 97888c5 to 39dd40f Compare June 11, 2025 09:08
@BaptisteFoy BaptisteFoy force-pushed the baptiste.foy/FA/update-injector-scripts branch from 39dd40f to 582b6e2 Compare June 11, 2025 09:28
@BaptisteFoy
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jun 11, 2025

View all feedbacks in Devflow UI.

2025-06-11 11:27:45 UTC ℹ️ Start processing command /merge


2025-06-11 11:27:50 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 47m (p90).


2025-06-11 12:07:55 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 13d24f2 into main Jun 11, 2025
293 checks passed
@dd-mergequeue dd-mergequeue bot deleted the baptiste.foy/FA/update-injector-scripts branch June 11, 2025 12:07
@github-actions github-actions bot added this to the 7.68.0 milestone Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog long review PR is complex, plan time to review it qa/done QA done before merge and regressions are covered by tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants