-
Notifications
You must be signed in to change notification settings - Fork 1.3k
chore(fleet): Create APM SSI script #37362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Uncompressed package size comparisonComparison with ancestor Diff per package
Decision |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 6402feb Optimization Goals: ✅ No significant changes detected
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +4.36 | [+3.48, +5.24] | 1 | Logs |
➖ | quality_gate_logs | % cpu utilization | +2.22 | [-0.58, +5.01] | 1 | Logs bounds checks dashboard |
➖ | otlp_ingest_metrics | memory utilization | +0.85 | [+0.68, +1.01] | 1 | Logs |
➖ | quality_gate_idle | memory utilization | +0.61 | [+0.55, +0.68] | 1 | Logs bounds checks dashboard |
➖ | otlp_ingest_logs | memory utilization | +0.56 | [+0.43, +0.68] | 1 | Logs |
➖ | ddot_metrics | memory utilization | +0.17 | [+0.05, +0.29] | 1 | Logs |
➖ | docker_containers_memory | memory utilization | +0.13 | [+0.07, +0.19] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | +0.12 | [-0.40, +0.65] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.05 | [-0.54, +0.63] | 1 | Logs |
➖ | file_to_blackhole_100ms_latency | egress throughput | +0.03 | [-0.58, +0.65] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | +0.03 | [-0.20, +0.26] | 1 | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.01 | [-0.02, +0.03] | 1 | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.26, +0.26] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency | egress throughput | -0.00 | [-0.62, +0.61] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | -0.03 | [-0.59, +0.54] | 1 | Logs |
➖ | file_to_blackhole_500ms_latency | egress throughput | -0.03 | [-0.67, +0.60] | 1 | Logs |
➖ | file_to_blackhole_300ms_latency | egress throughput | -0.05 | [-0.68, +0.59] | 1 | Logs |
➖ | file_tree | memory utilization | -0.06 | [-0.23, +0.12] | 1 | Logs |
➖ | quality_gate_idle_all_features | memory utilization | -0.23 | [-0.35, -0.11] | 1 | Logs bounds checks dashboard |
➖ | tcp_syslog_to_blackhole | ingress throughput | -0.44 | [-0.53, -0.36] | 1 | Logs |
➖ | ddot_logs | memory utilization | -0.60 | [-0.74, -0.47] | 1 | Logs |
➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | -0.78 | [-0.85, -0.72] | 1 | Logs |
➖ | docker_containers_cpu | % cpu utilization | -1.52 | [-4.57, +1.54] | 1 | Logs |
Bounds Checks: ✅ Passed
perf | experiment | bounds_check_name | replicates_passed | links |
---|---|---|---|---|
✅ | docker_containers_cpu | simple_check_run | 10/10 | |
✅ | docker_containers_memory | memory_usage | 10/10 | |
✅ | docker_containers_memory | simple_check_run | 10/10 | |
✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_logs | intake_connections | 10/10 | bounds checks dashboard |
✅ | quality_gate_logs | lost_bytes | 10/10 | bounds checks dashboard |
✅ | quality_gate_logs | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
79efadf
to
ab12bfc
Compare
Gitlab CI Configuration ChangesModified Jobsinstaller-install-scripts installer-install-scripts:
artifacts:
expire_in: 2 weeks
paths:
- $OMNIBUS_PACKAGE_DIR
image: registry.ddbuild.io/ci/datadog-agent-buildimages/linux-glibc-2-17-x64$CI_IMAGE_LINUX_GLIBC_2_17_X64_SUFFIX:$CI_IMAGE_LINUX_GLIBC_2_17_X64
needs:
- go_mod_tidy_check
- go_deps
- installer-amd64-oci
- installer-arm64-oci
rules:
- if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
when: never
- when: on_success
script:
- mkdir -p $GOPATH/pkg/mod/cache && tar xJf modcache.tar.xz -C $GOPATH/pkg/mod/cache
|| exit 101
- rm -f modcache.tar.xz
- VERSION="$(dda inv agent.version --url-safe)-1" || exit $?
- echo "About to build for $VERSION"
- mkdir -p $OMNIBUS_PACKAGE_DIR
- tar -xJOf $OMNIBUS_PACKAGE_DIR/datadog-installer-7*amd64.tar.xz --wildcards "opt/datadog-packages/datadog-installer/*/bin/installer/installer"
> installer-amd64
- tar -xJOf $OMNIBUS_PACKAGE_DIR/datadog-installer-7*arm64.tar.xz --wildcards "opt/datadog-packages/datadog-installer/*/bin/installer/installer"
> installer-arm64
- dda inv -- -e installer.build-linux-script "default" "$VERSION" "installer-amd64"
"installer-arm64" "install.sh" --package="agent-package"
+ - dda inv -- -e installer.build-linux-script "APM SSI" "$VERSION" "installer-amd64"
+ "installer-arm64" "install-ssi.sh" --package="agent-package"
- dda inv -- -e installer.build-linux-script "databricks" "$VERSION" "installer-amd64"
"installer-arm64" "install-databricks.sh"
- dda inv -- -e installer.build-linux-script "emr" "$VERSION" "installer-amd64"
"installer-arm64" "install-emr.sh"
- dda inv -- -e installer.build-linux-script "dataproc" "$VERSION" "installer-amd64"
"installer-arm64" "install-dataproc.sh"
- mv ./bin/installer/install*.sh $OMNIBUS_PACKAGE_DIR/
- ls -la $OMNIBUS_PACKAGE_DIR
stage: package_build
tags:
- arch:amd64
variables:
KUBERNETES_CPU_REQUEST: 8
KUBERNETES_MEMORY_LIMIT: 16Gi
KUBERNETES_MEMORY_REQUEST: 16Gi Changes Summary
ℹ️ Diff available in the job log. |
f65e82a
to
15e8cfe
Compare
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
|
15e8cfe
to
450173d
Compare
450173d
to
131baea
Compare
ef22c08
to
850052f
Compare
a2f392b
to
1284f33
Compare
18ed53c
to
ff6a0e1
Compare
97888c5
to
39dd40f
Compare
39dd40f
to
582b6e2
Compare
/merge |
View all feedbacks in Devflow UI.
The expected merge time in
|
What does this PR do?
Creates an APM SSI install script flavour that will install the packages & copy the installer to
/usr/bin/datadog-installer
if the agent isn't installed.Updates the APM scripts to reference that installer instead of the packaged one.
Motivation
Describe how you validated your changes
Manual QA, E2E tests
Possible Drawbacks / Trade-offs
Additional Notes