[CWS] change the gRPC connection direction #37390

safchain · 2025-05-26T22:58:49Z

What does this PR do?

Change the direction of the gRPC connection between the security-agent and system-probe for the events and the activity dumps. Now system-probe to security-agent. System-probe now makes use of 2 gRPC socket, one for the command line, the other for the msg sent to the backend.

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

pkg/security/module/server.go

cit-pr-commenter · 2025-05-26T23:11:04Z

Go Package Import Differences

Baseline: 06e08cf
Comparison: acbe783

binary	os	arch	change
security-agent	linux	amd64	+1, -1 +github.com/DataDog/datadog-agent/pkg/security/utils/grpc -github.com/cenkalti/backoff/v4
security-agent	linux	arm64	+1, -1 +github.com/DataDog/datadog-agent/pkg/security/utils/grpc -github.com/cenkalti/backoff/v4
security-agent	windows	amd64	+1, -1 +github.com/DataDog/datadog-agent/pkg/security/utils/grpc -github.com/cenkalti/backoff/v4
system-probe	linux	amd64	+1, -0 +github.com/DataDog/datadog-agent/pkg/security/utils/grpc
system-probe	linux	arm64	+1, -0 +github.com/DataDog/datadog-agent/pkg/security/utils/grpc
system-probe	windows	amd64	+1, -0 +github.com/DataDog/datadog-agent/pkg/security/utils/grpc

agent-platform-auto-pr · 2025-05-26T23:25:28Z

Uncompressed package size comparison

Comparison with ancestor 06e08cf387fb430c0acb1508a8e0b55778d2f6c7

Size reduction summary

package	diff	status	size	ancestor	threshold
datadog-agent-aarch64-rpm	-0.01MB	✅	769.29MB	769.30MB	0.50MB
datadog-agent-arm64-deb	-0.01MB	✅	760.36MB	760.37MB	0.50MB
datadog-agent-amd64-deb	-0.01MB	✅	774.25MB	774.27MB	0.50MB
datadog-agent-x86_64-rpm	-0.01MB	✅	783.20MB	783.22MB	0.50MB
datadog-agent-x86_64-suse	-0.01MB	✅	783.20MB	783.22MB	0.50MB

Diff per package

package	diff	status	size	ancestor	threshold
datadog-dogstatsd-amd64-deb	0.00MB	✅	31.99MB	31.99MB	0.50MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	32.07MB	32.07MB	0.50MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	32.07MB	32.07MB	0.50MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	30.47MB	30.47MB	0.50MB
datadog-heroku-agent-amd64-deb	0.00MB	✅	380.65MB	380.65MB	0.50MB
datadog-iot-agent-amd64-deb	0.00MB	✅	62.80MB	62.80MB	0.50MB
datadog-iot-agent-x86_64-rpm	0.00MB	✅	62.88MB	62.88MB	0.50MB
datadog-iot-agent-x86_64-suse	0.00MB	✅	62.88MB	62.88MB	0.50MB
datadog-iot-agent-arm64-deb	0.00MB	✅	59.37MB	59.37MB	0.50MB
datadog-iot-agent-aarch64-rpm	0.00MB	✅	59.45MB	59.45MB	0.50MB

Decision

✅ Passed

cit-pr-commenter · 2025-05-26T23:43:20Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: ac4b4e12-4c12-4168-9c35-e591a98d897c

Baseline: 06e08cf
Comparison: acbe783
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+1.62	[-1.05, +4.29]	1	Logs bounds checks dashboard
➖	quality_gate_idle_all_features	memory utilization	+0.44	[+0.33, +0.54]	1	Logs bounds checks dashboard
➖	file_tree	memory utilization	+0.10	[-0.06, +0.27]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	+0.09	[-0.16, +0.33]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.06	[-0.53, +0.64]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	+0.06	[-0.58, +0.69]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.05	[-0.51, +0.62]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.01	[-0.56, +0.58]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.02, +0.03]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.01	[-0.29, +0.28]	1	Logs
➖	ddot_metrics	memory utilization	-0.01	[-0.12, +0.10]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.02	[-0.61, +0.56]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	-0.02	[-0.66, +0.61]	1	Logs
➖	ddot_logs	memory utilization	-0.06	[-0.20, +0.08]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	-0.09	[-0.68, +0.50]	1	Logs
➖	docker_containers_memory	memory utilization	-0.25	[-0.35, -0.15]	1	Logs
➖	quality_gate_idle	memory utilization	-0.36	[-0.42, -0.30]	1	Logs bounds checks dashboard
➖	tcp_syslog_to_blackhole	ingress throughput	-0.38	[-0.44, -0.33]	1	Logs
➖	otlp_ingest_logs	memory utilization	-0.42	[-0.55, -0.29]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-0.67	[-1.53, +0.20]	1	Logs
➖	otlp_ingest_metrics	memory utilization	-0.88	[-1.04, -0.72]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	-1.00	[-1.05, -0.95]	1	Logs
➖	docker_containers_cpu	% cpu utilization	-2.18	[-5.89, +1.52]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	docker_containers_cpu	simple_check_run	10/10
✅	docker_containers_memory	memory_usage	10/10
✅	docker_containers_memory	simple_check_run	10/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

pkg/security/probe/config/config.go

pkg/security/agent/agent.go

agent-platform-auto-pr · 2025-05-27T15:32:41Z

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 06e08cf

Successful checks

Info

	Quality gate	Delta	On disk size (MiB)	Delta	On wire size (MiB)
✅	agent_deb_amd64	$${\color{red}+0.01}$$	$${\color{green}746.93}$$ < $${752.99}$$	$${\color{green}-0.05}$$	$${\color{green}184.94}$$ < $${187.44}$$
✅	agent_deb_amd64_fips	$${\color{red}+0.01}$$	$${\color{green}745.3}$$ < $${751.36}$$	$${\color{red}+0.02}$$	$${\color{green}184.35}$$ < $${187.06}$$
✅	agent_heroku_amd64	$${\color{green}-0}$$	$${\color{green}369.0}$$ < $${369.68}$$	$${\color{green}-0}$$	$${\color{green}98.67}$$ < $${99.55}$$
✅	agent_msi	$${\color{red}+0.01}$$	$${\color{green}985.96}$$ < $${986.01}$$	$${\color{green}-0.03}$$	$${\color{green}149.68}$$ < $${149.72}$$
✅	agent_rpm_amd64	$${\color{red}+0.01}$$	$${\color{green}746.92}$$ < $${752.98}$$	$${\color{green}-0.02}$$	$${\color{green}186.57}$$ < $${190.03}$$
✅	agent_rpm_amd64_fips	$${\color{red}+0.01}$$	$${\color{green}745.28}$$ < $${751.35}$$	$${\color{red}+0.01}$$	$${\color{green}186.26}$$ < $${189.81}$$
✅	agent_rpm_arm64	$${\color{red}+0.01}$$	$${\color{green}733.66}$$ < $${739.42}$$	$${\color{red}+0.02}$$	$${\color{green}168.56}$$ < $${171.23}$$
✅	agent_rpm_arm64_fips	$${\color{red}+0.01}$$	$${\color{green}732.15}$$ < $${737.91}$$	$${\color{red}+0.04}$$	$${\color{green}167.64}$$ < $${170.22}$$
✅	agent_suse_amd64	$${\color{red}+0.01}$$	$${\color{green}746.92}$$ < $${752.98}$$	$${\color{green}-0.02}$$	$${\color{green}186.57}$$ < $${190.03}$$
✅	agent_suse_amd64_fips	$${\color{red}+0.01}$$	$${\color{green}745.28}$$ < $${751.35}$$	$${\color{red}+0.01}$$	$${\color{green}186.26}$$ < $${189.81}$$
✅	agent_suse_arm64	$${\color{red}+0.01}$$	$${\color{green}733.66}$$ < $${739.42}$$	$${\color{red}+0.02}$$	$${\color{green}168.56}$$ < $${171.23}$$
✅	agent_suse_arm64_fips	$${\color{red}+0.01}$$	$${\color{green}732.15}$$ < $${737.91}$$	$${\color{red}+0.04}$$	$${\color{green}167.64}$$ < $${170.22}$$
✅	docker_agent_amd64	$${\color{red}+0.01}$$	$${\color{green}830.71}$$ < $${849.39}$$	$${\color{green}-0.01}$$	$${\color{green}282.07}$$ < $${288.34}$$
✅	docker_agent_arm64	$${\color{red}+0.01}$$	$${\color{green}840.9}$$ < $${858.97}$$	$${\color{green}-0.03}$$	$${\color{green}268.21}$$ < $${274.36}$$
✅	docker_agent_jmx_amd64	$${\color{red}+0.01}$$	$${\color{green}830.71}$$ < $${849.39}$$	$${\color{green}-0.01}$$	$${\color{green}282.07}$$ < $${288.34}$$
✅	docker_agent_jmx_arm64	$${\color{red}+0.01}$$	$${\color{green}840.9}$$ < $${858.97}$$	$${\color{green}-0.03}$$	$${\color{green}268.21}$$ < $${274.36}$$
✅	docker_agent_windows1809	$${\color{red}+0.01}$$	$${\color{green}830.71}$$ < $${849.39}$$	$${\color{green}-0.01}$$	$${\color{green}282.07}$$ < $${288.34}$$
✅	docker_agent_windows1809_core	$${\color{red}+0.01}$$	$${\color{green}830.71}$$ < $${849.39}$$	$${\color{green}-0.01}$$	$${\color{green}282.07}$$ < $${288.34}$$
✅	docker_agent_windows1809_core_jmx	$${\color{red}+0.01}$$	$${\color{green}830.71}$$ < $${849.39}$$	$${\color{green}-0.01}$$	$${\color{green}282.07}$$ < $${288.34}$$
✅	docker_agent_windows1809_jmx	$${\color{red}+0.01}$$	$${\color{green}830.71}$$ < $${849.39}$$	$${\color{green}-0.01}$$	$${\color{green}282.07}$$ < $${288.34}$$
✅	docker_agent_windows2022	$${\color{red}+0.01}$$	$${\color{green}830.71}$$ < $${849.39}$$	$${\color{green}-0.01}$$	$${\color{green}282.07}$$ < $${288.34}$$
✅	docker_agent_windows2022_core	$${\color{red}+0.01}$$	$${\color{green}830.71}$$ < $${849.39}$$	$${\color{green}-0.01}$$	$${\color{green}282.07}$$ < $${288.34}$$
✅	docker_agent_windows2022_core_jmx	$${\color{red}+0.01}$$	$${\color{green}830.71}$$ < $${849.39}$$	$${\color{green}-0.01}$$	$${\color{green}282.07}$$ < $${288.34}$$
✅	docker_agent_windows2022_jmx	$${\color{red}+0.01}$$	$${\color{green}830.71}$$ < $${849.39}$$	$${\color{green}-0.01}$$	$${\color{green}282.07}$$ < $${288.34}$$
✅	docker_cluster_agent_amd64	$${\color{green}-0}$$	$${\color{green}258.97}$$ < $${259.73}$$	$${\color{red}+0}$$	$${\color{green}102.79}$$ < $${103.68}$$
✅	docker_cluster_agent_arm64	$${\color{green}-0}$$	$${\color{green}273.46}$$ < $${274.24}$$	$${\color{green}-0}$$	$${\color{green}97.55}$$ < $${98.45}$$
✅	docker_cws_instrumentation_amd64	$${\color{red}+0}$$	$${\color{green}7.08}$$ < $${7.12}$$	$${\color{red}+0}$$	$${\color{green}2.95}$$ < $${3.29}$$
✅	docker_cws_instrumentation_arm64	$${\color{red}+0}$$	$${\color{green}6.69}$$ < $${6.92}$$	$${\color{red}+0}$$	$${\color{green}2.7}$$ < $${3.07}$$
✅	docker_dogstatsd_amd64	$${\color{green}0}$$	$${\color{green}38.63}$$ < $${39.57}$$	$${\color{green}-0}$$	$${\color{green}14.81}$$ < $${15.76}$$
✅	docker_dogstatsd_arm64	$${\color{red}+0}$$	$${\color{green}37.26}$$ < $${38.2}$$	$${\color{red}+0}$$	$${\color{green}13.88}$$ < $${14.83}$$
✅	dogstatsd_deb_amd64	$${\color{green}0}$$	$${\color{green}30.58}$$ < $${31.52}$$	$${\color{red}+0}$$	$${\color{green}8.03}$$ < $${8.97}$$
✅	dogstatsd_deb_arm64	$${\color{green}0}$$	$${\color{green}29.14}$$ < $${30.08}$$	$${\color{green}-0}$$	$${\color{green}6.97}$$ < $${7.92}$$
✅	dogstatsd_rpm_amd64	$${\color{green}0}$$	$${\color{green}30.58}$$ < $${31.52}$$	$${\color{red}+0}$$	$${\color{green}8.04}$$ < $${8.98}$$
✅	dogstatsd_suse_amd64	$${\color{green}0}$$	$${\color{green}30.58}$$ < $${31.52}$$	$${\color{red}+0}$$	$${\color{green}8.04}$$ < $${8.98}$$
✅	iot_agent_deb_amd64	$${\color{green}0}$$	$${\color{green}59.97}$$ < $${60.17}$$	$${\color{red}+0}$$	$${\color{green}15.0}$$ < $${15.82}$$
✅	iot_agent_deb_arm64	$${\color{green}0}$$	$${\color{green}56.7}$$ < $${56.94}$$	$${\color{green}-0}$$	$${\color{green}12.87}$$ < $${13.86}$$
✅	iot_agent_deb_armhf	$${\color{green}0}$$	$${\color{green}56.15}$$ < $${56.41}$$	$${\color{red}+0}$$	$${\color{green}13.02}$$ < $${13.86}$$
✅	iot_agent_rpm_amd64	$${\color{green}0}$$	$${\color{green}59.97}$$ < $${60.18}$$	$${\color{red}+0.01}$$	$${\color{green}15.01}$$ < $${15.84}$$
✅	iot_agent_rpm_arm64	$${\color{green}0}$$	$${\color{green}56.7}$$ < $${56.94}$$	$${\color{red}+0}$$	$${\color{green}12.88}$$ < $${13.76}$$
✅	iot_agent_suse_amd64	$${\color{green}0}$$	$${\color{green}59.97}$$ < $${60.18}$$	$${\color{red}+0.01}$$	$${\color{green}15.01}$$ < $${15.84}$$

dustmop

LGTM for agent-configuration owned files

safchain added this to the Triage milestone May 26, 2025

safchain added changelog/no-changelog team/agent-security category/improvement qa/done QA done before merge and regressions are covered by tests labels May 26, 2025

github-actions bot added component/system-probe long review PR is complex, plan time to review it labels May 26, 2025

safchain commented May 26, 2025

View reviewed changes

pkg/security/module/server.go Show resolved Hide resolved

safchain marked this pull request as ready for review May 27, 2025 12:30

safchain requested review from a team as code owners May 27, 2025 12:30

safchain requested a review from dustmop May 27, 2025 12:30

YoannGh reviewed May 27, 2025

View reviewed changes

pkg/security/probe/config/config.go Outdated Show resolved Hide resolved

YoannGh reviewed May 27, 2025

View reviewed changes

pkg/security/agent/agent.go Outdated Show resolved Hide resolved

safchain added 9 commits May 28, 2025 10:25

[CWS] change the gRPC connection

5f4c577

refacto and add a cmd socket

f61eb9f

dispatch events

b69688b

mocks & cleanup

b943c3c

handle on connect

07504c4

move grpc server

b3436d4

fix lint

e70f389

fix review

d8d8606

fix test

acbe783

safchain force-pushed the safchain/kata branch from 88e8c55 to acbe783 Compare May 28, 2025 08:25

safchain added the ask-review Ask required teams to review this PR label May 28, 2025

dustmop approved these changes Jun 2, 2025

View reviewed changes

spikat approved these changes Jun 12, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[CWS] change the gRPC connection direction #37390

[CWS] change the gRPC connection direction #37390

Uh oh!

safchain commented May 26, 2025

Uh oh!

Uh oh!

cit-pr-commenter bot commented May 26, 2025 •

edited

Loading

Uh oh!

agent-platform-auto-pr bot commented May 26, 2025 •

edited

Loading

Uh oh!

cit-pr-commenter bot commented May 26, 2025 •

edited

Loading

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

Uh oh!

Uh oh!

Uh oh!

agent-platform-auto-pr bot commented May 27, 2025 •

edited

Loading

Info

Uh oh!

dustmop left a comment

Uh oh!

Uh oh!

[CWS] change the gRPC connection direction #37390

Are you sure you want to change the base?

[CWS] change the gRPC connection direction #37390

Uh oh!

Conversation

safchain commented May 26, 2025

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

Uh oh!

Uh oh!

cit-pr-commenter bot commented May 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Go Package Import Differences

Uh oh!

agent-platform-auto-pr bot commented May 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uncompressed package size comparison

Decision

Uh oh!

cit-pr-commenter bot commented May 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

CI Pass/Fail Decision

Uh oh!

Uh oh!

Uh oh!

agent-platform-auto-pr bot commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Static quality checks

Info

Uh oh!

dustmop left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cit-pr-commenter bot commented May 26, 2025 •

edited

Loading

agent-platform-auto-pr bot commented May 26, 2025 •

edited

Loading

cit-pr-commenter bot commented May 26, 2025 •

edited

Loading

agent-platform-auto-pr bot commented May 27, 2025 •

edited

Loading