Skip to content

update network path example config #37420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

update network path example config #37420

wants to merge 4 commits into from

Conversation

jack0x2
Copy link
Contributor

@jack0x2 jack0x2 commented May 27, 2025

What does this PR do?

Updates the example config to show tcp_methods option.

Motivation

https://datadoghq.atlassian.net/browse/WINA-1510

Describe how you validated your changes

Only doc changes

Possible Drawbacks / Trade-offs

Additional Notes

@github-actions github-actions bot added team/networks short review PR is simple enough to be reviewed quickly labels May 27, 2025
@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor 2d70888296fac9334b862b37b9af44b9840533bc

Diff per package
package diff status size ancestor threshold
datadog-agent-x86_64-rpm 0.00MB ✅ 782.92MB 782.92MB 0.50MB
datadog-agent-x86_64-suse 0.00MB ✅ 782.92MB 782.92MB 0.50MB
datadog-agent-aarch64-rpm 0.00MB ✅ 769.00MB 769.00MB 0.50MB
datadog-agent-amd64-deb 0.00MB ✅ 773.97MB 773.97MB 0.50MB
datadog-agent-arm64-deb 0.00MB ✅ 760.08MB 760.08MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB ✅ 31.99MB 31.99MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB ✅ 32.07MB 32.07MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB ✅ 32.07MB 32.07MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB ✅ 30.47MB 30.47MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB ✅ 380.65MB 380.65MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB ✅ 62.80MB 62.80MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB ✅ 62.88MB 62.88MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB ✅ 62.88MB 62.88MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB ✅ 59.37MB 59.37MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB ✅ 59.45MB 59.45MB 0.50MB

Decision

✅ Passed

@cit-pr-commenter cit-pr-commenter
Copy link

cit-pr-commenter bot commented May 27, 2025 •
edited
Loading

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 45ba0f38-c4b9-43f1-bdb6-c74695b912f0

Baseline: a74d008
Comparison: 06009ba
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ quality_gate_logs % cpu utilization +1.64 [-1.18, +4.46] 1 Logs bounds checks dashboard
➖ docker_containers_cpu % cpu utilization +1.18 [-1.99, +4.35] 1 Logs
➖ ddot_logs memory utilization +0.50 [+0.37, +0.64] 1 Logs
➖ quality_gate_idle_all_features memory utilization +0.20 [+0.06, +0.34] 1 Logs bounds checks dashboard
➖ file_to_blackhole_1000ms_latency_linear_load egress throughput +0.05 [-0.18, +0.28] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput +0.04 [-0.55, +0.62] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput +0.02 [-0.56, +0.60] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput +0.02 [-0.23, +0.26] 1 Logs
➖ file_to_blackhole_0ms_latency_http1 egress throughput +0.01 [-0.60, +0.63] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.02, +0.02] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput +0.00 [-0.60, +0.60] 1 Logs
➖ ddot_metrics memory utilization -0.00 [-0.12, +0.12] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput -0.01 [-0.60, +0.58] 1 Logs
➖ file_to_blackhole_300ms_latency egress throughput -0.03 [-0.68, +0.62] 1 Logs
➖ uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.12 [-0.19, -0.05] 1 Logs
➖ file_to_blackhole_0ms_latency_http2 egress throughput -0.14 [-0.78, +0.49] 1 Logs
➖ quality_gate_idle memory utilization -0.34 [-0.40, -0.28] 1 Logs bounds checks dashboard
➖ otlp_ingest_metrics memory utilization -0.37 [-0.53, -0.22] 1 Logs
➖ otlp_ingest_logs memory utilization -0.50 [-0.62, -0.37] 1 Logs
➖ uds_dogstatsd_to_api_cpu % cpu utilization -0.99 [-1.82, -0.17] 1 Logs
➖ tcp_syslog_to_blackhole ingress throughput -1.06 [-1.12, -0.99] 1 Logs
➖ file_tree memory utilization -2.80 [-2.95, -2.64] 1 Logs
➖ docker_containers_memory memory utilization -3.63 [-3.81, -3.45] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
❌ docker_containers_memory memory_usage 0/10
✅ docker_containers_cpu simple_check_run 10/10
✅ docker_containers_memory simple_check_run 10/10
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http1 memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http2 memory_usage 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_300ms_latency lost_bytes 10/10
✅ file_to_blackhole_300ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented May 27, 2025 •
edited
Loading

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor a74d008

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
✅ agent_deb_amd64 $${\color{red}+0}$$ $${\color{green}746.96}$$ < $${752.99}$$ $${\color{red}+0.01}$$ $${\color{green}184.9}$$ < $${187.44}$$
✅ agent_deb_amd64_fips $${\color{red}+0}$$ $${\color{green}745.32}$$ < $${751.36}$$ $${\color{red}+0}$$ $${\color{green}184.35}$$ < $${187.06}$$
✅ agent_heroku_amd64 $${\color{red}+0}$$ $${\color{green}369.02}$$ < $${369.68}$$ $${\color{green}-0.01}$$ $${\color{green}98.67}$$ < $${99.55}$$
✅ agent_msi $${\color{red}+0}$$ $${\color{green}986.0}$$ < $${987.01}$$ $${\color{red}+0.01}$$ $${\color{green}149.68}$$ < $${150.72}$$
✅ agent_rpm_amd64 $${\color{red}+0}$$ $${\color{green}746.95}$$ < $${752.98}$$ $${\color{red}+0.01}$$ $${\color{green}186.53}$$ < $${190.03}$$
✅ agent_rpm_amd64_fips $${\color{red}+0}$$ $${\color{green}745.31}$$ < $${751.35}$$ $${\color{green}-0.01}$$ $${\color{green}186.27}$$ < $${189.81}$$
✅ agent_rpm_arm64 $${\color{red}+0}$$ $${\color{green}733.71}$$ < $${739.42}$$ $${\color{green}-0}$$ $${\color{green}168.56}$$ < $${171.23}$$
✅ agent_rpm_arm64_fips $${\color{red}+0}$$ $${\color{green}732.21}$$ < $${737.91}$$ $${\color{green}-0.02}$$ $${\color{green}167.66}$$ < $${170.22}$$
✅ agent_suse_amd64 $${\color{red}+0}$$ $${\color{green}746.95}$$ < $${752.98}$$ $${\color{red}+0.01}$$ $${\color{green}186.53}$$ < $${190.03}$$
✅ agent_suse_amd64_fips $${\color{red}+0}$$ $${\color{green}745.31}$$ < $${751.35}$$ $${\color{green}-0.01}$$ $${\color{green}186.27}$$ < $${189.81}$$
✅ agent_suse_arm64 $${\color{red}+0}$$ $${\color{green}733.71}$$ < $${739.42}$$ $${\color{green}-0}$$ $${\color{green}168.56}$$ < $${171.23}$$
✅ agent_suse_arm64_fips $${\color{red}+0}$$ $${\color{green}732.21}$$ < $${737.91}$$ $${\color{green}-0.02}$$ $${\color{green}167.66}$$ < $${170.22}$$
✅ docker_agent_amd64 $${\color{red}+0}$$ $${\color{green}830.74}$$ < $${849.39}$$ $${\color{red}+0}$$ $${\color{green}282.06}$$ < $${288.34}$$
✅ docker_agent_arm64 $${\color{red}+0}$$ $${\color{green}840.96}$$ < $${858.97}$$ $${\color{green}-0}$$ $${\color{green}268.19}$$ < $${274.36}$$
✅ docker_agent_jmx_amd64 $${\color{red}+0}$$ $${\color{green}830.74}$$ < $${849.39}$$ $${\color{red}+0}$$ $${\color{green}282.06}$$ < $${288.34}$$
✅ docker_agent_jmx_arm64 $${\color{red}+0}$$ $${\color{green}840.96}$$ < $${858.97}$$ $${\color{green}-0}$$ $${\color{green}268.19}$$ < $${274.36}$$
✅ docker_agent_windows1809 $${\color{red}+0}$$ $${\color{green}830.74}$$ < $${849.39}$$ $${\color{red}+0}$$ $${\color{green}282.06}$$ < $${288.34}$$
✅ docker_agent_windows1809_core $${\color{red}+0}$$ $${\color{green}830.74}$$ < $${849.39}$$ $${\color{red}+0}$$ $${\color{green}282.06}$$ < $${288.34}$$
✅ docker_agent_windows1809_core_jmx $${\color{red}+0}$$ $${\color{green}830.74}$$ < $${849.39}$$ $${\color{red}+0}$$ $${\color{green}282.06}$$ < $${288.34}$$
✅ docker_agent_windows1809_jmx $${\color{red}+0}$$ $${\color{green}830.74}$$ < $${849.39}$$ $${\color{red}+0}$$ $${\color{green}282.06}$$ < $${288.34}$$
✅ docker_agent_windows2022 $${\color{red}+0}$$ $${\color{green}830.74}$$ < $${849.39}$$ $${\color{red}+0}$$ $${\color{green}282.06}$$ < $${288.34}$$
✅ docker_agent_windows2022_core $${\color{red}+0}$$ $${\color{green}830.74}$$ < $${849.39}$$ $${\color{red}+0}$$ $${\color{green}282.06}$$ < $${288.34}$$
✅ docker_agent_windows2022_core_jmx $${\color{red}+0}$$ $${\color{green}830.74}$$ < $${849.39}$$ $${\color{red}+0}$$ $${\color{green}282.06}$$ < $${288.34}$$
✅ docker_agent_windows2022_jmx $${\color{red}+0}$$ $${\color{green}830.74}$$ < $${849.39}$$ $${\color{red}+0}$$ $${\color{green}282.06}$$ < $${288.34}$$
✅ docker_cluster_agent_amd64 $${\color{green}0}$$ $${\color{green}259.04}$$ < $${259.73}$$ $${\color{red}+0}$$ $${\color{green}102.83}$$ < $${103.68}$$
✅ docker_cluster_agent_arm64 $${\color{red}+0}$$ $${\color{green}273.48}$$ < $${274.24}$$ $${\color{red}+0}$$ $${\color{green}97.54}$$ < $${98.45}$$
✅ docker_cws_instrumentation_amd64 $${\color{green}-0}$$ $${\color{green}7.08}$$ < $${7.12}$$ $${\color{red}+0}$$ $${\color{green}2.95}$$ < $${3.29}$$
✅ docker_cws_instrumentation_arm64 $${\color{green}0}$$ $${\color{green}6.69}$$ < $${6.92}$$ $${\color{green}-0}$$ $${\color{green}2.7}$$ < $${3.07}$$
✅ docker_dogstatsd_amd64 $${\color{green}0}$$ $${\color{green}38.9}$$ < $${39.57}$$ $${\color{green}-0}$$ $${\color{green}14.94}$$ < $${15.76}$$
✅ docker_dogstatsd_arm64 $${\color{green}0}$$ $${\color{green}37.52}$$ < $${38.2}$$ $${\color{green}-0}$$ $${\color{green}13.95}$$ < $${14.83}$$
✅ dogstatsd_deb_amd64 $${\color{green}0}$$ $${\color{green}30.58}$$ < $${31.52}$$ $${\color{green}-0}$$ $${\color{green}8.03}$$ < $${8.97}$$
✅ dogstatsd_deb_arm64 $${\color{green}0}$$ $${\color{green}29.14}$$ < $${30.08}$$ $${\color{red}+0}$$ $${\color{green}6.97}$$ < $${7.92}$$
✅ dogstatsd_rpm_amd64 $${\color{green}0}$$ $${\color{green}30.58}$$ < $${31.52}$$ $${\color{red}+0}$$ $${\color{green}8.04}$$ < $${8.98}$$
✅ dogstatsd_suse_amd64 $${\color{green}0}$$ $${\color{green}30.58}$$ < $${31.52}$$ $${\color{red}+0}$$ $${\color{green}8.04}$$ < $${8.98}$$
✅ iot_agent_deb_amd64 $${\color{green}0}$$ $${\color{green}59.97}$$ < $${60.17}$$ $${\color{red}+0}$$ $${\color{green}14.99}$$ < $${15.82}$$
✅ iot_agent_deb_arm64 $${\color{green}0}$$ $${\color{green}56.7}$$ < $${56.94}$$ $${\color{red}+0}$$ $${\color{green}12.87}$$ < $${13.86}$$
✅ iot_agent_deb_armhf $${\color{green}0}$$ $${\color{green}56.14}$$ < $${56.41}$$ $${\color{green}-0.02}$$ $${\color{green}13.0}$$ < $${13.86}$$
✅ iot_agent_rpm_amd64 $${\color{green}0}$$ $${\color{green}59.97}$$ < $${60.18}$$ $${\color{red}+0}$$ $${\color{green}15.02}$$ < $${15.84}$$
✅ iot_agent_rpm_arm64 $${\color{green}0}$$ $${\color{green}56.7}$$ < $${56.94}$$ $${\color{red}+0}$$ $${\color{green}12.89}$$ < $${13.76}$$
✅ iot_agent_suse_amd64 $${\color{green}0}$$ $${\color{green}59.97}$$ < $${60.18}$$ $${\color{red}+0}$$ $${\color{green}15.02}$$ < $${15.84}$$

@jack0x2 jack0x2 added qa/no-code-change No code change in Agent code requiring validation changelog/no-changelog labels May 28, 2025
@jack0x2 jack0x2 marked this pull request as ready for review May 28, 2025 21:02
@jack0x2 jack0x2 requested a review from a team as a code owner May 28, 2025 21:02
@jack0x2 jack0x2 requested review from Jakobovski and a team May 28, 2025 21:02
@jack0x2 jack0x2 added the ask-review Ask required teams to review this PR label May 28, 2025
@buraizu buraizu self-assigned this May 28, 2025
buraizu
buraizu approved these changes May 28, 2025
View reviewed changes
Copy link
Contributor

@buraizu buraizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with a suggested update

@jack0x2 @buraizu
Update cmd/agent/dist/conf.d/network_path.d/conf.yaml.example
06009ba 
Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>
@jack0x2 jack0x2 changed the title Jack.phillips/update network path config update network path example config May 28, 2025
@leeavital leeavital requested a review from pimlu June 11, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buraizu buraizu buraizu approved these changes

@Jakobovski Jakobovski Awaiting requested review from Jakobovski Jakobovski is a code owner automatically assigned from DataDog/networks

@pimlu pimlu Awaiting requested review from pimlu

At least 1 approving review is required to merge this pull request.

Assignees

@buraizu buraizu

Labels
ask-review Ask required teams to review this PR changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/networks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jack0x2 @buraizu