Skip to content

Build otel-only packages instead of agent+otel (deb) #37647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Build otel-only packages instead of agent+otel (deb) #37647

wants to merge 6 commits into from

Conversation

alopezz
Copy link
Contributor

@alopezz alopezz commented Jun 4, 2025 •
edited by jira bot
Loading

What does this PR do?

It adds the build of deb and rpm packages containing only the otel-agent (ddot). These packages will depend on the datadog-agent at the package-manager level.

Motivation

ABLD-56

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

This PR replaces existing jobs for deb packages that are no longer used. These were building a combination a "fat" package which combined the regular datadog-agent package with this additional binary. Since we've discarded that approach now, this should make sense.

@github-actions github-actions bot added medium review PR review might take time team/agent-delivery labels Jun 4, 2025
@alopezz alopezz force-pushed the alopez/ot-only-packages branch from 7ec23a1 to 87d2146 Compare June 4, 2025 12:01
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jun 4, 2025 •
edited
Loading

Gitlab CI Configuration Changes

Modified Jobs

ot_agent_deb-arm64-a7 
  ot_agent_deb-arm64-a7:
    artifacts:
      expire_in: 2 weeks
      paths:
      - $OMNIBUS_PACKAGE_DIR
    cache:
    - key:
        files:
        - omnibus/Gemfile
        - release.json
        prefix: omnibus-deps-$CI_JOB_NAME-$OMNIBUS_RUBY_VERSION
      paths:
      - omnibus/vendor/bundle
    image: registry.ddbuild.io/ci/datadog-agent-buildimages/linux-glibc-2-23-arm64$CI_IMAGE_LINUX_GLIBC_2_23_ARM64_SUFFIX:$CI_IMAGE_LINUX_GLIBC_2_23_ARM64
    needs:
-   - datadog-agent-7-arm64
    - datadog-otel-agent-arm64
    rules:
    - if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
      when: never
    - when: on_success
    script:
    - pushd omnibus && bundle config set --local path 'vendor/bundle' && popd
    - set +x
    - printf -- "$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $DEB_GPG_KEY)" | gpg --import
      --batch
    - EXIT="${PIPESTATUS[0]}"; if [ $EXIT -ne 0 ]; then echo "Unable to locate credentials
      needs gitlab runner restart"; exit $EXIT; fi
    - DEB_SIGNING_PASSPHRASE=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $DEB_SIGNING_PASSPHRASE)
      || exit $?; export DEB_SIGNING_PASSPHRASE
    - dda inv -- -e omnibus.build --base-dir $OMNIBUS_BASE_DIR --skip-deps --target-project
-     ${DD_PROJECT} --flavor ot ${OMNIBUS_EXTRA_ARGS}
?                  ------------
+     ${DD_PROJECT} ${OMNIBUS_EXTRA_ARGS}
    - curl -sSL "https://dd-package-tools.s3.amazonaws.com/dd-pkg/${DD_PKG_VERSION}/dd-pkg_Linux_${DD_PKG_ARCH}.tar.gz"
      | tar -xz -C /usr/local/bin dd-pkg
    - dd-pkg version
    - find $OMNIBUS_PACKAGE_DIR -iregex '.*\.\(deb\|rpm\)' | xargs dd-pkg lint
    - "if [ -n \"$PACKAGE_REQUIRED_FILES_LIST\" ]; then\n  find $OMNIBUS_PACKAGE_DIR\
      \ \\( -name '*.deb' -or -name '*.rpm' \\) -a -not -name '*-dbg[_-]*' | xargs dd-pkg\
      \ check-files --required-files ${PACKAGE_REQUIRED_FILES_LIST}\nfi\n"
    - dd-pkg sign --key-id "${PIPELINE_KEY_ALIAS}" "${OMNIBUS_PACKAGE_DIR}"
    stage: packaging
    tags:
    - arch:arm64
    variables:
      DD_PKG_ARCH: arm64
-     DD_PROJECT: agent
+     DD_PROJECT: otel-agent
?                 +++++
      KUBERNETES_CPU_REQUEST: 16
      KUBERNETES_MEMORY_LIMIT: 32Gi
      KUBERNETES_MEMORY_REQUEST: 32Gi
      OMNIBUS_PACKAGE_ARTIFACT_DIR: $OMNIBUS_PACKAGE_DIR
      PACKAGE_ARCH: arm64
-     PACKAGE_REQUIRED_FILES_LIST: test/required_files/agent-deb.txt
+     PACKAGE_REQUIRED_FILES_LIST: ''
ot_agent_deb-x64-a7 
  ot_agent_deb-x64-a7:
    artifacts:
      expire_in: 2 weeks
      paths:
      - $OMNIBUS_PACKAGE_DIR
    cache:
    - key:
        files:
        - omnibus/Gemfile
        - release.json
        prefix: omnibus-deps-$CI_JOB_NAME-$OMNIBUS_RUBY_VERSION
      paths:
      - omnibus/vendor/bundle
    image: registry.ddbuild.io/ci/datadog-agent-buildimages/linux-glibc-2-17-x64$CI_IMAGE_LINUX_GLIBC_2_17_X64_SUFFIX:$CI_IMAGE_LINUX_GLIBC_2_17_X64
    needs:
-   - datadog-agent-7-x64
    - datadog-otel-agent-x64
    rules:
    - if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
      when: never
    - when: on_success
    script:
    - pushd omnibus && bundle config set --local path 'vendor/bundle' && popd
    - set +x
    - printf -- "$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $DEB_GPG_KEY)" | gpg --import
      --batch
    - EXIT="${PIPESTATUS[0]}"; if [ $EXIT -ne 0 ]; then echo "Unable to locate credentials
      needs gitlab runner restart"; exit $EXIT; fi
    - DEB_SIGNING_PASSPHRASE=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $DEB_SIGNING_PASSPHRASE)
      || exit $?; export DEB_SIGNING_PASSPHRASE
    - dda inv -- -e omnibus.build --base-dir $OMNIBUS_BASE_DIR --skip-deps --target-project
-     ${DD_PROJECT} --flavor ot ${OMNIBUS_EXTRA_ARGS}
?                  ------------
+     ${DD_PROJECT} ${OMNIBUS_EXTRA_ARGS}
    - curl -sSL "https://dd-package-tools.s3.amazonaws.com/dd-pkg/${DD_PKG_VERSION}/dd-pkg_Linux_${DD_PKG_ARCH}.tar.gz"
      | tar -xz -C /usr/local/bin dd-pkg
    - dd-pkg version
    - find $OMNIBUS_PACKAGE_DIR -iregex '.*\.\(deb\|rpm\)' | xargs dd-pkg lint
    - "if [ -n \"$PACKAGE_REQUIRED_FILES_LIST\" ]; then\n  find $OMNIBUS_PACKAGE_DIR\
      \ \\( -name '*.deb' -or -name '*.rpm' \\) -a -not -name '*-dbg[_-]*' | xargs dd-pkg\
      \ check-files --required-files ${PACKAGE_REQUIRED_FILES_LIST}\nfi\n"
    - dd-pkg sign --key-id "${PIPELINE_KEY_ALIAS}" "${OMNIBUS_PACKAGE_DIR}"
    stage: packaging
    tags:
    - arch:amd64
    variables:
      DD_PKG_ARCH: x86_64
-     DD_PROJECT: agent
+     DD_PROJECT: otel-agent
?                 +++++
      KUBERNETES_CPU_REQUEST: 16
      KUBERNETES_MEMORY_LIMIT: 32Gi
      KUBERNETES_MEMORY_REQUEST: 32Gi
      OMNIBUS_PACKAGE_ARTIFACT_DIR: $OMNIBUS_PACKAGE_DIR
      PACKAGE_ARCH: amd64
-     PACKAGE_REQUIRED_FILES_LIST: test/required_files/agent-deb.txt
+     PACKAGE_REQUIRED_FILES_LIST: ''

Added Jobs

ot_agent_rpm-amd64 
ot_agent_rpm-amd64:
  artifacts:
    expire_in: 2 weeks
    paths:
    - $OMNIBUS_PACKAGE_DIR
  before_script: null
  cache:
  - key:
      files:
      - omnibus/Gemfile
      - release.json
      prefix: omnibus-deps-$CI_JOB_NAME-$OMNIBUS_RUBY_VERSION
    paths:
    - omnibus/vendor/bundle
  image: registry.ddbuild.io/ci/datadog-agent-buildimages/rpm_x64$CI_IMAGE_RPM_X64_SUFFIX:$CI_IMAGE_RPM_X64
  needs:
  - datadog-otel-agent-x64
  rules:
  - if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
    when: never
  - when: on_success
  script:
  - pushd omnibus && bundle config set --local path 'vendor/bundle' && popd
  - printf -- "$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $RPM_GPG_KEY)" | gpg --import
    --batch
  - EXIT="${PIPESTATUS[0]}"; if [ $EXIT -ne 0 ]; then echo "Unable to locate credentials
    needs gitlab runner restart"; exit $EXIT; fi
  - RPM_SIGNING_PASSPHRASE=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $RPM_SIGNING_PASSPHRASE)
    || exit $?; export RPM_SIGNING_PASSPHRASE
  - dda inv -- -e omnibus.build --base-dir $OMNIBUS_BASE_DIR --skip-deps --target-project=${DD_PROJECT}
    ${OMNIBUS_EXTRA_ARGS}
  - ls -la $OMNIBUS_PACKAGE_DIR/
  - curl -sSL "https://dd-package-tools.s3.amazonaws.com/dd-pkg/${DD_PKG_VERSION}/dd-pkg_Linux_${DD_PKG_ARCH}.tar.gz"
    | tar -xz -C /usr/local/bin dd-pkg
  - dd-pkg version
  - find $OMNIBUS_PACKAGE_DIR -iregex '.*\.\(deb\|rpm\)' | xargs dd-pkg lint
  - "if [ -n \"$PACKAGE_REQUIRED_FILES_LIST\" ]; then\n  find $OMNIBUS_PACKAGE_DIR\
    \ \\( -name '*.deb' -or -name '*.rpm' \\) -a -not -name '*-dbg[_-]*' | xargs dd-pkg\
    \ check-files --required-files ${PACKAGE_REQUIRED_FILES_LIST}\nfi\n"
  - dd-pkg sign --key-id "${PIPELINE_KEY_ALIAS}" "${OMNIBUS_PACKAGE_DIR}"
  stage: packaging
  tags:
  - arch:amd64
  variables:
    DD_PKG_ARCH: x86_64
    DD_PROJECT: otel-agent
    KUBERNETES_CPU_REQUEST: 16
    KUBERNETES_MEMORY_LIMIT: 32Gi
    KUBERNETES_MEMORY_REQUEST: 32Gi
    OMNIBUS_PACKAGE_ARTIFACT_DIR: $OMNIBUS_PACKAGE_DIR
    PACKAGE_ARCH: amd64
    PACKAGE_REQUIRED_FILES_LIST: ''
ot_agent_rpm-arm64 
ot_agent_rpm-arm64:
  artifacts:
    expire_in: 2 weeks
    paths:
    - $OMNIBUS_PACKAGE_DIR
  before_script: null
  cache:
  - key:
      files:
      - omnibus/Gemfile
      - release.json
      prefix: omnibus-deps-$CI_JOB_NAME-$OMNIBUS_RUBY_VERSION
    paths:
    - omnibus/vendor/bundle
  image: registry.ddbuild.io/ci/datadog-agent-buildimages/rpm_arm64$CI_IMAGE_RPM_ARM64_SUFFIX:$CI_IMAGE_RPM_ARM64
  needs:
  - datadog-otel-agent-arm64
  rules:
  - if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
    when: never
  - when: on_success
  script:
  - pushd omnibus && bundle config set --local path 'vendor/bundle' && popd
  - printf -- "$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $RPM_GPG_KEY)" | gpg --import
    --batch
  - EXIT="${PIPESTATUS[0]}"; if [ $EXIT -ne 0 ]; then echo "Unable to locate credentials
    needs gitlab runner restart"; exit $EXIT; fi
  - RPM_SIGNING_PASSPHRASE=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $RPM_SIGNING_PASSPHRASE)
    || exit $?; export RPM_SIGNING_PASSPHRASE
  - dda inv -- -e omnibus.build --base-dir $OMNIBUS_BASE_DIR --skip-deps --target-project=${DD_PROJECT}
    ${OMNIBUS_EXTRA_ARGS}
  - ls -la $OMNIBUS_PACKAGE_DIR/
  - curl -sSL "https://dd-package-tools.s3.amazonaws.com/dd-pkg/${DD_PKG_VERSION}/dd-pkg_Linux_${DD_PKG_ARCH}.tar.gz"
    | tar -xz -C /usr/local/bin dd-pkg
  - dd-pkg version
  - find $OMNIBUS_PACKAGE_DIR -iregex '.*\.\(deb\|rpm\)' | xargs dd-pkg lint
  - "if [ -n \"$PACKAGE_REQUIRED_FILES_LIST\" ]; then\n  find $OMNIBUS_PACKAGE_DIR\
    \ \\( -name '*.deb' -or -name '*.rpm' \\) -a -not -name '*-dbg[_-]*' | xargs dd-pkg\
    \ check-files --required-files ${PACKAGE_REQUIRED_FILES_LIST}\nfi\n"
  - dd-pkg sign --key-id "${PIPELINE_KEY_ALIAS}" "${OMNIBUS_PACKAGE_DIR}"
  stage: packaging
  tags:
  - arch:arm64
  variables:
    DD_PKG_ARCH: arm64
    DD_PROJECT: otel-agent
    KUBERNETES_CPU_REQUEST: 16
    KUBERNETES_MEMORY_LIMIT: 32Gi
    KUBERNETES_MEMORY_REQUEST: 32Gi
    OMNIBUS_PACKAGE_ARTIFACT_DIR: $OMNIBUS_PACKAGE_DIR
    PACKAGE_ARCH: arm64
    PACKAGE_REQUIRED_FILES_LIST: ''

Removed Jobs

  • .package_ot_deb_common

Changes Summary

Removed Modified Added Renamed
1 2 2 0

ℹ️ Diff available in the job log.

@alopezz alopezz added qa/no-code-change No code change in Agent code requiring validation changelog/no-changelog and removed qa/no-code-change No code change in Agent code requiring validation labels Jun 4, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jun 4, 2025 •
edited
Loading

Static quality checks

❌ Please find below the results from static quality gates
Comparison made with ancestor d2e51b7

Error

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
❌ docker_agent_windows1809 $${-0.07}$$ $${1486.93}$$ > $${1484.8}$$ $${-0.02}$$ $${488.05}$$ < $${488.95}$$
❌ docker_agent_windows1809_core $${-0}$$ $${6216.96}$$ > $${6215.68}$$ $${0}$$ $${2048.0}$$ < $${2048.0}$$
❌ docker_agent_windows1809_jmx $${-0}$$ $${1608.63}$$ > $${1607.68}$$ $${-0.02}$$ $${530.31}$$ < $${531.32}$$
❌ docker_agent_windows2022 $${+0.14}$$ $${1506.43}$$ > $${1505.28}$$ $${+0.01}$$ $${500.8}$$ < $${501.7}$$
❌ docker_agent_windows2022_core_jmx $${+0.17}$$ $${6311.86}$$ > $${6307.84}$$ $${0}$$ $${2048.0}$$ < $${2048.0}$$
Gate failure full details
Quality gate Error type Error message
docker_agent_windows1809 AssertionError Image size on disk (uncompressed image size) 1559161240 is higher than the maximum allowed 1556925644 by the gate !
docker_agent_windows1809_core AssertionError Image size on disk (uncompressed image size) 6518951120 is higher than the maximum allowed 6517612871 by the gate !
docker_agent_windows1809_jmx AssertionError Image size on disk (uncompressed image size) 1686768713 is higher than the maximum allowed 1685774663 by the gate !
docker_agent_windows2022 AssertionError Image size on disk (uncompressed image size) 1579602140 is higher than the maximum allowed 1578400481 by the gate !
docker_agent_windows2022_core_jmx AssertionError Image size on disk (uncompressed image size) 6618463814 is higher than the maximum allowed 6614249635 by the gate !

Static quality gates prevent the PR to merge! You can check the static quality gates confluence page for guidance. We also have a toolbox page available to list tools useful to debug the size increase.

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
✅ agent_deb_amd64 $${+0}$$ $${696.37}$$ < $${697.37}$$ $${+0.06}$$ $${176.08}$$ < $${177.03}$$
✅ agent_deb_amd64_fips $${+0}$$ $${694.59}$$ < $${695.59}$$ $${+0.02}$$ $${175.52}$$ < $${176.51}$$
✅ agent_heroku_amd64 $${0}$$ $${358.66}$$ < $${359.67}$$ $${-0.01}$$ $${96.52}$$ < $${97.47}$$
✅ agent_msi $${+0}$$ $${958.86}$$ < $${959.86}$$ $${+0.01}$$ $${146.29}$$ < $${147.27}$$
✅ agent_rpm_amd64 $${+0}$$ $${696.36}$$ < $${697.36}$$ $${-0.03}$$ $${177.58}$$ < $${178.56}$$
✅ agent_rpm_amd64_fips $${+0}$$ $${694.58}$$ < $${695.58}$$ $${+0.01}$$ $${177.48}$$ < $${178.43}$$
✅ agent_rpm_arm64 $${+0}$$ $${686.37}$$ < $${687.37}$$ $${+0.02}$$ $${161.06}$$ < $${161.99}$$
✅ agent_rpm_arm64_fips $${+0}$$ $${684.72}$$ < $${685.72}$$ $${+0.01}$$ $${160.14}$$ < $${161.11}$$
✅ agent_suse_amd64 $${+0}$$ $${696.36}$$ < $${697.36}$$ $${-0.03}$$ $${177.58}$$ < $${178.56}$$
✅ agent_suse_amd64_fips $${+0}$$ $${694.58}$$ < $${695.58}$$ $${+0.01}$$ $${177.48}$$ < $${178.43}$$
✅ agent_suse_arm64 $${+0}$$ $${686.37}$$ < $${687.37}$$ $${+0.02}$$ $${161.06}$$ < $${161.99}$$
✅ agent_suse_arm64_fips $${+0}$$ $${684.72}$$ < $${685.72}$$ $${+0.01}$$ $${160.14}$$ < $${161.11}$$
✅ docker_agent_amd64 $${+0}$$ $${780.16}$$ < $${781.16}$$ $${+0.01}$$ $${268.68}$$ < $${269.63}$$
✅ docker_agent_arm64 $${+0}$$ $${793.62}$$ < $${794.62}$$ $${+0.01}$$ $${256.05}$$ < $${257.0}$$
✅ docker_agent_jmx_amd64 $${+0}$$ $${971.35}$$ < $${972.35}$$ $${-0.01}$$ $${337.65}$$ < $${338.6}$$
✅ docker_agent_jmx_arm64 $${+0}$$ $${973.41}$$ < $${974.41}$$ $${-0}$$ $${320.99}$$ < $${321.97}$$
✅ docker_agent_windows1809_core_jmx $${+0}$$ $${6338.53}$$ < $${6338.56}$$ $${0}$$ $${2048.0}$$ < $${2048.0}$$
✅ docker_agent_windows2022_core $${+0.28}$$ $${6190.3}$$ < $${6195.2}$$ $${0}$$ $${2048.0}$$ < $${2048.0}$$
✅ docker_agent_windows2022_jmx $${-0}$$ $${1627.88}$$ < $${1628.16}$$ $${-0.01}$$ $${543.04}$$ < $${543.98}$$
✅ docker_cluster_agent_amd64 $${0}$$ $${212.84}$$ < $${213.79}$$ $${-0}$$ $${72.38}$$ < $${73.33}$$
✅ docker_cluster_agent_arm64 $${-0}$$ $${228.68}$$ < $${229.64}$$ $${-0}$$ $${68.64}$$ < $${69.6}$$
✅ docker_cws_instrumentation_amd64 $${0}$$ $${7.08}$$ < $${7.12}$$ $${-0}$$ $${2.95}$$ < $${3.29}$$
✅ docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${-0}$$ $${2.7}$$ < $${3.07}$$
✅ docker_dogstatsd_amd64 $${0}$$ $${39.22}$$ < $${39.57}$$ $${+0}$$ $${15.12}$$ < $${15.76}$$
✅ docker_dogstatsd_arm64 $${0}$$ $${37.88}$$ < $${38.2}$$ $${-0}$$ $${14.54}$$ < $${14.83}$$
✅ dogstatsd_deb_amd64 $${0}$$ $${30.44}$$ < $${31.4}$$ $${+0}$$ $${8.0}$$ < $${8.95}$$
✅ dogstatsd_deb_arm64 $${0}$$ $${29.02}$$ < $${29.97}$$ $${-0}$$ $${6.94}$$ < $${7.89}$$
✅ dogstatsd_rpm_amd64 $${0}$$ $${30.44}$$ < $${31.4}$$ $${+0}$$ $${8.01}$$ < $${8.96}$$
✅ dogstatsd_suse_amd64 $${0}$$ $${30.44}$$ < $${31.4}$$ $${+0}$$ $${8.01}$$ < $${8.96}$$
✅ iot_agent_deb_amd64 $${0}$$ $${50.42}$$ < $${51.38}$$ $${-0}$$ $${12.84}$$ < $${13.79}$$
✅ iot_agent_deb_arm64 $${0}$$ $${47.9}$$ < $${48.85}$$ $${+0}$$ $${11.14}$$ < $${12.09}$$
✅ iot_agent_deb_armhf $${0}$$ $${47.47}$$ < $${48.42}$$ $${+0}$$ $${11.2}$$ < $${12.16}$$
✅ iot_agent_rpm_amd64 $${0}$$ $${50.42}$$ < $${51.38}$$ $${+0}$$ $${12.86}$$ < $${13.81}$$
✅ iot_agent_rpm_arm64 $${0}$$ $${47.9}$$ < $${48.85}$$ $${-0}$$ $${11.15}$$ < $${12.11}$$
✅ iot_agent_suse_amd64 $${0}$$ $${50.42}$$ < $${51.38}$$ $${+0}$$ $${12.86}$$ < $${13.81}$$

liustanley
liustanley reviewed Jun 4, 2025
View reviewed changes
@alopezz alopezz force-pushed the alopez/ot-only-packages branch from 87d2146 to 93ef018 Compare June 6, 2025 12:42
@cit-pr-commenter cit-pr-commenter
Copy link

cit-pr-commenter bot commented Jun 6, 2025 •
edited
Loading

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 176af85e-5bf4-4d1b-b969-d073ad1b85eb

Baseline: d2e51b7
Comparison: 4888bd0
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ docker_containers_cpu % cpu utilization +1.56 [-1.42, +4.55] 1 Logs
➖ docker_containers_memory memory utilization +0.54 [+0.45, +0.62] 1 Logs
➖ tcp_syslog_to_blackhole ingress throughput +0.43 [+0.35, +0.51] 1 Logs
➖ otlp_ingest_logs memory utilization +0.41 [+0.29, +0.54] 1 Logs
➖ ddot_logs memory utilization +0.40 [+0.28, +0.52] 1 Logs
➖ ddot_metrics memory utilization +0.27 [+0.15, +0.38] 1 Logs
➖ uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.23 [+0.19, +0.28] 1 Logs
➖ otlp_ingest_metrics memory utilization +0.18 [+0.01, +0.34] 1 Logs
➖ file_to_blackhole_300ms_latency egress throughput +0.07 [-0.52, +0.65] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput +0.05 [-0.51, +0.61] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput +0.02 [-0.57, +0.60] 1 Logs
➖ file_to_blackhole_0ms_latency_http2 egress throughput +0.00 [-0.56, +0.57] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput +0.00 [-0.28, +0.28] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.02, +0.02] 1 Logs
➖ file_to_blackhole_1000ms_latency_linear_load egress throughput -0.03 [-0.27, +0.20] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput -0.03 [-0.66, +0.59] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput -0.05 [-0.63, +0.54] 1 Logs
➖ file_to_blackhole_0ms_latency_http1 egress throughput -0.06 [-0.65, +0.53] 1 Logs
➖ quality_gate_idle_all_features memory utilization -0.55 [-0.69, -0.41] 1 Logs bounds checks dashboard
➖ uds_dogstatsd_to_api_cpu % cpu utilization -0.64 [-1.47, +0.18] 1 Logs
➖ quality_gate_idle memory utilization -0.65 [-0.71, -0.60] 1 Logs bounds checks dashboard
➖ quality_gate_logs % cpu utilization -2.51 [-5.24, +0.22] 1 Logs bounds checks dashboard
➖ file_tree memory utilization -4.24 [-4.43, -4.05] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
❌ quality_gate_logs memory_usage 8/10 bounds checks dashboard
✅ docker_containers_cpu simple_check_run 10/10
✅ docker_containers_memory memory_usage 10/10
✅ docker_containers_memory simple_check_run 10/10
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http1 memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http2 memory_usage 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_300ms_latency lost_bytes 10/10
✅ file_to_blackhole_300ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

❌ Failed. Some Quality Gates were violated.

  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 8/10 replicas passed. Failed 2 which is > 0. Gate FAILED.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@alopezz alopezz force-pushed the alopez/ot-only-packages branch 9 times, most recently from 4f27dec to ae7d877 Compare June 10, 2025 12:17
truthbk
truthbk reviewed Jun 10, 2025
View reviewed changes
Copy link
Member

@truthbk truthbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, just a couple of questions...

omnibus/config/projects/otel-agent.rb
# ------------------------------------

if debian_target?
runtime_dependency "datadog-agent (= 1:#{build_version}-1)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

@alopezz alopezz force-pushed the alopez/ot-only-packages branch 9 times, most recently from eae7f7d to 459d22e Compare June 12, 2025 08:10
@alopezz alopezz force-pushed the alopez/ot-only-packages branch 9 times, most recently from 09fc97a to d028ad3 Compare June 13, 2025 08:34
@alopezz alopezz force-pushed the alopez/ot-only-packages branch from d028ad3 to af7a42f Compare June 13, 2025 09:33
@alopezz alopezz force-pushed the alopez/ot-only-packages branch 3 times, most recently from ea11450 to a9ed3a8 Compare June 13, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@truthbk truthbk truthbk left review comments

@liustanley liustanley liustanley left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
changelog/no-changelog medium review PR review might take time team/agent-delivery
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alopezz @truthbk @liustanley