Skip to content

Fix nodetreemodel not handling all map interface #37658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix nodetreemodel not handling all map interface #37658

wants to merge 1 commit into from

Conversation

hush-hush
Copy link
Member

What does this PR do?

YAML will only return map[string]interface{} and map[interface{}]interface{}. But through manual Set, other types of map can make their way in the config.

Describe how you validated your changes

Running the CI with nodetreemodel is enough

@hush-hush
Fix nodetreemodel not handling all map interface
70fc7c4 
YAML will only return map[string]interface{} and map[interface{}]interface{}.
But throught manual set other types of map can make their way in the config.
@hush-hush hush-hush requested a review from a team as a code owner June 4, 2025 15:07
@hush-hush hush-hush requested review from rahulkaukuntla and dustmop and removed request for rahulkaukuntla June 4, 2025 15:07
@github-actions github-actions bot added team/agent-configuration short review PR is simple enough to be reviewed quickly labels Jun 4, 2025
@cit-pr-commenter cit-pr-commenter
Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: ee74e861-34cf-435a-922f-1898fe0732dd

Baseline: 8df8f44
Comparison: 70fc7c4
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ uds_dogstatsd_to_api_cpu % cpu utilization +2.31 [+1.42, +3.20] 1 Logs
➖ docker_containers_cpu % cpu utilization +2.28 [-0.83, +5.39] 1 Logs
➖ quality_gate_logs % cpu utilization +1.42 [-1.41, +4.25] 1 Logs bounds checks dashboard
➖ otlp_ingest_logs memory utilization +0.61 [+0.49, +0.73] 1 Logs
➖ docker_containers_memory memory utilization +0.49 [+0.44, +0.54] 1 Logs
➖ quality_gate_idle_all_features memory utilization +0.37 [+0.31, +0.44] 1 Logs bounds checks dashboard
➖ quality_gate_idle memory utilization +0.31 [+0.25, +0.36] 1 Logs bounds checks dashboard
➖ ddot_metrics memory utilization +0.17 [+0.05, +0.28] 1 Logs
➖ file_tree memory utilization +0.13 [+0.02, +0.24] 1 Logs
➖ uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.10 [+0.05, +0.14] 1 Logs
➖ file_to_blackhole_0ms_latency_http2 egress throughput +0.10 [-0.54, +0.73] 1 Logs
➖ file_to_blackhole_0ms_latency_http1 egress throughput +0.07 [-0.59, +0.73] 1 Logs
➖ otlp_ingest_metrics memory utilization +0.04 [-0.12, +0.21] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput +0.04 [-0.56, +0.64] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput +0.00 [-0.27, +0.28] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.02, +0.03] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput -0.00 [-0.62, +0.62] 1 Logs
➖ file_to_blackhole_1000ms_latency_linear_load egress throughput -0.01 [-0.24, +0.22] 1 Logs
➖ file_to_blackhole_300ms_latency egress throughput -0.02 [-0.64, +0.60] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput -0.02 [-0.64, +0.59] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput -0.05 [-0.62, +0.51] 1 Logs
➖ tcp_syslog_to_blackhole ingress throughput -0.26 [-0.32, -0.20] 1 Logs
➖ ddot_logs memory utilization -0.87 [-1.00, -0.75] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
❌ docker_containers_memory memory_usage 0/10
✅ docker_containers_cpu simple_check_run 10/10
✅ docker_containers_memory simple_check_run 10/10
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http1 memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http2 memory_usage 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_300ms_latency lost_bytes 10/10
✅ file_to_blackhole_300ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr
Copy link
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 0ba38bc

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
✅ agent_deb_amd64 DataNotFound $${731.82}$$ < $${752.99}$$ DataNotFound $${181.35}$$ < $${187.44}$$
✅ agent_deb_amd64_fips DataNotFound $${730.12}$$ < $${751.36}$$ DataNotFound $${180.75}$$ < $${187.06}$$
✅ agent_heroku_amd64 DataNotFound $${358.52}$$ < $${369.68}$$ DataNotFound $${96.49}$$ < $${99.55}$$
✅ agent_msi DataNotFound $${959.59}$$ < $${987.01}$$ DataNotFound $${146.4}$$ < $${150.72}$$
✅ agent_rpm_amd64 DataNotFound $${731.81}$$ < $${752.98}$$ DataNotFound $${183.54}$$ < $${190.03}$$
✅ agent_rpm_amd64_fips DataNotFound $${730.1}$$ < $${751.35}$$ DataNotFound $${183.64}$$ < $${189.81}$$
✅ agent_rpm_arm64 DataNotFound $${719.21}$$ < $${739.42}$$ DataNotFound $${165.42}$$ < $${171.23}$$
✅ agent_rpm_arm64_fips DataNotFound $${717.63}$$ < $${737.91}$$ DataNotFound $${164.71}$$ < $${170.22}$$
✅ agent_suse_amd64 DataNotFound $${731.81}$$ < $${752.98}$$ DataNotFound $${183.54}$$ < $${190.03}$$
✅ agent_suse_amd64_fips DataNotFound $${730.1}$$ < $${751.35}$$ DataNotFound $${183.64}$$ < $${189.81}$$
✅ agent_suse_arm64 DataNotFound $${719.21}$$ < $${739.42}$$ DataNotFound $${165.42}$$ < $${171.23}$$
✅ agent_suse_arm64_fips DataNotFound $${717.63}$$ < $${737.91}$$ DataNotFound $${164.71}$$ < $${170.22}$$
✅ docker_agent_amd64 DataNotFound $${815.61}$$ < $${849.39}$$ DataNotFound $${277.09}$$ < $${288.34}$$
✅ docker_agent_arm64 DataNotFound $${826.46}$$ < $${858.97}$$ DataNotFound $${263.63}$$ < $${274.36}$$
✅ docker_agent_jmx_amd64 DataNotFound $${815.61}$$ < $${849.39}$$ DataNotFound $${277.09}$$ < $${288.34}$$
✅ docker_agent_jmx_arm64 DataNotFound $${826.46}$$ < $${858.97}$$ DataNotFound $${263.63}$$ < $${274.36}$$
✅ docker_agent_windows1809 DataNotFound $${815.61}$$ < $${849.39}$$ DataNotFound $${277.09}$$ < $${288.34}$$
✅ docker_agent_windows1809_core DataNotFound $${815.61}$$ < $${849.39}$$ DataNotFound $${277.09}$$ < $${288.34}$$
✅ docker_agent_windows1809_core_jmx DataNotFound $${815.61}$$ < $${849.39}$$ DataNotFound $${277.09}$$ < $${288.34}$$
✅ docker_agent_windows1809_jmx DataNotFound $${815.61}$$ < $${849.39}$$ DataNotFound $${277.09}$$ < $${288.34}$$
✅ docker_agent_windows2022 DataNotFound $${815.61}$$ < $${849.39}$$ DataNotFound $${277.09}$$ < $${288.34}$$
✅ docker_agent_windows2022_core DataNotFound $${815.61}$$ < $${849.39}$$ DataNotFound $${277.09}$$ < $${288.34}$$
✅ docker_agent_windows2022_core_jmx DataNotFound $${815.61}$$ < $${849.39}$$ DataNotFound $${277.09}$$ < $${288.34}$$
✅ docker_agent_windows2022_jmx DataNotFound $${815.61}$$ < $${849.39}$$ DataNotFound $${277.09}$$ < $${288.34}$$
✅ docker_cluster_agent_amd64 DataNotFound $${259.13}$$ < $${259.73}$$ DataNotFound $${102.86}$$ < $${103.68}$$
✅ docker_cluster_agent_arm64 DataNotFound $${273.57}$$ < $${274.24}$$ DataNotFound $${97.57}$$ < $${98.45}$$
✅ docker_cws_instrumentation_amd64 DataNotFound $${7.08}$$ < $${7.12}$$ DataNotFound $${2.95}$$ < $${3.29}$$
✅ docker_cws_instrumentation_arm64 DataNotFound $${6.69}$$ < $${6.92}$$ DataNotFound $${2.7}$$ < $${3.07}$$
✅ docker_dogstatsd_amd64 DataNotFound $${38.92}$$ < $${39.57}$$ DataNotFound $${14.95}$$ < $${15.76}$$
✅ docker_dogstatsd_arm64 DataNotFound $${37.52}$$ < $${38.2}$$ DataNotFound $${13.96}$$ < $${14.83}$$
✅ dogstatsd_deb_amd64 DataNotFound $${30.61}$$ < $${31.52}$$ DataNotFound $${8.03}$$ < $${8.97}$$
✅ dogstatsd_deb_arm64 DataNotFound $${29.16}$$ < $${30.08}$$ DataNotFound $${6.97}$$ < $${7.92}$$
✅ dogstatsd_rpm_amd64 DataNotFound $${30.61}$$ < $${31.52}$$ DataNotFound $${8.04}$$ < $${8.98}$$
✅ dogstatsd_suse_amd64 DataNotFound $${30.61}$$ < $${31.52}$$ DataNotFound $${8.04}$$ < $${8.98}$$
✅ iot_agent_deb_amd64 DataNotFound $${50.44}$$ < $${60.17}$$ DataNotFound $${12.85}$$ < $${15.82}$$
✅ iot_agent_deb_arm64 DataNotFound $${47.9}$$ < $${56.94}$$ DataNotFound $${11.14}$$ < $${13.86}$$
✅ iot_agent_deb_armhf DataNotFound $${47.48}$$ < $${56.41}$$ DataNotFound $${11.2}$$ < $${13.86}$$
✅ iot_agent_rpm_amd64 DataNotFound $${50.44}$$ < $${60.18}$$ DataNotFound $${12.87}$$ < $${15.84}$$
✅ iot_agent_rpm_arm64 DataNotFound $${47.9}$$ < $${56.94}$$ DataNotFound $${11.16}$$ < $${13.76}$$
✅ iot_agent_suse_amd64 DataNotFound $${50.44}$$ < $${60.18}$$ DataNotFound $${12.87}$$ < $${15.84}$$

@hush-hush hush-hush added changelog/no-changelog qa/skip-qa qa/done QA done before merge and regressions are covered by tests and removed qa/skip-qa labels Jun 5, 2025
dustmop
dustmop reviewed Jun 9, 2025
View reviewed changes
pkg/config/structure/unmarshal_test.go
checkInt()

mockConfig.Set("test", map[interface{}]interface{}{"a": 1, "b": 2}, model.SourceAgentRuntime)
checkInt()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we get a test case for map[int]string to validate that it works correctly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustmop dustmop dustmop left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
changelog/no-changelog qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/agent-configuration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hush-hush @dustmop