Skip to content

background experiment hooks for Agent package on Windows #37667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Jun 11, 2025
Merged

background experiment hooks for Agent package on Windows #37667

merged 18 commits into from
Jun 11, 2025

Conversation

clarkb7
Copy link
Contributor

@clarkb7 clarkb7 commented Jun 4, 2025 •
edited
Loading

What does this PR do?

Fix issue that prevents fleet daemon from reporting task completed state to the backend during experiments, causing an increase in experiment times.

Moves work for Agent package hooks on Windows into a background process. This applies to both update and config experiments. And must apply to any future hooks that restart the daemon.
Adds new package-command subcommand to provide an entry point for the new background processes.
process chain is now: daemon -> start-experiment -> hook postStartExperiment -> (detached, no wait) package-command datadog-agent postStartExperimentBackground
After the *Background process is created, the other processes will exit, unblocking the daemon so it can update task state and also properly handle a stop signal from the *Background process.

Motivation

https://datadoghq.atlassian.net/browse/WINA-1542
Allow package subcommands to exit and return control to daemon, so it can mark task status as DONE (which triggers the backend to move to the next step) and then stop cleanly (without hitting fx timeout).

Describe how you validated your changes

Updates existing E2E tests

  • checks result of daemon experiment commands, which previously returned EOF when the service was killed. These should now return successfully.

Working on future PR to update task state during local API commands and not just remote commands. Then we can assert the task state is DONE in E2E tests, too.

Adding qa/rc-required label so we can test remotely updating to release candidates. Working on getting a dev build on staging, too.

  • The update should succeed in less than 10 minutes and there shouldn't be a timeout error from the HostUpdateLoop in the backend

Possible Drawbacks / Trade-offs

Additional Notes

Remote updates work in previous versions despite the backend waiting on the task because after the backend hits the 10 minute timeout it rechecks the experiment state, finds it correct, and moved to the next phase. After this change we should see a decrease in overall experiment times for Windows hosts.

After a subprocess terminates, Go's os/exec waits for standard IO handles to complete and these handles can also be inherited by child processes who will hold them open, thereby blocking the parent tree. So we must be careful to detach standard IO from our background processes.

Since update experiments are executed by the experiment's datadog-installer.exe, this change will take effect for any remote updates TO 7.68 or later, (e.g. 7.65 -> 7.68), and will not be available for downgrades to a version lower than 7.68.

Creates new package-command subcommand interface rather than using the existing hooks subcommand interface in order to hooks as a clean interface between the installer and the packages.

@clarkb7 clarkb7 force-pushed the branden.clark/background-hooks branch from 32fb897 to 61861f5 Compare June 4, 2025 19:34
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jun 4, 2025 •
edited
Loading

Gitlab CI Configuration Changes

Modified Jobs

new-e2e-installer-windows 
  new-e2e-installer-windows:
    after_script:
    - $CI_PROJECT_DIR/tools/ci/junit_upload.sh "junit-${CI_JOB_ID}.tgz" "$E2E_RESULT_JSON"
    artifacts:
      expire_in: 2 weeks
      paths:
      - $E2E_OUTPUT_DIR
      - $E2E_RESULT_JSON
      - junit-*.tgz
      reports:
        annotations:
        - $EXTERNAL_LINKS_PATH
      when: always
    before_script:
    - CURRENT_AGENT_VERSION=$(dda inv agent.version) || exit $?; export CURRENT_AGENT_VERSION
    - CURRENT_AGENT_VERSION_PACKAGE=$(dda inv agent.version --url-safe)-1 || exit $?;
      export CURRENT_AGENT_VERSION_PACKAGE
    - mkdir -p $GOPATH/pkg/mod/cache && tar xJf modcache_e2e.tar.xz -C $GOPATH/pkg/mod/cache
      || exit 101
    - rm -f modcache_e2e.tar.xz
    - mkdir -p ~/.aws
    - "if [ -n \"$E2E_USE_AWS_PROFILE\" ]; then\n  echo Using agent-qa-ci aws profile\n\
      \  $CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_QA_E2E profile >> ~/.aws/config\
      \ || exit $?\n  # Now all `aws` commands target the agent-qa profile\n  export\
      \ AWS_PROFILE=agent-qa-ci\nelse\n  # Assume role to fetch only once credentials\
      \ and avoid rate limits\n  echo Assuming ddbuild-agent-ci role\n  roleoutput=\"\
      $(aws sts assume-role --role-arn arn:aws:iam::669783387624:role/ddbuild-agent-ci\
      \ --external-id ddbuild-agent-ci --role-session-name RoleSession)\"\n  export\
      \ AWS_ACCESS_KEY_ID=\"$(echo \"$roleoutput\" | jq -r '.Credentials.AccessKeyId')\"\
      \n  export AWS_SECRET_ACCESS_KEY=\"$(echo \"$roleoutput\" | jq -r '.Credentials.SecretAccessKey')\"\
      \n  export AWS_SESSION_TOKEN=\"$(echo \"$roleoutput\" | jq -r '.Credentials.SessionToken')\"\
      \nfi\n"
    - $CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_QA_E2E ssh_public_key_rsa > $E2E_AWS_PUBLIC_KEY_PATH
      || exit $?
    - touch $E2E_AWS_PRIVATE_KEY_PATH && chmod 600 $E2E_AWS_PRIVATE_KEY_PATH && $CI_PROJECT_DIR/tools/ci/fetch_secret.sh
      $AGENT_QA_E2E ssh_key_rsa > $E2E_AWS_PRIVATE_KEY_PATH || exit $?
    - $CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_QA_E2E ssh_public_key_rsa > $E2E_AZURE_PUBLIC_KEY_PATH
      || exit $?
    - touch $E2E_AZURE_PRIVATE_KEY_PATH && chmod 600 $E2E_AZURE_PRIVATE_KEY_PATH &&
      $CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_QA_E2E ssh_key_rsa > $E2E_AZURE_PRIVATE_KEY_PATH
      || exit $?
    - $CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_QA_E2E ssh_public_key_rsa > $E2E_GCP_PUBLIC_KEY_PATH
      || exit $?
    - touch $E2E_GCP_PRIVATE_KEY_PATH && chmod 600 $E2E_GCP_PRIVATE_KEY_PATH && $CI_PROJECT_DIR/tools/ci/fetch_secret.sh
      $AGENT_QA_E2E ssh_key_rsa > $E2E_GCP_PRIVATE_KEY_PATH || exit $?
    - pulumi login "s3://dd-pulumi-state?region=us-east-1&awssdk=v2&profile=$AWS_PROFILE"
    - ARM_CLIENT_ID=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $E2E_AZURE client_id)
      || exit $?; export ARM_CLIENT_ID
    - ARM_CLIENT_SECRET=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $E2E_AZURE token)
      || exit $?; export ARM_CLIENT_SECRET
    - ARM_TENANT_ID=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $E2E_AZURE tenant_id)
      || exit $?; export ARM_TENANT_ID
    - ARM_SUBSCRIPTION_ID=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $E2E_AZURE subscription_id)
      || exit $?; export ARM_SUBSCRIPTION_ID
    - $CI_PROJECT_DIR/tools/ci/fetch_secret.sh $E2E_GCP credentials_json > ~/gcp-credentials.json
      || exit $?
    - export GOOGLE_APPLICATION_CREDENTIALS=~/gcp-credentials.json
    - dda inv -- -e gitlab.generate-ci-visibility-links --output=$EXTERNAL_LINKS_PATH
    image: registry.ddbuild.io/ci/test-infra-definitions/runner$TEST_INFRA_DEFINITIONS_BUILDIMAGES_SUFFIX:$TEST_INFRA_DEFINITIONS_BUILDIMAGES
    needs:
    - go_e2e_deps
    - deploy_windows_testing-a7
    - deploy_installer_oci
    - deploy_agent_oci
    - qa_installer_script_windows
    parallel:
      matrix:
      - EXTRA_PARAMS: --run "TestAgentUpgrades$/TestUpgradeMSI$"
      - EXTRA_PARAMS: --run "TestAgentUpgrades$/TestUpgradeAgentPackage$"
      - EXTRA_PARAMS: --run "TestAgentUpgrades$/TestUpgradeAgentPackageWithAltDir$"
      - EXTRA_PARAMS: --run "TestAgentUpgrades$/TestUpgradeAgentPackageAfterRollback$"
      - EXTRA_PARAMS: --run "TestAgentUpgrades$/TestDowngradeAgentPackage$"
      - EXTRA_PARAMS: --run "TestAgentUpgrades$/TestStopExperiment$"
      - EXTRA_PARAMS: --run "TestAgentUpgrades$/TestExperimentForNonExistingPackageFails$"
      - EXTRA_PARAMS: --run "TestAgentUpgrades$/TestExperimentCurrentVersionFails$"
      - EXTRA_PARAMS: --run "TestAgentUpgrades$/TestStopWithoutExperiment$"
      - EXTRA_PARAMS: --run "TestAgentUpgrades$/TestRevertsExperimentWhenServiceDies$"
      - EXTRA_PARAMS: --run "TestAgentUpgrades$/TestRevertsExperimentWhenTimeout$"
      - EXTRA_PARAMS: --run "TestAgentUpgrades$/TestExperimentMSIRollbackMaintainsCustomUserAndAltDir$"
      - EXTRA_PARAMS: --run "TestAgentUpgrades$/TestRevertsExperimentWhenServiceDiesMaintainsCustomUserAndAltDir$"
      - EXTRA_PARAMS: --run "TestAgentUpgrades$/TestRunAgentMSIAfterExperiment$"
      - EXTRA_PARAMS: --run "TestAgentUpgrades$/TestUpgradeWithAgentUser$"
      - EXTRA_PARAMS: --run "TestAgentUpgradesOnDC$/TestUpgradeMSI$"
      - EXTRA_PARAMS: --run "TestAgentUpgradesOnDC$/TestUpgradeAgentPackage$"
      - EXTRA_PARAMS: --run "TestAgentUpgradesOnDCWithGMSA$/TestUpgradeMSI$"
      - EXTRA_PARAMS: --run "TestAgentUpgradesOnDCWithGMSA$/TestUpgradeAgentPackage$"
      - EXTRA_PARAMS: --run "TestAgentUpgradesFromGA$/TestUpgradeAgentPackage$"
      - EXTRA_PARAMS: --run "TestAgentUpgradesFromGA$/TestUpgradeAgentPackageAfterRollback$"
      - EXTRA_PARAMS: --run "TestAgentConfig$/TestConfigUpgradeSuccessful$"
      - EXTRA_PARAMS: --run "TestAgentConfig$/TestConfigUpgradeFailure$"
      - EXTRA_PARAMS: --run "TestAgentConfig$/TestConfigUpgradeNewAgents$"
+     - EXTRA_PARAMS: --run "TestAgentConfig$/TestRevertsConfigExperimentWhenServiceDies$"
+     - EXTRA_PARAMS: --run "TestAgentConfig$/TestRevertsConfigExperimentWhenTimeout$"
      - EXTRA_PARAMS: --run "TestInstallExe$/TestInstallAgentPackage$"
      - EXTRA_PARAMS: --run "TestInstallScript$/TestInstallAgentPackage$"
      - EXTRA_PARAMS: --run "TestInstallScript$/TestInstallFromOldInstaller$"
      - EXTRA_PARAMS: --run "TestInstallScript$/TestFailedUnsupportedVersion$"
      - EXTRA_PARAMS: --run "TestInstallScriptWithAgentUser$"
      - EXTRA_PARAMS: --run "TestInstallScriptWithAgentUserOnDC$"
      - EXTRA_PARAMS: --run "TestInstaller$"
      - EXTRA_PARAMS: --run "TestDotnetLibraryInstalls$"
      - EXTRA_PARAMS: --run "TestDotnetLibraryInstallsWithoutIIS/TestInstallDotnetLibraryPackageWithoutIIS$"
      - EXTRA_PARAMS: --run "TestDotnetLibraryInstallsWithoutIIS/TestMSIInstallDotnetLibraryFailsWithoutIIS$"
      - EXTRA_PARAMS: --run "TestAgentMSIInstallsDotnetLibrary/TestInstallFromMSI$"
      - EXTRA_PARAMS: --run "TestAgentMSIInstallsDotnetLibrary/TestMSIThenRemoteUpgrade$"
      - EXTRA_PARAMS: --run "TestAgentMSIInstallsDotnetLibrary/TestUpgradeWithMSI$"
      - EXTRA_PARAMS: --run "TestAgentMSIInstallsDotnetLibrary/TestMSIRollbackRemovesLibrary$"
      - EXTRA_PARAMS: --run "TestAgentMSIInstallsDotnetLibrary/TestMSISkipRollbackIfInstalled$"
      - EXTRA_PARAMS: --run "TestAgentMSIInstallsDotnetLibrary/TestUninstallKeepsLibrary$"
    retry: 1
    rules:
    - if: $RUN_E2E_TESTS == "off"
      when: never
    - if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
      when: never
    - if: $RUN_E2E_TESTS == "on"
      when: on_success
    - if: $CI_COMMIT_BRANCH == "main"
      when: on_success
    - if: $CI_COMMIT_BRANCH =~ /^[0-9]+\.[0-9]+\.x$/
      when: on_success
    - if: $CI_COMMIT_TAG =~ /^[0-9]+\.[0-9]+\.[0-9]+-rc\.[0-9]+$/
      when: on_success
    - changes:
        compare_to: $COMPARE_TO_BRANCH
        paths:
        - .gitlab/e2e/e2e.yml
        - test/new-e2e/pkg/**/*
        - test/new-e2e/go.mod
        - flakes.yaml
        - release.json
    - changes:
        compare_to: $COMPARE_TO_BRANCH
        paths:
        - .gitlab/**/*
        - omnibus/config/**/*
        - pkg/fleet/**/*
        - cmd/installer/**/*
        - test/new-e2e/tests/installer/**/*
        - tasks/installer.py
      when: on_success
    - if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
      when: never
    - allow_failure: true
      when: manual
    script:
    - dda inv -- -e new-e2e-tests.run --local-package $CI_PROJECT_DIR/$OMNIBUS_BASE_DIR
      --result-json $E2E_RESULT_JSON --targets $TARGETS -c ddagent:imagePullRegistry=669783387624.dkr.ecr.us-east-1.amazonaws.com
      -c ddagent:imagePullUsername=AWS -c ddagent:imagePullPassword=$(aws ecr get-login-password)
      --junit-tar junit-${CI_JOB_ID}.tgz ${EXTRA_PARAMS} --test-washer --logs-folder=$E2E_OUTPUT_DIR/logs
      --logs-post-processing --logs-post-processing-test-depth=$E2E_LOGS_PROCESSING_TEST_DEPTH
    stage: e2e
    tags:
    - arch:amd64
    variables:
      E2E_AWS_PRIVATE_KEY_PATH: /tmp/agent-qa-aws-ssh-key
      E2E_AWS_PUBLIC_KEY_PATH: /tmp/agent-qa-aws-ssh-key.pub
      E2E_AZURE_PRIVATE_KEY_PATH: /tmp/agent-qa-azure-ssh-key
      E2E_AZURE_PUBLIC_KEY_PATH: /tmp/agent-qa-azure-ssh-key.pub
      E2E_COMMIT_SHA: $CI_COMMIT_SHORT_SHA
      E2E_GCP_PRIVATE_KEY_PATH: /tmp/agent-qa-gcp-ssh-key
      E2E_GCP_PUBLIC_KEY_PATH: /tmp/agent-qa-gcp-ssh-key.pub
      E2E_KEY_PAIR_NAME: datadog-agent-ci-rsa
      E2E_LOGS_PROCESSING_TEST_DEPTH: 1
      E2E_OUTPUT_DIR: $CI_PROJECT_DIR/e2e-output
      E2E_PIPELINE_ID: $CI_PIPELINE_ID
      E2E_RESULT_JSON: $CI_PROJECT_DIR/e2e_test_output.json
      E2E_USE_AWS_PROFILE: 'false'
      EXTERNAL_LINKS_PATH: external_links_$CI_JOB_ID.json
      FLAKY_PATTERNS_CONFIG: $CI_PROJECT_DIR/flaky-patterns-runtime.yaml
      FLEET_INSTALL_METHOD: windows
      KUBERNETES_CPU_REQUEST: 6
      KUBERNETES_MEMORY_LIMIT: 16Gi
      KUBERNETES_MEMORY_REQUEST: 12Gi
      SHOULD_RUN_IN_FLAKES_FINDER: 'true'
      TARGETS: ./tests/installer/windows
      TEAM: fleet

Changes Summary

Removed Modified Added Renamed
0 1 0 0

ℹ️ Diff available in the job log.

@cit-pr-commenter cit-pr-commenter
Copy link

cit-pr-commenter bot commented Jun 4, 2025 •
edited
Loading

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 45e72e41-2d6b-4c30-b67e-5e68aa90ea0a

Baseline: 4ecfdda
Comparison: 3c7ac18
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ quality_gate_idle memory utilization +0.56 [+0.51, +0.62] 1 Logs bounds checks dashboard
➖ uds_dogstatsd_to_api_cpu % cpu utilization +0.53 [-0.33, +1.40] 1 Logs
➖ otlp_ingest_metrics memory utilization +0.38 [+0.20, +0.56] 1 Logs
➖ ddot_logs memory utilization +0.37 [+0.23, +0.51] 1 Logs
➖ tcp_syslog_to_blackhole ingress throughput +0.16 [+0.10, +0.22] 1 Logs
➖ otlp_ingest_logs memory utilization +0.10 [-0.03, +0.23] 1 Logs
➖ quality_gate_idle_all_features memory utilization +0.08 [-0.00, +0.16] 1 Logs bounds checks dashboard
➖ file_to_blackhole_300ms_latency egress throughput +0.07 [-0.54, +0.68] 1 Logs
➖ ddot_metrics memory utilization +0.06 [-0.06, +0.17] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput +0.05 [-0.51, +0.62] 1 Logs
➖ file_to_blackhole_0ms_latency_http1 egress throughput +0.04 [-0.54, +0.62] 1 Logs
➖ file_to_blackhole_0ms_latency_http2 egress throughput +0.02 [-0.54, +0.59] 1 Logs
➖ file_to_blackhole_1000ms_latency_linear_load egress throughput +0.02 [-0.22, +0.25] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput +0.01 [-0.55, +0.57] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.02] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput -0.00 [-0.27, +0.26] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput -0.01 [-0.61, +0.59] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput -0.05 [-0.64, +0.54] 1 Logs
➖ docker_containers_memory memory utilization -1.06 [-1.13, -0.98] 1 Logs
➖ uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -1.26 [-1.31, -1.21] 1 Logs
➖ docker_containers_cpu % cpu utilization -1.48 [-4.45, +1.48] 1 Logs
➖ file_tree memory utilization -1.57 [-1.72, -1.41] 1 Logs
➖ quality_gate_logs % cpu utilization -3.19 [-5.87, -0.50] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
✅ docker_containers_cpu simple_check_run 10/10
✅ docker_containers_memory memory_usage 10/10
✅ docker_containers_memory simple_check_run 10/10
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http1 memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http2 memory_usage 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_300ms_latency lost_bytes 10/10
✅ file_to_blackhole_300ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jun 4, 2025 •
edited
Loading

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 4ecfdda

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
✅ agent_deb_amd64 DataNotFound $${696.19}$$ < $${752.99}$$ DataNotFound $${176.02}$$ < $${187.44}$$
✅ agent_deb_amd64_fips DataNotFound $${694.42}$$ < $${751.36}$$ DataNotFound $${175.5}$$ < $${187.06}$$
✅ agent_heroku_amd64 DataNotFound $${358.58}$$ < $${369.68}$$ DataNotFound $${96.49}$$ < $${99.55}$$
✅ agent_msi DataNotFound $${959.89}$$ < $${987.01}$$ DataNotFound $${146.44}$$ < $${150.72}$$
✅ agent_rpm_amd64 DataNotFound $${696.18}$$ < $${752.98}$$ DataNotFound $${177.57}$$ < $${190.03}$$
✅ agent_rpm_amd64_fips DataNotFound $${694.41}$$ < $${751.35}$$ DataNotFound $${177.44}$$ < $${189.81}$$
✅ agent_rpm_arm64 DataNotFound $${686.13}$$ < $${739.42}$$ DataNotFound $${161.06}$$ < $${171.23}$$
✅ agent_rpm_arm64_fips DataNotFound $${684.48}$$ < $${737.91}$$ DataNotFound $${160.11}$$ < $${170.22}$$
✅ agent_suse_amd64 DataNotFound $${696.18}$$ < $${752.98}$$ DataNotFound $${177.57}$$ < $${190.03}$$
✅ agent_suse_amd64_fips DataNotFound $${694.41}$$ < $${751.35}$$ DataNotFound $${177.44}$$ < $${189.81}$$
✅ agent_suse_arm64 DataNotFound $${686.13}$$ < $${739.42}$$ DataNotFound $${161.06}$$ < $${171.23}$$
✅ agent_suse_arm64_fips DataNotFound $${684.48}$$ < $${737.91}$$ DataNotFound $${160.11}$$ < $${170.22}$$
✅ docker_agent_amd64 DataNotFound $${779.98}$$ < $${849.39}$$ DataNotFound $${268.63}$$ < $${288.34}$$
✅ docker_agent_arm64 DataNotFound $${793.38}$$ < $${858.97}$$ DataNotFound $${255.99}$$ < $${274.36}$$
✅ docker_agent_jmx_amd64 DataNotFound $${971.18}$$ < $${1040.59}$$ DataNotFound $${337.58}$$ < $${357.3}$$
✅ docker_agent_jmx_arm64 DataNotFound $${973.17}$$ < $${1038.77}$$ DataNotFound $${320.96}$$ < $${339.32}$$
✅ docker_agent_windows1809 DataNotFound $${1487.98}$$ < $${1557.19}$$ DataNotFound $${488.22}$$ < $${507.33}$$
✅ docker_agent_windows1809_core DataNotFound $${6217.94}$$ < $${6287.46}$$ DataNotFound $${2048.0}$$ < $${2067.76}$$
✅ docker_agent_windows1809_core_jmx DataNotFound $${6361.84}$$ < $${6409.04}$$ DataNotFound $${2048.0}$$ < $${2067.76}$$
✅ docker_agent_windows1809_jmx DataNotFound $${1609.61}$$ < $${1679.14}$$ DataNotFound $${530.52}$$ < $${550.27}$$
✅ docker_agent_windows2022 DataNotFound $${1507.44}$$ < $${1576.85}$$ DataNotFound $${501.0}$$ < $${520.76}$$
✅ docker_agent_windows2022_core DataNotFound $${6191.25}$$ < $${6260.53}$$ DataNotFound $${2048.0}$$ < $${2067.76}$$
✅ docker_agent_windows2022_core_jmx DataNotFound $${6312.94}$$ < $${6382.17}$$ DataNotFound $${2048.0}$$ < $${2067.76}$$
✅ docker_agent_windows2022_jmx DataNotFound $${1628.86}$$ < $${1698.2}$$ DataNotFound $${543.28}$$ < $${562.99}$$
✅ docker_cluster_agent_amd64 DataNotFound $${259.22}$$ < $${259.73}$$ DataNotFound $${102.9}$$ < $${103.68}$$
✅ docker_cluster_agent_arm64 DataNotFound $${273.65}$$ < $${274.24}$$ DataNotFound $${97.58}$$ < $${98.45}$$
✅ docker_cws_instrumentation_amd64 DataNotFound $${7.08}$$ < $${7.12}$$ DataNotFound $${2.95}$$ < $${3.29}$$
✅ docker_cws_instrumentation_arm64 DataNotFound $${6.69}$$ < $${6.92}$$ DataNotFound $${2.7}$$ < $${3.07}$$
✅ docker_dogstatsd_amd64 DataNotFound $${38.93}$$ < $${39.57}$$ DataNotFound $${14.95}$$ < $${15.76}$$
✅ docker_dogstatsd_arm64 DataNotFound $${37.52}$$ < $${38.2}$$ DataNotFound $${13.96}$$ < $${14.83}$$
✅ dogstatsd_deb_amd64 DataNotFound $${30.61}$$ < $${31.52}$$ DataNotFound $${8.03}$$ < $${8.97}$$
✅ dogstatsd_deb_arm64 DataNotFound $${29.16}$$ < $${30.08}$$ DataNotFound $${6.97}$$ < $${7.92}$$
✅ dogstatsd_rpm_amd64 DataNotFound $${30.61}$$ < $${31.52}$$ DataNotFound $${8.04}$$ < $${8.98}$$
✅ dogstatsd_suse_amd64 DataNotFound $${30.61}$$ < $${31.52}$$ DataNotFound $${8.04}$$ < $${8.98}$$
✅ iot_agent_deb_amd64 DataNotFound $${50.49}$$ < $${60.17}$$ DataNotFound $${12.85}$$ < $${15.82}$$
✅ iot_agent_deb_arm64 DataNotFound $${47.94}$$ < $${56.94}$$ DataNotFound $${11.14}$$ < $${13.86}$$
✅ iot_agent_deb_armhf DataNotFound $${47.52}$$ < $${56.41}$$ DataNotFound $${11.2}$$ < $${13.86}$$
✅ iot_agent_rpm_amd64 DataNotFound $${50.49}$$ < $${60.18}$$ DataNotFound $${12.87}$$ < $${15.84}$$
✅ iot_agent_rpm_arm64 DataNotFound $${47.94}$$ < $${56.94}$$ DataNotFound $${11.16}$$ < $${13.76}$$
✅ iot_agent_suse_amd64 DataNotFound $${50.49}$$ < $${60.18}$$ DataNotFound $${12.87}$$ < $${15.84}$$

@clarkb7 clarkb7 force-pushed the branden.clark/fleet-config-rollback branch from 475d64f to 08cfb8a Compare June 5, 2025 22:21
@clarkb7 clarkb7 mentioned this pull request Jun 5, 2025
Merged
@clarkb7 clarkb7 force-pushed the branden.clark/background-hooks branch from 61861f5 to 2a5a9df Compare June 5, 2025 23:30
@clarkb7
Copy link
Contributor Author

clarkb7 commented Jun 5, 2025

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable DEPLOY_AGENT=true --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on

@dd-devflow
Copy link

dd-devflow bot commented Jun 5, 2025

View all feedbacks in Devflow UI.

2025-06-05 23:43:28 UTC ℹ️ Start processing command /trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable DEPLOY_AGENT=true --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on
If you need support, contact us on Slack #devflow!

2025-06-05 23:46:31 UTC 🚨 Devflow

Post "https://gitlab.ddbuild.io/api/v4/projects/DataDog%2Fdatadog-agent/pipeline": net/http: request canceled (Client.Timeout exceeded while awaiting headers)

Details 
child workflow execution error (type: devflow.Devflow_TriggerCiFromPr, workflowID: 405e58a6-672c-46ef-8a8c-1cf97427f5ec_26, runID: 9093c869-5da5-4c9d-b7c2-8eb9411603c4, initiatedEventID: 26, startedEventID: 27): child workflow execution error (type: devflow.Devflow_TriggerCi, workflowID: 9093c869-5da5-4c9d-b7c2-8eb9411603c4_14, runID: 02ef8045-d2dc-449c-a72b-11e337f64c35, initiatedEventID: 14, startedEventID: 15): activity error (type: gitlab.GitlabService_CreatePipeline, scheduledEventID: 26, startedEventID: 27, identity: ): activity ScheduleToClose timeout (type: ScheduleToClose): Post "https://gitlab.ddbuild.io/api/v4/projects/DataDog%2Fdatadog-agent/pipeline": net/http: request canceled (Client.Timeout exceeded while awaiting headers) (type: Error, retryable: true): net/http: request canceled (Client.Timeout exceeded while awaiting headers) (type: timeoutError, retryable: true)

If you need support, contact us on Slack #devflow with those details!

@clarkb7
Copy link
Contributor Author

clarkb7 commented Jun 6, 2025

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable DEPLOY_AGENT=true --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on

@dd-devflow
Copy link

dd-devflow bot commented Jun 6, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-06-06 00:09:41 UTC ℹ️ Start processing command /trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable DEPLOY_AGENT=true --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on

2025-06-06 00:10:39 UTC ℹ️ Gitlab pipeline started

Started pipeline #67137912

@clarkb7
Copy link
Contributor Author

clarkb7 commented Jun 10, 2025

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable DEPLOY_AGENT=true --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on

@dd-devflow
Copy link

dd-devflow bot commented Jun 10, 2025

View all feedbacks in Devflow UI.

2025-06-10 17:33:58 UTC ℹ️ Start processing command /trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable DEPLOY_AGENT=true --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on
If you need support, contact us on Slack #devflow!

2025-06-10 17:37:01 UTC 🚨 Devflow

Post "https://gitlab.ddbuild.io/api/v4/projects/DataDog%2Fdatadog-agent/pipeline": net/http: request canceled (Client.Timeout exceeded while awaiting headers)

Details 
child workflow execution error (type: devflow.Devflow_TriggerCiFromPr, workflowID: 2f5869c4-f507-4f0c-b244-9a1d408d3750_26, runID: 559eb699-20d4-46e3-8d89-a362ea2447a7, initiatedEventID: 26, startedEventID: 27): child workflow execution error (type: devflow.Devflow_TriggerCi, workflowID: 559eb699-20d4-46e3-8d89-a362ea2447a7_14, runID: 57139bd3-f2ef-48e2-8bc5-633e0ad4d40e, initiatedEventID: 14, startedEventID: 15): activity error (type: gitlab.GitlabService_CreatePipeline, scheduledEventID: 26, startedEventID: 27, identity: ): activity ScheduleToClose timeout (type: ScheduleToClose): Post "https://gitlab.ddbuild.io/api/v4/projects/DataDog%2Fdatadog-agent/pipeline": net/http: request canceled (Client.Timeout exceeded while awaiting headers) (type: Error, retryable: true): net/http: request canceled (Client.Timeout exceeded while awaiting headers) (type: timeoutError, retryable: true)

If you need support, contact us on Slack #devflow with those details!

Base automatically changed from branden.clark/fleet-config-rollback to main June 10, 2025 18:53
arbll
arbll reviewed Jun 10, 2025
View reviewed changes
arbll
arbll reviewed Jun 10, 2025
View reviewed changes
pkg/fleet/installer/packages/packages.go
// For example, the Agent Windows package hooks must start some background worker processes.
//
// The content of the command string is entirely defined by the individual package. Do NOT include
// private information in the command string, use environment variables instead.
Copy link
Member

@arbll arbll Jun 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I think this will likely end up being specialised for the datadog windows agent scripts, so I would probably not make generic tooling for now and only do that if we end up having other usecase. I assume you did that for .net but unfortunately the needs are different

@clarkb7 clarkb7 force-pushed the branden.clark/background-hooks branch from f697c7b to 3c7ac18 Compare June 10, 2025 19:31
@github-actions github-actions bot added team/windows-agent long review PR is complex, plan time to review it labels Jun 10, 2025
@clarkb7 clarkb7 marked this pull request as ready for review June 10, 2025 23:17
@clarkb7 clarkb7 requested review from a team as code owners June 10, 2025 23:17
@clarkb7 clarkb7 added qa/rc-required Only for a PR that requires validation on the Release Candidate ask-review Ask required teams to review this PR labels Jun 10, 2025
@clarkb7
Copy link
Contributor Author

clarkb7 commented Jun 11, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jun 11, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-06-11 18:40:22 UTC ℹ️ Start processing command /merge

2025-06-11 18:40:28 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 52m (p90).

2025-06-11 19:20:29 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 3376e28 into main Jun 11, 2025
313 of 314 checks passed
@dd-mergequeue dd-mergequeue bot deleted the branden.clark/background-hooks branch June 11, 2025 19:20
@github-actions github-actions bot added this to the 7.68.0 milestone Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arbll arbll arbll left review comments

@rtrieu rtrieu rtrieu approved these changes

@jack0x2 jack0x2 jack0x2 approved these changes

Assignees
No one assigned
Labels
ask-review Ask required teams to review this PR long review PR is complex, plan time to review it qa/rc-required Only for a PR that requires validation on the Release Candidate team/windows-agent
Projects
None yet
Milestone
7.68.0
Development

Successfully merging this pull request may close these issues.
4 participants
@clarkb7 @arbll @rtrieu @jack0x2