CXP-2267 [agent] feat: add language data collection #37668

gengnamstyle · 2025-06-04T19:33:50Z

What does this PR do?

add's language collection via languagedetector to replicate functionality from process language collector
- uses fx to get config and checks if language_detection.enabled is true
uses fx to inject system probe config (process language collector utilizes the non-component version, but we want to move towards componentization as part of the component framework effort)

Motivation

we already have a process language collector that we want to merge into this new collector as part of the process + service discovery consolidation effort, by duplicating the functionality, we can move forward with eventually removing the process language collector
service discovery and process collection have duplicate data collected and we want to consolidate this to reduce resource usage for customers RFC: https://datadoghq.atlassian.net/wiki/spaces/cxg/pages/5013111768/RFC+Processes+and+Service+Discovery+Agent+Consolidation

Describe how you validated your changes

unit tests
- unit tests do not test privileged language collection (for go). if wanted I can include them in this pr

Possible Drawbacks / Trade-offs

Additional Notes

cit-pr-commenter · 2025-06-04T20:32:01Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 3c3313ad-eb98-4eb6-bf50-d7f906e8ad32

Baseline: 44790aa
Comparison: 6a6b4e3
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+2.59	[-0.18, +5.35]	1	Logs bounds checks dashboard
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.88	[+0.03, +1.73]	1	Logs
➖	ddot_logs	memory utilization	+0.49	[+0.35, +0.63]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	+0.47	[+0.43, +0.51]	1	Logs
➖	file_tree	memory utilization	+0.41	[+0.25, +0.57]	1	Logs
➖	otlp_ingest_metrics	memory utilization	+0.34	[+0.17, +0.50]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.07	[-0.54, +0.68]	1	Logs
➖	otlp_ingest_logs	memory utilization	+0.03	[-0.10, +0.15]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.27, +0.27]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.01, +0.01]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.01	[-0.63, +0.61]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	-0.01	[-0.61, +0.59]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.01	[-0.62, +0.59]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	-0.02	[-0.26, +0.22]	1	Logs
➖	docker_containers_cpu	% cpu utilization	-0.02	[-3.08, +3.04]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	-0.05	[-0.60, +0.51]	1	Logs
➖	ddot_metrics	memory utilization	-0.05	[-0.17, +0.07]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	-0.05	[-0.68, +0.58]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.16	[-0.79, +0.48]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	-0.70	[-0.84, -0.55]	1	Logs bounds checks dashboard
➖	docker_containers_memory	memory utilization	-0.83	[-0.89, -0.78]	1	Logs
➖	quality_gate_idle	memory utilization	-1.10	[-1.17, -1.04]	1	Logs bounds checks dashboard
➖	tcp_syslog_to_blackhole	ingress throughput	-1.40	[-1.47, -1.33]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	docker_containers_cpu	simple_check_run	10/10
✅	docker_containers_memory	memory_usage	10/10
✅	docker_containers_memory	simple_check_run	10/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

agent-platform-auto-pr · 2025-06-04T21:22:02Z

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 44790aa

Successful checks

Info

	Quality gate	Delta	On disk size (MiB)	Delta	On wire size (MiB)
✅	agent_deb_amd64	$${+0}$$	$${696.04}$$ < $${752.99}$$	$${-0.03}$$	$${176.0}$$ < $${187.44}$$
✅	agent_deb_amd64_fips	$${+0}$$	$${694.26}$$ < $${751.36}$$	$${-0.01}$$	$${175.47}$$ < $${187.06}$$
✅	agent_heroku_amd64	$${+0}$$	$${358.56}$$ < $${369.68}$$	$${-0}$$	$${96.5}$$ < $${99.55}$$
✅	agent_msi	$${0}$$	$${959.85}$$ < $${987.01}$$	$${-0.01}$$	$${146.45}$$ < $${150.72}$$
✅	agent_rpm_amd64	$${+0}$$	$${696.03}$$ < $${752.98}$$	$${+0.01}$$	$${177.55}$$ < $${190.03}$$
✅	agent_rpm_amd64_fips	$${+0}$$	$${694.25}$$ < $${751.35}$$	$${+0.01}$$	$${177.43}$$ < $${189.81}$$
✅	agent_rpm_arm64	$${+0}$$	$${685.98}$$ < $${739.42}$$	$${+0.01}$$	$${161.02}$$ < $${171.23}$$
✅	agent_rpm_arm64_fips	$${+0}$$	$${684.33}$$ < $${737.91}$$	$${-0.01}$$	$${160.08}$$ < $${170.22}$$
✅	agent_suse_amd64	$${+0}$$	$${696.03}$$ < $${752.98}$$	$${+0.01}$$	$${177.55}$$ < $${190.03}$$
✅	agent_suse_amd64_fips	$${+0}$$	$${694.25}$$ < $${751.35}$$	$${+0.01}$$	$${177.43}$$ < $${189.81}$$
✅	agent_suse_arm64	$${+0}$$	$${685.98}$$ < $${739.42}$$	$${+0.01}$$	$${161.02}$$ < $${171.23}$$
✅	agent_suse_arm64_fips	$${+0}$$	$${684.33}$$ < $${737.91}$$	$${-0.01}$$	$${160.08}$$ < $${170.22}$$
✅	docker_agent_amd64	$${+0}$$	$${779.82}$$ < $${849.39}$$	$${-0}$$	$${268.58}$$ < $${288.34}$$
✅	docker_agent_arm64	$${+0}$$	$${793.23}$$ < $${858.97}$$	$${+0.01}$$	$${255.97}$$ < $${274.36}$$
✅	docker_agent_jmx_amd64	$${+0}$$	$${779.82}$$ < $${849.39}$$	$${-0}$$	$${268.58}$$ < $${288.34}$$
✅	docker_agent_jmx_arm64	$${+0}$$	$${793.23}$$ < $${858.97}$$	$${+0.01}$$	$${255.97}$$ < $${274.36}$$
✅	docker_agent_windows1809	$${+0}$$	$${779.82}$$ < $${849.39}$$	$${-0}$$	$${268.58}$$ < $${288.34}$$
✅	docker_agent_windows1809_core	$${+0}$$	$${779.82}$$ < $${849.39}$$	$${-0}$$	$${268.58}$$ < $${288.34}$$
✅	docker_agent_windows1809_core_jmx	$${+0}$$	$${779.82}$$ < $${849.39}$$	$${-0}$$	$${268.58}$$ < $${288.34}$$
✅	docker_agent_windows1809_jmx	$${+0}$$	$${779.82}$$ < $${849.39}$$	$${-0}$$	$${268.58}$$ < $${288.34}$$
✅	docker_agent_windows2022	$${+0}$$	$${779.82}$$ < $${849.39}$$	$${-0}$$	$${268.58}$$ < $${288.34}$$
✅	docker_agent_windows2022_core	$${+0}$$	$${779.82}$$ < $${849.39}$$	$${-0}$$	$${268.58}$$ < $${288.34}$$
✅	docker_agent_windows2022_core_jmx	$${+0}$$	$${779.82}$$ < $${849.39}$$	$${-0}$$	$${268.58}$$ < $${288.34}$$
✅	docker_agent_windows2022_jmx	$${+0}$$	$${779.82}$$ < $${849.39}$$	$${-0}$$	$${268.58}$$ < $${288.34}$$
✅	docker_cluster_agent_amd64	$${0}$$	$${259.19}$$ < $${259.73}$$	$${-0}$$	$${102.88}$$ < $${103.68}$$
✅	docker_cluster_agent_arm64	$${0}$$	$${273.58}$$ < $${274.24}$$	$${+0}$$	$${97.59}$$ < $${98.45}$$
✅	docker_cws_instrumentation_amd64	$${0}$$	$${7.08}$$ < $${7.12}$$	$${0}$$	$${2.95}$$ < $${3.29}$$
✅	docker_cws_instrumentation_arm64	$${0}$$	$${6.69}$$ < $${6.92}$$	$${+0}$$	$${2.7}$$ < $${3.07}$$
✅	docker_dogstatsd_amd64	$${0}$$	$${38.93}$$ < $${39.57}$$	$${-0}$$	$${14.95}$$ < $${15.76}$$
✅	docker_dogstatsd_arm64	$${0}$$	$${37.52}$$ < $${38.2}$$	$${+0}$$	$${13.96}$$ < $${14.83}$$
✅	dogstatsd_deb_amd64	$${0}$$	$${30.61}$$ < $${31.52}$$	$${-0}$$	$${8.03}$$ < $${8.97}$$
✅	dogstatsd_deb_arm64	$${0}$$	$${29.16}$$ < $${30.08}$$	$${-0}$$	$${6.97}$$ < $${7.92}$$
✅	dogstatsd_rpm_amd64	$${0}$$	$${30.61}$$ < $${31.52}$$	$${-0}$$	$${8.04}$$ < $${8.98}$$
✅	dogstatsd_suse_amd64	$${0}$$	$${30.61}$$ < $${31.52}$$	$${-0}$$	$${8.04}$$ < $${8.98}$$
✅	iot_agent_deb_amd64	$${+0}$$	$${50.48}$$ < $${60.17}$$	$${+0}$$	$${12.85}$$ < $${15.82}$$
✅	iot_agent_deb_arm64	$${+0}$$	$${47.94}$$ < $${56.94}$$	$${+0}$$	$${11.14}$$ < $${13.86}$$
✅	iot_agent_deb_armhf	$${+0}$$	$${47.51}$$ < $${56.41}$$	$${+0}$$	$${11.21}$$ < $${13.86}$$
✅	iot_agent_rpm_amd64	$${+0}$$	$${50.48}$$ < $${60.18}$$	$${-0}$$	$${12.86}$$ < $${15.84}$$
✅	iot_agent_rpm_arm64	$${+0}$$	$${47.94}$$ < $${56.94}$$	$${+0}$$	$${11.16}$$ < $${13.76}$$
✅	iot_agent_suse_amd64	$${+0}$$	$${50.48}$$ < $${60.18}$$	$${-0}$$	$${12.86}$$ < $${15.84}$$

comp/core/workloadmeta/collectors/internal/process/process_collector.go

comp/core/workloadmeta/collectors/internal/process/process_collector_test.go

daniel-taf · 2025-06-05T15:02:13Z

I think CODEOWNERS needs to be updated to include our team for this new collector. Our team isn't tagged in the review.

comp/core/workloadmeta/collectors/internal/process/process_collector_test.go

comp/core/workloadmeta/collectors/internal/process/process_collector.go

daniel-taf · 2025-06-06T21:11:57Z

comp/core/workloadmeta/collectors/internal/process/process_collector.go

 	wlmProcs := make([]*workloadmeta.Process, len(createdProcs))
+	isLanguageDataAvailable := len(languages) == len(createdProcs) // language data is not always available, so we have to check


nit: I think it make more sense to check that the language slice is not nil. languagedetection.DetectLanguage always returns a slice that's the same size as procs. But, detectLanguages returns nil when the feature is not enabled.

Yeah I was considering that, but I was worried that this function could then have a fatal error if the length of languages is not the same length as the processes due to the index access in the loop below. I understand we "own" both functions but it seems scary to have a fatal error as a possibility.

gabedos · 2025-06-09T14:22:35Z

.github/CODEOWNERS

@@ -596,6 +596,7 @@
 /pkg/snmp/                              @DataDog/ndm-core
 /pkg/tagger/                            @DataDog/container-platform
 /pkg/windowsdriver/                     @DataDog/windows-agent
+/comp/core/workloadmeta/collectors/internal/process  @DataDog/container-experiences


Can you make @container-platform also a co-owner of this collector for visibility. I think if multiple teams are co-owners, only a review from 1 team is actually required but we'll still get tagged/notifs from the PR.

Also small nit: alphabetical ordering of the CODEOWNER. comp/core/workloadmeta/collectors/internal/process would be last.

added @DataDog/container-platform as a co-owner!

gabedos · 2025-06-09T14:33:13Z

comp/core/workloadmeta/collectors/internal/process/process_collector.go

 	return collector{
 		id:                     id,
 		catalog:                catalog,
 		clock:                  clock,
 		processProbe:           processProbe,
+		config:                 config,
+		systemProbeConfig:      systemProbeConfig,


Slightly unrelated and doesn't need to be added right now but,

All of the wmeta collectors send the wmeta entity events via c.store.Notify(events) instead of directly through a channel. It might make sense for uniformity to also store wmeta in the collector and feed the events in func (c *collector) collect like that.

gabedos

Approved with small nits

gengnamstyle · 2025-06-10T16:06:00Z

/merge

dd-devflow · 2025-06-10T16:06:03Z

View all feedbacks in Devflow UI.

2025-06-10 16:06:03 UTC ℹ️ Start processing command /merge

2025-06-10 16:06:09 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 47m (p90).

2025-06-10 16:44:01 UTC ℹ️ MergeQueue: This merge request was merged

gengnamstyle requested a review from a team as a code owner June 4, 2025 19:33

github-actions bot added medium review PR review might take time team/container-platform The Container Platform Team labels Jun 4, 2025

gengnamstyle changed the title ~~feat: add language data collection~~ CXP-2267 [agent] feat: add language data collection Jun 4, 2025

gengnamstyle added qa/done QA done before merge and regressions are covered by tests changelog/no-changelog labels Jun 4, 2025

gengnamstyle added this to the 7.68.0 milestone Jun 4, 2025

daniel-taf reviewed Jun 5, 2025

View reviewed changes

gengnamstyle force-pushed the matthew.geng/CXP-2267-process-collector-language-data branch from e4c9fc0 to 225f714 Compare June 5, 2025 21:20

gengnamstyle requested a review from daniel-taf June 6, 2025 14:29

daniel-taf reviewed Jun 6, 2025

View reviewed changes

comp/core/workloadmeta/collectors/internal/process/process_collector_test.go Outdated Show resolved Hide resolved

daniel-taf reviewed Jun 6, 2025

View reviewed changes

comp/core/workloadmeta/collectors/internal/process/process_collector_test.go Outdated Show resolved Hide resolved

daniel-taf reviewed Jun 6, 2025

View reviewed changes

comp/core/workloadmeta/collectors/internal/process/process_collector_test.go Outdated Show resolved Hide resolved

daniel-taf reviewed Jun 6, 2025

View reviewed changes

comp/core/workloadmeta/collectors/internal/process/process_collector.go Outdated Show resolved Hide resolved

gengnamstyle removed this from the 7.68.0 milestone Jun 6, 2025

github-actions bot added long review PR is complex, plan time to review it and removed medium review PR review might take time labels Jun 6, 2025

gengnamstyle requested a review from daniel-taf June 6, 2025 20:59

daniel-taf approved these changes Jun 6, 2025

View reviewed changes

gabedos reviewed Jun 9, 2025

View reviewed changes

gabedos approved these changes Jun 9, 2025

View reviewed changes

gengnamstyle added 5 commits June 9, 2025 12:52

feat: add language data collection

033b0b7

nit: refactor + test updates

25dbc53

add cxp to process collection codeowner

29919e2

fix: codeowners file

1f8f757

fix: linter

0bfd886

gengnamstyle added 3 commits June 9, 2025 12:52

fix: syntax

458c231

fix: check language detection config

4094bc6

update codeowners with container-platform as co-owner

6a6b4e3

gengnamstyle force-pushed the matthew.geng/CXP-2267-process-collector-language-data branch from 9811293 to 6a6b4e3 Compare June 9, 2025 16:54

dd-mergequeue bot merged commit d54f38c into main Jun 10, 2025
246 checks passed

dd-mergequeue bot deleted the matthew.geng/CXP-2267-process-collector-language-data branch June 10, 2025 16:43

github-actions bot added this to the 7.68.0 milestone Jun 10, 2025

		wlmProcs := make([]*workloadmeta.Process, len(createdProcs))
		isLanguageDataAvailable := len(languages) == len(createdProcs) // language data is not always available, so we have to check

CXP-2267 [agent] feat: add language data collection #37668

CXP-2267 [agent] feat: add language data collection #37668

Uh oh!

Conversation

gengnamstyle commented Jun 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

Uh oh!

cit-pr-commenter bot commented Jun 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

CI Pass/Fail Decision

Uh oh!

agent-platform-auto-pr bot commented Jun 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Static quality checks

Info

Uh oh!

Uh oh!

Uh oh!

Uh oh!

daniel-taf commented Jun 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

daniel-taf Jun 6, 2025

Choose a reason for hiding this comment

Uh oh!

gengnamstyle Jun 9, 2025

Choose a reason for hiding this comment

Uh oh!

gabedos Jun 9, 2025

Choose a reason for hiding this comment

Uh oh!

gengnamstyle Jun 9, 2025

Choose a reason for hiding this comment

Uh oh!

gabedos Jun 9, 2025

Choose a reason for hiding this comment

Uh oh!

gabedos left a comment

Choose a reason for hiding this comment

Uh oh!

gengnamstyle commented Jun 10, 2025

Uh oh!

dd-devflow bot commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gengnamstyle commented Jun 4, 2025 •

edited

Loading

cit-pr-commenter bot commented Jun 4, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Jun 4, 2025 •

edited

Loading

daniel-taf commented Jun 5, 2025 •

edited

Loading

dd-devflow bot commented Jun 10, 2025 •

edited

Loading