feat: added truncatedLogs metric #37703

lucastemb · 2025-06-05T19:01:56Z

What does this PR do?

Adds the datadog.agent.logs.truncated metric in metrics.go
Modified single_line_handler.go, multiline_handler.go, and aggregator.go to increment our logs.truncated metric by 1 while also implementing safeguards to check whether the message or message origin is nil to successfully increment the count with the message origin service and source.
Changed tests in status_test.go and metrics_test.go to include and check for new metric.
Added LogsTruncated to builder.go to expose new metric

Motivation

This metric enables customers to monitor the number of logs truncated by the Agent. It addresses the customer feature request FRLOGSS-3606 and aligns with the internal telemetry initiative AGNTLOG-227. The metric name differs from the backend’s datadog.estimated_usage.logs.truncated_count to maintain consistency with existing Agent metric naming conventions.

Describe how you validated your changes

Ran curl http://localhost:5000/telemetry | grep "truncated" to verify existence of metric on local DataDog agent.

Also, modified unit tests and ran them to ensure expected behavior.

Possible Drawbacks / Trade-offs

Additional Notes

bits-bot · 2025-06-05T19:02:01Z

All committers have signed the CLA.

cit-pr-commenter · 2025-06-06T21:21:24Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 100ee56d-ce0f-4e68-a5b9-7c3ab88bf35b

Baseline: 9d6ecd4
Comparison: 75c4605
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	+0.49	[+0.44, +0.54]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.36	[-0.51, +1.24]	1	Logs
➖	quality_gate_logs	% cpu utilization	+0.20	[-2.55, +2.96]	1	Logs bounds checks dashboard
➖	quality_gate_idle_all_features	memory utilization	+0.12	[+0.04, +0.21]	1	Logs bounds checks dashboard
➖	ddot_logs	memory utilization	+0.12	[-0.02, +0.26]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	+0.08	[-0.46, +0.63]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	+0.08	[-0.15, +0.31]	1	Logs
➖	quality_gate_idle	memory utilization	+0.08	[+0.02, +0.13]	1	Logs bounds checks dashboard
➖	docker_containers_memory	memory utilization	+0.03	[-0.07, +0.13]	1	Logs
➖	otlp_ingest_metrics	memory utilization	+0.02	[-0.15, +0.18]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.02, +0.01]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.27, +0.27]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	-0.01	[-0.62, +0.61]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.02	[-0.61, +0.57]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.06	[-0.65, +0.54]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.07	[-0.65, +0.51]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	-0.08	[-0.63, +0.48]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.08	[-0.72, +0.56]	1	Logs
➖	file_tree	memory utilization	-0.24	[-0.36, -0.11]	1	Logs
➖	otlp_ingest_logs	memory utilization	-0.29	[-0.41, -0.16]	1	Logs
➖	ddot_metrics	memory utilization	-0.44	[-0.56, -0.33]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-1.21	[-1.28, -1.14]	1	Logs
➖	docker_containers_cpu	% cpu utilization	-1.54	[-4.47, +1.38]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	docker_containers_cpu	simple_check_run	10/10
✅	docker_containers_memory	memory_usage	10/10
✅	docker_containers_memory	simple_check_run	10/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

agent-platform-auto-pr · 2025-06-09T17:43:09Z

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 9d6ecd4

Successful checks

Info

	Quality gate	Delta	On disk size (MiB)	Delta	On wire size (MiB)
✅	agent_deb_amd64	$${+0.01}$$	$${696.07}$$ < $${752.99}$$	$${-0.03}$$	$${176.03}$$ < $${187.44}$$
✅	agent_deb_amd64_fips	$${-0}$$	$${694.29}$$ < $${751.36}$$	$${-0.03}$$	$${175.48}$$ < $${187.06}$$
✅	agent_heroku_amd64	$${0}$$	$${358.56}$$ < $${369.68}$$	$${+0}$$	$${96.5}$$ < $${99.55}$$
✅	agent_msi	$${+0.01}$$	$${959.88}$$ < $${987.01}$$	$${+0.04}$$	$${146.46}$$ < $${150.72}$$
✅	agent_rpm_amd64	$${+0.01}$$	$${696.06}$$ < $${752.98}$$	$${-0.04}$$	$${177.55}$$ < $${190.03}$$
✅	agent_rpm_amd64_fips	$${-0}$$	$${694.28}$$ < $${751.35}$$	$${-0.04}$$	$${177.41}$$ < $${189.81}$$
✅	agent_rpm_arm64	$${-0}$$	$${686.0}$$ < $${739.42}$$	$${+0.02}$$	$${161.04}$$ < $${171.23}$$
✅	agent_rpm_arm64_fips	$${+0.01}$$	$${684.36}$$ < $${737.91}$$	$${-0.04}$$	$${160.07}$$ < $${170.22}$$
✅	agent_suse_amd64	$${+0.01}$$	$${696.06}$$ < $${752.98}$$	$${-0.04}$$	$${177.55}$$ < $${190.03}$$
✅	agent_suse_amd64_fips	$${-0}$$	$${694.28}$$ < $${751.35}$$	$${-0.04}$$	$${177.41}$$ < $${189.81}$$
✅	agent_suse_arm64	$${-0}$$	$${686.0}$$ < $${739.42}$$	$${+0.02}$$	$${161.04}$$ < $${171.23}$$
✅	agent_suse_arm64_fips	$${+0.01}$$	$${684.36}$$ < $${737.91}$$	$${-0.04}$$	$${160.07}$$ < $${170.22}$$
✅	docker_agent_amd64	$${+0.01}$$	$${779.86}$$ < $${849.39}$$	$${+0.01}$$	$${268.59}$$ < $${288.34}$$
✅	docker_agent_arm64	$${-0}$$	$${793.25}$$ < $${858.97}$$	$${-0.01}$$	$${255.98}$$ < $${274.36}$$
✅	docker_agent_jmx_amd64	$${+0.01}$$	$${779.86}$$ < $${849.39}$$	$${+0.01}$$	$${268.59}$$ < $${288.34}$$
✅	docker_agent_jmx_arm64	$${-0}$$	$${793.25}$$ < $${858.97}$$	$${-0.01}$$	$${255.98}$$ < $${274.36}$$
✅	docker_agent_windows1809	$${+0.01}$$	$${779.86}$$ < $${849.39}$$	$${+0.01}$$	$${268.59}$$ < $${288.34}$$
✅	docker_agent_windows1809_core	$${+0.01}$$	$${779.86}$$ < $${849.39}$$	$${+0.01}$$	$${268.59}$$ < $${288.34}$$
✅	docker_agent_windows1809_core_jmx	$${+0.01}$$	$${779.86}$$ < $${849.39}$$	$${+0.01}$$	$${268.59}$$ < $${288.34}$$
✅	docker_agent_windows1809_jmx	$${+0.01}$$	$${779.86}$$ < $${849.39}$$	$${+0.01}$$	$${268.59}$$ < $${288.34}$$
✅	docker_agent_windows2022	$${+0.01}$$	$${779.86}$$ < $${849.39}$$	$${+0.01}$$	$${268.59}$$ < $${288.34}$$
✅	docker_agent_windows2022_core	$${+0.01}$$	$${779.86}$$ < $${849.39}$$	$${+0.01}$$	$${268.59}$$ < $${288.34}$$
✅	docker_agent_windows2022_core_jmx	$${+0.01}$$	$${779.86}$$ < $${849.39}$$	$${+0.01}$$	$${268.59}$$ < $${288.34}$$
✅	docker_agent_windows2022_jmx	$${+0.01}$$	$${779.86}$$ < $${849.39}$$	$${+0.01}$$	$${268.59}$$ < $${288.34}$$
✅	docker_cluster_agent_amd64	$${+0}$$	$${259.22}$$ < $${259.73}$$	$${+0}$$	$${102.9}$$ < $${103.68}$$
✅	docker_cluster_agent_arm64	$${+0}$$	$${273.65}$$ < $${274.24}$$	$${-0}$$	$${97.58}$$ < $${98.45}$$
✅	docker_cws_instrumentation_amd64	$${0}$$	$${7.08}$$ < $${7.12}$$	$${+0}$$	$${2.95}$$ < $${3.29}$$
✅	docker_cws_instrumentation_arm64	$${0}$$	$${6.69}$$ < $${6.92}$$	$${-0}$$	$${2.7}$$ < $${3.07}$$
✅	docker_dogstatsd_amd64	$${0}$$	$${38.93}$$ < $${39.57}$$	$${-0}$$	$${14.95}$$ < $${15.76}$$
✅	docker_dogstatsd_arm64	$${0}$$	$${37.52}$$ < $${38.2}$$	$${-0}$$	$${13.96}$$ < $${14.83}$$
✅	dogstatsd_deb_amd64	$${+0}$$	$${30.61}$$ < $${31.52}$$	$${+0}$$	$${8.03}$$ < $${8.97}$$
✅	dogstatsd_deb_arm64	$${0}$$	$${29.16}$$ < $${30.08}$$	$${-0}$$	$${6.97}$$ < $${7.92}$$
✅	dogstatsd_rpm_amd64	$${+0}$$	$${30.61}$$ < $${31.52}$$	$${-0}$$	$${8.04}$$ < $${8.98}$$
✅	dogstatsd_suse_amd64	$${+0}$$	$${30.61}$$ < $${31.52}$$	$${-0}$$	$${8.04}$$ < $${8.98}$$
✅	iot_agent_deb_amd64	$${0}$$	$${50.49}$$ < $${60.17}$$	$${+0}$$	$${12.85}$$ < $${15.82}$$
✅	iot_agent_deb_arm64	$${+0}$$	$${47.94}$$ < $${56.94}$$	$${+0}$$	$${11.15}$$ < $${13.86}$$
✅	iot_agent_deb_armhf	$${0}$$	$${47.52}$$ < $${56.41}$$	$${+0}$$	$${11.21}$$ < $${13.86}$$
✅	iot_agent_rpm_amd64	$${0}$$	$${50.49}$$ < $${60.18}$$	$${-0}$$	$${12.87}$$ < $${15.84}$$
✅	iot_agent_rpm_arm64	$${+0}$$	$${47.94}$$ < $${56.94}$$	$${+0}$$	$${11.17}$$ < $${13.76}$$
✅	iot_agent_suse_amd64	$${0}$$	$${50.49}$$ < $${60.18}$$	$${-0}$$	$${12.87}$$ < $${15.84}$$

jszwedko

Nice work!

releasenotes/notes/truncated_count_metric-ef102f7deabb9206.yaml

lucastemb · 2025-06-10T19:22:06Z

/merge

dd-devflow · 2025-06-10T19:22:10Z

View all feedbacks in Devflow UI.

2025-06-10 19:22:10 UTC ℹ️ Start processing command /merge

2025-06-10 19:22:20 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-06-10 20:09:46 UTC ⚠️ MergeQueue: This merge request was unqueued

lucas.tembras@datadoghq.com unqueued this merge request

lucastemb · 2025-06-10T20:09:40Z

/remove

dd-devflow · 2025-06-10T20:09:43Z

View all feedbacks in Devflow UI.

2025-06-10 20:09:42 UTC ℹ️ Start processing command /remove

2025-06-10 20:09:46 UTC ℹ️ Devflow: /remove

Co-authored-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>

lucastemb · 2025-06-11T02:08:56Z

/merge

dd-devflow · 2025-06-11T02:09:00Z

View all feedbacks in Devflow UI.

2025-06-11 02:08:59 UTC ℹ️ Start processing command /merge

2025-06-11 02:09:05 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 47m (p90).

2025-06-11 02:54:48 UTC ℹ️ MergeQueue: This merge request was merged

github-actions bot added medium review PR review might take time team/agent-log-pipelines labels Jun 5, 2025

lucastemb added the qa/rc-required Only for a PR that requires validation on the Release Candidate label Jun 6, 2025

lucastemb force-pushed the lucast/AGNTLOG-226 branch from 9fdc953 to d6abe10 Compare June 6, 2025 20:33

lucastemb added qa/done QA done before merge and regressions are covered by tests and removed qa/rc-required Only for a PR that requires validation on the Release Candidate labels Jun 9, 2025

lucastemb force-pushed the lucast/AGNTLOG-226 branch from 3ba6eef to 9c992a2 Compare June 10, 2025 13:20

lucastemb marked this pull request as ready for review June 10, 2025 15:24

lucastemb requested review from a team as code owners June 10, 2025 15:24

ddrthall approved these changes Jun 10, 2025

View reviewed changes

jszwedko reviewed Jun 10, 2025

View reviewed changes

releasenotes/notes/truncated_count_metric-ef102f7deabb9206.yaml Show resolved Hide resolved

releasenotes/notes/truncated_count_metric-ef102f7deabb9206.yaml Outdated Show resolved Hide resolved

michaelcretzman approved these changes Jun 10, 2025

View reviewed changes

feat: added truncatedLogs metric

75c4605

Co-authored-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>

lucastemb force-pushed the lucast/AGNTLOG-226 branch from 5ee5fac to 75c4605 Compare June 10, 2025 20:14

dd-mergequeue bot merged commit 45cf0fe into main Jun 11, 2025
237 checks passed

dd-mergequeue bot deleted the lucast/AGNTLOG-226 branch June 11, 2025 02:54

github-actions bot added this to the 7.68.0 milestone Jun 11, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: added truncatedLogs metric #37703

feat: added truncatedLogs metric #37703

Uh oh!

lucastemb commented Jun 5, 2025 •

edited

Loading

Uh oh!

bits-bot commented Jun 5, 2025 •

edited

Loading

Uh oh!

cit-pr-commenter bot commented Jun 6, 2025 •

edited

Loading

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

Uh oh!

agent-platform-auto-pr bot commented Jun 9, 2025 •

edited

Loading

Info

Uh oh!

jszwedko left a comment

Uh oh!

Uh oh!

Uh oh!

lucastemb commented Jun 10, 2025

Uh oh!

dd-devflow bot commented Jun 10, 2025 •

edited

Loading

Uh oh!

lucastemb commented Jun 10, 2025

Uh oh!

dd-devflow bot commented Jun 10, 2025 •

edited

Loading

Uh oh!

lucastemb commented Jun 11, 2025

Uh oh!

dd-devflow bot commented Jun 11, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

feat: added truncatedLogs metric #37703

feat: added truncatedLogs metric #37703

Uh oh!

Conversation

lucastemb commented Jun 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

Uh oh!

bits-bot commented Jun 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cit-pr-commenter bot commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

CI Pass/Fail Decision

Uh oh!

agent-platform-auto-pr bot commented Jun 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Static quality checks

Info

Uh oh!

jszwedko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

lucastemb commented Jun 10, 2025

Uh oh!

dd-devflow bot commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lucastemb commented Jun 10, 2025

Uh oh!

dd-devflow bot commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lucastemb commented Jun 11, 2025

Uh oh!

dd-devflow bot commented Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lucastemb commented Jun 5, 2025 •

edited

Loading

bits-bot commented Jun 5, 2025 •

edited

Loading

cit-pr-commenter bot commented Jun 6, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Jun 9, 2025 •

edited

Loading

dd-devflow bot commented Jun 10, 2025 •

edited

Loading

dd-devflow bot commented Jun 10, 2025 •

edited

Loading

dd-devflow bot commented Jun 11, 2025 •

edited

Loading