[CXP-2248] Update hostname setup for the process and container checks in fargate #37704

wiyu · 2025-06-05T20:09:55Z

What does this PR do?

Fix how the hostname is set for the process and containers check when running in the Agent in AWS Fargate
Fix the existing ECS Fargate tests to ensure the process-agent starts when running in AWS Fargate by explicitly disabling
DD_PROCESS_CONFIG_RUN_IN_CORE_AGENT_ENABLED

Motivation

https://datadoghq.atlassian.net/browse/CXP-2248

Describe how you validated your changes

The PR is validated through e2e tests.

Possible Drawbacks / Trade-offs

Additional Notes

cit-pr-commenter · 2025-06-05T21:11:42Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: c933ff28-d5ce-48ee-bdef-e8eb26d3dc5f

Baseline: 96e38c9
Comparison: 079fd32
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	+3.36	[+0.35, +6.36]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	+0.69	[+0.64, +0.73]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.65	[+0.57, +0.73]	1	Logs bounds checks dashboard
➖	otlp_ingest_logs	memory utilization	+0.42	[+0.30, +0.55]	1	Logs
➖	quality_gate_logs	% cpu utilization	+0.37	[-2.37, +3.11]	1	Logs bounds checks dashboard
➖	ddot_metrics	memory utilization	+0.21	[+0.09, +0.33]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	+0.03	[-0.60, +0.67]	1	Logs
➖	quality_gate_idle	memory utilization	+0.02	[-0.04, +0.08]	1	Logs bounds checks dashboard
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	+0.01	[-0.23, +0.24]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.01	[-0.24, +0.26]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	+0.00	[-0.54, +0.54]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.00	[-0.62, +0.63]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.02, +0.02]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.01	[-0.60, +0.59]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	-0.04	[-0.63, +0.55]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.04	[-0.68, +0.60]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.05	[-0.65, +0.55]	1	Logs
➖	ddot_logs	memory utilization	-0.16	[-0.31, -0.02]	1	Logs
➖	docker_containers_memory	memory utilization	-0.21	[-0.29, -0.14]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-0.34	[-1.24, +0.56]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-0.46	[-0.52, -0.40]	1	Logs
➖	file_tree	memory utilization	-0.78	[-0.94, -0.62]	1	Logs
➖	otlp_ingest_metrics	memory utilization	-1.02	[-1.18, -0.86]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	docker_containers_cpu	simple_check_run	10/10
✅	docker_containers_memory	memory_usage	10/10
✅	docker_containers_memory	simple_check_run	10/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

agent-platform-auto-pr · 2025-06-06T00:01:28Z

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 96e38c9

Successful checks

Info

	Quality gate	Delta	On disk size (MiB)	Delta	On wire size (MiB)
✅	agent_deb_amd64	$${+0.01}$$	$${696.06}$$ < $${752.99}$$	$${+0.07}$$	$${176.06}$$ < $${187.44}$$
✅	agent_deb_amd64_fips	$${+0}$$	$${694.29}$$ < $${751.36}$$	$${+0.01}$$	$${175.49}$$ < $${187.06}$$
✅	agent_heroku_amd64	$${0}$$	$${358.56}$$ < $${369.68}$$	$${-0}$$	$${96.5}$$ < $${99.55}$$
✅	agent_msi	$${+0.01}$$	$${959.88}$$ < $${987.01}$$	$${-0.01}$$	$${146.43}$$ < $${150.72}$$
✅	agent_rpm_amd64	$${+0.01}$$	$${696.05}$$ < $${752.98}$$	$${+0.04}$$	$${177.58}$$ < $${190.03}$$
✅	agent_rpm_amd64_fips	$${+0}$$	$${694.28}$$ < $${751.35}$$	$${+0}$$	$${177.43}$$ < $${189.81}$$
✅	agent_rpm_arm64	$${-0}$$	$${686.0}$$ < $${739.42}$$	$${-0.01}$$	$${161.0}$$ < $${171.23}$$
✅	agent_rpm_arm64_fips	$${+0.01}$$	$${684.36}$$ < $${737.91}$$	$${+0.02}$$	$${160.1}$$ < $${170.22}$$
✅	agent_suse_amd64	$${+0.01}$$	$${696.05}$$ < $${752.98}$$	$${+0.04}$$	$${177.58}$$ < $${190.03}$$
✅	agent_suse_amd64_fips	$${+0}$$	$${694.28}$$ < $${751.35}$$	$${+0}$$	$${177.43}$$ < $${189.81}$$
✅	agent_suse_arm64	$${-0}$$	$${686.0}$$ < $${739.42}$$	$${-0.01}$$	$${161.0}$$ < $${171.23}$$
✅	agent_suse_arm64_fips	$${+0.01}$$	$${684.36}$$ < $${737.91}$$	$${+0.02}$$	$${160.1}$$ < $${170.22}$$
✅	docker_agent_amd64	$${+0.01}$$	$${779.85}$$ < $${849.39}$$	$${+0.01}$$	$${268.6}$$ < $${288.34}$$
✅	docker_agent_arm64	$${-0}$$	$${793.25}$$ < $${858.97}$$	$${+0}$$	$${255.98}$$ < $${274.36}$$
✅	docker_agent_jmx_amd64	$${+0.01}$$	$${779.85}$$ < $${849.39}$$	$${+0.01}$$	$${268.6}$$ < $${288.34}$$
✅	docker_agent_jmx_arm64	$${-0}$$	$${793.25}$$ < $${858.97}$$	$${+0}$$	$${255.98}$$ < $${274.36}$$
✅	docker_agent_windows1809	$${+0.01}$$	$${779.85}$$ < $${849.39}$$	$${+0.01}$$	$${268.6}$$ < $${288.34}$$
✅	docker_agent_windows1809_core	$${+0.01}$$	$${779.85}$$ < $${849.39}$$	$${+0.01}$$	$${268.6}$$ < $${288.34}$$
✅	docker_agent_windows1809_core_jmx	$${+0.01}$$	$${779.85}$$ < $${849.39}$$	$${+0.01}$$	$${268.6}$$ < $${288.34}$$
✅	docker_agent_windows1809_jmx	$${+0.01}$$	$${779.85}$$ < $${849.39}$$	$${+0.01}$$	$${268.6}$$ < $${288.34}$$
✅	docker_agent_windows2022	$${+0.01}$$	$${779.85}$$ < $${849.39}$$	$${+0.01}$$	$${268.6}$$ < $${288.34}$$
✅	docker_agent_windows2022_core	$${+0.01}$$	$${779.85}$$ < $${849.39}$$	$${+0.01}$$	$${268.6}$$ < $${288.34}$$
✅	docker_agent_windows2022_core_jmx	$${+0.01}$$	$${779.85}$$ < $${849.39}$$	$${+0.01}$$	$${268.6}$$ < $${288.34}$$
✅	docker_agent_windows2022_jmx	$${+0.01}$$	$${779.85}$$ < $${849.39}$$	$${+0.01}$$	$${268.6}$$ < $${288.34}$$
✅	docker_cluster_agent_amd64	$${0}$$	$${259.2}$$ < $${259.73}$$	$${-0}$$	$${102.88}$$ < $${103.68}$$
✅	docker_cluster_agent_arm64	$${+0}$$	$${273.58}$$ < $${274.24}$$	$${+0}$$	$${97.61}$$ < $${98.45}$$
✅	docker_cws_instrumentation_amd64	$${0}$$	$${7.08}$$ < $${7.12}$$	$${-0}$$	$${2.95}$$ < $${3.29}$$
✅	docker_cws_instrumentation_arm64	$${0}$$	$${6.69}$$ < $${6.92}$$	$${+0}$$	$${2.7}$$ < $${3.07}$$
✅	docker_dogstatsd_amd64	$${+0}$$	$${38.93}$$ < $${39.57}$$	$${-0}$$	$${14.95}$$ < $${15.76}$$
✅	docker_dogstatsd_arm64	$${0}$$	$${37.52}$$ < $${38.2}$$	$${-0}$$	$${13.96}$$ < $${14.83}$$
✅	dogstatsd_deb_amd64	$${0}$$	$${30.61}$$ < $${31.52}$$	$${-0}$$	$${8.03}$$ < $${8.97}$$
✅	dogstatsd_deb_arm64	$${0}$$	$${29.16}$$ < $${30.08}$$	$${+0}$$	$${6.98}$$ < $${7.92}$$
✅	dogstatsd_rpm_amd64	$${0}$$	$${30.61}$$ < $${31.52}$$	$${-0}$$	$${8.04}$$ < $${8.98}$$
✅	dogstatsd_suse_amd64	$${0}$$	$${30.61}$$ < $${31.52}$$	$${-0}$$	$${8.04}$$ < $${8.98}$$
✅	iot_agent_deb_amd64	$${0}$$	$${50.49}$$ < $${60.17}$$	$${+0}$$	$${12.85}$$ < $${15.82}$$
✅	iot_agent_deb_arm64	$${+0}$$	$${47.94}$$ < $${56.94}$$	$${+0.01}$$	$${11.15}$$ < $${13.86}$$
✅	iot_agent_deb_armhf	$${0}$$	$${47.52}$$ < $${56.41}$$	$${-0.01}$$	$${11.21}$$ < $${13.86}$$
✅	iot_agent_rpm_amd64	$${0}$$	$${50.49}$$ < $${60.18}$$	$${+0}$$	$${12.87}$$ < $${15.84}$$
✅	iot_agent_rpm_arm64	$${+0}$$	$${47.94}$$ < $${56.94}$$	$${+0}$$	$${11.16}$$ < $${13.76}$$
✅	iot_agent_suse_amd64	$${0}$$	$${50.49}$$ < $${60.18}$$	$${+0}$$	$${12.87}$$ < $${15.84}$$

wiyu · 2025-06-10T11:20:24Z

tasks/build_tags.py

@@ -109,6 +110,7 @@
        "crio",
        "docker",
        "ec2",
+        "fargateprocess",


Excluded from the heroku build

wiyu · 2025-06-10T11:26:25Z

test/new-e2e/tests/process/fargate_test.go

+	extraConfig := runner.ConfigMap{
+		"ddagent:extraEnvVars": auto.ConfigValue{Value: "DD_PROCESS_CONFIG_RUN_IN_CORE_AGENT_ENABLED=false"},
+	}


This test's intention is to validate the process checks running in the process-agent, but it broke after we defaulted the process checks to run in the core agent. This explicitly sets the check to run in the process-agent to ensure the data is coming from the expected agent.

wiyu · 2025-06-10T11:30:31Z

test/new-e2e/tests/process/fargate_test.go

-	// Flush fake intake to remove any payloads which may have
-	s.Env().FakeIntake.Client().FlushServerAndResetAggregators()


This isn't necessary since we've split the two tests into their own suite so the envs are fresh

…rocess-agent behavior.

pkg/process/checks/host_info.go

michaelcretzman

Approved with one suggestion.

releasenotes/notes/process-checks-fix-fargate-hostname-9c00191b888ad634.yaml

…hostname

…b888ad634.yaml Co-authored-by: Michael Cretzman <58786311+michaelcretzman@users.noreply.github.com>

wiyu · 2025-06-12T12:53:27Z

/merge

dd-devflow · 2025-06-12T12:53:33Z

View all feedbacks in Devflow UI.

2025-06-12 12:53:33 UTC ℹ️ Start processing command /merge

2025-06-12 12:53:46 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 52m (p90).

2025-06-12 13:37:01 UTC ℹ️ MergeQueue: This merge request was merged

github-actions bot added short review PR is simple enough to be reviewed quickly team/container-experiences labels Jun 5, 2025

wiyu added the qa/done QA done before merge and regressions are covered by tests label Jun 6, 2025

wiyu commented Jun 10, 2025

View reviewed changes

tasks/build_tags.py

@@ -109,6 +110,7 @@

"crio",

"docker",

"ec2",

"fargateprocess",

Copy link

Contributor Author

wiyu Jun 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excluded from the heroku build

wiyu commented Jun 10, 2025

View reviewed changes

wiyu added 7 commits June 10, 2025 07:52

update test to check all payloads within timeout to reduce flakiness

543a888

Add check for fargate hostname in e2e tests

a9e0152

Add fargate tags to agent tags

34b8e97

lower test wait times

9e6b730

Disable running in core agent for the fargate ecs tests to validate p…

4e5ab6d

…rocess-agent behavior.

Add assertion for the process-agent to be running

6f3cc79

Move fargate hostname logic to occur first

ef60e63

wiyu force-pushed the william.yu/CXP-2248-fargate-hostname branch from 704de01 to ef60e63 Compare June 10, 2025 12:57

github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Jun 10, 2025

wiyu added 2 commits June 10, 2025 09:42

Update test to check hostname value

ec6da4e

Add release note

4737d48

wiyu changed the title ~~update test to check all payloads within timeout to reduce flakiness~~ [CXP-2248] Update hostname setup for the process and container checks in fargate Jun 10, 2025

wiyu marked this pull request as ready for review June 10, 2025 14:06

wiyu requested review from a team as code owners June 10, 2025 14:06

kkhor-datadog reviewed Jun 10, 2025

View reviewed changes

pkg/process/checks/host_info.go Outdated Show resolved Hide resolved

michaelcretzman approved these changes Jun 10, 2025

View reviewed changes

releasenotes/notes/process-checks-fix-fargate-hostname-9c00191b888ad634.yaml Outdated Show resolved Hide resolved

wiyu and others added 3 commits June 10, 2025 17:09

Update the fargate hostname logic to avoid overriding a user defined …

6f6c2dd

…hostname

Update releasenotes/notes/process-checks-fix-fargate-hostname-9c00191…

bea4671

…b888ad634.yaml Co-authored-by: Michael Cretzman <58786311+michaelcretzman@users.noreply.github.com>

Fix test order

079fd32

kkhor-datadog approved these changes Jun 11, 2025

View reviewed changes

chouetz approved these changes Jun 12, 2025

View reviewed changes

dd-mergequeue bot merged commit cea826f into main Jun 12, 2025
240 checks passed

dd-mergequeue bot deleted the william.yu/CXP-2248-fargate-hostname branch June 12, 2025 13:36

github-actions bot added this to the 7.68.0 milestone Jun 12, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[CXP-2248] Update hostname setup for the process and container checks in fargate #37704

[CXP-2248] Update hostname setup for the process and container checks in fargate #37704

Uh oh!

wiyu commented Jun 5, 2025 •

edited

Loading

Uh oh!

cit-pr-commenter bot commented Jun 5, 2025 •

edited

Loading

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

Uh oh!

agent-platform-auto-pr bot commented Jun 6, 2025 •

edited

Loading

Info

Uh oh!

wiyu Jun 10, 2025

Uh oh!

wiyu Jun 10, 2025

Uh oh!

wiyu Jun 10, 2025

Uh oh!

Uh oh!

michaelcretzman left a comment

Uh oh!

Uh oh!

wiyu commented Jun 12, 2025

Uh oh!

dd-devflow bot commented Jun 12, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

		// Flush fake intake to remove any payloads which may have
		s.Env().FakeIntake.Client().FlushServerAndResetAggregators()

[CXP-2248] Update hostname setup for the process and container checks in fargate #37704

[CXP-2248] Update hostname setup for the process and container checks in fargate #37704

Uh oh!

Conversation

wiyu commented Jun 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

Uh oh!

cit-pr-commenter bot commented Jun 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

CI Pass/Fail Decision

Uh oh!

agent-platform-auto-pr bot commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Static quality checks

Info

Uh oh!

wiyu Jun 10, 2025

Choose a reason for hiding this comment

Uh oh!

wiyu Jun 10, 2025

Choose a reason for hiding this comment

Uh oh!

wiyu Jun 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

michaelcretzman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

wiyu commented Jun 12, 2025

Uh oh!

dd-devflow bot commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wiyu commented Jun 5, 2025 •

edited

Loading

cit-pr-commenter bot commented Jun 5, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Jun 6, 2025 •

edited

Loading

dd-devflow bot commented Jun 12, 2025 •

edited

Loading