Skip to content

Add remote certificate collection to the Windows Certificate Store integration #37708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jun 13, 2025
Merged

Add remote certificate collection to the Windows Certificate Store integration #37708

merged 13 commits into from
Jun 13, 2025

Conversation

mrafi97
Copy link
Contributor

@mrafi97 mrafi97 commented Jun 5, 2025

What does this PR do?

This PR adds Remote Certificate collection to the Windows Certificate Store integration. This will allow users to specify a server and a username and password to use to login to the server. If a username and password is not provided, the Agent will attempt to access the server with its own credentials.

Motivation

https://datadoghq.atlassian.net/browse/WINA-1446

Describe how you validated your changes

Created an e2e test that creates two hosts, one with the agent installed and another that the agent host will connect to get certificates. The certificate host has a test certificate added to its MY certificate store. The Agent host has the following configuration set on the windows_certificate.d\conf.yaml file to collect that certificate:

init_config:
instances:
  - certificate_store: MY
    server: <SERVER>
    username: <USERNAME>
    password: <PASSWORD>

The e2e test succeeds if the Agent is able to connect to the remote host and collect metrics with the expected tags.

Possible Drawbacks / Trade-offs

Additional Notes

@github-actions github-actions bot added team/windows-agent medium review PR review might take time labels Jun 5, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jun 5, 2025 •
edited
Loading

Gitlab CI Configuration Changes

Added Jobs

.on_windows_certificate_or_e2e_changes 
.on_windows_certificate_or_e2e_changes:
- if: $RUN_E2E_TESTS == "off"
  when: never
- if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
  when: never
- if: $RUN_E2E_TESTS == "on"
  when: on_success
- if: $CI_COMMIT_BRANCH == "main"
  when: on_success
- if: $CI_COMMIT_BRANCH =~ /^[0-9]+\.[0-9]+\.x$/
  when: on_success
- if: $CI_COMMIT_TAG =~ /^[0-9]+\.[0-9]+\.[0-9]+-rc\.[0-9]+$/
  when: on_success
- changes:
    compare_to: $COMPARE_TO_BRANCH
    paths:
    - .gitlab/e2e/e2e.yml
    - test/new-e2e/pkg/**/*
    - test/new-e2e/go.mod
    - flakes.yaml
    - release.json
- changes:
    compare_to: $COMPARE_TO_BRANCH
    paths:
    - test/new-e2e/tests/windows/windows-certificate/**/*
    - pkg/collector/corechecks/system/windowscertificate/**/*
  when: on_success
new-e2e-windows-certificate 
new-e2e-windows-certificate:
  after_script:
  - $CI_PROJECT_DIR/tools/ci/junit_upload.sh "junit-${CI_JOB_ID}.tgz" "$E2E_RESULT_JSON"
  artifacts:
    expire_in: 2 weeks
    paths:
    - $E2E_OUTPUT_DIR
    - $E2E_RESULT_JSON
    - junit-*.tgz
    reports:
      annotations:
      - $EXTERNAL_LINKS_PATH
    when: always
  before_script:
  - mkdir -p $GOPATH/pkg/mod/cache && tar xJf modcache_e2e.tar.xz -C $GOPATH/pkg/mod/cache
    || exit 101
  - rm -f modcache_e2e.tar.xz
  - mkdir -p ~/.aws
  - "if [ -n \"$E2E_USE_AWS_PROFILE\" ]; then\n  echo Using agent-qa-ci aws profile\n\
    \  $CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_QA_E2E profile >> ~/.aws/config\
    \ || exit $?\n  # Now all `aws` commands target the agent-qa profile\n  export\
    \ AWS_PROFILE=agent-qa-ci\nelse\n  # Assume role to fetch only once credentials\
    \ and avoid rate limits\n  echo Assuming ddbuild-agent-ci role\n  roleoutput=\"\
    $(aws sts assume-role --role-arn arn:aws:iam::669783387624:role/ddbuild-agent-ci\
    \ --external-id ddbuild-agent-ci --role-session-name RoleSession)\"\n  export\
    \ AWS_ACCESS_KEY_ID=\"$(echo \"$roleoutput\" | jq -r '.Credentials.AccessKeyId')\"\
    \n  export AWS_SECRET_ACCESS_KEY=\"$(echo \"$roleoutput\" | jq -r '.Credentials.SecretAccessKey')\"\
    \n  export AWS_SESSION_TOKEN=\"$(echo \"$roleoutput\" | jq -r '.Credentials.SessionToken')\"\
    \nfi\n"
  - $CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_QA_E2E ssh_public_key_rsa > $E2E_AWS_PUBLIC_KEY_PATH
    || exit $?
  - touch $E2E_AWS_PRIVATE_KEY_PATH && chmod 600 $E2E_AWS_PRIVATE_KEY_PATH && $CI_PROJECT_DIR/tools/ci/fetch_secret.sh
    $AGENT_QA_E2E ssh_key_rsa > $E2E_AWS_PRIVATE_KEY_PATH || exit $?
  - $CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_QA_E2E ssh_public_key_rsa > $E2E_AZURE_PUBLIC_KEY_PATH
    || exit $?
  - touch $E2E_AZURE_PRIVATE_KEY_PATH && chmod 600 $E2E_AZURE_PRIVATE_KEY_PATH &&
    $CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_QA_E2E ssh_key_rsa > $E2E_AZURE_PRIVATE_KEY_PATH
    || exit $?
  - $CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_QA_E2E ssh_public_key_rsa > $E2E_GCP_PUBLIC_KEY_PATH
    || exit $?
  - touch $E2E_GCP_PRIVATE_KEY_PATH && chmod 600 $E2E_GCP_PRIVATE_KEY_PATH && $CI_PROJECT_DIR/tools/ci/fetch_secret.sh
    $AGENT_QA_E2E ssh_key_rsa > $E2E_GCP_PRIVATE_KEY_PATH || exit $?
  - pulumi login "s3://dd-pulumi-state?region=us-east-1&awssdk=v2&profile=$AWS_PROFILE"
  - ARM_CLIENT_ID=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $E2E_AZURE client_id)
    || exit $?; export ARM_CLIENT_ID
  - ARM_CLIENT_SECRET=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $E2E_AZURE token)
    || exit $?; export ARM_CLIENT_SECRET
  - ARM_TENANT_ID=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $E2E_AZURE tenant_id)
    || exit $?; export ARM_TENANT_ID
  - ARM_SUBSCRIPTION_ID=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $E2E_AZURE subscription_id)
    || exit $?; export ARM_SUBSCRIPTION_ID
  - $CI_PROJECT_DIR/tools/ci/fetch_secret.sh $E2E_GCP credentials_json > ~/gcp-credentials.json
    || exit $?
  - export GOOGLE_APPLICATION_CREDENTIALS=~/gcp-credentials.json
  - dda inv -- -e gitlab.generate-ci-visibility-links --output=$EXTERNAL_LINKS_PATH
  image: registry.ddbuild.io/ci/test-infra-definitions/runner$TEST_INFRA_DEFINITIONS_BUILDIMAGES_SUFFIX:$TEST_INFRA_DEFINITIONS_BUILDIMAGES
  needs:
  - go_e2e_deps
  - deploy_windows_testing-a7
  rules:
  - if: $RUN_E2E_TESTS == "off"
    when: never
  - if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
    when: never
  - if: $RUN_E2E_TESTS == "on"
    when: on_success
  - if: $CI_COMMIT_BRANCH == "main"
    when: on_success
  - if: $CI_COMMIT_BRANCH =~ /^[0-9]+\.[0-9]+\.x$/
    when: on_success
  - if: $CI_COMMIT_TAG =~ /^[0-9]+\.[0-9]+\.[0-9]+-rc\.[0-9]+$/
    when: on_success
  - changes:
      compare_to: $COMPARE_TO_BRANCH
      paths:
      - .gitlab/e2e/e2e.yml
      - test/new-e2e/pkg/**/*
      - test/new-e2e/go.mod
      - flakes.yaml
      - release.json
  - changes:
      compare_to: $COMPARE_TO_BRANCH
      paths:
      - test/new-e2e/tests/windows/windows-certificate/**/*
      - pkg/collector/corechecks/system/windowscertificate/**/*
    when: on_success
  - if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
    when: never
  - allow_failure: true
    when: manual
  script:
  - dda inv -- -e new-e2e-tests.run --local-package $CI_PROJECT_DIR/$OMNIBUS_BASE_DIR
    --result-json $E2E_RESULT_JSON --targets $TARGETS -c ddagent:imagePullRegistry=669783387624.dkr.ecr.us-east-1.amazonaws.com
    -c ddagent:imagePullUsername=AWS -c ddagent:imagePullPassword=$(aws ecr get-login-password)
    --junit-tar junit-${CI_JOB_ID}.tgz ${EXTRA_PARAMS} --test-washer --logs-folder=$E2E_OUTPUT_DIR/logs
    --logs-post-processing --logs-post-processing-test-depth=$E2E_LOGS_PROCESSING_TEST_DEPTH
  stage: e2e
  tags:
  - arch:amd64
  variables:
    E2E_AWS_PRIVATE_KEY_PATH: /tmp/agent-qa-aws-ssh-key
    E2E_AWS_PUBLIC_KEY_PATH: /tmp/agent-qa-aws-ssh-key.pub
    E2E_AZURE_PRIVATE_KEY_PATH: /tmp/agent-qa-azure-ssh-key
    E2E_AZURE_PUBLIC_KEY_PATH: /tmp/agent-qa-azure-ssh-key.pub
    E2E_COMMIT_SHA: $CI_COMMIT_SHORT_SHA
    E2E_GCP_PRIVATE_KEY_PATH: /tmp/agent-qa-gcp-ssh-key
    E2E_GCP_PUBLIC_KEY_PATH: /tmp/agent-qa-gcp-ssh-key.pub
    E2E_KEY_PAIR_NAME: datadog-agent-ci-rsa
    E2E_LOGS_PROCESSING_TEST_DEPTH: 1
    E2E_OUTPUT_DIR: $CI_PROJECT_DIR/e2e-output
    E2E_PIPELINE_ID: $CI_PIPELINE_ID
    E2E_RESULT_JSON: $CI_PROJECT_DIR/e2e_test_output.json
    E2E_USE_AWS_PROFILE: 'true'
    EXTERNAL_LINKS_PATH: external_links_$CI_JOB_ID.json
    EXTRA_PARAMS: --run "TestRemoteCertificates$"
    FLAKY_PATTERNS_CONFIG: $CI_PROJECT_DIR/flaky-patterns-runtime.yaml
    KUBERNETES_CPU_REQUEST: 6
    KUBERNETES_MEMORY_LIMIT: 16Gi
    KUBERNETES_MEMORY_REQUEST: 12Gi
    SHOULD_RUN_IN_FLAKES_FINDER: 'true'
    TARGETS: ./tests/windows/windows-certificate
    TEAM: windows-agent

Changes Summary

Removed Modified Added Renamed
0 0 2 0

ℹ️ Diff available in the job log.

@mrafi97 mrafi97 changed the title Add Remote certificate collection to the Windows Certificate Store integration Add remote certificate collection to the Windows Certificate Store integration Jun 5, 2025
@cit-pr-commenter cit-pr-commenter
Copy link

cit-pr-commenter bot commented Jun 5, 2025 •
edited
Loading

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 7ee00cfa-2e55-4fe4-aab0-b6bc135b6275

Baseline: c75e4f6
Comparison: c9c6c0f
Diff

Optimization Goals: ✅ Improvement(s) detected

perf experiment goal Δ mean % Δ mean % CI trials links
✅ docker_containers_cpu % cpu utilization -6.50 [-9.43, -3.56] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ uds_dogstatsd_to_api_cpu % cpu utilization +1.10 [+0.23, +1.97] 1 Logs
➖ uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.81 [+0.74, +0.87] 1 Logs
➖ tcp_syslog_to_blackhole ingress throughput +0.46 [+0.40, +0.52] 1 Logs
➖ quality_gate_logs % cpu utilization +0.14 [-2.60, +2.89] 1 Logs bounds checks dashboard
➖ file_to_blackhole_0ms_latency_http2 egress throughput +0.13 [-0.39, +0.65] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput +0.07 [-0.49, +0.62] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput +0.04 [-0.58, +0.65] 1 Logs
➖ file_to_blackhole_0ms_latency_http1 egress throughput +0.01 [-0.60, +0.62] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput +0.01 [-0.26, +0.27] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.03, +0.02] 1 Logs
➖ file_to_blackhole_300ms_latency egress throughput -0.01 [-0.59, +0.56] 1 Logs
➖ file_to_blackhole_1000ms_latency_linear_load egress throughput -0.02 [-0.25, +0.22] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput -0.07 [-0.66, +0.52] 1 Logs
➖ ddot_logs memory utilization -0.10 [-0.24, +0.05] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput -0.14 [-0.70, +0.42] 1 Logs
➖ ddot_metrics memory utilization -0.16 [-0.28, -0.05] 1 Logs
➖ file_tree memory utilization -0.18 [-0.41, +0.05] 1 Logs
➖ otlp_ingest_logs memory utilization -0.31 [-0.44, -0.18] 1 Logs
➖ otlp_ingest_metrics memory utilization -0.33 [-0.49, -0.17] 1 Logs
➖ quality_gate_idle_all_features memory utilization -0.40 [-0.54, -0.25] 1 Logs bounds checks dashboard
➖ quality_gate_idle memory utilization -0.70 [-0.77, -0.63] 1 Logs bounds checks dashboard
➖ docker_containers_memory memory utilization -0.76 [-0.86, -0.65] 1 Logs
✅ docker_containers_cpu % cpu utilization -6.50 [-9.43, -3.56] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
❌ quality_gate_logs memory_usage 2/10 bounds checks dashboard
✅ docker_containers_cpu simple_check_run 10/10
✅ docker_containers_memory memory_usage 10/10
✅ docker_containers_memory simple_check_run 10/10
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http1 memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http2 memory_usage 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_300ms_latency lost_bytes 10/10
✅ file_to_blackhole_300ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

❌ Failed. Some Quality Gates were violated.

  • quality_gate_logs, bounds check memory_usage: 2/10 replicas passed. Failed 8 which is > 0. Gate FAILED.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jun 5, 2025 •
edited
Loading

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor c75e4f6

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
✅ agent_deb_amd64 $${+0}$$ $${696.19}$$ < $${752.99}$$ $${+0.01}$$ $${176.02}$$ < $${187.44}$$
✅ agent_deb_amd64_fips $${+0}$$ $${694.42}$$ < $${751.36}$$ $${-0}$$ $${175.57}$$ < $${187.06}$$
✅ agent_heroku_amd64 $${0}$$ $${358.57}$$ < $${369.68}$$ $${-0.01}$$ $${96.49}$$ < $${99.55}$$
✅ agent_msi $${+0.05}$$ $${959.94}$$ < $${987.01}$$ $${+0.02}$$ $${146.47}$$ < $${150.72}$$
✅ agent_rpm_amd64 $${+0}$$ $${696.17}$$ < $${752.98}$$ $${+0}$$ $${177.57}$$ < $${190.03}$$
✅ agent_rpm_amd64_fips $${+0}$$ $${694.41}$$ < $${751.35}$$ $${+0.04}$$ $${177.42}$$ < $${189.81}$$
✅ agent_rpm_arm64 $${0}$$ $${686.12}$$ < $${739.42}$$ $${-0.05}$$ $${161.04}$$ < $${171.23}$$
✅ agent_rpm_arm64_fips $${0}$$ $${684.48}$$ < $${737.91}$$ $${+0.01}$$ $${160.1}$$ < $${170.22}$$
✅ agent_suse_amd64 $${+0}$$ $${696.17}$$ < $${752.98}$$ $${+0}$$ $${177.57}$$ < $${190.03}$$
✅ agent_suse_amd64_fips $${+0}$$ $${694.41}$$ < $${751.35}$$ $${+0.04}$$ $${177.42}$$ < $${189.81}$$
✅ agent_suse_arm64 $${0}$$ $${686.12}$$ < $${739.42}$$ $${-0.05}$$ $${161.04}$$ < $${171.23}$$
✅ agent_suse_arm64_fips $${0}$$ $${684.48}$$ < $${737.91}$$ $${+0.01}$$ $${160.1}$$ < $${170.22}$$
✅ docker_agent_amd64 $${+0}$$ $${779.97}$$ < $${849.39}$$ $${+0.01}$$ $${268.65}$$ < $${288.34}$$
✅ docker_agent_arm64 $${+0}$$ $${793.37}$$ < $${858.97}$$ $${+0}$$ $${255.98}$$ < $${274.36}$$
✅ docker_agent_jmx_amd64 $${+0}$$ $${971.17}$$ < $${1040.59}$$ $${-0.01}$$ $${337.59}$$ < $${357.3}$$
✅ docker_agent_jmx_arm64 $${+0}$$ $${973.16}$$ < $${1038.77}$$ $${+0.01}$$ $${320.96}$$ < $${339.32}$$
✅ docker_agent_windows1809 $${-5.62}$$ $${1482.36}$$ < $${1557.19}$$ $${-1.25}$$ $${487.0}$$ < $${507.33}$$
✅ docker_agent_windows1809_core $${+0.06}$$ $${6217.99}$$ < $${6287.46}$$ $${0}$$ $${2048.0}$$ < $${2067.76}$$
✅ docker_agent_windows1809_core_jmx $${-22.27}$$ $${6339.56}$$ < $${6409.04}$$ $${0}$$ $${2048.0}$$ < $${2067.76}$$
✅ docker_agent_windows1809_jmx $${+0.05}$$ $${1609.66}$$ < $${1679.14}$$ $${-0.02}$$ $${530.53}$$ < $${550.27}$$
✅ docker_agent_windows2022 $${+0.14}$$ $${1507.45}$$ < $${1576.85}$$ $${-0.01}$$ $${501.01}$$ < $${520.76}$$
✅ docker_agent_windows2022_core $${-0.33}$$ $${6190.8}$$ < $${6260.53}$$ $${0}$$ $${2048.0}$$ < $${2067.76}$$
✅ docker_agent_windows2022_core_jmx $${-0.25}$$ $${6312.69}$$ < $${6382.17}$$ $${0}$$ $${2048.0}$$ < $${2067.76}$$
✅ docker_agent_windows2022_jmx $${-0.1}$$ $${1629.05}$$ < $${1698.2}$$ $${+0.04}$$ $${543.28}$$ < $${562.99}$$
✅ docker_cluster_agent_amd64 $${-0}$$ $${259.22}$$ < $${259.73}$$ $${+0}$$ $${102.9}$$ < $${103.68}$$
✅ docker_cluster_agent_arm64 $${-0}$$ $${273.65}$$ < $${274.24}$$ $${-0}$$ $${97.58}$$ < $${98.45}$$
✅ docker_cws_instrumentation_amd64 $${0}$$ $${7.08}$$ < $${7.12}$$ $${-0}$$ $${2.95}$$ < $${3.29}$$
✅ docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${+0}$$ $${2.7}$$ < $${3.07}$$
✅ docker_dogstatsd_amd64 $${0}$$ $${38.93}$$ < $${39.57}$$ $${-0}$$ $${14.95}$$ < $${15.76}$$
✅ docker_dogstatsd_arm64 $${0}$$ $${37.52}$$ < $${38.2}$$ $${-0}$$ $${13.96}$$ < $${14.83}$$
✅ dogstatsd_deb_amd64 $${0}$$ $${30.61}$$ < $${31.52}$$ $${+0}$$ $${8.04}$$ < $${8.97}$$
✅ dogstatsd_deb_arm64 $${0}$$ $${29.16}$$ < $${30.08}$$ $${-0}$$ $${6.97}$$ < $${7.92}$$
✅ dogstatsd_rpm_amd64 $${0}$$ $${30.61}$$ < $${31.52}$$ $${+0}$$ $${8.04}$$ < $${8.98}$$
✅ dogstatsd_suse_amd64 $${0}$$ $${30.61}$$ < $${31.52}$$ $${+0}$$ $${8.04}$$ < $${8.98}$$
✅ iot_agent_deb_amd64 $${0}$$ $${50.49}$$ < $${60.17}$$ $${+0}$$ $${12.85}$$ < $${15.82}$$
✅ iot_agent_deb_arm64 $${0}$$ $${47.94}$$ < $${56.94}$$ $${+0}$$ $${11.15}$$ < $${13.86}$$
✅ iot_agent_deb_armhf $${0}$$ $${47.52}$$ < $${56.41}$$ $${-0.01}$$ $${11.2}$$ < $${13.86}$$
✅ iot_agent_rpm_amd64 $${0}$$ $${50.49}$$ < $${60.18}$$ $${-0}$$ $${12.87}$$ < $${15.84}$$
✅ iot_agent_rpm_arm64 $${0}$$ $${47.94}$$ < $${56.94}$$ $${-0}$$ $${11.16}$$ < $${13.76}$$
✅ iot_agent_suse_amd64 $${0}$$ $${50.49}$$ < $${60.18}$$ $${-0}$$ $${12.87}$$ < $${15.84}$$

@mrafi97 mrafi97 force-pushed the mrafi/win-cert-remote branch from cededa2 to 6a6cfe8 Compare June 10, 2025 19:10
@mrafi97 mrafi97 marked this pull request as ready for review June 10, 2025 19:12
@mrafi97 mrafi97 requested review from a team as code owners June 10, 2025 19:12
@mrafi97 mrafi97 added the ask-review Ask required teams to review this PR label Jun 10, 2025
iglendd
iglendd reviewed Jun 11, 2025
View reviewed changes
chouetz
chouetz approved these changes Jun 11, 2025
View reviewed changes
Copy link
Member

@chouetz chouetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for agent-devx files

@mrafi97 mrafi97 requested a review from iglendd June 11, 2025 19:37
@mrafi97 mrafi97 added the qa/done QA done before merge and regressions are covered by tests label Jun 11, 2025
iglendd
iglendd approved these changes Jun 12, 2025
View reviewed changes
Copy link
Contributor

@iglendd iglendd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

julien-lebot
julien-lebot reviewed Jun 12, 2025
View reviewed changes
Copy link
Contributor

@julien-lebot julien-lebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments

@github-actions github-actions bot added long review PR is complex, plan time to review it and removed medium review PR review might take time labels Jun 12, 2025
@mrafi97
Copy link
Contributor Author

mrafi97 commented Jun 13, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jun 13, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-06-13 00:09:01 UTC ℹ️ Start processing command /merge

2025-06-13 00:09:05 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 58m (p90).

2025-06-13 00:49:53 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit d9bfd7f into main Jun 13, 2025
376 checks passed
@dd-mergequeue dd-mergequeue bot deleted the mrafi/win-cert-remote branch June 13, 2025 00:49
@github-actions github-actions bot added this to the 7.68.0 milestone Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-lebot julien-lebot julien-lebot left review comments

@chouetz chouetz chouetz approved these changes

@michaelcretzman michaelcretzman michaelcretzman approved these changes

@iglendd iglendd iglendd approved these changes

Assignees
No one assigned
Labels
ask-review Ask required teams to review this PR long review PR is complex, plan time to review it qa/done QA done before merge and regressions are covered by tests team/windows-agent
Projects
None yet
Milestone
7.68.0
Development

Successfully merging this pull request may close these issues.
5 participants
@mrafi97 @julien-lebot @chouetz @michaelcretzman @iglendd