Skip to content

[CWS] remove kprobeOrFentry and kretprobeOrFexit #37732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2025
Merged

[CWS] remove kprobeOrFentry and kretprobeOrFexit #37732

merged 1 commit into from
Jun 10, 2025

Conversation

paulcacheux
Copy link
Contributor

@paulcacheux paulcacheux commented Jun 6, 2025 •
edited
Loading

What does this PR do?

This PR removes kprobeOrFentry and kretprobeOrFexit that basically do the same thing, in favor of a common simpler method that does the same for both. Another advantage of this cleanup is that all usage are now centralized around the usage of the function name directly -> meaning that searching for the function name shows all the usage of it.

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@cit-pr-commenter cit-pr-commenter
Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 2582b857-5691-40e9-b3ce-0b7bea4270db

Baseline: d51f461
Comparison: 2e845aa
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ quality_gate_logs % cpu utilization +1.40 [-1.36, +4.16] 1 Logs bounds checks dashboard
➖ docker_containers_memory memory utilization +1.23 [+1.16, +1.31] 1 Logs
➖ quality_gate_idle_all_features memory utilization +0.83 [+0.74, +0.92] 1 Logs bounds checks dashboard
➖ tcp_syslog_to_blackhole ingress throughput +0.57 [+0.51, +0.63] 1 Logs
➖ file_to_blackhole_0ms_latency_http2 egress throughput +0.14 [-0.50, +0.77] 1 Logs
➖ ddot_metrics memory utilization +0.10 [-0.02, +0.21] 1 Logs
➖ file_tree memory utilization +0.07 [-0.10, +0.24] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput +0.05 [-0.55, +0.65] 1 Logs
➖ file_to_blackhole_1000ms_latency_linear_load egress throughput +0.01 [-0.23, +0.24] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput +0.00 [-0.25, +0.25] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.02, +0.01] 1 Logs
➖ file_to_blackhole_300ms_latency egress throughput -0.00 [-0.63, +0.62] 1 Logs
➖ file_to_blackhole_0ms_latency_http1 egress throughput -0.01 [-0.63, +0.61] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput -0.01 [-0.61, +0.59] 1 Logs
➖ uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.05 [-0.10, -0.01] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput -0.08 [-0.66, +0.50] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput -0.12 [-0.72, +0.48] 1 Logs
➖ quality_gate_idle memory utilization -0.18 [-0.25, -0.12] 1 Logs bounds checks dashboard
➖ otlp_ingest_logs memory utilization -0.61 [-0.74, -0.49] 1 Logs
➖ uds_dogstatsd_to_api_cpu % cpu utilization -0.74 [-1.58, +0.11] 1 Logs
➖ otlp_ingest_metrics memory utilization -0.75 [-0.91, -0.58] 1 Logs
➖ ddot_logs memory utilization -0.86 [-0.99, -0.72] 1 Logs
➖ docker_containers_cpu % cpu utilization -3.70 [-6.77, -0.64] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
❌ docker_containers_memory memory_usage 0/10
✅ docker_containers_cpu simple_check_run 10/10
✅ docker_containers_memory simple_check_run 10/10
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http1 memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http2 memory_usage 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_300ms_latency lost_bytes 10/10
✅ file_to_blackhole_300ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr
Copy link
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor d51f461

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
✅ agent_deb_amd64 $${0}$$ $${696.03}$$ < $${752.99}$$ $${+0.01}$$ $${176.02}$$ < $${187.44}$$
✅ agent_deb_amd64_fips $${0}$$ $${694.26}$$ < $${751.36}$$ $${+0.01}$$ $${175.46}$$ < $${187.06}$$
✅ agent_heroku_amd64 $${0}$$ $${358.55}$$ < $${369.68}$$ $${+0}$$ $${96.5}$$ < $${99.55}$$
✅ agent_msi $${0}$$ $${959.83}$$ < $${987.01}$$ $${+0}$$ $${146.45}$$ < $${150.72}$$
✅ agent_rpm_amd64 $${0}$$ $${696.02}$$ < $${752.98}$$ $${-0}$$ $${177.55}$$ < $${190.03}$$
✅ agent_rpm_amd64_fips $${0}$$ $${694.25}$$ < $${751.35}$$ $${+0.02}$$ $${177.43}$$ < $${189.81}$$
✅ agent_rpm_arm64 $${-0}$$ $${685.97}$$ < $${739.42}$$ $${+0.02}$$ $${161.02}$$ < $${171.23}$$
✅ agent_rpm_arm64_fips $${-0}$$ $${684.32}$$ < $${737.91}$$ $${-0.02}$$ $${160.06}$$ < $${170.22}$$
✅ agent_suse_amd64 $${0}$$ $${696.02}$$ < $${752.98}$$ $${-0}$$ $${177.55}$$ < $${190.03}$$
✅ agent_suse_amd64_fips $${0}$$ $${694.25}$$ < $${751.35}$$ $${+0.02}$$ $${177.43}$$ < $${189.81}$$
✅ agent_suse_arm64 $${-0}$$ $${685.97}$$ < $${739.42}$$ $${+0.02}$$ $${161.02}$$ < $${171.23}$$
✅ agent_suse_arm64_fips $${-0}$$ $${684.32}$$ < $${737.91}$$ $${-0.02}$$ $${160.06}$$ < $${170.22}$$
✅ docker_agent_amd64 $${-0}$$ $${779.81}$$ < $${849.39}$$ $${+0.01}$$ $${268.6}$$ < $${288.34}$$
✅ docker_agent_arm64 $${-0}$$ $${793.22}$$ < $${858.97}$$ $${-0.01}$$ $${255.95}$$ < $${274.36}$$
✅ docker_agent_jmx_amd64 $${-0}$$ $${779.81}$$ < $${849.39}$$ $${+0.01}$$ $${268.6}$$ < $${288.34}$$
✅ docker_agent_jmx_arm64 $${-0}$$ $${793.22}$$ < $${858.97}$$ $${-0.01}$$ $${255.95}$$ < $${274.36}$$
✅ docker_agent_windows1809 $${-0}$$ $${779.81}$$ < $${849.39}$$ $${+0.01}$$ $${268.6}$$ < $${288.34}$$
✅ docker_agent_windows1809_core $${-0}$$ $${779.81}$$ < $${849.39}$$ $${+0.01}$$ $${268.6}$$ < $${288.34}$$
✅ docker_agent_windows1809_core_jmx $${-0}$$ $${779.81}$$ < $${849.39}$$ $${+0.01}$$ $${268.6}$$ < $${288.34}$$
✅ docker_agent_windows1809_jmx $${-0}$$ $${779.81}$$ < $${849.39}$$ $${+0.01}$$ $${268.6}$$ < $${288.34}$$
✅ docker_agent_windows2022 $${-0}$$ $${779.81}$$ < $${849.39}$$ $${+0.01}$$ $${268.6}$$ < $${288.34}$$
✅ docker_agent_windows2022_core $${-0}$$ $${779.81}$$ < $${849.39}$$ $${+0.01}$$ $${268.6}$$ < $${288.34}$$
✅ docker_agent_windows2022_core_jmx $${-0}$$ $${779.81}$$ < $${849.39}$$ $${+0.01}$$ $${268.6}$$ < $${288.34}$$
✅ docker_agent_windows2022_jmx $${-0}$$ $${779.81}$$ < $${849.39}$$ $${+0.01}$$ $${268.6}$$ < $${288.34}$$
✅ docker_cluster_agent_amd64 $${+0}$$ $${259.16}$$ < $${259.73}$$ $${-0}$$ $${102.86}$$ < $${103.68}$$
✅ docker_cluster_agent_arm64 $${+0}$$ $${273.57}$$ < $${274.24}$$ $${+0}$$ $${97.58}$$ < $${98.45}$$
✅ docker_cws_instrumentation_amd64 $${0}$$ $${7.08}$$ < $${7.12}$$ $${+0}$$ $${2.95}$$ < $${3.29}$$
✅ docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${-0}$$ $${2.7}$$ < $${3.07}$$
✅ docker_dogstatsd_amd64 $${0}$$ $${38.93}$$ < $${39.57}$$ $${-0}$$ $${14.95}$$ < $${15.76}$$
✅ docker_dogstatsd_arm64 $${0}$$ $${37.52}$$ < $${38.2}$$ $${-0}$$ $${13.97}$$ < $${14.83}$$
✅ dogstatsd_deb_amd64 $${0}$$ $${30.61}$$ < $${31.52}$$ $${+0}$$ $${8.03}$$ < $${8.97}$$
✅ dogstatsd_deb_arm64 $${0}$$ $${29.16}$$ < $${30.08}$$ $${-0}$$ $${6.97}$$ < $${7.92}$$
✅ dogstatsd_rpm_amd64 $${0}$$ $${30.61}$$ < $${31.52}$$ $${+0}$$ $${8.04}$$ < $${8.98}$$
✅ dogstatsd_suse_amd64 $${0}$$ $${30.61}$$ < $${31.52}$$ $${+0}$$ $${8.04}$$ < $${8.98}$$
✅ iot_agent_deb_amd64 $${0}$$ $${50.47}$$ < $${60.17}$$ $${+0}$$ $${12.84}$$ < $${15.82}$$
✅ iot_agent_deb_arm64 $${0}$$ $${47.93}$$ < $${56.94}$$ $${+0}$$ $${11.14}$$ < $${13.86}$$
✅ iot_agent_deb_armhf $${0}$$ $${47.51}$$ < $${56.41}$$ $${-0.01}$$ $${11.2}$$ < $${13.86}$$
✅ iot_agent_rpm_amd64 $${0}$$ $${50.47}$$ < $${60.18}$$ $${-0}$$ $${12.87}$$ < $${15.84}$$
✅ iot_agent_rpm_arm64 $${0}$$ $${47.93}$$ < $${56.94}$$ $${-0}$$ $${11.16}$$ < $${13.76}$$
✅ iot_agent_suse_amd64 $${0}$$ $${50.47}$$ < $${60.18}$$ $${-0}$$ $${12.87}$$ < $${15.84}$$

@paulcacheux paulcacheux added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests labels Jun 6, 2025
@paulcacheux paulcacheux marked this pull request as ready for review June 6, 2025 18:41
@paulcacheux paulcacheux requested a review from a team as a code owner June 6, 2025 18:41
@paulcacheux
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jun 10, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-06-10 07:22:08 UTC ℹ️ Start processing command /merge

2025-06-10 07:22:13 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 46m (p90).

2025-06-10 08:07:02 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 0dfd2c5 into main Jun 10, 2025
309 of 311 checks passed
@dd-mergequeue dd-mergequeue bot deleted the paulcacheux/remove-kprobe-or-fentry branch June 10, 2025 08:07
@github-actions github-actions bot added this to the 7.68.0 milestone Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spikat spikat spikat approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog component/system-probe medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/agent-security
Projects
None yet
Milestone
7.68.0
Development

Successfully merging this pull request may close these issues.
2 participants
@paulcacheux @spikat