APM: Only check for RC metrics in e2e tests outside FIPS (APMSP-2079) #37739

ajgajg1134 · 2025-06-06T18:36:11Z

What does this PR do?

Resolves test failures in e2e tests where we expect metrics from the RC client, however for the FIPS agent that feature is disabled thereby breaking these tests. When that feature is enabled for fips we can remove this check (and this test should start to fail as the metrics will appear again :) )

Motivation

broke tests are no fun

Describe how you validated your changes

Validation via the tests passing

Possible Drawbacks / Trade-offs

Additional Notes

cit-pr-commenter · 2025-06-06T19:39:25Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 97763407-d638-41cc-a9b5-8feb6f648ce8

Baseline: cbd7198
Comparison: b0f0ccd
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	+2.65	[-0.37, +5.66]	1	Logs
➖	docker_containers_memory	memory utilization	+1.51	[+1.38, +1.65]	1	Logs
➖	ddot_metrics	memory utilization	+0.46	[+0.34, +0.57]	1	Logs
➖	quality_gate_idle	memory utilization	+0.19	[+0.13, +0.25]	1	Logs bounds checks dashboard
➖	otlp_ingest_logs	memory utilization	+0.12	[-0.01, +0.25]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.10	[-0.49, +0.69]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.07	[-0.57, +0.72]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	+0.01	[-0.22, +0.25]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	-0.00	[-0.65, +0.65]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.27, +0.26]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.01	[-0.03, +0.01]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	-0.01	[-0.59, +0.57]	1	Logs
➖	file_tree	memory utilization	-0.01	[-0.16, +0.13]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-0.02	[-0.09, +0.04]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	-0.02	[-0.08, +0.03]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	-0.03	[-0.63, +0.57]	1	Logs
➖	ddot_logs	memory utilization	-0.03	[-0.17, +0.11]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.04	[-0.62, +0.54]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.06	[-0.62, +0.50]	1	Logs
➖	otlp_ingest_metrics	memory utilization	-0.28	[-0.45, -0.12]	1	Logs
➖	quality_gate_logs	% cpu utilization	-0.71	[-3.47, +2.05]	1	Logs bounds checks dashboard
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-0.79	[-1.66, +0.08]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	-1.38	[-1.46, -1.30]	1	Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	docker_containers_cpu	simple_check_run	10/10
✅	docker_containers_memory	memory_usage	10/10
✅	docker_containers_memory	simple_check_run	10/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

agent-platform-auto-pr · 2025-06-06T20:21:03Z

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor cbd7198

Successful checks

Info

	Quality gate	Delta	On disk size (MiB)	Delta	On wire size (MiB)
✅	agent_deb_amd64	$${0}$$	$${696.04}$$ < $${752.99}$$	$${-0}$$	$${176.02}$$ < $${187.44}$$
✅	agent_deb_amd64_fips	$${0}$$	$${694.26}$$ < $${751.36}$$	$${-0.04}$$	$${175.42}$$ < $${187.06}$$
✅	agent_heroku_amd64	$${0}$$	$${358.56}$$ < $${369.68}$$	$${+0}$$	$${96.5}$$ < $${99.55}$$
✅	agent_msi	$${0}$$	$${959.85}$$ < $${987.01}$$	$${+0.02}$$	$${146.45}$$ < $${150.72}$$
✅	agent_rpm_amd64	$${0}$$	$${696.03}$$ < $${752.98}$$	$${+0.04}$$	$${177.53}$$ < $${190.03}$$
✅	agent_rpm_amd64_fips	$${0}$$	$${694.25}$$ < $${751.35}$$	$${+0.03}$$	$${177.42}$$ < $${189.81}$$
✅	agent_rpm_arm64	$${0}$$	$${685.98}$$ < $${739.42}$$	$${+0.02}$$	$${161.01}$$ < $${171.23}$$
✅	agent_rpm_arm64_fips	$${0}$$	$${684.33}$$ < $${737.91}$$	$${-0}$$	$${160.08}$$ < $${170.22}$$
✅	agent_suse_amd64	$${0}$$	$${696.03}$$ < $${752.98}$$	$${+0.04}$$	$${177.53}$$ < $${190.03}$$
✅	agent_suse_amd64_fips	$${0}$$	$${694.25}$$ < $${751.35}$$	$${+0.03}$$	$${177.42}$$ < $${189.81}$$
✅	agent_suse_arm64	$${0}$$	$${685.98}$$ < $${739.42}$$	$${+0.02}$$	$${161.01}$$ < $${171.23}$$
✅	agent_suse_arm64_fips	$${0}$$	$${684.33}$$ < $${737.91}$$	$${-0}$$	$${160.08}$$ < $${170.22}$$
✅	docker_agent_amd64	$${+0}$$	$${779.82}$$ < $${849.39}$$	$${-0}$$	$${268.58}$$ < $${288.34}$$
✅	docker_agent_arm64	$${-0}$$	$${793.23}$$ < $${858.97}$$	$${+0}$$	$${255.97}$$ < $${274.36}$$
✅	docker_agent_jmx_amd64	$${+0}$$	$${779.82}$$ < $${849.39}$$	$${-0}$$	$${268.58}$$ < $${288.34}$$
✅	docker_agent_jmx_arm64	$${-0}$$	$${793.23}$$ < $${858.97}$$	$${+0}$$	$${255.97}$$ < $${274.36}$$
✅	docker_agent_windows1809	$${+0}$$	$${779.82}$$ < $${849.39}$$	$${-0}$$	$${268.58}$$ < $${288.34}$$
✅	docker_agent_windows1809_core	$${+0}$$	$${779.82}$$ < $${849.39}$$	$${-0}$$	$${268.58}$$ < $${288.34}$$
✅	docker_agent_windows1809_core_jmx	$${+0}$$	$${779.82}$$ < $${849.39}$$	$${-0}$$	$${268.58}$$ < $${288.34}$$
✅	docker_agent_windows1809_jmx	$${+0}$$	$${779.82}$$ < $${849.39}$$	$${-0}$$	$${268.58}$$ < $${288.34}$$
✅	docker_agent_windows2022	$${+0}$$	$${779.82}$$ < $${849.39}$$	$${-0}$$	$${268.58}$$ < $${288.34}$$
✅	docker_agent_windows2022_core	$${+0}$$	$${779.82}$$ < $${849.39}$$	$${-0}$$	$${268.58}$$ < $${288.34}$$
✅	docker_agent_windows2022_core_jmx	$${+0}$$	$${779.82}$$ < $${849.39}$$	$${-0}$$	$${268.58}$$ < $${288.34}$$
✅	docker_agent_windows2022_jmx	$${+0}$$	$${779.82}$$ < $${849.39}$$	$${-0}$$	$${268.58}$$ < $${288.34}$$
✅	docker_cluster_agent_amd64	$${+0}$$	$${259.18}$$ < $${259.73}$$	$${-0}$$	$${102.88}$$ < $${103.68}$$
✅	docker_cluster_agent_arm64	$${0}$$	$${273.58}$$ < $${274.24}$$	$${-0}$$	$${97.59}$$ < $${98.45}$$
✅	docker_cws_instrumentation_amd64	$${0}$$	$${7.08}$$ < $${7.12}$$	$${-0}$$	$${2.95}$$ < $${3.29}$$
✅	docker_cws_instrumentation_arm64	$${0}$$	$${6.69}$$ < $${6.92}$$	$${-0}$$	$${2.7}$$ < $${3.07}$$
✅	docker_dogstatsd_amd64	$${+0}$$	$${38.93}$$ < $${39.57}$$	$${+0}$$	$${14.95}$$ < $${15.76}$$
✅	docker_dogstatsd_arm64	$${0}$$	$${37.52}$$ < $${38.2}$$	$${-0}$$	$${13.96}$$ < $${14.83}$$
✅	dogstatsd_deb_amd64	$${0}$$	$${30.61}$$ < $${31.52}$$	$${-0}$$	$${8.03}$$ < $${8.97}$$
✅	dogstatsd_deb_arm64	$${0}$$	$${29.16}$$ < $${30.08}$$	$${-0}$$	$${6.97}$$ < $${7.92}$$
✅	dogstatsd_rpm_amd64	$${0}$$	$${30.61}$$ < $${31.52}$$	$${+0}$$	$${8.04}$$ < $${8.98}$$
✅	dogstatsd_suse_amd64	$${0}$$	$${30.61}$$ < $${31.52}$$	$${+0}$$	$${8.04}$$ < $${8.98}$$
✅	iot_agent_deb_amd64	$${0}$$	$${50.48}$$ < $${60.17}$$	$${-0}$$	$${12.85}$$ < $${15.82}$$
✅	iot_agent_deb_arm64	$${0}$$	$${47.93}$$ < $${56.94}$$	$${-0}$$	$${11.14}$$ < $${13.86}$$
✅	iot_agent_deb_armhf	$${0}$$	$${47.51}$$ < $${56.41}$$	$${+0}$$	$${11.21}$$ < $${13.86}$$
✅	iot_agent_rpm_amd64	$${0}$$	$${50.48}$$ < $${60.18}$$	$${+0}$$	$${12.86}$$ < $${15.84}$$
✅	iot_agent_rpm_arm64	$${0}$$	$${47.94}$$ < $${56.94}$$	$${+0}$$	$${11.16}$$ < $${13.76}$$
✅	iot_agent_suse_amd64	$${0}$$	$${50.48}$$ < $${60.18}$$	$${+0}$$	$${12.86}$$ < $${15.84}$$

ajgajg1134 · 2025-06-09T17:30:08Z

/merge

dd-devflow · 2025-06-09T17:30:12Z

View all feedbacks in Devflow UI.

2025-06-09 17:30:11 UTC ℹ️ Start processing command /merge

2025-06-09 17:30:17 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 47m (p90).

2025-06-09 18:07:13 UTC ℹ️ MergeQueue: This merge request was merged

APM: Only check for RC metrics in e2e tests outside FIPS

0f57017

ajgajg1134 requested a review from a team as a code owner June 6, 2025 18:36

ajgajg1134 added changelog/no-changelog team/agent-apm trace-agent qa/done QA done before merge and regressions are covered by tests labels Jun 6, 2025

github-actions bot added the short review PR is simple enough to be reviewed quickly label Jun 6, 2025

Merge branch 'main' into andrew.glaude/e2eFips

2c602ac

ichinaski approved these changes Jun 9, 2025

View reviewed changes

Merge branch 'main' into andrew.glaude/e2eFips

b0f0ccd

dd-mergequeue bot merged commit 0560e01 into main Jun 9, 2025
225 checks passed

dd-mergequeue bot deleted the andrew.glaude/e2eFips branch June 9, 2025 18:07

github-actions bot added this to the 7.68.0 milestone Jun 9, 2025

ajgajg1134 changed the title ~~APM: Only check for RC metrics in e2e tests outside FIPS~~ APM: Only check for RC metrics in e2e tests outside FIPS (APMSP-2079) Jun 9, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

APM: Only check for RC metrics in e2e tests outside FIPS (APMSP-2079) #37739

APM: Only check for RC metrics in e2e tests outside FIPS (APMSP-2079) #37739

Uh oh!

ajgajg1134 commented Jun 6, 2025 •

edited

Loading

Uh oh!

cit-pr-commenter bot commented Jun 6, 2025 •

edited

Loading

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

Uh oh!

agent-platform-auto-pr bot commented Jun 6, 2025 •

edited

Loading

Info

Uh oh!

ajgajg1134 commented Jun 9, 2025

Uh oh!

dd-devflow bot commented Jun 9, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

APM: Only check for RC metrics in e2e tests outside FIPS (APMSP-2079) #37739

APM: Only check for RC metrics in e2e tests outside FIPS (APMSP-2079) #37739

Uh oh!

Conversation

ajgajg1134 commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

Uh oh!

cit-pr-commenter bot commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

CI Pass/Fail Decision

Uh oh!

agent-platform-auto-pr bot commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Static quality checks

Info

Uh oh!

ajgajg1134 commented Jun 9, 2025

Uh oh!

dd-devflow bot commented Jun 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ajgajg1134 commented Jun 6, 2025 •

edited

Loading

cit-pr-commenter bot commented Jun 6, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Jun 6, 2025 •

edited

Loading

dd-devflow bot commented Jun 9, 2025 •

edited

Loading