[dyninst] Testing expansion #37744

piob-io · 2025-06-06T21:13:56Z

What does this PR do?

Share probe configs across tests.
Add snapshot test for compiler, dropping old, temporary test.
Merge simple and events_simple testprogs, they end up being almost the same.
Fix arm cfa offset calculation, exposed by more test cases.

Motivation

https://datadoghq.atlassian.net/browse/DEBUG-3887

ajwerner

🚢 🇮🇹

Seeing the generated code makes it so clear we should find a way to just stick this into const data maps and stop compiling on the host

ajwerner · 2025-06-06T21:44:36Z

pkg/dyninst/compiler/testdata/snapshot/simple.arch=amd64,toolchain=go1.24.3.c

+		SM_OP_PREPARE_EVENT_ROOT, 0x2a, 0x00, 0x00, 0x00, 0x09, 0x00, 0x00, 0x00, 
+		SM_OP_CALL, 0x9b, 0x00, 0x00, 0x00, // ProcessExpression[Probe[main.inlined]@0x491c66.expr[0]]
+		SM_OP_RETURN, 
+		SM_OP_ILLEGAL, 


nit: inject some commentary around the padding?

cit-pr-commenter · 2025-06-06T22:23:13Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: de3a5177-d751-4412-8804-9c808e7396ae

Baseline: 6e862a9
Comparison: c696732
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_idle_all_features	memory utilization	+0.72	[+0.63, +0.81]	1	Logs bounds checks dashboard
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.64	[-0.21, +1.48]	1	Logs
➖	otlp_ingest_logs	memory utilization	+0.48	[+0.35, +0.60]	1	Logs
➖	quality_gate_idle	memory utilization	+0.32	[+0.26, +0.38]	1	Logs bounds checks dashboard
➖	file_tree	memory utilization	+0.25	[+0.10, +0.40]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	+0.15	[+0.10, +0.19]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.11	[-0.46, +0.68]	1	Logs
➖	quality_gate_logs	% cpu utilization	+0.08	[-2.65, +2.82]	1	Logs bounds checks dashboard
➖	file_to_blackhole_0ms_latency_http2	egress throughput	+0.05	[-0.55, +0.65]	1	Logs
➖	ddot_metrics	memory utilization	+0.03	[-0.09, +0.15]	1	Logs
➖	ddot_logs	memory utilization	+0.00	[-0.14, +0.15]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.01, +0.02]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	+0.00	[-0.23, +0.24]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.29, +0.28]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.04	[-0.63, +0.55]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.04	[-0.67, +0.58]	1	Logs
➖	docker_containers_memory	memory utilization	-0.05	[-0.13, +0.03]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.06	[-0.69, +0.57]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	-0.06	[-0.64, +0.51]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	-0.09	[-0.70, +0.52]	1	Logs
➖	otlp_ingest_metrics	memory utilization	-0.16	[-0.32, +0.00]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-1.44	[-1.50, -1.37]	1	Logs
➖	docker_containers_cpu	% cpu utilization	-3.11	[-6.10, -0.11]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	docker_containers_cpu	simple_check_run	10/10
✅	docker_containers_memory	memory_usage	10/10
✅	docker_containers_memory	simple_check_run	10/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

agent-platform-auto-pr · 2025-06-07T12:58:43Z

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 6e862a9

Successful checks

Info

	Quality gate	Delta	On disk size (MiB)	Delta	On wire size (MiB)
✅	agent_deb_amd64	$${+0}$$	$${695.71}$$ < $${752.99}$$	$${+0.04}$$	$${175.93}$$ < $${187.44}$$
✅	agent_deb_amd64_fips	$${+0}$$	$${693.93}$$ < $${751.36}$$	$${+0.04}$$	$${175.61}$$ < $${187.06}$$
✅	agent_heroku_amd64	$${0}$$	$${358.21}$$ < $${369.68}$$	$${-0.01}$$	$${96.44}$$ < $${99.55}$$
✅	agent_msi	$${0}$$	$${957.72}$$ < $${987.01}$$	$${-0.02}$$	$${146.11}$$ < $${150.72}$$
✅	agent_rpm_amd64	$${+0}$$	$${695.7}$$ < $${752.98}$$	$${+0.01}$$	$${177.51}$$ < $${190.03}$$
✅	agent_rpm_amd64_fips	$${+0}$$	$${693.91}$$ < $${751.35}$$	$${+0.01}$$	$${177.34}$$ < $${189.81}$$
✅	agent_rpm_arm64	$${+0}$$	$${685.7}$$ < $${739.42}$$	$${-0.01}$$	$${160.83}$$ < $${171.23}$$
✅	agent_rpm_arm64_fips	$${+0}$$	$${684.05}$$ < $${737.91}$$	$${-0.05}$$	$${160.0}$$ < $${170.22}$$
✅	agent_suse_amd64	$${+0}$$	$${695.7}$$ < $${752.98}$$	$${+0.01}$$	$${177.51}$$ < $${190.03}$$
✅	agent_suse_amd64_fips	$${+0}$$	$${693.91}$$ < $${751.35}$$	$${+0.01}$$	$${177.34}$$ < $${189.81}$$
✅	agent_suse_arm64	$${+0}$$	$${685.7}$$ < $${739.42}$$	$${-0.01}$$	$${160.83}$$ < $${171.23}$$
✅	agent_suse_arm64_fips	$${+0}$$	$${684.05}$$ < $${737.91}$$	$${-0.05}$$	$${160.0}$$ < $${170.22}$$
✅	docker_agent_amd64	$${+0}$$	$${779.5}$$ < $${849.39}$$	$${-0}$$	$${268.44}$$ < $${288.34}$$
✅	docker_agent_arm64	$${+0}$$	$${792.95}$$ < $${858.97}$$	$${+0}$$	$${255.83}$$ < $${274.36}$$
✅	docker_agent_jmx_amd64	$${+0}$$	$${970.69}$$ < $${1040.59}$$	$${+0.01}$$	$${337.43}$$ < $${357.3}$$
✅	docker_agent_jmx_arm64	$${+0}$$	$${972.75}$$ < $${1038.77}$$	$${-0}$$	$${320.78}$$ < $${339.32}$$
✅	docker_agent_windows1809	$${-0.01}$$	$${1485.82}$$ < $${1557.19}$$	$${-0.11}$$	$${487.61}$$ < $${507.33}$$
✅	docker_agent_windows1809_core	$${-0}$$	$${6215.77}$$ < $${6287.46}$$	$${0}$$	$${2048.0}$$ < $${2067.76}$$
✅	docker_agent_windows1809_core_jmx	$${+22.12}$$	$${6359.67}$$ < $${6409.04}$$	$${0}$$	$${2048.0}$$ < $${2067.76}$$
✅	docker_agent_windows1809_jmx	$${+0.07}$$	$${1607.45}$$ < $${1679.14}$$	$${-0.07}$$	$${529.86}$$ < $${550.27}$$
✅	docker_agent_windows2022	$${+0.13}$$	$${1505.28}$$ < $${1576.85}$$	$${+0.03}$$	$${500.41}$$ < $${520.76}$$
✅	docker_agent_windows2022_core	$${+0}$$	$${6189.06}$$ < $${6260.53}$$	$${0}$$	$${2048.0}$$ < $${2067.76}$$
✅	docker_agent_windows2022_core_jmx	$${+0.02}$$	$${6310.72}$$ < $${6382.17}$$	$${0}$$	$${2048.0}$$ < $${2067.76}$$
✅	docker_agent_windows2022_jmx	$${-0.24}$$	$${1626.72}$$ < $${1698.2}$$	$${-0.01}$$	$${542.63}$$ < $${562.99}$$
✅	docker_cluster_agent_amd64	$${+0}$$	$${212.79}$$ < $${259.73}$$	$${-0}$$	$${72.36}$$ < $${103.68}$$
✅	docker_cluster_agent_arm64	$${+0}$$	$${228.68}$$ < $${274.24}$$	$${+0}$$	$${68.63}$$ < $${98.45}$$
✅	docker_cws_instrumentation_amd64	$${0}$$	$${7.08}$$ < $${7.12}$$	$${+0}$$	$${2.95}$$ < $${3.29}$$
✅	docker_cws_instrumentation_arm64	$${0}$$	$${6.69}$$ < $${6.92}$$	$${+0}$$	$${2.7}$$ < $${3.07}$$
✅	docker_dogstatsd_amd64	$${0}$$	$${39.21}$$ < $${39.57}$$	$${-0}$$	$${15.11}$$ < $${15.76}$$
✅	docker_dogstatsd_arm64	$${+0}$$	$${37.88}$$ < $${38.2}$$	$${+0}$$	$${14.54}$$ < $${14.83}$$
✅	dogstatsd_deb_amd64	$${0}$$	$${30.44}$$ < $${31.52}$$	$${+0}$$	$${7.99}$$ < $${8.97}$$
✅	dogstatsd_deb_arm64	$${0}$$	$${29.01}$$ < $${30.08}$$	$${+0}$$	$${6.94}$$ < $${7.92}$$
✅	dogstatsd_rpm_amd64	$${0}$$	$${30.44}$$ < $${31.52}$$	$${+0}$$	$${8.0}$$ < $${8.98}$$
✅	dogstatsd_suse_amd64	$${0}$$	$${30.44}$$ < $${31.52}$$	$${+0}$$	$${8.0}$$ < $${8.98}$$
✅	iot_agent_deb_amd64	$${0}$$	$${50.31}$$ < $${60.17}$$	$${+0}$$	$${12.81}$$ < $${15.82}$$
✅	iot_agent_deb_arm64	$${0}$$	$${47.78}$$ < $${56.94}$$	$${+0}$$	$${11.11}$$ < $${13.86}$$
✅	iot_agent_deb_armhf	$${0}$$	$${47.35}$$ < $${56.41}$$	$${-0.01}$$	$${11.17}$$ < $${13.86}$$
✅	iot_agent_rpm_amd64	$${0}$$	$${50.31}$$ < $${60.18}$$	$${+0}$$	$${12.82}$$ < $${15.84}$$
✅	iot_agent_rpm_arm64	$${0}$$	$${47.78}$$ < $${56.94}$$	$${+0}$$	$${11.13}$$ < $${13.76}$$
✅	iot_agent_suse_amd64	$${0}$$	$${50.31}$$ < $${60.18}$$	$${+0}$$	$${12.82}$$ < $${15.84}$$

piob-io · 2025-06-09T16:19:38Z

/merge

dd-devflow · 2025-06-09T16:19:42Z

View all feedbacks in Devflow UI.

2025-06-09 16:19:42 UTC ℹ️ Start processing command /merge

2025-06-09 16:20:12 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-06-09 20:21:03 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

tylfin · 2025-06-09T16:47:05Z

pkg/dyninst/compiler/snapshot_test.go

+	rewrite, _ := strconv.ParseBool(os.Getenv("REWRITE"))
+	return rewrite
+}()
+var rewrite = flag.Bool("rewrite", rewriteFromEnv, "rewrite the test files")


I'm surprised there isn't some existing machinery for snapshots, golden files, and rewrites already?

There definitely are, not sure how popular within datadog. However, we are looking for something really simple, while knowing exactly how we want to manage these files. I think a bar to use a framework has not been reached.

piob-io · 2025-06-09T18:01:18Z

/merge

dd-devflow · 2025-06-09T18:01:22Z

View all feedbacks in Devflow UI.

2025-06-09 18:01:21 UTC ℹ️ Start processing command /merge

2025-06-09 18:01:23 UTC ❌ MergeQueue

PR already in the queue with status waiting

Loading is testing in integration test. For compiler test it's worth seeing the generated code.

piob-io · 2025-06-11T19:01:05Z

/merge

dd-devflow · 2025-06-11T19:01:09Z

View all feedbacks in Devflow UI.

2025-06-11 19:01:08 UTC ℹ️ Start processing command /merge

2025-06-11 19:01:16 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-06-11 19:45:09 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 52m (p90).

2025-06-11 20:24:07 UTC ℹ️ MergeQueue: This merge request was merged

piob-io requested a review from a team as a code owner June 6, 2025 21:13

piob-io changed the title ~~Piob io/dyninst testing~~ [dyninst] Testing changes Jun 6, 2025

piob-io force-pushed the piob-io/dyninst-testing branch from 5488e33 to 2739c32 Compare June 6, 2025 21:27

piob-io added changelog/no-changelog team/dynamic-instrumentation Dynamic Instrumentation qa/done QA done before merge and regressions are covered by tests labels Jun 6, 2025

piob-io changed the title ~~[dyninst] Testing changes~~ [dyninst] Testing expansion Jun 6, 2025

piob-io force-pushed the piob-io/dyninst-testing branch from 2739c32 to 6a12148 Compare June 6, 2025 21:38

ajwerner approved these changes Jun 6, 2025

View reviewed changes

github-actions bot added the long review PR is complex, plan time to review it label Jun 6, 2025

piob-io force-pushed the piob-io/inlined branch from 8e2d6bc to e8142c6 Compare June 6, 2025 22:18

piob-io force-pushed the piob-io/inlined branch from e8142c6 to 9a4fa78 Compare June 6, 2025 22:26

piob-io force-pushed the piob-io/dyninst-testing branch 2 times, most recently from 6ef843b to 7aa430b Compare June 6, 2025 22:42

piob-io force-pushed the piob-io/inlined branch from 9a4fa78 to 461e518 Compare June 7, 2025 11:18

piob-io force-pushed the piob-io/dyninst-testing branch from 7aa430b to b299da6 Compare June 7, 2025 11:18

piob-io force-pushed the piob-io/inlined branch from 461e518 to a23e266 Compare June 9, 2025 13:40

piob-io force-pushed the piob-io/dyninst-testing branch from b299da6 to 83ab8a0 Compare June 9, 2025 13:40

Base automatically changed from piob-io/inlined to main June 9, 2025 16:17

piob-io force-pushed the piob-io/dyninst-testing branch from 83ab8a0 to b137bb4 Compare June 9, 2025 16:19

tylfin reviewed Jun 9, 2025

View reviewed changes

piob-io force-pushed the piob-io/dyninst-testing branch from b137bb4 to 689913d Compare June 9, 2025 18:00

piob-io added 2 commits June 11, 2025 13:50

[dyninst/testprogs] Share test probes configs

cef8158

[dyninst/compiler] Replace compile test with snapshot test

6f2127c

Loading is testing in integration test. For compiler test it's worth seeing the generated code.

piob-io added 3 commits June 11, 2025 13:50

[dyninst] Merge simple and events_simple testprogs.

e5f5b8f

[dyninst/compiler/codegen] Comment on illegal ops padding

450d759

[dyninst/ebpf] Fix cfa calculation on arm.

c696732

piob-io force-pushed the piob-io/dyninst-testing branch from 738cc84 to c696732 Compare June 11, 2025 17:50

dd-mergequeue bot merged commit 87ebaad into main Jun 11, 2025
317 checks passed

dd-mergequeue bot deleted the piob-io/dyninst-testing branch June 11, 2025 20:24

github-actions bot added this to the 7.68.0 milestone Jun 11, 2025

[dyninst] Testing expansion #37744

[dyninst] Testing expansion #37744

Uh oh!

Conversation

piob-io commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Uh oh!

ajwerner left a comment

Choose a reason for hiding this comment

Uh oh!

ajwerner Jun 6, 2025

Choose a reason for hiding this comment

Uh oh!

piob-io Jun 6, 2025

Choose a reason for hiding this comment

Uh oh!

cit-pr-commenter bot commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

CI Pass/Fail Decision

Uh oh!

agent-platform-auto-pr bot commented Jun 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Static quality checks

Info

Uh oh!

piob-io commented Jun 9, 2025

Uh oh!

dd-devflow bot commented Jun 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tylfin Jun 9, 2025

Choose a reason for hiding this comment

Uh oh!

piob-io Jun 9, 2025

Choose a reason for hiding this comment

Uh oh!

piob-io commented Jun 9, 2025

Uh oh!

dd-devflow bot commented Jun 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

piob-io commented Jun 11, 2025

Uh oh!

dd-devflow bot commented Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

piob-io commented Jun 6, 2025 •

edited

Loading

cit-pr-commenter bot commented Jun 6, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Jun 7, 2025 •

edited

Loading

dd-devflow bot commented Jun 9, 2025 •

edited

Loading

dd-devflow bot commented Jun 9, 2025 •

edited

Loading

dd-devflow bot commented Jun 11, 2025 •

edited

Loading