Skip to content

[AGENTCFG-268] Adding comma and space-supported delimitation for DD_PROXY_NO_PROXY #37756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 11, 2025
Merged

[AGENTCFG-268] Adding comma and space-supported delimitation for DD_PROXY_NO_PROXY #37756

merged 3 commits into from
Jun 11, 2025

Conversation

rahulkaukuntla
Copy link
Contributor

@rahulkaukuntla rahulkaukuntla commented Jun 9, 2025 •
edited
Loading

What does this PR do?

The DD_PROXY_NO_PROXY environment variable currently gets split on spaces, as specified in the config template. However the public docs says that it is split on commas. We should support both ways.

Motivation

Describe how you validated your changes

Unit testing is sufficient.

Possible Drawbacks / Trade-offs

Additional Notes

@github-actions github-actions bot added short review PR is simple enough to be reviewed quickly team/agent-configuration labels Jun 9, 2025
@rahulkaukuntla rahulkaukuntla added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests labels Jun 9, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jun 9, 2025 •
edited
Loading

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 9d6ecd4

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
✅ agent_deb_amd64 $${0}$$ $${696.06}$$ < $${752.99}$$ $${-0.02}$$ $${176.04}$$ < $${187.44}$$
✅ agent_deb_amd64_fips $${0}$$ $${694.29}$$ < $${751.36}$$ $${+0}$$ $${175.51}$$ < $${187.06}$$
✅ agent_heroku_amd64 $${0}$$ $${358.56}$$ < $${369.68}$$ $${-0.01}$$ $${96.5}$$ < $${99.55}$$
✅ agent_msi $${+0}$$ $${959.88}$$ < $${987.01}$$ $${+0.02}$$ $${146.45}$$ < $${150.72}$$
✅ agent_rpm_amd64 $${0}$$ $${696.05}$$ < $${752.98}$$ $${-0.05}$$ $${177.54}$$ < $${190.03}$$
✅ agent_rpm_amd64_fips $${0}$$ $${694.28}$$ < $${751.35}$$ $${-0.02}$$ $${177.42}$$ < $${189.81}$$
✅ agent_rpm_arm64 $${0}$$ $${686.0}$$ < $${739.42}$$ $${+0.03}$$ $${161.06}$$ < $${171.23}$$
✅ agent_rpm_arm64_fips $${+0}$$ $${684.36}$$ < $${737.91}$$ $${-0.02}$$ $${160.09}$$ < $${170.22}$$
✅ agent_suse_amd64 $${0}$$ $${696.05}$$ < $${752.98}$$ $${-0.05}$$ $${177.54}$$ < $${190.03}$$
✅ agent_suse_amd64_fips $${0}$$ $${694.28}$$ < $${751.35}$$ $${-0.02}$$ $${177.42}$$ < $${189.81}$$
✅ agent_suse_arm64 $${0}$$ $${686.0}$$ < $${739.42}$$ $${+0.03}$$ $${161.06}$$ < $${171.23}$$
✅ agent_suse_arm64_fips $${+0}$$ $${684.36}$$ < $${737.91}$$ $${-0.02}$$ $${160.09}$$ < $${170.22}$$
✅ docker_agent_amd64 $${+0}$$ $${779.85}$$ < $${849.39}$$ $${+0.01}$$ $${268.6}$$ < $${288.34}$$
✅ docker_agent_arm64 $${-0}$$ $${793.25}$$ < $${858.97}$$ $${-0}$$ $${255.98}$$ < $${274.36}$$
✅ docker_agent_jmx_amd64 $${+0}$$ $${779.85}$$ < $${849.39}$$ $${+0.01}$$ $${268.6}$$ < $${288.34}$$
✅ docker_agent_jmx_arm64 $${-0}$$ $${793.25}$$ < $${858.97}$$ $${-0}$$ $${255.98}$$ < $${274.36}$$
✅ docker_agent_windows1809 $${+0}$$ $${779.85}$$ < $${849.39}$$ $${+0.01}$$ $${268.6}$$ < $${288.34}$$
✅ docker_agent_windows1809_core $${+0}$$ $${779.85}$$ < $${849.39}$$ $${+0.01}$$ $${268.6}$$ < $${288.34}$$
✅ docker_agent_windows1809_core_jmx $${+0}$$ $${779.85}$$ < $${849.39}$$ $${+0.01}$$ $${268.6}$$ < $${288.34}$$
✅ docker_agent_windows1809_jmx $${+0}$$ $${779.85}$$ < $${849.39}$$ $${+0.01}$$ $${268.6}$$ < $${288.34}$$
✅ docker_agent_windows2022 $${+0}$$ $${779.85}$$ < $${849.39}$$ $${+0.01}$$ $${268.6}$$ < $${288.34}$$
✅ docker_agent_windows2022_core $${+0}$$ $${779.85}$$ < $${849.39}$$ $${+0.01}$$ $${268.6}$$ < $${288.34}$$
✅ docker_agent_windows2022_core_jmx $${+0}$$ $${779.85}$$ < $${849.39}$$ $${+0.01}$$ $${268.6}$$ < $${288.34}$$
✅ docker_agent_windows2022_jmx $${+0}$$ $${779.85}$$ < $${849.39}$$ $${+0.01}$$ $${268.6}$$ < $${288.34}$$
✅ docker_cluster_agent_amd64 $${+0}$$ $${259.22}$$ < $${259.73}$$ $${-0}$$ $${102.9}$$ < $${103.68}$$
✅ docker_cluster_agent_arm64 $${+0}$$ $${273.65}$$ < $${274.24}$$ $${+0}$$ $${97.59}$$ < $${98.45}$$
✅ docker_cws_instrumentation_amd64 $${0}$$ $${7.08}$$ < $${7.12}$$ $${+0}$$ $${2.95}$$ < $${3.29}$$
✅ docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${-0}$$ $${2.7}$$ < $${3.07}$$
✅ docker_dogstatsd_amd64 $${0}$$ $${38.93}$$ < $${39.57}$$ $${+0}$$ $${14.95}$$ < $${15.76}$$
✅ docker_dogstatsd_arm64 $${+0}$$ $${37.52}$$ < $${38.2}$$ $${+0}$$ $${13.97}$$ < $${14.83}$$
✅ dogstatsd_deb_amd64 $${0}$$ $${30.61}$$ < $${31.52}$$ $${+0}$$ $${8.03}$$ < $${8.97}$$
✅ dogstatsd_deb_arm64 $${0}$$ $${29.16}$$ < $${30.08}$$ $${+0}$$ $${6.97}$$ < $${7.92}$$
✅ dogstatsd_rpm_amd64 $${0}$$ $${30.61}$$ < $${31.52}$$ $${-0}$$ $${8.05}$$ < $${8.98}$$
✅ dogstatsd_suse_amd64 $${0}$$ $${30.61}$$ < $${31.52}$$ $${-0}$$ $${8.05}$$ < $${8.98}$$
✅ iot_agent_deb_amd64 $${0}$$ $${50.49}$$ < $${60.17}$$ $${+0}$$ $${12.85}$$ < $${15.82}$$
✅ iot_agent_deb_arm64 $${0}$$ $${47.94}$$ < $${56.94}$$ $${-0}$$ $${11.14}$$ < $${13.86}$$
✅ iot_agent_deb_armhf $${0}$$ $${47.52}$$ < $${56.41}$$ $${+0}$$ $${11.21}$$ < $${13.86}$$
✅ iot_agent_rpm_amd64 $${0}$$ $${50.49}$$ < $${60.18}$$ $${-0}$$ $${12.86}$$ < $${15.84}$$
✅ iot_agent_rpm_arm64 $${0}$$ $${47.94}$$ < $${56.94}$$ $${-0}$$ $${11.16}$$ < $${13.76}$$
✅ iot_agent_suse_amd64 $${0}$$ $${50.49}$$ < $${60.18}$$ $${-0}$$ $${12.86}$$ < $${15.84}$$

@cit-pr-commenter cit-pr-commenter
Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 56b7d7a1-f317-4163-b02a-d45cc8eebbde

Baseline: 9d6ecd4
Comparison: 1a70dea
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ uds_dogstatsd_to_api_cpu % cpu utilization +2.84 [+1.94, +3.75] 1 Logs
➖ otlp_ingest_metrics memory utilization +0.93 [+0.76, +1.10] 1 Logs
➖ quality_gate_logs % cpu utilization +0.89 [-1.92, +3.70] 1 Logs bounds checks dashboard
➖ quality_gate_idle_all_features memory utilization +0.70 [+0.55, +0.86] 1 Logs bounds checks dashboard
➖ uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.57 [+0.51, +0.64] 1 Logs
➖ docker_containers_memory memory utilization +0.24 [+0.17, +0.31] 1 Logs
➖ tcp_syslog_to_blackhole ingress throughput +0.11 [+0.06, +0.16] 1 Logs
➖ otlp_ingest_logs memory utilization +0.11 [-0.02, +0.24] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput +0.11 [-0.47, +0.68] 1 Logs
➖ file_to_blackhole_1000ms_latency_linear_load egress throughput +0.08 [-0.15, +0.31] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput +0.02 [-0.54, +0.59] 1 Logs
➖ file_to_blackhole_300ms_latency egress throughput +0.02 [-0.58, +0.62] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput +0.01 [-0.61, +0.62] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput -0.00 [-0.62, +0.62] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.02, +0.02] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput -0.01 [-0.27, +0.26] 1 Logs
➖ ddot_metrics memory utilization -0.03 [-0.15, +0.09] 1 Logs
➖ file_to_blackhole_0ms_latency_http2 egress throughput -0.03 [-0.63, +0.57] 1 Logs
➖ file_to_blackhole_0ms_latency_http1 egress throughput -0.07 [-0.63, +0.50] 1 Logs
➖ ddot_logs memory utilization -0.33 [-0.47, -0.19] 1 Logs
➖ quality_gate_idle memory utilization -0.47 [-0.56, -0.39] 1 Logs bounds checks dashboard
➖ docker_containers_cpu % cpu utilization -1.81 [-4.88, +1.26] 1 Logs
➖ file_tree memory utilization -2.06 [-2.27, -1.84] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
✅ docker_containers_cpu simple_check_run 10/10
✅ docker_containers_memory memory_usage 10/10
✅ docker_containers_memory simple_check_run 10/10
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http1 memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http2 memory_usage 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_300ms_latency lost_bytes 10/10
✅ file_to_blackhole_300ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@rahulkaukuntla rahulkaukuntla marked this pull request as ready for review June 10, 2025 16:11
@rahulkaukuntla rahulkaukuntla requested review from a team as code owners June 10, 2025 16:11
@rahulkaukuntla rahulkaukuntla requested a review from dustmop June 10, 2025 16:11
@rahulkaukuntla
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jun 11, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-06-11 16:26:12 UTC ℹ️ Start processing command /merge

2025-06-11 16:26:18 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 52m (p90).

2025-06-11 17:04:07 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 2950751 into main Jun 11, 2025
288 checks passed
@dd-mergequeue dd-mergequeue bot deleted the rahul/proxy-comma-space-separation branch June 11, 2025 17:04
@github-actions github-actions bot added this to the 7.68.0 milestone Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustmop dustmop dustmop approved these changes

@BaptisteFoy BaptisteFoy BaptisteFoy approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/agent-configuration
Projects
None yet
Milestone
7.68.0
Development

Successfully merging this pull request may close these issues.
3 participants
@rahulkaukuntla @dustmop @BaptisteFoy