Skip to content

Add optional CI job to run tests using nodetreemodel #37758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add optional CI job to run tests using nodetreemodel #37758

wants to merge 2 commits into from

Conversation

dustmop
Copy link
Contributor

@dustmop dustmop commented Jun 9, 2025

What does this PR do?

Adds a CI job which runs the agent tests using the nodetreemodel implementation of the config.

This reverts #37735, reenabling #37698. We are disabling the junit test upload in this PR, which should prevent the failing CI from spamming test owners.

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@dustmop dustmop requested a review from a team as a code owner June 9, 2025 19:50
@dustmop dustmop added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation team/agent-configuration labels Jun 9, 2025
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Jun 9, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jun 9, 2025 •
edited
Loading

Gitlab CI Configuration Changes

Added Jobs

tests_nodetreemodel 
tests_nodetreemodel:
  after_script:
  - CODECOV_TOKEN=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $CODECOV token) || exit
    $?; export CODECOV_TOKEN
  - dda inv -- -e coverage.upload-to-codecov $COVERAGE_CACHE_FLAG || true
  allow_failure: true
  artifacts:
    expire_in: 2 weeks
    paths:
    - $TEST_OUTPUT_FILE
    - junit-*.tgz
    reports:
      annotations:
      - $EXTERNAL_LINKS_PATH
      junit:
      - '**/junit-out-*.xml'
    when: always
  before_script:
  - source /root/.bashrc && conda activate $CONDA_ENV
  - mkdir -p $GOPATH/pkg/mod/cache && tar xJf modcache.tar.xz -C $GOPATH/pkg/mod/cache
    || exit 101
  - rm -f modcache.tar.xz
  - dda inv -- -e rtloader.make --install-prefix=$CI_PROJECT_DIR/dev
  - dda inv -- -e rtloader.install
  - dda inv -- -e rtloader.format --raise-if-changed
  - dda inv -- -e rtloader.test
  image: registry.ddbuild.io/ci/datadog-agent-buildimages/rpm_x64$CI_IMAGE_RPM_X64_SUFFIX:$CI_IMAGE_RPM_X64
  needs:
  - go_deps
  - go_tools_deps
  rules:
  - if: $RUN_UNIT_TESTS == "off"
    when: never
  - if: $CI_COMMIT_BRANCH == "main"
    variables:
      COVERAGE_CACHE_FLAG: --push-coverage-cache
      FAST_TESTS: 'false'
  - if: $CI_COMMIT_BRANCH =~ /^[0-9]+\.[0-9]+\.x$/
    variables:
      COVERAGE_CACHE_FLAG: ''
      FAST_TESTS: 'false'
  - if: $CI_COMMIT_TAG != null
    variables:
      COVERAGE_CACHE_FLAG: ''
      FAST_TESTS: 'false'
  - if: $CI_PIPELINE_SOURCE == "trigger" || $CI_PIPELINE_SOURCE == "pipeline"
    variables:
      COVERAGE_CACHE_FLAG: ''
      FAST_TESTS: 'false'
  - if: $RUN_UNIT_TESTS == "on"
    variables:
      COVERAGE_CACHE_FLAG: ''
      FAST_TESTS: 'false'
  - variables:
      COVERAGE_CACHE_FLAG: --pull-coverage-cache
      FAST_TESTS: 'true'
  script:
  - mkdir -p $GOPATH/pkg/mod/cache && tar xJf modcache_tools.tar.xz -C $GOPATH/pkg/mod/cache
    || exit 101
  - rm -f modcache_tools.tar.xz
  - dda inv -- -e install-tools
  - dda inv -- -e gitlab.generate-ci-visibility-links --output=$EXTERNAL_LINKS_PATH
  - FAST_TESTS_FLAG=""
  - if [[ "$FAST_TESTS" == "true" ]]; then FAST_TESTS_FLAG="--only-impacted-packages";
    fi
  - dda inv -- -e sds.build-library
  - dda inv -- -e agent.build
  - dda inv -- -e test $FLAVORS --include-sds --race --profile --rerun-fails=2 --coverage
    --cpus $KUBERNETES_CPU_REQUEST $EXTRA_OPTS --result-json $TEST_OUTPUT_FILE --junit-tar
    "junit-${CI_JOB_NAME}.tgz" --build-stdlib $FAST_TESTS_FLAG --test-washer
  stage: source_test
  tags:
  - arch:amd64
  variables:
    CONDA_ENV: ddpy3
    DD_CONF_NODETREEMODEL: enable
    EXTERNAL_LINKS_PATH: external_links_$CI_JOB_ID.json
    FLAKY_PATTERNS_CONFIG: $CI_PROJECT_DIR/flaky-patterns-runtime.yaml
    FLAVORS: --flavor base
    KUBERNETES_CPU_REQUEST: 16
    KUBERNETES_MEMORY_LIMIT: 16Gi
    KUBERNETES_MEMORY_REQUEST: 16Gi
    TEST_OUTPUT_FILE: test_output.json

Changes Summary

Removed Modified Added Renamed
0 0 1 0

ℹ️ Diff available in the job log.

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jun 9, 2025 •
edited
Loading

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 99942ff

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
✅ agent_deb_amd64 $${0}$$ $${696.37}$$ < $${697.37}$$ $${+0}$$ $${176.06}$$ < $${177.03}$$
✅ agent_deb_amd64_fips $${0}$$ $${694.67}$$ < $${695.59}$$ $${+0.01}$$ $${175.52}$$ < $${176.51}$$
✅ agent_heroku_amd64 $${0}$$ $${358.67}$$ < $${359.67}$$ $${+0}$$ $${96.52}$$ < $${97.47}$$
✅ agent_msi $${+0}$$ $${958.88}$$ < $${959.86}$$ $${-0.01}$$ $${146.3}$$ < $${147.27}$$
✅ agent_rpm_amd64 $${0}$$ $${696.36}$$ < $${697.36}$$ $${+0.01}$$ $${177.61}$$ < $${178.56}$$
✅ agent_rpm_amd64_fips $${0}$$ $${694.66}$$ < $${695.58}$$ $${+0.04}$$ $${177.47}$$ < $${178.43}$$
✅ agent_rpm_arm64 $${0}$$ $${686.38}$$ < $${687.37}$$ $${+0}$$ $${161.04}$$ < $${161.99}$$
✅ agent_rpm_arm64_fips $${0}$$ $${684.79}$$ < $${685.72}$$ $${+0.01}$$ $${160.23}$$ < $${161.11}$$
✅ agent_suse_amd64 $${0}$$ $${696.36}$$ < $${697.36}$$ $${+0.01}$$ $${177.61}$$ < $${178.56}$$
✅ agent_suse_amd64_fips $${0}$$ $${694.66}$$ < $${695.58}$$ $${+0.04}$$ $${177.47}$$ < $${178.43}$$
✅ agent_suse_arm64 $${0}$$ $${686.38}$$ < $${687.37}$$ $${+0}$$ $${161.04}$$ < $${161.99}$$
✅ agent_suse_arm64_fips $${0}$$ $${684.79}$$ < $${685.72}$$ $${+0.01}$$ $${160.23}$$ < $${161.11}$$
✅ docker_agent_amd64 $${0}$$ $${780.16}$$ < $${781.16}$$ $${+0.01}$$ $${268.68}$$ < $${269.63}$$
✅ docker_agent_arm64 $${+0}$$ $${793.63}$$ < $${794.62}$$ $${-0.02}$$ $${256.04}$$ < $${257.0}$$
✅ docker_agent_jmx_amd64 $${0}$$ $${971.36}$$ < $${972.35}$$ $${+0.01}$$ $${337.65}$$ < $${338.6}$$
✅ docker_agent_jmx_arm64 $${+0}$$ $${973.42}$$ < $${974.41}$$ $${+0.01}$$ $${320.99}$$ < $${321.97}$$
✅ docker_agent_windows1809 $${+0}$$ $${1487.02}$$ < $${1488.0}$$ $${+0.07}$$ $${488.06}$$ < $${488.95}$$
✅ docker_agent_windows1809_core $${+0}$$ $${6216.98}$$ < $${6218.0}$$ $${0}$$ $${2048.0}$$ < $${2049.0}$$
✅ docker_agent_windows1809_core_jmx $${-0.03}$$ $${6360.87}$$ < $${6361.0}$$ $${0}$$ $${2048.0}$$ < $${2049.0}$$
✅ docker_agent_windows1809_jmx $${+0}$$ $${1608.65}$$ < $${1609.5}$$ $${-0.03}$$ $${530.34}$$ < $${531.32}$$
✅ docker_agent_windows2022 $${+0.08}$$ $${1506.2}$$ < $${1507.0}$$ $${+0.03}$$ $${500.79}$$ < $${501.7}$$
✅ docker_agent_windows2022_core $${-0.03}$$ $${6190.24}$$ < $${6311.0}$$ $${0}$$ $${2048.0}$$ < $${2049.0}$$
✅ docker_agent_windows2022_core_jmx $${+0.05}$$ $${6311.93}$$ < $${6313.0}$$ $${0}$$ $${2048.0}$$ < $${2049.0}$$
✅ docker_agent_windows2022_jmx $${-0.26}$$ $${1627.89}$$ < $${1628.16}$$ $${-0}$$ $${543.03}$$ < $${543.98}$$
✅ docker_cluster_agent_amd64 $${+0}$$ $${212.84}$$ < $${213.79}$$ $${-0}$$ $${72.38}$$ < $${73.33}$$
✅ docker_cluster_agent_arm64 $${-0}$$ $${228.68}$$ < $${229.64}$$ $${+0}$$ $${68.65}$$ < $${69.6}$$
✅ docker_cws_instrumentation_amd64 $${-0}$$ $${7.08}$$ < $${7.12}$$ $${-0}$$ $${2.95}$$ < $${3.29}$$
✅ docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${-0}$$ $${2.7}$$ < $${3.07}$$
✅ docker_dogstatsd_amd64 $${+0}$$ $${39.22}$$ < $${39.57}$$ $${-0}$$ $${15.12}$$ < $${15.76}$$
✅ docker_dogstatsd_arm64 $${0}$$ $${37.88}$$ < $${38.2}$$ $${-0}$$ $${14.53}$$ < $${14.83}$$
✅ dogstatsd_deb_amd64 $${0}$$ $${30.45}$$ < $${31.4}$$ $${-0}$$ $${8.0}$$ < $${8.95}$$
✅ dogstatsd_deb_arm64 $${0}$$ $${29.02}$$ < $${29.97}$$ $${-0}$$ $${6.94}$$ < $${7.89}$$
✅ dogstatsd_rpm_amd64 $${0}$$ $${30.45}$$ < $${31.4}$$ $${-0}$$ $${8.01}$$ < $${8.96}$$
✅ dogstatsd_suse_amd64 $${0}$$ $${30.45}$$ < $${31.4}$$ $${-0}$$ $${8.01}$$ < $${8.96}$$
✅ iot_agent_deb_amd64 $${0}$$ $${50.43}$$ < $${51.38}$$ $${-0}$$ $${12.83}$$ < $${13.79}$$
✅ iot_agent_deb_arm64 $${0}$$ $${47.9}$$ < $${48.85}$$ $${+0}$$ $${11.14}$$ < $${12.09}$$
✅ iot_agent_deb_armhf $${0}$$ $${47.47}$$ < $${48.42}$$ $${+0.01}$$ $${11.21}$$ < $${12.16}$$
✅ iot_agent_rpm_amd64 $${0}$$ $${50.43}$$ < $${51.38}$$ $${-0}$$ $${12.86}$$ < $${13.81}$$
✅ iot_agent_rpm_arm64 $${0}$$ $${47.9}$$ < $${48.85}$$ $${-0}$$ $${11.15}$$ < $${12.11}$$
✅ iot_agent_suse_amd64 $${0}$$ $${50.43}$$ < $${51.38}$$ $${-0}$$ $${12.86}$$ < $${13.81}$$

@dustmop
Copy link
Contributor Author

dustmop commented Jun 12, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jun 12, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-06-12 15:43:11 UTC ℹ️ Start processing command /merge

2025-06-12 15:43:35 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-06-12 19:44:05 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@cit-pr-commenter cit-pr-commenter
Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 57121bec-3f7f-46f4-9351-34d61b825c2c

Baseline: 99942ff
Comparison: 6c09381
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ quality_gate_logs % cpu utilization +1.15 [-1.62, +3.93] 1 Logs bounds checks dashboard
➖ docker_containers_memory memory utilization +0.99 [+0.91, +1.07] 1 Logs
➖ otlp_ingest_logs memory utilization +0.60 [+0.48, +0.73] 1 Logs
➖ quality_gate_idle_all_features memory utilization +0.30 [+0.19, +0.42] 1 Logs bounds checks dashboard
➖ uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.29 [+0.22, +0.37] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput +0.07 [-0.54, +0.67] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput +0.03 [-0.58, +0.65] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput +0.01 [-0.58, +0.61] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput +0.01 [-0.26, +0.28] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
➖ file_to_blackhole_0ms_latency_http2 egress throughput -0.01 [-0.61, +0.59] 1 Logs
➖ file_to_blackhole_300ms_latency egress throughput -0.02 [-0.61, +0.57] 1 Logs
➖ file_to_blackhole_0ms_latency_http1 egress throughput -0.04 [-0.63, +0.55] 1 Logs
➖ tcp_syslog_to_blackhole ingress throughput -0.06 [-0.12, +0.00] 1 Logs
➖ file_to_blackhole_1000ms_latency_linear_load egress throughput -0.06 [-0.29, +0.17] 1 Logs
➖ ddot_metrics memory utilization -0.08 [-0.20, +0.03] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput -0.09 [-0.65, +0.47] 1 Logs
➖ ddot_logs memory utilization -0.11 [-0.22, +0.01] 1 Logs
➖ otlp_ingest_metrics memory utilization -0.38 [-0.54, -0.22] 1 Logs
➖ quality_gate_idle memory utilization -0.58 [-0.63, -0.52] 1 Logs bounds checks dashboard
➖ uds_dogstatsd_to_api_cpu % cpu utilization -0.76 [-1.63, +0.11] 1 Logs
➖ file_tree memory utilization -1.17 [-1.31, -1.03] 1 Logs
➖ docker_containers_cpu % cpu utilization -1.27 [-4.31, +1.77] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
✅ docker_containers_cpu simple_check_run 10/10
✅ docker_containers_memory memory_usage 10/10
✅ docker_containers_memory simple_check_run 10/10
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http1 memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http2 memory_usage 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_300ms_latency lost_bytes 10/10
✅ file_to_blackhole_300ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinFairise2 KevinFairise2 KevinFairise2 approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/agent-configuration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dustmop @KevinFairise2 @hush-hush