Skip to content

omnibus: update libkrb5 to 1.21.3 #37800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2025
Merged

omnibus: update libkrb5 to 1.21.3 #37800

merged 1 commit into from
Jun 11, 2025

Conversation

chouquette
Copy link
Contributor

What does this PR do?

Update libkrb5 from 1.20.1 to 1.21.3

Motivation

Stay up to date with upstream

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@chouquette chouquette requested review from a team as code owners June 10, 2025 08:06
@chouquette chouquette added qa/no-code-change No code change in Agent code requiring validation team/agent-delivery labels Jun 10, 2025
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Jun 10, 2025
@chouquette chouquette added the ask-review Ask required teams to review this PR label Jun 10, 2025
@cit-pr-commenter cit-pr-commenter
Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 281239a6-595b-4149-aac3-f861bf310809

Baseline: ad0e415
Comparison: b3c5937
Diff

Optimization Goals: ❌ Regression(s) detected

perf experiment goal Δ mean % Δ mean % CI trials links
❌ docker_containers_cpu % cpu utilization +7.08 [+3.73, +10.44] 1 Logs
✅ quality_gate_idle_all_features memory utilization -5.87 [-5.98, -5.75] 1 Logs bounds checks dashboard

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
❌ docker_containers_cpu % cpu utilization +7.08 [+3.73, +10.44] 1 Logs
➖ quality_gate_idle memory utilization +0.51 [+0.43, +0.58] 1 Logs bounds checks dashboard
➖ otlp_ingest_logs memory utilization +0.33 [+0.20, +0.46] 1 Logs
➖ ddot_metrics memory utilization +0.20 [+0.08, +0.32] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput +0.13 [-0.44, +0.71] 1 Logs
➖ file_to_blackhole_1000ms_latency_linear_load egress throughput +0.04 [-0.19, +0.28] 1 Logs
➖ ddot_logs memory utilization +0.03 [-0.11, +0.17] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput +0.02 [-0.57, +0.61] 1 Logs
➖ file_to_blackhole_0ms_latency_http2 egress throughput +0.01 [-0.60, +0.62] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput +0.01 [-0.26, +0.28] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.02, +0.01] 1 Logs
➖ file_to_blackhole_300ms_latency egress throughput -0.03 [-0.65, +0.58] 1 Logs
➖ file_to_blackhole_0ms_latency_http1 egress throughput -0.08 [-0.68, +0.52] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput -0.18 [-0.79, +0.43] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput -0.19 [-0.82, +0.44] 1 Logs
➖ uds_dogstatsd_to_api_cpu % cpu utilization -0.24 [-1.15, +0.68] 1 Logs
➖ quality_gate_logs % cpu utilization -0.31 [-3.06, +2.44] 1 Logs bounds checks dashboard
➖ docker_containers_memory memory utilization -0.35 [-0.40, -0.30] 1 Logs
➖ otlp_ingest_metrics memory utilization -0.45 [-0.62, -0.28] 1 Logs
➖ uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.90 [-0.97, -0.83] 1 Logs
➖ tcp_syslog_to_blackhole ingress throughput -1.13 [-1.18, -1.07] 1 Logs
➖ file_tree memory utilization -2.84 [-3.06, -2.61] 1 Logs
✅ quality_gate_idle_all_features memory utilization -5.87 [-5.98, -5.75] 1 Logs bounds checks dashboard

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
❌ quality_gate_logs memory_usage 7/10 bounds checks dashboard
✅ docker_containers_cpu simple_check_run 10/10
✅ docker_containers_memory memory_usage 10/10
✅ docker_containers_memory simple_check_run 10/10
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http1 memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http2 memory_usage 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_300ms_latency lost_bytes 10/10
✅ file_to_blackhole_300ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

❌ Failed. Some Quality Gates were violated.

  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 7/10 replicas passed. Failed 3 which is > 0. Gate FAILED.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@chouquette
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jun 10, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-06-10 09:32:07 UTC ℹ️ Start processing command /merge

2025-06-10 09:32:14 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-06-10 13:33:07 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@agent-platform-auto-pr
Copy link
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor ad0e415

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
✅ agent_deb_amd64 $${+0.29}$$ $${696.33}$$ < $${752.99}$$ $${+0.02}$$ $${176.07}$$ < $${187.44}$$
✅ agent_deb_amd64_fips $${+0.29}$$ $${694.55}$$ < $${751.36}$$ $${+0.09}$$ $${175.53}$$ < $${187.06}$$
✅ agent_heroku_amd64 $${0}$$ $${358.56}$$ < $${369.68}$$ $${+0}$$ $${96.5}$$ < $${99.55}$$
✅ agent_msi $${+0}$$ $${959.85}$$ < $${987.01}$$ $${+0.05}$$ $${146.46}$$ < $${150.72}$$
✅ agent_rpm_amd64 $${+0.29}$$ $${696.31}$$ < $${752.98}$$ $${+0.01}$$ $${177.58}$$ < $${190.03}$$
✅ agent_rpm_amd64_fips $${+0.29}$$ $${694.54}$$ < $${751.35}$$ $${-0}$$ $${177.43}$$ < $${189.81}$$
✅ agent_rpm_arm64 $${+0.28}$$ $${686.26}$$ < $${739.42}$$ $${+0.05}$$ $${161.05}$$ < $${171.23}$$
✅ agent_rpm_arm64_fips $${+0.28}$$ $${684.6}$$ < $${737.91}$$ $${+0.06}$$ $${160.14}$$ < $${170.22}$$
✅ agent_suse_amd64 $${+0.29}$$ $${696.31}$$ < $${752.98}$$ $${+0.01}$$ $${177.58}$$ < $${190.03}$$
✅ agent_suse_amd64_fips $${+0.29}$$ $${694.54}$$ < $${751.35}$$ $${-0}$$ $${177.43}$$ < $${189.81}$$
✅ agent_suse_arm64 $${+0.28}$$ $${686.26}$$ < $${739.42}$$ $${+0.05}$$ $${161.05}$$ < $${171.23}$$
✅ agent_suse_arm64_fips $${+0.28}$$ $${684.6}$$ < $${737.91}$$ $${+0.06}$$ $${160.14}$$ < $${170.22}$$
✅ docker_agent_amd64 $${+0.29}$$ $${780.11}$$ < $${849.39}$$ $${+0.07}$$ $${268.65}$$ < $${288.34}$$
✅ docker_agent_arm64 $${+0.28}$$ $${793.51}$$ < $${858.97}$$ $${+0.07}$$ $${256.04}$$ < $${274.36}$$
✅ docker_agent_jmx_amd64 $${+0.29}$$ $${780.11}$$ < $${849.39}$$ $${+0.07}$$ $${268.65}$$ < $${288.34}$$
✅ docker_agent_jmx_arm64 $${+0.28}$$ $${793.51}$$ < $${858.97}$$ $${+0.07}$$ $${256.04}$$ < $${274.36}$$
✅ docker_agent_windows1809 $${+0.29}$$ $${780.11}$$ < $${849.39}$$ $${+0.07}$$ $${268.65}$$ < $${288.34}$$
✅ docker_agent_windows1809_core $${+0.29}$$ $${780.11}$$ < $${849.39}$$ $${+0.07}$$ $${268.65}$$ < $${288.34}$$
✅ docker_agent_windows1809_core_jmx $${+0.29}$$ $${780.11}$$ < $${849.39}$$ $${+0.07}$$ $${268.65}$$ < $${288.34}$$
✅ docker_agent_windows1809_jmx $${+0.29}$$ $${780.11}$$ < $${849.39}$$ $${+0.07}$$ $${268.65}$$ < $${288.34}$$
✅ docker_agent_windows2022 $${+0.29}$$ $${780.11}$$ < $${849.39}$$ $${+0.07}$$ $${268.65}$$ < $${288.34}$$
✅ docker_agent_windows2022_core $${+0.29}$$ $${780.11}$$ < $${849.39}$$ $${+0.07}$$ $${268.65}$$ < $${288.34}$$
✅ docker_agent_windows2022_core_jmx $${+0.29}$$ $${780.11}$$ < $${849.39}$$ $${+0.07}$$ $${268.65}$$ < $${288.34}$$
✅ docker_agent_windows2022_jmx $${+0.29}$$ $${780.11}$$ < $${849.39}$$ $${+0.07}$$ $${268.65}$$ < $${288.34}$$
✅ docker_cluster_agent_amd64 $${-0}$$ $${259.19}$$ < $${259.73}$$ $${+0}$$ $${102.88}$$ < $${103.68}$$
✅ docker_cluster_agent_arm64 $${-0}$$ $${273.64}$$ < $${274.24}$$ $${+0}$$ $${97.59}$$ < $${98.45}$$
✅ docker_cws_instrumentation_amd64 $${-0}$$ $${7.08}$$ < $${7.12}$$ $${-0}$$ $${2.95}$$ < $${3.29}$$
✅ docker_cws_instrumentation_arm64 $${-0}$$ $${6.69}$$ < $${6.92}$$ $${+0}$$ $${2.7}$$ < $${3.07}$$
✅ docker_dogstatsd_amd64 $${0}$$ $${38.93}$$ < $${39.57}$$ $${+0}$$ $${14.95}$$ < $${15.76}$$
✅ docker_dogstatsd_arm64 $${+0}$$ $${37.52}$$ < $${38.2}$$ $${+0}$$ $${13.96}$$ < $${14.83}$$
✅ dogstatsd_deb_amd64 $${0}$$ $${30.61}$$ < $${31.52}$$ $${-0}$$ $${8.03}$$ < $${8.97}$$
✅ dogstatsd_deb_arm64 $${0}$$ $${29.16}$$ < $${30.08}$$ $${+0}$$ $${6.97}$$ < $${7.92}$$
✅ dogstatsd_rpm_amd64 $${0}$$ $${30.61}$$ < $${31.52}$$ $${-0.01}$$ $${8.04}$$ < $${8.98}$$
✅ dogstatsd_suse_amd64 $${0}$$ $${30.61}$$ < $${31.52}$$ $${-0.01}$$ $${8.04}$$ < $${8.98}$$
✅ iot_agent_deb_amd64 $${0}$$ $${50.48}$$ < $${60.17}$$ $${+0}$$ $${12.85}$$ < $${15.82}$$
✅ iot_agent_deb_arm64 $${0}$$ $${47.93}$$ < $${56.94}$$ $${-0}$$ $${11.14}$$ < $${13.86}$$
✅ iot_agent_deb_armhf $${0}$$ $${47.51}$$ < $${56.41}$$ $${+0}$$ $${11.21}$$ < $${13.86}$$
✅ iot_agent_rpm_amd64 $${0}$$ $${50.48}$$ < $${60.18}$$ $${+0}$$ $${12.86}$$ < $${15.84}$$
✅ iot_agent_rpm_arm64 $${0}$$ $${47.94}$$ < $${56.94}$$ $${-0}$$ $${11.16}$$ < $${13.76}$$
✅ iot_agent_suse_amd64 $${0}$$ $${50.48}$$ < $${60.18}$$ $${+0}$$ $${12.86}$$ < $${15.84}$$

@chouquette
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jun 11, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-06-11 05:59:55 UTC ℹ️ Start processing command /merge

2025-06-11 05:59:59 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 47m (p90).

2025-06-11 06:39:41 UTC ℹ️ MergeQueue: This merge request was merged

@chouquette chouquette added the backport/7.67.x Automatically create a backport PR to 7.67.x label Jun 11, 2025
@dd-mergequeue dd-mergequeue bot merged commit 6402feb into main Jun 11, 2025
354 checks passed
@dd-mergequeue dd-mergequeue bot deleted the chouquette/update_krb5 branch June 11, 2025 06:39
@github-actions github-actions bot added this to the 7.68.0 milestone Jun 11, 2025
agent-platform-auto-pr bot pushed a commit that referenced this pull request Jun 11, 2025
@chouquette @github-actions
omnibus: update libkrb5 to 1.21.3 (#37800)
fee3059 
(cherry picked from commit 6402feb)
@agent-platform-auto-pr agent-platform-auto-pr bot mentioned this pull request Jun 11, 2025
Merged
github-actions bot pushed a commit to offsoc/datadog-agent that referenced this pull request Jun 11, 2025
@offsoc
omnibus: update libkrb5 to 1.21.3 (DataDog#37800) 6402feb
4a79dbb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorentClarret FlorentClarret FlorentClarret approved these changes

@alopezz alopezz alopezz approved these changes

@michaelcretzman michaelcretzman michaelcretzman approved these changes

Assignees
No one assigned
Labels
ask-review Ask required teams to review this PR backport/7.67.x Automatically create a backport PR to 7.67.x qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/agent-delivery
Projects
None yet
Milestone
7.68.0
Development

Successfully merging this pull request may close these issues.
4 participants
@chouquette @FlorentClarret @alopezz @michaelcretzman