Skip to content

(fleet) Update E2E tests not to fail .NET SSI install when IIS is not installed #37811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2025
Merged

(fleet) Update E2E tests not to fail .NET SSI install when IIS is not installed #37811

merged 1 commit into from
Jun 13, 2025

Conversation

bmermet
Copy link
Contributor

@bmermet bmermet commented Jun 10, 2025 •
edited
Loading

What does this PR do?

This PR updates E2E of the datadog-installer to ensure that lack of an IIS installation does not prevent installing the .NET library OCI package on Windows.

Motivation

Make it easier for Windows customers to use the same installation command for all their hosts without having to know if IIS is installed on them or not.

Describe how you validated your changes

These tests are validated by E2E tests.

Possible Drawbacks / Trade-offs

Additional Notes

@github-actions github-actions bot added team/windows-agent short review PR is simple enough to be reviewed quickly labels Jun 10, 2025
@cit-pr-commenter cit-pr-commenter
Copy link

cit-pr-commenter bot commented Jun 10, 2025 •
edited
Loading

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 77ebbc36-3292-492d-9bac-056e6033452c

Baseline: 0dfd2c5
Comparison: 625a303
Diff

Optimization Goals: ✅ Improvement(s) detected

perf experiment goal Δ mean % Δ mean % CI trials links
✅ docker_containers_cpu % cpu utilization -8.36 [-11.29, -5.43] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ quality_gate_idle memory utilization +0.59 [+0.54, +0.65] 1 Logs bounds checks dashboard
➖ otlp_ingest_metrics memory utilization +0.45 [+0.29, +0.61] 1 Logs
➖ uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.45 [+0.40, +0.50] 1 Logs
➖ file_tree memory utilization +0.39 [+0.24, +0.54] 1 Logs
➖ otlp_ingest_logs memory utilization +0.35 [+0.22, +0.48] 1 Logs
➖ file_to_blackhole_0ms_latency_http2 egress throughput +0.08 [-0.50, +0.65] 1 Logs
➖ ddot_metrics memory utilization +0.06 [-0.06, +0.18] 1 Logs
➖ file_to_blackhole_1000ms_latency_linear_load egress throughput +0.01 [-0.22, +0.24] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput +0.01 [-0.26, +0.28] 1 Logs
➖ file_to_blackhole_300ms_latency egress throughput +0.01 [-0.64, +0.66] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput +0.00 [-0.60, +0.61] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.02, +0.02] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput -0.02 [-0.57, +0.53] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput -0.05 [-0.69, +0.60] 1 Logs
➖ file_to_blackhole_0ms_latency_http1 egress throughput -0.06 [-0.66, +0.54] 1 Logs
➖ ddot_logs memory utilization -0.09 [-0.22, +0.05] 1 Logs
➖ docker_containers_memory memory utilization -0.10 [-0.17, -0.04] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput -0.13 [-0.71, +0.45] 1 Logs
➖ quality_gate_logs % cpu utilization -0.40 [-3.12, +2.31] 1 Logs bounds checks dashboard
➖ quality_gate_idle_all_features memory utilization -0.41 [-0.49, -0.33] 1 Logs bounds checks dashboard
➖ uds_dogstatsd_to_api_cpu % cpu utilization -0.52 [-1.36, +0.33] 1 Logs
➖ tcp_syslog_to_blackhole ingress throughput -1.10 [-1.17, -1.03] 1 Logs
✅ docker_containers_cpu % cpu utilization -8.36 [-11.29, -5.43] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
✅ docker_containers_cpu simple_check_run 10/10
✅ docker_containers_memory memory_usage 10/10
✅ docker_containers_memory simple_check_run 10/10
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http1 memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http2 memory_usage 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_300ms_latency lost_bytes 10/10
✅ file_to_blackhole_300ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jun 10, 2025 •
edited
Loading

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 0dfd2c5

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
✅ agent_deb_amd64 $${-0}$$ $${696.04}$$ < $${752.99}$$ $${+0.01}$$ $${176.02}$$ < $${187.44}$$
✅ agent_deb_amd64_fips $${-0}$$ $${694.26}$$ < $${751.36}$$ $${+0}$$ $${175.45}$$ < $${187.06}$$
✅ agent_heroku_amd64 $${0}$$ $${358.56}$$ < $${369.68}$$ $${-0}$$ $${96.5}$$ < $${99.55}$$
✅ agent_msi $${+0}$$ $${959.85}$$ < $${987.01}$$ $${-0.01}$$ $${146.46}$$ < $${150.72}$$
✅ agent_rpm_amd64 $${-0}$$ $${696.03}$$ < $${752.98}$$ $${-0}$$ $${177.54}$$ < $${190.03}$$
✅ agent_rpm_amd64_fips $${-0}$$ $${694.25}$$ < $${751.35}$$ $${-0.01}$$ $${177.39}$$ < $${189.81}$$
✅ agent_rpm_arm64 $${-0}$$ $${685.98}$$ < $${739.42}$$ $${-0.01}$$ $${161.01}$$ < $${171.23}$$
✅ agent_rpm_arm64_fips $${-0}$$ $${684.32}$$ < $${737.91}$$ $${+0.03}$$ $${160.12}$$ < $${170.22}$$
✅ agent_suse_amd64 $${-0}$$ $${696.03}$$ < $${752.98}$$ $${-0}$$ $${177.54}$$ < $${190.03}$$
✅ agent_suse_amd64_fips $${-0}$$ $${694.25}$$ < $${751.35}$$ $${-0.01}$$ $${177.39}$$ < $${189.81}$$
✅ agent_suse_arm64 $${-0}$$ $${685.98}$$ < $${739.42}$$ $${-0.01}$$ $${161.01}$$ < $${171.23}$$
✅ agent_suse_arm64_fips $${-0}$$ $${684.32}$$ < $${737.91}$$ $${+0.03}$$ $${160.12}$$ < $${170.22}$$
✅ docker_agent_amd64 $${-0}$$ $${779.83}$$ < $${849.39}$$ $${+0}$$ $${268.6}$$ < $${288.34}$$
✅ docker_agent_arm64 $${-0}$$ $${793.23}$$ < $${858.97}$$ $${-0.01}$$ $${255.96}$$ < $${274.36}$$
✅ docker_agent_jmx_amd64 $${-0}$$ $${779.83}$$ < $${849.39}$$ $${+0}$$ $${268.6}$$ < $${288.34}$$
✅ docker_agent_jmx_arm64 $${-0}$$ $${793.23}$$ < $${858.97}$$ $${-0.01}$$ $${255.96}$$ < $${274.36}$$
✅ docker_agent_windows1809 $${-0}$$ $${779.83}$$ < $${849.39}$$ $${+0}$$ $${268.6}$$ < $${288.34}$$
✅ docker_agent_windows1809_core $${-0}$$ $${779.83}$$ < $${849.39}$$ $${+0}$$ $${268.6}$$ < $${288.34}$$
✅ docker_agent_windows1809_core_jmx $${-0}$$ $${779.83}$$ < $${849.39}$$ $${+0}$$ $${268.6}$$ < $${288.34}$$
✅ docker_agent_windows1809_jmx $${-0}$$ $${779.83}$$ < $${849.39}$$ $${+0}$$ $${268.6}$$ < $${288.34}$$
✅ docker_agent_windows2022 $${-0}$$ $${779.83}$$ < $${849.39}$$ $${+0}$$ $${268.6}$$ < $${288.34}$$
✅ docker_agent_windows2022_core $${-0}$$ $${779.83}$$ < $${849.39}$$ $${+0}$$ $${268.6}$$ < $${288.34}$$
✅ docker_agent_windows2022_core_jmx $${-0}$$ $${779.83}$$ < $${849.39}$$ $${+0}$$ $${268.6}$$ < $${288.34}$$
✅ docker_agent_windows2022_jmx $${-0}$$ $${779.83}$$ < $${849.39}$$ $${+0}$$ $${268.6}$$ < $${288.34}$$
✅ docker_cluster_agent_amd64 $${+0}$$ $${259.19}$$ < $${259.73}$$ $${-0}$$ $${102.88}$$ < $${103.68}$$
✅ docker_cluster_agent_arm64 $${-0}$$ $${273.64}$$ < $${274.24}$$ $${+0}$$ $${97.59}$$ < $${98.45}$$
✅ docker_cws_instrumentation_amd64 $${+0}$$ $${7.08}$$ < $${7.12}$$ $${+0}$$ $${2.95}$$ < $${3.29}$$
✅ docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${+0}$$ $${2.7}$$ < $${3.07}$$
✅ docker_dogstatsd_amd64 $${+0}$$ $${38.93}$$ < $${39.57}$$ $${-0}$$ $${14.95}$$ < $${15.76}$$
✅ docker_dogstatsd_arm64 $${0}$$ $${37.52}$$ < $${38.2}$$ $${+0}$$ $${13.96}$$ < $${14.83}$$
✅ dogstatsd_deb_amd64 $${0}$$ $${30.61}$$ < $${31.52}$$ $${+0}$$ $${8.03}$$ < $${8.97}$$
✅ dogstatsd_deb_arm64 $${0}$$ $${29.16}$$ < $${30.08}$$ $${+0}$$ $${6.97}$$ < $${7.92}$$
✅ dogstatsd_rpm_amd64 $${0}$$ $${30.61}$$ < $${31.52}$$ $${-0}$$ $${8.04}$$ < $${8.98}$$
✅ dogstatsd_suse_amd64 $${0}$$ $${30.61}$$ < $${31.52}$$ $${-0}$$ $${8.04}$$ < $${8.98}$$
✅ iot_agent_deb_amd64 $${0}$$ $${50.48}$$ < $${60.17}$$ $${+0}$$ $${12.85}$$ < $${15.82}$$
✅ iot_agent_deb_arm64 $${0}$$ $${47.93}$$ < $${56.94}$$ $${-0}$$ $${11.14}$$ < $${13.86}$$
✅ iot_agent_deb_armhf $${0}$$ $${47.51}$$ < $${56.41}$$ $${-0.01}$$ $${11.2}$$ < $${13.86}$$
✅ iot_agent_rpm_amd64 $${0}$$ $${50.48}$$ < $${60.18}$$ $${-0}$$ $${12.86}$$ < $${15.84}$$
✅ iot_agent_rpm_arm64 $${0}$$ $${47.94}$$ < $${56.94}$$ $${+0}$$ $${11.16}$$ < $${13.76}$$
✅ iot_agent_suse_amd64 $${0}$$ $${50.48}$$ < $${60.18}$$ $${-0}$$ $${12.86}$$ < $${15.84}$$

@bmermet bmermet force-pushed the bmermet/dotnet-iis-no-failure branch from 6084c96 to 239b47d Compare June 10, 2025 13:10
@bmermet bmermet marked this pull request as ready for review June 10, 2025 16:04
@bmermet bmermet requested review from a team as code owners June 10, 2025 16:04
andrewlock
andrewlock approved these changes Jun 10, 2025
View reviewed changes
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmermet bmermet force-pushed the bmermet/dotnet-iis-no-failure branch from 239b47d to 625a303 Compare June 10, 2025 23:47
@bmermet bmermet added qa/done QA done before merge and regressions are covered by tests changelog/no-changelog labels Jun 12, 2025
@bmermet
Copy link
Contributor Author

bmermet commented Jun 13, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jun 13, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-06-13 09:31:41 UTC ℹ️ Start processing command /merge

2025-06-13 09:31:46 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 58m (p90).

2025-06-13 10:14:42 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 650ae4e into main Jun 13, 2025
292 of 294 checks passed
@dd-mergequeue dd-mergequeue bot deleted the bmermet/dotnet-iis-no-failure branch June 13, 2025 10:14
@github-actions github-actions bot added this to the 7.69.0 milestone Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewlock andrewlock andrewlock approved these changes

@BaptisteFoy BaptisteFoy BaptisteFoy approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/windows-agent
Projects
None yet
Milestone
7.69.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bmermet @andrewlock @BaptisteFoy