Set 'HostProcMountinfo' for Disk integration #37826

jose-manuel-almaza · 2025-06-10T15:46:32Z

What does this PR do?

This PR introduces a new configuration option proc_mountinfo_path (defaulting to "/proc/self/mounts") and updates our disk check to call disk.PartitionsWithContext(ctx, includeAll) instead of the previous call to disk.Partitions(includeAll) from gopsutil

Motivation

When migrating our disk checks from Python’s psutil to Go’s gopsutil, we discovered that by default:

psutil reads mount information from the current process’s namespace (/proc/self/mounts).
gopsutil reads from /proc/1/mountinfo, which doesn’t reflect the container’s view.

These differences led to inconsistent results inside containers (see here). This PR introduces a new proc_mountinfo_path config (defaulting to "/proc/self/mounts") and switches all disk-check calls to PartitionsWithContext (instead of Partitions). By carrying the override in the context, we now have per-call control of the mountinfo source, making gopsutil behave like psutil by default, while still retaining its full fallback logic for other advanced scenarios.

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

cit-pr-commenter · 2025-06-10T16:34:24Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: a3bfcbc2-5d2a-49f6-932e-362c380ff56a

Baseline: 39ac529
Comparison: 67e3cdd
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	+2.35	[-0.72, +5.42]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+1.99	[+1.13, +2.85]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.72	[+0.63, +0.81]	1	Logs bounds checks dashboard
➖	quality_gate_idle	memory utilization	+0.31	[+0.25, +0.37]	1	Logs bounds checks dashboard
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	+0.25	[+0.20, +0.30]	1	Logs
➖	ddot_metrics	memory utilization	+0.24	[+0.12, +0.36]	1	Logs
➖	ddot_logs	memory utilization	+0.15	[+0.01, +0.29]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.07	[-0.48, +0.61]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.02	[-0.60, +0.63]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	+0.01	[-0.54, +0.56]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	-0.00	[-0.24, +0.24]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.02, +0.01]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.29, +0.28]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.03	[-0.55, +0.49]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	-0.03	[-0.60, +0.54]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.07	[-0.67, +0.53]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	-0.07	[-0.66, +0.51]	1	Logs
➖	otlp_ingest_metrics	memory utilization	-0.20	[-0.36, -0.04]	1	Logs
➖	otlp_ingest_logs	memory utilization	-0.21	[-0.33, -0.08]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-0.32	[-0.38, -0.25]	1	Logs
➖	file_tree	memory utilization	-0.50	[-0.66, -0.34]	1	Logs
➖	docker_containers_memory	memory utilization	-1.12	[-1.19, -1.04]	1	Logs
➖	quality_gate_logs	% cpu utilization	-4.43	[-7.12, -1.74]	1	Logs bounds checks dashboard

Bounds Checks: ❌ Failed

perf	experiment	bounds_check_name	replicates_passed	links
❌	file_to_blackhole_0ms_latency_http2	lost_bytes	9/10
✅	docker_containers_cpu	simple_check_run	10/10
✅	docker_containers_memory	memory_usage	10/10
✅	docker_containers_memory	simple_check_run	10/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

agent-platform-auto-pr · 2025-06-10T19:09:10Z

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 39ac529

Successful checks

Info

	Quality gate	Delta	On disk size (MiB)	Delta	On wire size (MiB)
✅	agent_deb_amd64	$${+0}$$	$${696.07}$$ < $${752.99}$$	$${+0}$$	$${176.01}$$ < $${187.44}$$
✅	agent_deb_amd64_fips	$${+0}$$	$${694.3}$$ < $${751.36}$$	$${-0.03}$$	$${175.49}$$ < $${187.06}$$
✅	agent_heroku_amd64	$${0}$$	$${358.56}$$ < $${369.68}$$	$${-0}$$	$${96.5}$$ < $${99.55}$$
✅	agent_msi	$${+0}$$	$${959.89}$$ < $${987.01}$$	$${+0.02}$$	$${146.45}$$ < $${150.72}$$
✅	agent_rpm_amd64	$${+0}$$	$${696.06}$$ < $${752.98}$$	$${-0.01}$$	$${177.54}$$ < $${190.03}$$
✅	agent_rpm_amd64_fips	$${+0}$$	$${694.29}$$ < $${751.35}$$	$${+0.01}$$	$${177.43}$$ < $${189.81}$$
✅	agent_rpm_arm64	$${0}$$	$${686.01}$$ < $${739.42}$$	$${-0}$$	$${161.05}$$ < $${171.23}$$
✅	agent_rpm_arm64_fips	$${0}$$	$${684.36}$$ < $${737.91}$$	$${-0.02}$$	$${160.07}$$ < $${170.22}$$
✅	agent_suse_amd64	$${+0}$$	$${696.06}$$ < $${752.98}$$	$${-0.01}$$	$${177.54}$$ < $${190.03}$$
✅	agent_suse_amd64_fips	$${+0}$$	$${694.29}$$ < $${751.35}$$	$${+0.01}$$	$${177.43}$$ < $${189.81}$$
✅	agent_suse_arm64	$${0}$$	$${686.01}$$ < $${739.42}$$	$${-0}$$	$${161.05}$$ < $${171.23}$$
✅	agent_suse_arm64_fips	$${0}$$	$${684.36}$$ < $${737.91}$$	$${-0.02}$$	$${160.07}$$ < $${170.22}$$
✅	docker_agent_amd64	$${+0}$$	$${779.86}$$ < $${849.39}$$	$${+0.02}$$	$${268.61}$$ < $${288.34}$$
✅	docker_agent_arm64	$${+0}$$	$${793.26}$$ < $${858.97}$$	$${+0}$$	$${255.98}$$ < $${274.36}$$
✅	docker_agent_jmx_amd64	$${+0}$$	$${971.05}$$ < $${1040.59}$$	$${+0.01}$$	$${337.59}$$ < $${357.3}$$
✅	docker_agent_jmx_arm64	$${+0}$$	$${973.05}$$ < $${1038.77}$$	$${-0}$$	$${320.9}$$ < $${339.32}$$
✅	docker_agent_windows1809	$${+0}$$	$${1487.98}$$ < $${1557.19}$$	$${-0.01}$$	$${488.24}$$ < $${507.33}$$
✅	docker_agent_windows1809_core	$${+0}$$	$${6217.94}$$ < $${6287.46}$$	$${0}$$	$${2048.0}$$ < $${2067.76}$$
✅	docker_agent_windows1809_core_jmx	$${+22.33}$$	$${6361.83}$$ < $${6409.04}$$	$${0}$$	$${2048.0}$$ < $${2067.76}$$
✅	docker_agent_windows1809_jmx	$${+0}$$	$${1609.61}$$ < $${1679.14}$$	$${+0.01}$$	$${530.51}$$ < $${550.27}$$
✅	docker_agent_windows2022	$${-0.02}$$	$${1507.17}$$ < $${1576.85}$$	$${+0.03}$$	$${501.02}$$ < $${520.76}$$
✅	docker_agent_windows2022_core	$${-0.22}$$	$${6191.0}$$ < $${6260.53}$$	$${0}$$	$${2048.0}$$ < $${2067.76}$$
✅	docker_agent_windows2022_core_jmx	$${-0.67}$$	$${6312.19}$$ < $${6382.17}$$	$${0}$$	$${2048.0}$$ < $${2067.76}$$
✅	docker_agent_windows2022_jmx	$${-0.38}$$	$${1628.84}$$ < $${1698.2}$$	$${+0.03}$$	$${543.29}$$ < $${562.99}$$
✅	docker_cluster_agent_amd64	$${+0}$$	$${259.22}$$ < $${259.73}$$	$${+0.02}$$	$${102.91}$$ < $${103.68}$$
✅	docker_cluster_agent_arm64	$${-0}$$	$${273.65}$$ < $${274.24}$$	$${+0.01}$$	$${97.59}$$ < $${98.45}$$
✅	docker_cws_instrumentation_amd64	$${0}$$	$${7.08}$$ < $${7.12}$$	$${-0}$$	$${2.95}$$ < $${3.29}$$
✅	docker_cws_instrumentation_arm64	$${0}$$	$${6.69}$$ < $${6.92}$$	$${0}$$	$${2.7}$$ < $${3.07}$$
✅	docker_dogstatsd_amd64	$${+0}$$	$${38.93}$$ < $${39.57}$$	$${+0}$$	$${14.95}$$ < $${15.76}$$
✅	docker_dogstatsd_arm64	$${+0}$$	$${37.52}$$ < $${38.2}$$	$${-0}$$	$${13.96}$$ < $${14.83}$$
✅	dogstatsd_deb_amd64	$${0}$$	$${30.61}$$ < $${31.52}$$	$${+0}$$	$${8.04}$$ < $${8.97}$$
✅	dogstatsd_deb_arm64	$${0}$$	$${29.16}$$ < $${30.08}$$	$${-0}$$	$${6.97}$$ < $${7.92}$$
✅	dogstatsd_rpm_amd64	$${0}$$	$${30.61}$$ < $${31.52}$$	$${-0}$$	$${8.04}$$ < $${8.98}$$
✅	dogstatsd_suse_amd64	$${0}$$	$${30.61}$$ < $${31.52}$$	$${-0}$$	$${8.04}$$ < $${8.98}$$
✅	iot_agent_deb_amd64	$${+0}$$	$${50.49}$$ < $${60.17}$$	$${+0}$$	$${12.85}$$ < $${15.82}$$
✅	iot_agent_deb_arm64	$${+0}$$	$${47.94}$$ < $${56.94}$$	$${+0}$$	$${11.15}$$ < $${13.86}$$
✅	iot_agent_deb_armhf	$${+0}$$	$${47.52}$$ < $${56.41}$$	$${-0}$$	$${11.2}$$ < $${13.86}$$
✅	iot_agent_rpm_amd64	$${+0}$$	$${50.49}$$ < $${60.18}$$	$${+0}$$	$${12.87}$$ < $${15.84}$$
✅	iot_agent_rpm_arm64	$${+0}$$	$${47.94}$$ < $${56.94}$$	$${-0}$$	$${11.16}$$ < $${13.76}$$
✅	iot_agent_suse_amd64	$${+0}$$	$${50.49}$$ < $${60.18}$$	$${+0}$$	$${12.87}$$ < $${15.84}$$

cmd/agent/dist/conf.d/disk.d/conf.yaml.default

pkg/collector/corechecks/system/disk/diskv2/disk.go

jose-manuel-almaza · 2025-06-11T12:24:31Z

/merge

dd-devflow · 2025-06-11T12:24:35Z

View all feedbacks in Devflow UI.

2025-06-11 12:24:35 UTC ℹ️ Start processing command /merge

2025-06-11 12:24:43 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-06-11 15:29:08 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 51m (p90).

2025-06-11 16:08:14 UTC ℹ️ MergeQueue: This merge request was merged

migrate from 'Partitions' to 'PartitionsWithContext'

03c63ac

jose-manuel-almaza requested review from a team as code owners June 10, 2025 15:46

jose-manuel-almaza requested a review from pgimalac June 10, 2025 15:46

jose-manuel-almaza added the changelog/no-changelog label Jun 10, 2025

github-actions bot added team/agent-runtimes medium review PR review might take time labels Jun 10, 2025

jose-manuel-almaza added qa/done QA done before merge and regressions are covered by tests and removed medium review PR review might take time team/agent-runtimes labels Jun 10, 2025

Merge branch 'main' into jose/configure-host-proc-mountinfo

3f83646

fix unit tests

bdc675c

github-actions bot added the medium review PR review might take time label Jun 10, 2025

jose-manuel-almaza added 6 commits June 11, 2025 08:01

add 'proc_mountinfo_path' config key

694154f

remove 'diskPartitions' member from Check

e39c0a9

configure 'proc_mountinfo_path' for linux e2e tests

91021b7

default value for 'proc_mountinfo_path' to '/proc/self/mounts'

591c322

restore config e2e test

b4812ab

update default yaml config

64bd54e

jose-manuel-almaza requested a review from a team as a code owner June 11, 2025 10:03

jose-manuel-almaza requested a review from rahulkaukuntla June 11, 2025 10:03

pgimalac approved these changes Jun 11, 2025

View reviewed changes

GustavoCaso reviewed Jun 11, 2025

View reviewed changes

cmd/agent/dist/conf.d/disk.d/conf.yaml.default Outdated Show resolved Hide resolved

GustavoCaso reviewed Jun 11, 2025

View reviewed changes

pkg/collector/corechecks/system/disk/diskv2/disk.go Show resolved Hide resolved

GustavoCaso approved these changes Jun 11, 2025

View reviewed changes

fixed 'proc_mountinfo_path' yaml comment

67e3cdd

rahulkaukuntla approved these changes Jun 11, 2025

View reviewed changes

dd-mergequeue bot merged commit 129fbdf into main Jun 11, 2025
475 of 603 checks passed

dd-mergequeue bot deleted the jose/configure-host-proc-mountinfo branch June 11, 2025 16:08

github-actions bot added this to the 7.68.0 milestone Jun 11, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Set 'HostProcMountinfo' for Disk integration #37826

Set 'HostProcMountinfo' for Disk integration #37826

Uh oh!

jose-manuel-almaza commented Jun 10, 2025 •

edited

Loading

Uh oh!

cit-pr-commenter bot commented Jun 10, 2025 •

edited

Loading

Fine details of change detection per experiment

Explanation

Uh oh!

agent-platform-auto-pr bot commented Jun 10, 2025 •

edited

Loading

Info

Uh oh!

Uh oh!

Uh oh!

jose-manuel-almaza commented Jun 11, 2025

Uh oh!

dd-devflow bot commented Jun 11, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Set 'HostProcMountinfo' for Disk integration #37826

Set 'HostProcMountinfo' for Disk integration #37826

Uh oh!

Conversation

jose-manuel-almaza commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

Uh oh!

cit-pr-commenter bot commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

Bounds Checks: ❌ Failed

Explanation

CI Pass/Fail Decision

Uh oh!

agent-platform-auto-pr bot commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Static quality checks

Info

Uh oh!

Uh oh!

Uh oh!

jose-manuel-almaza commented Jun 11, 2025

Uh oh!

dd-devflow bot commented Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jose-manuel-almaza commented Jun 10, 2025 •

edited

Loading

cit-pr-commenter bot commented Jun 10, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Jun 10, 2025 •

edited

Loading

dd-devflow bot commented Jun 11, 2025 •

edited

Loading