Skip to content

Add forgotten origin mappings in the agent for Keda, DuckDB and Supabase #37838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 11, 2025
Merged

Add forgotten origin mappings in the agent for Keda, DuckDB and Supabase #37838

merged 4 commits into from
Jun 11, 2025

Conversation

steveny91
Copy link
Contributor

What does this PR do?

This PR adds the origin for DuckDB(423), Keda (424) and Supabase (428). These were added here:
https://github.com/DataDog/dd-source/commit/62a041c4e2b9322f7e4f82d933fb275cb05bbecf

But it never made it into the agent.

@steveny91 steveny91 requested review from a team as code owners June 10, 2025 20:54
@github-actions github-actions bot added short review PR is simple enough to be reviewed quickly team/agent-metric-pipelines labels Jun 10, 2025
@steveny91 steveny91 requested a review from a team as a code owner June 10, 2025 20:56
@steveny91 steveny91 changed the title add forgotten origin mappings in the agent Add forgotten origin mappings in the agent for Keda, DuckDB and Supabase Jun 10, 2025
@steveny91 steveny91 added qa/done QA done before merge and regressions are covered by tests and removed qa/skip-qa labels Jun 10, 2025
@buraizu buraizu self-assigned this Jun 10, 2025
@cit-pr-commenter cit-pr-commenter
Copy link

cit-pr-commenter bot commented Jun 10, 2025 •
edited
Loading

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 2270ce85-7823-42f8-b436-5134d27bfa1b

Baseline: 09e8c90
Comparison: 044d943
Diff

Optimization Goals: ❌ Regression(s) detected

perf experiment goal Δ mean % Δ mean % CI trials links
❌ docker_containers_cpu % cpu utilization +5.53 [+2.45, +8.62] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
❌ docker_containers_cpu % cpu utilization +5.53 [+2.45, +8.62] 1 Logs
➖ quality_gate_idle memory utilization +0.78 [+0.70, +0.85] 1 Logs bounds checks dashboard
➖ file_tree memory utilization +0.74 [+0.52, +0.96] 1 Logs
➖ tcp_syslog_to_blackhole ingress throughput +0.22 [+0.16, +0.28] 1 Logs
➖ file_to_blackhole_300ms_latency egress throughput +0.06 [-0.54, +0.65] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput +0.05 [-0.60, +0.69] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput +0.04 [-0.59, +0.66] 1 Logs
➖ file_to_blackhole_1000ms_latency_linear_load egress throughput +0.00 [-0.23, +0.24] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.02, +0.02] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput -0.00 [-0.27, +0.27] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput -0.03 [-0.57, +0.52] 1 Logs
➖ file_to_blackhole_0ms_latency_http1 egress throughput -0.04 [-0.62, +0.55] 1 Logs
➖ file_to_blackhole_0ms_latency_http2 egress throughput -0.10 [-0.74, +0.54] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput -0.12 [-0.68, +0.44] 1 Logs
➖ ddot_metrics memory utilization -0.18 [-0.29, -0.06] 1 Logs
➖ otlp_ingest_metrics memory utilization -0.20 [-0.37, -0.03] 1 Logs
➖ otlp_ingest_logs memory utilization -0.43 [-0.56, -0.30] 1 Logs
➖ uds_dogstatsd_to_api_cpu % cpu utilization -0.46 [-1.34, +0.42] 1 Logs
➖ quality_gate_logs % cpu utilization -0.47 [-3.22, +2.29] 1 Logs bounds checks dashboard
➖ ddot_logs memory utilization -0.66 [-0.80, -0.51] 1 Logs
➖ docker_containers_memory memory utilization -0.96 [-1.06, -0.86] 1 Logs
➖ uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -1.15 [-1.20, -1.09] 1 Logs
➖ quality_gate_idle_all_features memory utilization -4.17 [-4.30, -4.03] 1 Logs bounds checks dashboard

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
❌ quality_gate_logs memory_usage 6/10 bounds checks dashboard
✅ docker_containers_cpu simple_check_run 10/10
✅ docker_containers_memory memory_usage 10/10
✅ docker_containers_memory simple_check_run 10/10
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http1 memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http2 memory_usage 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_300ms_latency lost_bytes 10/10
✅ file_to_blackhole_300ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

❌ Failed. Some Quality Gates were violated.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 6/10 replicas passed. Failed 4 which is > 0. Gate FAILED.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jun 10, 2025 •
edited
Loading

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 09e8c90

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
✅ agent_deb_amd64 $${-0}$$ $${695.71}$$ < $${752.99}$$ $${+0.06}$$ $${175.98}$$ < $${187.44}$$
✅ agent_deb_amd64_fips $${-0}$$ $${693.92}$$ < $${751.36}$$ $${-0.01}$$ $${175.57}$$ < $${187.06}$$
✅ agent_heroku_amd64 $${0}$$ $${358.21}$$ < $${369.68}$$ $${-0}$$ $${96.44}$$ < $${99.55}$$
✅ agent_msi $${+0}$$ $${957.72}$$ < $${987.01}$$ $${-0.02}$$ $${146.13}$$ < $${150.72}$$
✅ agent_rpm_amd64 $${-0}$$ $${695.7}$$ < $${752.98}$$ $${+0}$$ $${177.5}$$ < $${190.03}$$
✅ agent_rpm_amd64_fips $${-0}$$ $${693.91}$$ < $${751.35}$$ $${-0.02}$$ $${177.35}$$ < $${189.81}$$
✅ agent_rpm_arm64 $${+0}$$ $${685.7}$$ < $${739.42}$$ $${+0.06}$$ $${160.89}$$ < $${171.23}$$
✅ agent_rpm_arm64_fips $${+0}$$ $${684.05}$$ < $${737.91}$$ $${-0}$$ $${160.01}$$ < $${170.22}$$
✅ agent_suse_amd64 $${-0}$$ $${695.7}$$ < $${752.98}$$ $${+0}$$ $${177.5}$$ < $${190.03}$$
✅ agent_suse_amd64_fips $${-0}$$ $${693.91}$$ < $${751.35}$$ $${-0.02}$$ $${177.35}$$ < $${189.81}$$
✅ agent_suse_arm64 $${+0}$$ $${685.7}$$ < $${739.42}$$ $${+0.06}$$ $${160.89}$$ < $${171.23}$$
✅ agent_suse_arm64_fips $${+0}$$ $${684.05}$$ < $${737.91}$$ $${-0}$$ $${160.01}$$ < $${170.22}$$
✅ docker_agent_amd64 $${-0}$$ $${779.5}$$ < $${849.39}$$ $${+0}$$ $${268.44}$$ < $${288.34}$$
✅ docker_agent_arm64 $${+0}$$ $${792.95}$$ < $${858.97}$$ $${-0}$$ $${255.83}$$ < $${274.36}$$
✅ docker_agent_jmx_amd64 $${-0}$$ $${970.69}$$ < $${1040.59}$$ $${-0}$$ $${337.43}$$ < $${357.3}$$
✅ docker_agent_jmx_arm64 $${+0}$$ $${972.75}$$ < $${1038.77}$$ $${+0}$$ $${320.79}$$ < $${339.32}$$
✅ docker_agent_windows1809 $${+0}$$ $${1485.81}$$ < $${1557.19}$$ $${+0.01}$$ $${487.63}$$ < $${507.33}$$
✅ docker_agent_windows1809_core $${+0}$$ $${6215.77}$$ < $${6287.46}$$ $${0}$$ $${2048.0}$$ < $${2067.76}$$
✅ docker_agent_windows1809_core_jmx $${+22.32}$$ $${6359.67}$$ < $${6409.04}$$ $${0}$$ $${2048.0}$$ < $${2067.76}$$
✅ docker_agent_windows1809_jmx $${+0}$$ $${1607.45}$$ < $${1679.14}$$ $${-0.01}$$ $${529.89}$$ < $${550.27}$$
✅ docker_agent_windows2022 $${-0.16}$$ $${1505.11}$$ < $${1576.85}$$ $${-0.07}$$ $${500.35}$$ < $${520.76}$$
✅ docker_agent_windows2022_core $${-0.02}$$ $${6188.98}$$ < $${6260.53}$$ $${0}$$ $${2048.0}$$ < $${2067.76}$$
✅ docker_agent_windows2022_core_jmx $${-0.09}$$ $${6310.69}$$ < $${6382.17}$$ $${0}$$ $${2048.0}$$ < $${2067.76}$$
✅ docker_agent_windows2022_jmx $${-0.21}$$ $${1626.74}$$ < $${1698.2}$$ $${-0.04}$$ $${542.64}$$ < $${562.99}$$
✅ docker_cluster_agent_amd64 $${-0}$$ $${212.79}$$ < $${259.73}$$ $${-0}$$ $${72.36}$$ < $${103.68}$$
✅ docker_cluster_agent_arm64 $${+0}$$ $${228.68}$$ < $${274.24}$$ $${-0}$$ $${68.63}$$ < $${98.45}$$
✅ docker_cws_instrumentation_amd64 $${0}$$ $${7.08}$$ < $${7.12}$$ $${-0}$$ $${2.95}$$ < $${3.29}$$
✅ docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${-0}$$ $${2.7}$$ < $${3.07}$$
✅ docker_dogstatsd_amd64 $${0}$$ $${39.21}$$ < $${39.57}$$ $${-0}$$ $${15.11}$$ < $${15.76}$$
✅ docker_dogstatsd_arm64 $${0}$$ $${37.88}$$ < $${38.2}$$ $${+0.01}$$ $${14.53}$$ < $${14.83}$$
✅ dogstatsd_deb_amd64 $${0}$$ $${30.44}$$ < $${31.52}$$ $${-0}$$ $${7.99}$$ < $${8.97}$$
✅ dogstatsd_deb_arm64 $${0}$$ $${29.01}$$ < $${30.08}$$ $${-0}$$ $${6.94}$$ < $${7.92}$$
✅ dogstatsd_rpm_amd64 $${0}$$ $${30.44}$$ < $${31.52}$$ $${+0}$$ $${8.01}$$ < $${8.98}$$
✅ dogstatsd_suse_amd64 $${0}$$ $${30.44}$$ < $${31.52}$$ $${+0}$$ $${8.01}$$ < $${8.98}$$
✅ iot_agent_deb_amd64 $${0}$$ $${50.31}$$ < $${60.17}$$ $${-0}$$ $${12.8}$$ < $${15.82}$$
✅ iot_agent_deb_arm64 $${0}$$ $${47.78}$$ < $${56.94}$$ $${-0}$$ $${11.11}$$ < $${13.86}$$
✅ iot_agent_deb_armhf $${0}$$ $${47.35}$$ < $${56.41}$$ $${-0}$$ $${11.18}$$ < $${13.86}$$
✅ iot_agent_rpm_amd64 $${0}$$ $${50.31}$$ < $${60.18}$$ $${+0}$$ $${12.82}$$ < $${15.84}$$
✅ iot_agent_rpm_arm64 $${0}$$ $${47.78}$$ < $${56.94}$$ $${-0}$$ $${11.13}$$ < $${13.76}$$
✅ iot_agent_suse_amd64 $${0}$$ $${50.31}$$ < $${60.18}$$ $${+0}$$ $${12.82}$$ < $${15.84}$$

@steveny91
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jun 11, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-06-11 20:09:12 UTC ℹ️ Start processing command /merge

2025-06-11 20:09:19 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 52m (p90).

2025-06-11 20:51:14 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit e1d209a into main Jun 11, 2025
238 checks passed
@dd-mergequeue dd-mergequeue bot deleted the sy/add-forgotten-origins branch June 11, 2025 20:51
@github-actions github-actions bot added this to the 7.68.0 milestone Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobz tobz tobz approved these changes

@sarah-witt sarah-witt sarah-witt approved these changes

@buraizu buraizu buraizu approved these changes

@Kyle-Neale Kyle-Neale Kyle-Neale approved these changes

Assignees

@buraizu buraizu

Labels
qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/agent-metric-pipelines
Projects
None yet
Milestone
7.68.0
Development

Successfully merging this pull request may close these issues.
5 participants
@steveny91 @tobz @sarah-witt @buraizu @Kyle-Neale