Skip to content

[Backport 7.67.x] SMP: Reduce requested # of CPUs for failing experiments #37855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2025
Merged

[Backport 7.67.x] SMP: Reduce requested # of CPUs for failing experiments #37855

merged 1 commit into from
Jun 11, 2025
+2 −2

Conversation

agent-platform-auto-pr[bot]
Copy link
Contributor

Backport ad0e415 from #37792.

<!--

  • Contributors are encouraged to read our CONTRIBUTING documentation.
  • Both Contributor and Reviewer Checklists are available at https://datadoghq.dev/datadog-agent/guidelines/contributing/#pull-requests.
  • The pull request:
    • Should only fix one issue or add one feature at a time.
    • Must update the test suite for the relevant functionality.
    • Should pass all status checks before being reviewed or merged.
  • Commit titles should be prefixed with general area of pull request's change.
  • Please fill the below sections if possible with relevant information or links.
    -->

What does this PR do?

Reduces the CPUs requested by two experiments that failed to be updated.

Motivation

SMP's recent release reduces the available CPU cores

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@agent-platform-auto-pr agent-platform-auto-pr bot added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Jun 11, 2025
@agent-platform-auto-pr agent-platform-auto-pr bot requested a review from a team as a code owner June 11, 2025 12:55
@agent-platform-auto-pr agent-platform-auto-pr bot added backport bot short review PR is simple enough to be reviewed quickly changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Jun 11, 2025
@agent-platform-auto-pr
Copy link
Contributor Author

Uncompressed package size comparison

Comparison with ancestor 72b16c13c417cb262f767cf14beb0d9c338f8e9d

Diff per package
package diff status size ancestor threshold
datadog-agent-x86_64-rpm 0.74MB ❌ 784.77MB 784.03MB 0.50MB
datadog-agent-x86_64-suse 0.74MB ❌ 784.77MB 784.03MB 0.50MB
datadog-agent-amd64-deb 0.74MB ❌ 775.82MB 775.08MB 0.50MB
datadog-agent-arm64-deb 0.71MB ❌ 765.10MB 764.39MB 0.50MB
datadog-agent-aarch64-rpm 0.71MB ❌ 774.03MB 773.33MB 0.50MB
datadog-heroku-agent-amd64-deb 0.02MB ⚠️ 378.73MB 378.71MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.01MB ⚠️ 31.30MB 31.30MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.01MB ⚠️ 31.30MB 31.30MB 0.50MB
datadog-dogstatsd-amd64-deb 0.01MB ⚠️ 31.22MB 31.21MB 0.50MB
datadog-dogstatsd-arm64-deb 0.01MB ⚠️ 30.05MB 30.04MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB ✅ 61.14MB 61.14MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB ✅ 61.14MB 61.14MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB ✅ 58.40MB 58.39MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB ✅ 61.06MB 61.06MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB ✅ 58.31MB 58.31MB 0.50MB

Decision

❌ Failed

Currently this PR is blocked, you can reach out to #agent-delivery-help to get support/ask for an exception.

@cit-pr-commenter cit-pr-commenter
Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: fe871111-c465-496c-aa91-f16ba9214630

Baseline: 7629988
Comparison: d84834e
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ otlp_ingest_metrics memory utilization +0.77 [+0.61, +0.93] 1 Logs
➖ ddot_metrics memory utilization +0.64 [+0.54, +0.73] 1 Logs
➖ quality_gate_idle_all_features memory utilization +0.33 [+0.22, +0.44] 1 Logs bounds checks dashboard
➖ docker_containers_memory memory utilization +0.31 [+0.24, +0.38] 1 Logs
➖ otlp_ingest_logs memory utilization +0.21 [+0.09, +0.32] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput +0.11 [-0.51, +0.73] 1 Logs
➖ quality_gate_logs % cpu utilization +0.08 [-2.75, +2.91] 1 Logs bounds checks dashboard
➖ file_to_blackhole_300ms_latency egress throughput +0.04 [-0.60, +0.69] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput +0.04 [-0.59, +0.67] 1 Logs
➖ file_to_blackhole_0ms_latency_http2 egress throughput +0.04 [-0.59, +0.67] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput +0.01 [-0.28, +0.30] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.02] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput -0.03 [-0.65, +0.60] 1 Logs
➖ uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.03 [-0.08, +0.03] 1 Logs
➖ file_to_blackhole_1000ms_latency_linear_load egress throughput -0.03 [-0.26, +0.19] 1 Logs
➖ file_to_blackhole_0ms_latency_http1 egress throughput -0.04 [-0.66, +0.59] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput -0.08 [-0.70, +0.53] 1 Logs
➖ tcp_syslog_to_blackhole ingress throughput -0.44 [-0.52, -0.36] 1 Logs
➖ file_tree memory utilization -0.54 [-0.72, -0.36] 1 Logs
➖ uds_dogstatsd_to_api_cpu % cpu utilization -0.76 [-1.63, +0.11] 1 Logs
➖ quality_gate_idle memory utilization -0.89 [-0.95, -0.83] 1 Logs bounds checks dashboard
➖ ddot_logs memory utilization -0.92 [-1.03, -0.80] 1 Logs
➖ docker_containers_cpu % cpu utilization -2.30 [-5.15, +0.55] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
❌ docker_containers_memory memory_usage 0/10
✅ docker_containers_cpu simple_check_run 10/10
✅ docker_containers_memory simple_check_run 10/10
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http1 memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http2 memory_usage 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_300ms_latency lost_bytes 10/10
✅ file_to_blackhole_300ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@chouquette chouquette merged commit 36d32d2 into 7.67.x Jun 11, 2025
311 of 323 checks passed
@chouquette chouquette deleted the backport-37792-to-7.67.x branch June 11, 2025 14:23
@github-actions github-actions bot added this to the 7.67.0 milestone Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preinlein preinlein preinlein approved these changes

Assignees
No one assigned
Labels
backport bot changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly
Projects
None yet
Milestone
7.67.0
Development

Successfully merging this pull request may close these issues.
3 participants
@preinlein @chouquette @scottopell