Skip to content

[ACIX-883] Auto-retry e2e tests in CI #37862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[ACIX-883] Auto-retry e2e tests in CI #37862

wants to merge 4 commits into from

Conversation

Ishirui
Copy link
Contributor

@Ishirui Ishirui commented Jun 11, 2025 •
edited
Loading

What does this PR do?

Following-up on ACIX-859 and #36422, try a new method for automatically rerunning failing e2e tests. This new method does not re-run tests that are already known as flaky and whose failure is accepted, contrary to what the previous method would do.

Motivation

Increase CI reliability and diminish the impact (lost time) of flaky (but not yet marked as flaky) tests

Describe how you validated your changes

TBD

Possible Drawbacks / Trade-offs

Increased pipeline runtime + lost visibility on which tests are failing/flaky

Additional Notes

@Ishirui Ishirui self-assigned this Jun 11, 2025
@github-actions github-actions bot added team/agent-devx short review PR is simple enough to be reviewed quickly labels Jun 11, 2025
@Ishirui Ishirui added the qa/no-code-change No code change in Agent code requiring validation label Jun 11, 2025
@cit-pr-commenter cit-pr-commenter
Copy link

cit-pr-commenter bot commented Jun 11, 2025 •
edited
Loading

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 330aec63-8e45-4a06-ba7d-2cea0b6282ea

Baseline: bda39cf
Comparison: 685fb37
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ quality_gate_idle_all_features memory utilization +0.80 [+0.72, +0.88] 1 Logs bounds checks dashboard
➖ otlp_ingest_logs memory utilization +0.78 [+0.66, +0.91] 1 Logs
➖ file_tree memory utilization +0.40 [+0.27, +0.53] 1 Logs
➖ ddot_metrics memory utilization +0.38 [+0.26, +0.49] 1 Logs
➖ quality_gate_idle memory utilization +0.35 [+0.29, +0.40] 1 Logs bounds checks dashboard
➖ docker_containers_cpu % cpu utilization +0.19 [-2.82, +3.20] 1 Logs
➖ quality_gate_logs % cpu utilization +0.17 [-2.61, +2.96] 1 Logs bounds checks dashboard
➖ ddot_logs memory utilization +0.13 [-0.01, +0.27] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput +0.12 [-0.45, +0.70] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput +0.05 [-0.54, +0.63] 1 Logs
➖ file_to_blackhole_300ms_latency egress throughput +0.02 [-0.59, +0.62] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput +0.01 [-0.27, +0.29] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.02] 1 Logs
➖ file_to_blackhole_0ms_latency_http2 egress throughput -0.01 [-0.60, +0.59] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput -0.01 [-0.58, +0.55] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput -0.03 [-0.66, +0.61] 1 Logs
➖ file_to_blackhole_0ms_latency_http1 egress throughput -0.05 [-0.64, +0.54] 1 Logs
➖ file_to_blackhole_1000ms_latency_linear_load egress throughput -0.08 [-0.32, +0.15] 1 Logs
➖ docker_containers_memory memory utilization -0.09 [-0.15, -0.03] 1 Logs
➖ otlp_ingest_metrics memory utilization -0.51 [-0.67, -0.35] 1 Logs
➖ uds_dogstatsd_to_api_cpu % cpu utilization -0.71 [-1.58, +0.17] 1 Logs
➖ tcp_syslog_to_blackhole ingress throughput -0.78 [-0.85, -0.72] 1 Logs
➖ uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -1.22 [-1.27, -1.17] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
✅ docker_containers_cpu simple_check_run 10/10
✅ docker_containers_memory memory_usage 10/10
✅ docker_containers_memory simple_check_run 10/10
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http1 memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http2 memory_usage 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_300ms_latency lost_bytes 10/10
✅ file_to_blackhole_300ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jun 11, 2025 •
edited
Loading

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor bda39cf

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
✅ agent_deb_amd64 DataNotFound $${696.02}$$ < $${752.99}$$ DataNotFound $${175.96}$$ < $${187.44}$$
✅ agent_deb_amd64_fips DataNotFound $${694.24}$$ < $${751.36}$$ DataNotFound $${175.63}$$ < $${187.06}$$
✅ agent_heroku_amd64 DataNotFound $${358.51}$$ < $${369.68}$$ DataNotFound $${96.49}$$ < $${99.55}$$
✅ agent_msi DataNotFound $${958.01}$$ < $${987.01}$$ DataNotFound $${146.22}$$ < $${150.72}$$
✅ agent_rpm_amd64 DataNotFound $${696.01}$$ < $${752.98}$$ DataNotFound $${177.56}$$ < $${190.03}$$
✅ agent_rpm_amd64_fips DataNotFound $${694.23}$$ < $${751.35}$$ DataNotFound $${177.4}$$ < $${189.81}$$
✅ agent_rpm_arm64 DataNotFound $${686.03}$$ < $${739.42}$$ DataNotFound $${160.97}$$ < $${171.23}$$
✅ agent_rpm_arm64_fips DataNotFound $${684.37}$$ < $${737.91}$$ DataNotFound $${160.08}$$ < $${170.22}$$
✅ agent_suse_amd64 DataNotFound $${696.01}$$ < $${752.98}$$ DataNotFound $${177.56}$$ < $${190.03}$$
✅ agent_suse_amd64_fips DataNotFound $${694.23}$$ < $${751.35}$$ DataNotFound $${177.4}$$ < $${189.81}$$
✅ agent_suse_arm64 DataNotFound $${686.03}$$ < $${739.42}$$ DataNotFound $${160.97}$$ < $${171.23}$$
✅ agent_suse_arm64_fips DataNotFound $${684.37}$$ < $${737.91}$$ DataNotFound $${160.08}$$ < $${170.22}$$
✅ docker_agent_amd64 DataNotFound $${779.81}$$ < $${849.39}$$ DataNotFound $${268.56}$$ < $${288.34}$$
✅ docker_agent_arm64 DataNotFound $${793.28}$$ < $${858.97}$$ DataNotFound $${255.94}$$ < $${274.36}$$
✅ docker_agent_jmx_amd64 DataNotFound $${971.0}$$ < $${1040.59}$$ DataNotFound $${337.55}$$ < $${357.3}$$
✅ docker_agent_jmx_arm64 DataNotFound $${973.07}$$ < $${1038.77}$$ DataNotFound $${320.89}$$ < $${339.32}$$
✅ docker_agent_windows1809 DataNotFound $${1486.15}$$ < $${1557.19}$$ DataNotFound $${487.76}$$ < $${507.33}$$
✅ docker_agent_windows1809_core DataNotFound $${6216.12}$$ < $${6287.46}$$ DataNotFound $${2048.0}$$ < $${2067.76}$$
✅ docker_agent_windows1809_core_jmx DataNotFound $${6337.68}$$ < $${6409.04}$$ DataNotFound $${2048.0}$$ < $${2067.76}$$
✅ docker_agent_windows1809_jmx DataNotFound $${1607.78}$$ < $${1679.14}$$ DataNotFound $${530.0}$$ < $${550.27}$$
✅ docker_agent_windows2022 DataNotFound $${1505.45}$$ < $${1576.85}$$ DataNotFound $${500.47}$$ < $${520.76}$$
✅ docker_agent_windows2022_core DataNotFound $${6189.4}$$ < $${6260.53}$$ DataNotFound $${2048.0}$$ < $${2067.76}$$
✅ docker_agent_windows2022_core_jmx DataNotFound $${6310.85}$$ < $${6382.17}$$ DataNotFound $${2048.0}$$ < $${2067.76}$$
✅ docker_agent_windows2022_jmx DataNotFound $${1627.04}$$ < $${1698.2}$$ DataNotFound $${542.8}$$ < $${562.99}$$
✅ docker_cluster_agent_amd64 DataNotFound $${212.79}$$ < $${259.73}$$ DataNotFound $${72.36}$$ < $${103.68}$$
✅ docker_cluster_agent_arm64 DataNotFound $${228.68}$$ < $${274.24}$$ DataNotFound $${68.64}$$ < $${98.45}$$
✅ docker_cws_instrumentation_amd64 DataNotFound $${7.08}$$ < $${7.12}$$ DataNotFound $${2.95}$$ < $${3.29}$$
✅ docker_cws_instrumentation_arm64 DataNotFound $${6.69}$$ < $${6.92}$$ DataNotFound $${2.7}$$ < $${3.07}$$
✅ docker_dogstatsd_amd64 DataNotFound $${39.21}$$ < $${39.57}$$ DataNotFound $${15.11}$$ < $${15.76}$$
✅ docker_dogstatsd_arm64 DataNotFound $${37.88}$$ < $${38.2}$$ DataNotFound $${14.53}$$ < $${14.83}$$
✅ dogstatsd_deb_amd64 DataNotFound $${30.44}$$ < $${31.52}$$ DataNotFound $${7.99}$$ < $${8.97}$$
✅ dogstatsd_deb_arm64 DataNotFound $${29.01}$$ < $${30.08}$$ DataNotFound $${6.94}$$ < $${7.92}$$
✅ dogstatsd_rpm_amd64 DataNotFound $${30.44}$$ < $${31.52}$$ DataNotFound $${8.0}$$ < $${8.98}$$
✅ dogstatsd_suse_amd64 DataNotFound $${30.44}$$ < $${31.52}$$ DataNotFound $${8.0}$$ < $${8.98}$$
✅ iot_agent_deb_amd64 DataNotFound $${50.31}$$ < $${60.17}$$ DataNotFound $${12.81}$$ < $${15.82}$$
✅ iot_agent_deb_arm64 DataNotFound $${47.78}$$ < $${56.94}$$ DataNotFound $${11.11}$$ < $${13.86}$$
✅ iot_agent_deb_armhf DataNotFound $${47.35}$$ < $${56.41}$$ DataNotFound $${11.18}$$ < $${13.86}$$
✅ iot_agent_rpm_amd64 DataNotFound $${50.31}$$ < $${60.18}$$ DataNotFound $${12.82}$$ < $${15.84}$$
✅ iot_agent_rpm_arm64 DataNotFound $${47.78}$$ < $${56.94}$$ DataNotFound $${11.13}$$ < $${13.76}$$
✅ iot_agent_suse_amd64 DataNotFound $${50.31}$$ < $${60.18}$$ DataNotFound $${12.82}$$ < $${15.84}$$

@Ishirui Ishirui force-pushed the pierrelouis.veyrenc/ACIX-883-retry-e2e-tests branch from bcee97a to ad4f5d4 Compare June 12, 2025 09:41
@github-actions github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Jun 12, 2025
@Ishirui Ishirui force-pushed the pierrelouis.veyrenc/ACIX-883-retry-e2e-tests branch from ad4f5d4 to 685fb37 Compare June 12, 2025 09:45
@Ishirui Ishirui marked this pull request as ready for review June 12, 2025 13:29
@Ishirui Ishirui requested review from a team as code owners June 12, 2025 13:29
KevinFairise2
KevinFairise2 reviewed Jun 13, 2025
View reviewed changes
tasks/new_e2e_tests.py
)

# Retry the failed tests only
affected_packages = {package.partition("/test/new-e2e/")[2] for package, _ in to_retry}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe try os.path.relpath() or something else to compute path relative to test/new-e2e

Ishirui
Ishirui commented Jun 13, 2025
View reviewed changes
Copy link
Contributor Author

@Ishirui Ishirui left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo:

  • Default retries to 0
  • If retry logic enabled, pass "nth retry" and "max retries" to TearDownSuite method to prevent tearing down the infra on test failure if there are going to be further retries

Try to make it so that if we don't pass any --max-retries flag, the behavior does not change at all

  • In order to do pass these env vars, add it here so it gets loaded as a global go var

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinFairise2 KevinFairise2 KevinFairise2 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@Ishirui Ishirui

Labels
changelog/no-changelog medium review PR review might take time qa/no-code-change No code change in Agent code requiring validation team/agent-devx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ishirui @KevinFairise2