Skip to content

Piotr wolski/add remote config restart checks #37884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

piochelepiotr
Copy link
Contributor

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@github-actions github-actions bot added medium review PR review might take time team/agent-runtimes labels Jun 12, 2025
Copy link

cit-pr-commenter bot commented Jun 12, 2025

Go Package Import Differences

Baseline: 1966596
Comparison: 74bb3e9

binaryosarchchange
agentlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/datastreams
agentlinuxarm64
+1, -0
+github.com/DataDog/datadog-agent/pkg/datastreams
agentwindowsamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/datastreams
agentdarwinamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/datastreams
agentdarwinarm64
+1, -0
+github.com/DataDog/datadog-agent/pkg/datastreams
iot-agentlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/datastreams
iot-agentlinuxarm64
+1, -0
+github.com/DataDog/datadog-agent/pkg/datastreams
heroku-agentlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/datastreams

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jun 12, 2025

Uncompressed package size comparison

Comparison with ancestor 19665966e160456fb6fe2af676c69866989cd6bb

Diff per package
package diff status size ancestor threshold
datadog-agent-x86_64-rpm 0.03MB ⚠️ 783.25MB 783.22MB 0.50MB
datadog-agent-x86_64-suse 0.03MB ⚠️ 783.25MB 783.22MB 0.50MB
datadog-agent-amd64-deb 0.03MB ⚠️ 774.30MB 774.27MB 0.50MB
datadog-agent-aarch64-rpm 0.02MB ⚠️ 769.15MB 769.12MB 0.50MB
datadog-agent-arm64-deb 0.02MB ⚠️ 760.22MB 760.19MB 0.50MB
datadog-heroku-agent-amd64-deb 0.02MB ⚠️ 381.12MB 381.10MB 0.50MB
datadog-iot-agent-amd64-deb 0.01MB ⚠️ 62.71MB 62.70MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.01MB ⚠️ 62.79MB 62.78MB 0.50MB
datadog-iot-agent-x86_64-suse 0.01MB ⚠️ 62.79MB 62.78MB 0.50MB
datadog-iot-agent-arm64-deb 0.01MB ⚠️ 59.28MB 59.27MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.01MB ⚠️ 59.36MB 59.35MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 31.99MB 31.99MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 32.07MB 32.07MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 32.07MB 32.07MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 30.47MB 30.47MB 0.50MB

Decision

⚠️ Warning

@piochelepiotr piochelepiotr force-pushed the piotr-wolski/add-remote-config-restart-checks branch from fba990a to 9ccc027 Compare June 13, 2025 08:12
@@ -22,7 +22,9 @@ var Commit string
// used to serialize to protobuf
var AgentPayloadVersion string

var agentVersionDefault = "6.0.0"
var agentVersionDefault = "7.66.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo: remove that

@piochelepiotr piochelepiotr force-pushed the piotr-wolski/add-remote-config-restart-checks branch from 97ad3e8 to ffc5271 Compare June 13, 2025 10:32
@piochelepiotr piochelepiotr force-pushed the piotr-wolski/add-remote-config-restart-checks branch from 4cb2268 to 74bb3e9 Compare June 13, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium review PR review might take time team/agent-runtimes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant