Skip to content

Fix static quality gates image suffix logic (#37802) #37891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 13, 2025
Merged

Fix static quality gates image suffix logic (#37802) #37891

merged 2 commits into from
Jun 13, 2025

Conversation

Pythyu
Copy link
Contributor

@Pythyu Pythyu commented Jun 12, 2025

(cherry picked from commit bea966a)

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@Pythyu Pythyu requested a review from a team as a code owner June 12, 2025 13:56
@Pythyu Pythyu added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Jun 12, 2025
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Jun 12, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jun 12, 2025 •
edited
Loading

Uncompressed package size comparison

Comparison with ancestor 72b16c13c417cb262f767cf14beb0d9c338f8e9d

Size reduction summary
package diff status size ancestor threshold
datadog-dogstatsd-x86_64-rpm -0.00MB ✅ 31.30MB 31.30MB 0.50MB
datadog-dogstatsd-x86_64-suse -0.00MB ✅ 31.30MB 31.30MB 0.50MB
datadog-iot-agent-x86_64-rpm -0.00MB ✅ 61.14MB 61.14MB 0.50MB
datadog-iot-agent-x86_64-suse -0.00MB ✅ 61.14MB 61.14MB 0.50MB
datadog-iot-agent-aarch64-rpm -0.00MB ✅ 58.39MB 58.39MB 0.50MB
Diff per package
package diff status size ancestor threshold
datadog-agent-x86_64-rpm 0.01MB ⚠️ 784.04MB 784.03MB 0.50MB
datadog-agent-x86_64-suse 0.01MB ⚠️ 784.04MB 784.03MB 0.50MB
datadog-agent-amd64-deb 0.01MB ⚠️ 775.09MB 775.08MB 0.50MB
datadog-agent-aarch64-rpm 0.00MB ✅ 773.33MB 773.33MB 0.50MB
datadog-agent-arm64-deb 0.00MB ✅ 764.40MB 764.39MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB ✅ 378.71MB 378.71MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB ✅ 31.21MB 31.21MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB ✅ 30.04MB 30.04MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB ✅ 61.06MB 61.06MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB ✅ 58.31MB 58.31MB 0.50MB

Decision

⚠️ Warning

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jun 12, 2025 •
edited
Loading

Static quality checks

✅ Please find below the results from static quality gates

Successful checks

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
✅ static_quality_gate_agent_deb_amd64 747.73 MiB 778.06 MiB 185.69 MiB 191.06 MiB
✅ static_quality_gate_agent_deb_amd64_fips 745.58 MiB 776.09 MiB 184.91 MiB 190.72 MiB
✅ static_quality_gate_agent_heroku_amd64 367.15 MiB 434.99 MiB 98.38 MiB 114.34 MiB
✅ static_quality_gate_agent_msi 963.9 MiB 978.45 MiB 147.06 MiB 151.65 MiB
✅ static_quality_gate_agent_rpm_amd64 747.72 MiB 778.06 MiB 187.34 MiB 193.42 MiB
✅ static_quality_gate_agent_rpm_amd64_fips 745.56 MiB 776.06 MiB 186.81 MiB 192.61 MiB
✅ static_quality_gate_agent_rpm_arm64 737.51 MiB 768.33 MiB 169.85 MiB 174.71 MiB
✅ static_quality_gate_agent_rpm_arm64_fips 735.56 MiB 766.55 MiB 168.79 MiB 173.92 MiB
✅ static_quality_gate_agent_suse_amd64 747.72 MiB 778.08 MiB 187.34 MiB 193.42 MiB
✅ static_quality_gate_agent_suse_amd64_fips 745.56 MiB 776.11 MiB 186.81 MiB 192.78 MiB
✅ static_quality_gate_agent_suse_arm64 737.51 MiB 768.31 MiB 169.85 MiB 174.71 MiB
✅ static_quality_gate_agent_suse_arm64_fips 735.56 MiB 766.5 MiB 168.79 MiB 173.92 MiB
✅ static_quality_gate_docker_agent_amd64 844.14 MiB 862.5 MiB 286.2 MiB 292.0 MiB
✅ static_quality_gate_docker_agent_arm64 857.07 MiB 876.0 MiB 272.65 MiB 278.3 MiB
✅ static_quality_gate_docker_agent_jmx_amd64 1.02 GiB 1.02 GiB 361.27 MiB 362.3 MiB
✅ static_quality_gate_docker_agent_jmx_arm64 1.02 GiB 1.02 GiB 343.7 MiB 344.32 MiB
✅ static_quality_gate_docker_agent_windows1809 1.46 GiB 1.52 GiB 488.51 MiB 507.33 MiB
✅ static_quality_gate_docker_agent_windows1809_core 6.08 GiB 6.14 GiB 2.0 GiB 2.02 GiB
✅ static_quality_gate_docker_agent_windows1809_core_jmx 6.19 GiB 6.26 GiB 2.0 GiB 2.02 GiB
✅ static_quality_gate_docker_agent_windows1809_jmx 1.58 GiB 1.64 GiB 531.05 MiB 550.27 MiB
✅ static_quality_gate_docker_agent_windows2022 1.48 GiB 1.54 GiB 501.46 MiB 520.76 MiB
✅ static_quality_gate_docker_agent_windows2022_core 6.05 GiB 6.11 GiB 2.0 GiB 2.02 GiB
✅ static_quality_gate_docker_agent_windows2022_core_jmx 6.17 GiB 6.23 GiB 2.0 GiB 2.02 GiB
✅ static_quality_gate_docker_agent_windows2022_jmx 1.59 GiB 1.66 GiB 543.74 MiB 562.99 MiB
✅ static_quality_gate_docker_cluster_agent_amd64 256.96 MiB 263.4 MiB 101.96 MiB 104.07 MiB
✅ static_quality_gate_docker_cluster_agent_arm64 272.99 MiB 279.38 MiB 96.95 MiB 98.95 MiB
✅ static_quality_gate_docker_cws_instrumentation_amd64 6.66 MiB 7.12 MiB 2.82 MiB 3.29 MiB
✅ static_quality_gate_docker_cws_instrumentation_arm64 6.44 MiB 6.92 MiB 2.6 MiB 3.07 MiB
✅ static_quality_gate_docker_dogstatsd_amd64 37.89 MiB 46.39 MiB 14.61 MiB 17.78 MiB
✅ static_quality_gate_docker_dogstatsd_arm64 36.84 MiB 45.05 MiB 13.73 MiB 16.65 MiB
✅ static_quality_gate_dogstatsd_deb_amd64 29.85 MiB 38.4 MiB 7.9 MiB 10.26 MiB
✅ static_quality_gate_dogstatsd_deb_arm64 28.73 MiB 36.98 MiB 6.88 MiB 8.96 MiB
✅ static_quality_gate_dogstatsd_rpm_amd64 29.85 MiB 38.4 MiB 7.91 MiB 10.27 MiB
✅ static_quality_gate_dogstatsd_suse_amd64 29.85 MiB 38.4 MiB 7.91 MiB 10.27 MiB
✅ static_quality_gate_iot_agent_deb_amd64 58.31 MiB 58.51 MiB 14.69 MiB 15.02 MiB
✅ static_quality_gate_iot_agent_deb_arm64 55.69 MiB 55.94 MiB 12.68 MiB 13.05 MiB
✅ static_quality_gate_iot_agent_deb_armhf 54.46 MiB 54.65 MiB 12.7 MiB 13.05 MiB
✅ static_quality_gate_iot_agent_rpm_amd64 58.31 MiB 58.51 MiB 14.71 MiB 15.04 MiB
✅ static_quality_gate_iot_agent_rpm_arm64 55.69 MiB 55.94 MiB 12.7 MiB 13.07 MiB
✅ static_quality_gate_iot_agent_suse_amd64 58.31 MiB 58.51 MiB 14.71 MiB 15.04 MiB

@chouquette chouquette merged commit f7ece82 into 7.67.x Jun 13, 2025
209 of 217 checks passed
@chouquette chouquette deleted the backport-37802-to-7.67.x branch June 13, 2025 12:09
@github-actions github-actions bot added this to the 7.67.0 milestone Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chouquette chouquette chouquette approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly
Projects
None yet
Milestone
7.67.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Pythyu @chouquette @pgimalac